-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: cp-12.17.0 bump @metamask/eth-ledger-bridge-keyring
to ^11.0.3
#32046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikesposito
merged 2 commits into
main
from
mikesposito/bumps/eth-ledger-bridge-keyring
Apr 25, 2025
Merged
fix: cp-12.17.0 bump @metamask/eth-ledger-bridge-keyring
to ^11.0.3
#32046
mikesposito
merged 2 commits into
main
from
mikesposito/bumps/eth-ledger-bridge-keyring
Apr 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cryptodev-2s
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@metamask/eth-ledger-bridge-keyring
to ^11.0.3
@metamask/eth-ledger-bridge-keyring
to ^11.0.3
@metamask/eth-ledger-bridge-keyring
to ^11.0.3
@metamask/eth-ledger-bridge-keyring
to ^11.0.3
Gudahtt
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [b204556]
UI Startup Metrics (1209 ± 71 ms)
Benchmark value 2320 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1826 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1813 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1808 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2713 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2237 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2181 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 137 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2152 exceeds gate value 1970 for chrome webpack home p95 loadScripts Sum of mean exceeds: 462ms | Sum of p95 exceeds: 881ms Sum of all benchmark exceeds: 1343ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping
@metamask/eth-ledger-bridge-keyring
from11.0.2
to11.0.3
Related issues
N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist