Skip to content

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Apr 16, 2025

Description

Bumping @metamask/eth-ledger-bridge-keyring from 11.0.2 to 11.0.3

## [11.0.3]

### Fixed

- Removed timeout for messages requiring user actions ([#279](https://github.com/MetaMask/accounts/pull/279))

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security
Copy link

socket-security bot commented Apr 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​eth-ledger-bridge-keyring@​11.0.2 ⏵ 11.0.3931008599100

View full report

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito changed the title chore: bump @metamask/eth-ledger-bridge-keyring to ^11.0.3 chore: cp-12.17.0 bump @metamask/eth-ledger-bridge-keyring to ^11.0.3 Apr 24, 2025
@mikesposito mikesposito changed the title chore: cp-12.17.0 bump @metamask/eth-ledger-bridge-keyring to ^11.0.3 fix: cp-12.17.0 bump @metamask/eth-ledger-bridge-keyring to ^11.0.3 Apr 24, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [b204556]
UI Startup Metrics (1209 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1209108015307112511330
load105094612976110901166
domContentLoaded104493912876010791157
domInteractive17133541628
firstPaint74379129941910701161
backgroundConnect74182711
firstReactRender20153442028
getState1254371625
initialActions001000
loadScripts806708101758841918
setupStore85213816
WebpackHomeuiStartup23191841277920424422713
load18251406244420119282236
domContentLoaded18121402237919119202180
domInteractive1812106141554
firstPaint1917246773237335
backgroundConnect41104266234137
firstReactRender21755463128331379
getState174250321532
initialActions317147
loadScripts18071401237818919172151
setupStore236293352344
FirefoxBrowserifyHomeuiStartup13811186172512214561637
load12281036157012413011480
domContentLoaded12271035156912413011480
domInteractive1043637141116172
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414235252144
firstReactRender23205342429
getState948810921
initialActions001001
loadScripts12061019154612212701466
setupStore64293612
WebpackHomeuiStartup15101319192011815971739
load12911142171510613411483
domContentLoaded12911142171510613411483
domInteractive83431702193129
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221496102239
firstReactRender35284953844
getState94316929
initialActions002111
loadScripts12711129162610313221463
setupStore12628028828
cc: @HowardBraham
Benchmark value 2320 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1826 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1813 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1808 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2713 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2237 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2181 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 137 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2152 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Sum of mean exceeds: 462ms | Sum of p95 exceeds: 881ms
Sum of all benchmark exceeds: 1343ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@mikesposito mikesposito enabled auto-merge April 24, 2025 16:51
@mikesposito mikesposito added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@mikesposito mikesposito added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 29b3fc6 Apr 25, 2025
173 of 175 checks passed
@mikesposito mikesposito deleted the mikesposito/bumps/eth-ledger-bridge-keyring branch April 25, 2025 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants