fix: cp-12.17.0 Fix remove nft

[sahar-fehri]

Description

PR to fix removal of NFT on a network different than the nft network.

Related issues

Fixes:

Manual testing steps

1. Make sure you have NFTs on two different networks exp (linea and ethereum)
2. Select Ethereum network
3. Go to NFTs tab
4. Remove and NFT on linea
5. It should be removed successfully

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[gambinish]

LGTM. Does this need to be cherry picked to a release?

[metamaskbot]

Builds ready [f55a4e4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1255 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1255	1115	1403	66	1305	1369
			load	1089	976	1230	64	1136	1192
			domContentLoaded	1082	969	1221	64	1129	1186
			domInteractive	18	14	65	6	17	28
			firstPaint	691	164	1228	430	1104	1183
			backgroundConnect	8	3	30	4	8	16
			firstReactRender	21	16	47	5	22	36
			getState	12	5	31	7	18	26
			initialActions	0	0	1	0	0	1
			loadScripts	838	730	965	62	892	936
			setupStore	8	5	25	3	9	12
	Webpack	Home	uiStartup	2122	1762	2601	169	2218	2387
			load	1636	1294	2008	133	1736	1837
			domContentLoaded	1629	1287	1998	132	1732	1827
			domInteractive	15	11	54	9	13	45
			firstPaint	179	62	424	65	202	310
			backgroundConnect	35	10	373	56	31	72
			firstReactRender	223	55	370	123	345	363
			getState	12	4	43	7	14	27
			initialActions	3	1	5	1	3	4
			loadScripts	1624	1285	1974	131	1731	1822
			setupStore	19	7	304	29	20	29
Firefox	Browserify	Home	uiStartup	1351	1190	1741	105	1393	1569
			load	1209	1012	1625	113	1267	1447
			domContentLoaded	1209	1011	1625	113	1267	1447
			domInteractive	106	39	242	33	121	179
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	120	14	19	48
			firstReactRender	22	19	64	5	22	27
			getState	6	4	18	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1191	998	1611	114	1249	1432
			setupStore	6	4	29	3	6	7
	Webpack	Home	uiStartup	1471	1314	1707	88	1540	1650
			load	1258	1127	1497	81	1290	1455
			domContentLoaded	1258	1127	1497	81	1290	1454
			domInteractive	79	38	269	29	82	129
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	46	5	21	32
			firstReactRender	34	29	54	4	36	43
			getState	11	4	67	9	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1239	1109	1483	81	1274	1437
			setupStore	9	5	50	7	8	23

[metamaskbot]

Builds ready [4d4df84]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1219 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1082	1394	62	1249	1337
			load	1055	956	1195	53	1082	1175
			domContentLoaded	1049	951	1191	53	1075	1168
			domInteractive	18	13	63	8	16	30
			firstPaint	691	136	1176	413	1063	1120
			backgroundConnect	7	4	19	3	8	11
			firstReactRender	22	16	52	8	22	41
			getState	13	4	42	9	18	33
			initialActions	0	0	1	0	0	0
			loadScripts	809	719	949	51	838	905
			setupStore	8	5	25	3	9	13
	Webpack	Home	uiStartup	2200	1811	2644	163	2315	2411
			load	1702	1388	2124	127	1790	1894
			domContentLoaded	1694	1384	2095	125	1783	1876
			domInteractive	15	12	76	10	13	43
			firstPaint	200	72	1799	172	228	323
			backgroundConnect	28	10	78	14	33	62
			firstReactRender	240	57	368	113	337	359
			getState	18	4	264	33	18	35
			initialActions	3	1	8	1	4	7
			loadScripts	1689	1382	2069	124	1780	1860
			setupStore	20	7	182	18	22	35
Firefox	Browserify	Home	uiStartup	1371	1181	1838	111	1435	1578
			load	1223	1034	1684	113	1303	1431
			domContentLoaded	1222	1034	1683	114	1303	1431
			domInteractive	106	38	294	36	121	175
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	12	177	25	21	101
			firstReactRender	22	19	41	3	23	28
			getState	8	4	60	7	8	13
			initialActions	0	0	1	0	0	1
			loadScripts	1199	1019	1663	112	1273	1403
			setupStore	6	4	15	1	6	8
	Webpack	Home	uiStartup	1444	1285	1873	108	1510	1648
			load	1241	1113	1646	99	1298	1450
			domContentLoaded	1241	1112	1646	99	1298	1449
			domInteractive	80	34	232	27	90	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	59	7	21	33
			firstReactRender	34	28	53	5	35	44
			getState	9	4	57	7	8	29
			initialActions	0	0	2	1	1	1
			loadScripts	1223	1097	1630	98	1281	1408
			setupStore	8	5	39	5	8	19

cc: @HowardBraham
Benchmark value 33 exceeds gate value 31 for chrome browserify home p95 getState
Benchmark value 2201 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 200 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 241 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 324 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 101 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Sum of mean exceeds: 41ms | Sum of p95 exceeds: 47ms
Sum of all benchmark exceeds: 88ms