chore: cp-12.16.2 Make "Dapp Viewed" event exclude metametrics id data

[adonesky1]

Description

Per this slack thread, we should exclude metametrics Id data from Dapp Viewed events

Before

After

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4743

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [ecdd221]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1211 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1093	1450	65	1248	1318
			load	1044	935	1222	57	1082	1133
			domContentLoaded	1038	932	1219	56	1075	1127
			domInteractive	18	13	76	9	16	29
			firstPaint	776	133	1185	396	1067	1127
			backgroundConnect	7	4	20	2	7	14
			firstReactRender	20	15	47	4	21	29
			getState	14	5	111	13	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	801	707	962	53	835	893
			setupStore	8	5	21	3	8	12
	Webpack	Home	uiStartup	2131	1729	2574	165	2249	2358
			load	1643	1349	2165	132	1731	1816
			domContentLoaded	1634	1345	1974	124	1723	1805
			domInteractive	16	11	57	10	13	48
			firstPaint	176	58	408	68	217	313
			backgroundConnect	27	9	247	26	28	57
			firstReactRender	226	55	369	117	337	357
			getState	12	4	49	8	15	29
			initialActions	3	1	8	1	4	7
			loadScripts	1630	1344	1950	124	1720	1803
			setupStore	21	7	332	32	23	34
Firefox	Browserify	Home	uiStartup	1396	1215	1683	106	1476	1591
			load	1242	1063	1536	112	1326	1459
			domContentLoaded	1242	1063	1535	112	1326	1459
			domInteractive	105	37	248	35	119	181
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	80	11	22	44
			firstReactRender	24	19	55	6	25	34
			getState	8	4	30	4	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1222	1046	1521	113	1308	1441
			setupStore	8	4	192	19	6	10
	Webpack	Home	uiStartup	1497	1335	1787	115	1567	1773
			load	1284	1137	1591	102	1344	1520
			domContentLoaded	1284	1136	1590	102	1344	1519
			domInteractive	80	36	151	20	87	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	46	5	21	30
			firstReactRender	34	28	50	4	36	45
			getState	8	4	39	5	8	22
			initialActions	0	0	2	1	1	1
			loadScripts	1266	1121	1560	102	1322	1501
			setupStore	9	5	62	7	8	27

Benchmark value 1242 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 0ms
Sum of all benchmark exceeds: 3ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 78 Bytes (0%)
• ui: 24.22 KiB (0.35%)
• common: 0 Bytes (0%)

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

Builds ready [a1b4f7b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1199 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1199	1079	1447	65	1231	1329
			load	1036	920	1243	58	1067	1144
			domContentLoaded	1031	916	1239	58	1062	1139
			domInteractive	18	13	63	9	16	31
			firstPaint	620	132	1146	413	1027	1093
			backgroundConnect	6	4	17	2	7	9
			firstReactRender	19	15	30	3	20	24
			getState	13	5	33	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	795	684	988	57	823	902
			setupStore	8	4	17	2	8	13
	Webpack	Home	uiStartup	2089	1693	2494	174	2223	2333
			load	1607	1326	1991	124	1699	1762
			domContentLoaded	1601	1323	1971	123	1695	1755
			domInteractive	17	11	96	13	13	50
			firstPaint	181	71	388	61	206	319
			backgroundConnect	25	9	81	14	26	59
			firstReactRender	199	55	374	116	313	358
			getState	14	4	217	22	13	32
			initialActions	3	1	6	1	3	5
			loadScripts	1593	1321	1948	126	1691	1753
			setupStore	21	6	288	38	19	39
Firefox	Browserify	Home	uiStartup	1341	1182	1744	110	1399	1564
			load	1194	1001	1595	116	1261	1418
			domContentLoaded	1194	1000	1594	115	1261	1418
			domInteractive	107	40	383	48	120	227
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	201	21	20	28
			firstReactRender	22	19	39	3	22	27
			getState	9	4	228	22	7	13
			initialActions	0	0	1	0	0	1
			loadScripts	1175	989	1583	114	1244	1402
			setupStore	6	4	27	3	6	7
	Webpack	Home	uiStartup	1492	1266	1839	114	1586	1712
			load	1287	1091	1605	101	1360	1475
			domContentLoaded	1287	1091	1605	101	1359	1475
			domInteractive	83	37	152	22	96	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	116	11	21	33
			firstReactRender	34	29	45	4	36	41
			getState	7	5	22	2	8	11
			initialActions	1	0	2	1	1	1
			loadScripts	1268	1075	1590	101	1340	1457
			setupStore	8	5	64	8	8	24

Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 32ms
Sum of all benchmark exceeds: 32ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: 3.68 KiB (0.07%)
• ui: 13.69 KiB (0.2%)
• common: -38.8 KiB (-0.42%)