feat: 1.11 New SRP review and confirm UI #33289

lionellbriones · 2025-05-29T17:06:37Z

Description

New SRP review UI
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=6188-88752&t=KttJt1lvkqwslaMK-4

Screen.Recording.2025-06-11.at.4.23.05.PM.mov

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- update social login button radius - allow closing terms of use modal

- toggle password button stop propagating

…etail-modal

…re-your-wallet

…tametrics

…successful

…in-extension

ui/pages/onboarding-flow/recovery-phrase/confirm-srp-modal.tsx

metamaskbot · 2025-06-12T14:06:34Z

Builds ready [42e483d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1083	1355	60	1240	1307
			load	1047	932	1180	57	1080	1144
			domContentLoaded	1041	926	1170	58	1075	1138
			domInteractive	16	13	35	4	16	28
			firstPaint	749	130	1178	413	1069	1144
			backgroundConnect	7	4	26	4	8	21
			firstReactRender	20	16	42	5	20	34
			getState	14	6	38	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	798	693	927	57	831	900
			setupStore	8	5	18	3	8	14
	Webpack	Home	uiStartup	2157	1726	2551	197	2261	2532
			load	1684	1342	1954	158	1797	1931
			domContentLoaded	1678	1338	1945	157	1791	1926
			domInteractive	17	12	76	12	13	49
			firstPaint	158	63	314	52	174	264
			backgroundConnect	21	11	40	6	23	36
			firstReactRender	145	47	380	110	207	366
			getState	14	4	321	31	13	21
			initialActions	3	1	5	1	3	4
			loadScripts	1675	1336	1934	156	1789	1921
			setupStore	45	7	326	90	19	317
Firefox	Browserify	Home	uiStartup	1327	1185	1620	82	1380	1471
			load	1178	1053	1454	78	1228	1320
			domContentLoaded	1178	1053	1454	79	1228	1319
			domInteractive	101	32	187	26	111	146
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	139	18	22	48
			firstReactRender	23	20	60	4	23	29
			getState	7	4	36	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1157	1036	1365	75	1212	1302
			setupStore	7	4	34	5	6	11
	Webpack	Home	uiStartup	1495	1350	1751	97	1568	1696
			load	1305	1164	1562	100	1366	1521
			domContentLoaded	1305	1164	1562	100	1366	1520
			domInteractive	79	58	173	16	86	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	28	2	21	24
			firstReactRender	40	32	47	3	42	45
			getState	8	5	30	4	8	10
			initialActions	0	0	2	1	1	1
			loadScripts	1286	1147	1542	101	1349	1502
			setupStore	7	5	30	3	7	9

Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 46 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2533 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 317 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 334ms
Sum of all benchmark exceeds: 350ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

metamaskbot · 2025-06-12T15:42:48Z

Builds ready [0fd1c82]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1112	1479	71	1271	1363
			load	1070	956	1252	69	1126	1187
			domContentLoaded	1064	941	1247	69	1120	1181
			domInteractive	18	14	97	12	17	29
			firstPaint	672	84	1255	436	1068	1170
			backgroundConnect	8	4	27	6	8	25
			firstReactRender	20	16	45	4	21	28
			getState	14	6	42	8	20	29
			initialActions	0	0	1	0	0	1
			loadScripts	815	705	982	67	870	934
			setupStore	8	5	30	3	8	13
	Webpack	Home	uiStartup	2216	1723	2692	216	2357	2587
			load	1734	1346	2109	177	1836	1990
			domContentLoaded	1728	1342	2104	176	1828	1981
			domInteractive	16	12	62	10	13	47
			firstPaint	159	66	382	53	182	268
			backgroundConnect	21	11	45	7	25	37
			firstReactRender	154	46	383	111	295	349
			getState	12	4	40	6	14	26
			initialActions	3	1	5	1	3	4
			loadScripts	1725	1340	2102	175	1826	1977
			setupStore	43	7	329	87	20	324
Firefox	Browserify	Home	uiStartup	1330	1197	1519	72	1370	1491
			load	1185	1060	1368	73	1240	1347
			domContentLoaded	1185	1060	1367	73	1239	1346
			domInteractive	97	36	171	27	114	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	105	12	21	27
			firstReactRender	23	20	29	2	23	28
			getState	7	5	39	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1165	1046	1348	69	1220	1324
			setupStore	7	4	36	4	6	11
	Webpack	Home	uiStartup	1620	1389	1908	118	1708	1833
			load	1409	1202	1688	121	1502	1623
			domContentLoaded	1409	1201	1687	121	1500	1622
			domInteractive	83	57	168	15	90	107
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	17	53	6	24	43
			firstReactRender	44	36	54	3	47	49
			getState	9	5	30	4	10	18
			initialActions	0	0	2	1	1	1
			loadScripts	1389	1182	1666	121	1482	1601
			setupStore	8	6	21	3	9	14

Benchmark value 1236 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2216 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1735 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1729 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1726 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 44 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2588 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1978 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 324 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1621 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1409 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1389 exceeds gate value 1360 for firefox webpack home mean loadScripts
Sum of mean exceeds: 218ms | Sum of p95 exceeds: 409ms
Sum of all benchmark exceeds: 627ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

metamaskbot · 2025-06-12T16:12:52Z

Builds ready [9812728]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1111	1449	69	1260	1347
			load	1058	960	1260	66	1094	1196
			domContentLoaded	1052	952	1256	66	1088	1189
			domInteractive	17	14	34	4	17	29
			firstPaint	767	97	1265	420	1087	1196
			backgroundConnect	7	4	24	4	7	21
			firstReactRender	20	16	31	2	21	23
			getState	14	5	45	8	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	805	697	995	66	843	940
			setupStore	8	5	15	2	8	13
	Webpack	Home	uiStartup	2168	1731	2678	244	2323	2590
			load	1685	1350	2110	202	1837	2012
			domContentLoaded	1679	1346	2099	200	1833	2003
			domInteractive	16	12	56	10	14	49
			firstPaint	159	65	444	59	179	267
			backgroundConnect	22	13	50	7	24	40
			firstReactRender	149	48	375	111	274	355
			getState	12	4	39	6	14	27
			initialActions	3	1	6	1	3	4
			loadScripts	1676	1344	2088	199	1831	1992
			setupStore	45	7	333	91	20	321
Firefox	Browserify	Home	uiStartup	1321	1184	1522	65	1361	1455
			load	1172	1061	1396	60	1221	1270
			domContentLoaded	1172	1061	1396	60	1221	1270
			domInteractive	98	36	201	27	107	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	64	8	21	49
			firstReactRender	24	21	55	5	24	28
			getState	7	4	35	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1153	1044	1370	59	1201	1257
			setupStore	6	4	24	2	6	11
	Webpack	Home	uiStartup	1501	1356	1884	112	1567	1715
			load	1306	1150	1597	106	1380	1526
			domContentLoaded	1305	1150	1597	106	1380	1525
			domInteractive	79	52	147	15	85	111
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	41	6	21	39
			firstReactRender	40	29	47	3	42	46
			getState	8	4	29	3	9	10
			initialActions	0	0	2	1	1	1
			loadScripts	1288	1131	1579	106	1359	1507
			setupStore	10	5	248	24	8	9

Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 46 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2591 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1993 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 321 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 450ms
Sum of all benchmark exceeds: 466ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

metamaskbot · 2025-06-13T02:13:38Z

Builds ready [4344f8c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1228 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1228	1121	1528	72	1253	1377
			load	1063	954	1315	67	1089	1216
			domContentLoaded	1057	950	1311	67	1082	1210
			domInteractive	17	14	36	5	16	32
			firstPaint	772	84	1256	416	1085	1166
			backgroundConnect	7	4	28	4	8	21
			firstReactRender	21	16	58	6	21	36
			getState	14	6	32	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	809	714	1057	65	834	957
			setupStore	8	5	15	2	8	13
	Webpack	Home	uiStartup	2112	1639	2590	218	2256	2460
			load	1630	1285	1994	166	1744	1885
			domContentLoaded	1624	1281	1984	165	1740	1876
			domInteractive	17	11	72	13	13	52
			firstPaint	155	63	305	49	186	241
			backgroundConnect	21	10	45	7	25	35
			firstReactRender	154	46	372	115	310	363
			getState	16	4	410	40	13	24
			initialActions	5	1	266	26	3	4
			loadScripts	1620	1280	1973	163	1738	1865
			setupStore	48	7	322	92	21	315
Firefox	Browserify	Home	uiStartup	1338	1193	1585	73	1376	1480
			load	1193	1039	1433	76	1241	1338
			domContentLoaded	1193	1039	1432	76	1241	1338
			domInteractive	104	36	248	29	120	145
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	108	11	22	40
			firstReactRender	23	20	33	2	24	27
			getState	7	4	21	3	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1173	1025	1419	76	1222	1313
			setupStore	6	4	31	3	6	11
	Webpack	Home	uiStartup	1519	1375	1766	97	1580	1712
			load	1319	1178	1564	96	1380	1509
			domContentLoaded	1318	1178	1563	96	1380	1509
			domInteractive	80	61	164	16	87	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	42	5	22	28
			firstReactRender	41	28	48	4	44	46
			getState	9	5	31	5	9	28
			initialActions	1	0	2	1	1	2
			loadScripts	1300	1158	1545	97	1361	1491
			setupStore	8	5	24	3	8	10

Benchmark value 1377 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 49 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2460 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 21ms | Sum of p95 exceeds: 346ms
Sum of all benchmark exceeds: 367ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

metamaskbot · 2025-06-13T02:56:34Z

Builds ready [d9044fb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1095	1403	61	1250	1336
			load	1045	944	1176	52	1077	1161
			domContentLoaded	1039	941	1172	53	1072	1155
			domInteractive	17	14	44	6	17	32
			firstPaint	775	130	1170	395	1065	1162
			backgroundConnect	7	4	26	4	7	22
			firstReactRender	21	17	44	5	21	33
			getState	13	5	40	8	18	27
			initialActions	0	0	1	0	0	1
			loadScripts	792	699	926	52	819	904
			setupStore	8	5	25	3	8	14
	Webpack	Home	uiStartup	2072	1617	2563	224	2220	2436
			load	1591	1267	1961	171	1728	1858
			domContentLoaded	1585	1263	1950	170	1720	1849
			domInteractive	16	11	67	12	13	52
			firstPaint	166	61	681	76	191	293
			backgroundConnect	21	11	44	6	25	33
			firstReactRender	154	46	366	114	313	354
			getState	14	4	317	31	12	20
			initialActions	3	1	5	1	3	4
			loadScripts	1582	1261	1940	169	1717	1838
			setupStore	50	7	320	95	20	308
Firefox	Browserify	Home	uiStartup	1288	1154	1567	73	1332	1412
			load	1147	1027	1422	71	1193	1267
			domContentLoaded	1147	1027	1421	71	1193	1267
			domInteractive	98	36	190	27	113	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	18	13	48	5	19	26
			firstReactRender	22	20	28	2	22	27
			getState	7	4	36	5	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1129	1012	1397	70	1177	1253
			setupStore	7	3	36	5	6	21
	Webpack	Home	uiStartup	1505	1357	1758	83	1559	1676
			load	1312	1177	1560	87	1364	1495
			domContentLoaded	1311	1177	1559	87	1364	1494
			domInteractive	81	31	164	16	88	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	16	47	5	21	27
			firstReactRender	40	29	47	3	42	45
			getState	9	4	65	8	9	30
			initialActions	0	0	2	1	1	1
			loadScripts	1294	1166	1543	88	1345	1477
			setupStore	8	5	29	4	8	20

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 247ms
Sum of all benchmark exceeds: 267ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

metamaskbot · 2025-06-13T03:23:38Z

Builds ready [4669a0b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1090	1474	69	1240	1346
			load	1050	946	1260	63	1081	1156
			domContentLoaded	1044	941	1254	63	1074	1150
			domInteractive	17	13	103	10	16	30
			firstPaint	790	144	1262	392	1065	1158
			backgroundConnect	7	3	34	5	7	25
			firstReactRender	19	16	42	3	20	23
			getState	13	5	39	7	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	800	698	1009	62	834	899
			setupStore	8	5	22	2	8	12
	Webpack	Home	uiStartup	2200	1673	2596	192	2305	2508
			load	1701	1292	2085	168	1809	1952
			domContentLoaded	1695	1288	2081	167	1805	1948
			domInteractive	16	12	75	9	14	35
			firstPaint	156	61	582	72	179	262
			backgroundConnect	28	11	289	35	27	41
			firstReactRender	147	47	368	106	286	341
			getState	14	5	202	20	15	25
			initialActions	6	1	284	28	4	5
			loadScripts	1691	1286	2079	166	1803	1947
			setupStore	52	7	321	96	23	318
Firefox	Browserify	Home	uiStartup	1291	1168	1567	70	1334	1435
			load	1149	1040	1418	69	1182	1288
			domContentLoaded	1149	1040	1417	70	1181	1288
			domInteractive	96	35	173	25	111	142
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	49	6	19	27
			firstReactRender	22	20	29	2	23	27
			getState	7	4	36	4	8	10
			initialActions	0	0	31	3	0	1
			loadScripts	1132	1025	1392	68	1162	1263
			setupStore	6	4	11	2	6	10
	Webpack	Home	uiStartup	1537	1364	1773	100	1610	1722
			load	1340	1179	1592	103	1421	1543
			domContentLoaded	1340	1179	1592	103	1421	1543
			domInteractive	80	54	206	18	85	107
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	78	7	22	30
			firstReactRender	41	30	52	4	43	47
			getState	9	4	31	5	9	21
			initialActions	1	0	4	1	1	1
			loadScripts	1321	1163	1573	104	1405	1527
			setupStore	8	5	28	3	8	10

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2200 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 53 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2509 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 318 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 32ms | Sum of p95 exceeds: 315ms
Sum of all benchmark exceeds: 347ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 2.75 KiB (0.04%)
common: 358 Bytes (0%)

lionellbriones added 30 commits May 22, 2025 18:23

chore: clean locales

202518d

feat: add confirm srp locales

16f0c4e

Merge branch 'main' into feat/srp-flow-assets

4e3d265

Merge branch 'feat/srp-flow-assets' into feat/srp-flow-terms-of-use

63b1936

fix: fix copywriting for check agree TOS

e7c6d80

Merge branch 'feat/srp-flow-terms-of-use' into feat/srp-flow-welcome

0f066c3

fix: support smaller screen height

0c19dc4

- update social login button radius - allow closing terms of use modal

Merge branch 'feat/srp-flow-welcome' into feat/srp-flow-header

68558c6

feat: do not show app-header on onboarding routes

ba29c6f

Merge branch 'feat/srp-flow-header' into feat/srp-flow-create-password

491e548

fix: back button

0d5aa4b

- toggle password button stop propagating

Merge branch 'feat/srp-flow-create-password' into feat/srp-flow-srp-d…

a17a68c

…etail-modal

Merge branch 'feat/srp-flow-srp-detail-modal' into feat/srp-flow-secu…

9ab3c24

…re-your-wallet

Merge branch 'feat/srp-flow-secure-your-wallet' into feat/srp-flow-me…

1e8e319

…tametrics

fix: remove privacy description, not part of new design

90e6d94

fix: update disclaimer note at bottom

f649ff2

Merge branch 'feat/srp-flow-metametrics' into feat/srp-flow-creation-…

3debc3a

…successful

fix: use same logic on displaying texts

461d282

Merge branch 'feat/srp-flow-creation-successful' into feat/srp-flow-p…

fd23307

…in-extension

fix: render details not found

621993b

Merge branch 'feat/srp-flow-creation-successful' into feat/srp-flow-p…

3928afe

…in-extension

fix: align text color with design

7f939d2

Merge branch 'feat/srp-flow-creation-successful' into feat/srp-flow-p…

d8b3f93

…in-extension

fix: update asset and minor ui issues

9dd289f

Merge branch 'feat/srp-flow-pin-extension' into feat/srp-flow-review

29b0bfc

fix: minor text color fix

e4766d0

Merge branch 'feat/srp-flow-review' into feat/srp-flow-confirm

60d5801

fix: remove confirm modal close button

c7bd19b

Merge branch 'main' into feat/srp-flow-assets

a3dec94

Merge branch 'feat/srp-flow-assets' into feat/srp-flow-terms-of-use

82ce82d

darkwing reviewed Jun 12, 2025

View reviewed changes

ui/pages/onboarding-flow/recovery-phrase/confirm-srp-modal.tsx Show resolved Hide resolved

darkwing approved these changes Jun 12, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 12, 2025

nakulmk disabled auto-merge June 12, 2025 14:15

nakulmk enabled auto-merge June 12, 2025 14:16

chaitanyapotti and others added 3 commits June 12, 2025 22:47

Merge branch 'main' into feat/srp-flow-review

35bce4c

Merge branch 'main' into feat/srp-flow-review

82ca614

Merge branch 'main' into feat/srp-flow-review

0fd1c82

Merge branch 'main' into feat/srp-flow-review

9812728

nakulmk added this pull request to the merge queue Jun 12, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025

Merge branch 'main' into feat/srp-flow-review

368df19

lwin-kyaw enabled auto-merge June 12, 2025 17:51

lwin-kyaw and others added 2 commits June 13, 2025 02:34

Merge branch 'main' into feat/srp-flow-review

9d98e29

Merge branch 'main' into feat/srp-flow-review

4344f8c

chaitanyapotti disabled auto-merge June 13, 2025 02:25

Merge branch 'main' into feat/srp-flow-review

d9044fb

Merge branch 'main' into feat/srp-flow-review

4669a0b

lwin-kyaw added this pull request to the merge queue Jun 13, 2025

Merged via the queue into main with commit 929f04a Jun 13, 2025
398 of 403 checks passed

lwin-kyaw deleted the feat/srp-flow-review branch June 13, 2025 04:05

github-actions bot locked and limited conversation to collaborators Jun 13, 2025

metamaskbot added the release-12.22.0 Issue or pull request that will be included in release 12.22.0 label Jun 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: 1.11 New SRP review and confirm UI #33289

feat: 1.11 New SRP review and confirm UI #33289

Uh oh!

lionellbriones commented May 29, 2025 •

edited by chaitanyapotti

Loading

Uh oh!

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

feat: 1.11 New SRP review and confirm UI #33289

feat: 1.11 New SRP review and confirm UI #33289

Uh oh!

Conversation

lionellbriones commented May 29, 2025 • edited by chaitanyapotti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

metamaskbot commented Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lionellbriones commented May 29, 2025 •

edited by chaitanyapotti

Loading