-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: 1.12 new srp import UI #33297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: 1.12 new srp import UI #33297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation-successful
chaitanyapotti
requested changes
Jun 13, 2025
Collaborator
Builds ready [531b824]
UI Startup Metrics (1214 ± 60 ms)
Benchmark value 71 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 40ms | Sum of p95 exceeds: 254ms Sum of all benchmark exceeds: 294ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a6191b4]
UI Startup Metrics (1182 ± 55 ms)
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2480 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 12ms | Sum of p95 exceeds: 282ms Sum of all benchmark exceeds: 294ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
388834e to
f1fa829
Compare
chaitanyapotti
approved these changes
Jun 13, 2025
Member
chaitanyapotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Collaborator
Builds ready [f1fa829]
UI Startup Metrics (1212 ± 68 ms)
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 58 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 87ms | Sum of p95 exceeds: 253ms Sum of all benchmark exceeds: 340ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
lwin-kyaw
approved these changes
Jun 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-onboarding
release-12.22.0
Issue or pull request that will be included in release 12.22.0
team-onboarding
Onboarding team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New srp import UI
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=2552-59203&t=KttJt1lvkqwslaMK-4
Screen.Recording.2025-06-11.at.6.17.46.PM.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist