Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented May 30, 2025

Description

New srp import UI
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=2552-59203&t=KttJt1lvkqwslaMK-4

Screen.Recording.2025-06-11.at.6.17.46.PM.mov

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Needs more work from the author in PR review queue Jun 13, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [531b824]
UI Startup Metrics (1214 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1214110913896012581326
load105596212155810911155
domContentLoaded104894511875810851148
domInteractive17143541630
firstPaint74873119941510731156
backgroundConnect74274721
firstReactRender20164152035
getState1464681928
initialActions001001
loadScripts80170394157835897
setupStore85343812
WebpackHomeuiStartup20451612249820421382445
load15861264189616417101864
domContentLoaded15801260188616417061855
domInteractive161154101346
firstPaint1526639651179235
backgroundConnect20103452333
firstReactRender13245375112107357
getState1042841118
initialActions216134
loadScripts15771259187516317041844
setupStore71632111719315
FirefoxBrowserifyHomeuiStartup1342120516488113901497
load1191106814898212431362
domContentLoaded1190106714898212421362
domInteractive1033625832117164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201310292127
firstReactRender24214032429
getState85385810
initialActions002001
loadScripts1172105214748012201312
setupStore74376712
WebpackHomeuiStartup14541314171110115311640
load12711132153210113371462
domContentLoaded12711132153110113371462
domInteractive75301652081119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20144142126
firstReactRender39284534144
getState75282810
initialActions002111
loadScripts12531114151410113201443
setupStore7528278
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 71 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 40ms | Sum of p95 exceeds: 254ms
Sum of all benchmark exceeds: 294ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 4.67 KiB (0.07%)
  • common: 76 Bytes (0%)

@lwin-kyaw lwin-kyaw requested a review from chaitanyapotti June 13, 2025 05:03
@metamaskbot
Copy link
Collaborator

Builds ready [a6191b4]
UI Startup Metrics (1182 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1182108613645512091297
load102694011785110551145
domContentLoaded102092711645210481137
domInteractive16143541627
firstPaint69277117440610411088
backgroundConnect84336725
firstReactRender20153132027
getState1463471928
initialActions001000
loadScripts77769190850802886
setupStore74172813
WebpackHomeuiStartup20881620249720022122480
load16191253191315717221888
domContentLoaded16131249190215617181877
domInteractive161162111348
firstPaint1526230648167255
backgroundConnect21104372436
firstReactRender13346366104144342
getState204322531321
initialActions316134
loadScripts16101247189115517161866
setupStore4173208519313
FirefoxBrowserifyHomeuiStartup1292118814686113371400
load1151104313116412051272
domContentLoaded1151104313116412051271
domInteractive953318827109133
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20125682047
firstReactRender22202722227
getState7437489
initialActions001001
loadScripts1134103012986311861254
setupStore5311167
WebpackHomeuiStartup1494134817289315731672
load1301117315479513961485
domContentLoaded1300117315469513961484
domInteractive79321241591106
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20164552129
firstReactRender39314834245
getState84314810
initialActions102111
loadScripts1282115315299613781467
setupStore85293810
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2480 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 12ms | Sum of p95 exceeds: 282ms
Sum of all benchmark exceeds: 294ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 4.67 KiB (0.07%)
  • common: 76 Bytes (0%)

@lwin-kyaw lwin-kyaw force-pushed the feat/srp-flow-import branch from 388834e to f1fa829 Compare June 13, 2025 05:34
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti enabled auto-merge June 13, 2025 05:36
@metamaskbot
Copy link
Collaborator

Builds ready [f1fa829]
UI Startup Metrics (1212 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212109713696812621332
load105694411796511071173
domContentLoaded104993311706511021164
domInteractive17136361632
firstPaint859126118537210971172
backgroundConnect84305723
firstReactRender20145242022
getState1564172028
initialActions001001
loadScripts80669493365857921
setupStore75142812
WebpackHomeuiStartup20551482250322321912439
load15941140192317717201849
domContentLoaded15891136191417617151841
domInteractive1711189201348
firstPaint1596448259187271
backgroundConnect20106072233
firstReactRender13246368105124351
getState1042341219
initialActions512962935
loadScripts15861135190417517141830
setupStore58632110520312
FirefoxBrowserifyHomeuiStartup1363119715538114261517
load1212106914147812711362
domContentLoaded1212106914137812711362
domInteractive1043617231124165
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515128172352
firstReactRender24216142427
getState84373811
initialActions001001
loadScripts1189105413957812491346
setupStore64394611
WebpackHomeuiStartup14931297178910715811679
load13011138160610913891499
domContentLoaded13011137160510913891499
domInteractive77331671682100
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20154452131
firstReactRender40276954246
getState95305828
initialActions001011
loadScripts12831123158410913601485
setupStore85456825
Benchmark value 859 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 58 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 87ms | Sum of p95 exceeds: 253ms
Sum of all benchmark exceeds: 340ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 4.71 KiB (0.07%)
  • common: 76 Bytes (0%)

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jun 13, 2025
@github-project-automation github-project-automation bot moved this from Needs more work from the author to Review finalised - Ready to be merged in PR review queue Jun 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@nakulmk nakulmk added this pull request to the merge queue Jun 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@lwin-kyaw lwin-kyaw added this pull request to the merge queue Jun 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@lwin-kyaw lwin-kyaw added this pull request to the merge queue Jun 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit d2c6be7 Jun 13, 2025
271 of 274 checks passed
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 13, 2025
@chaitanyapotti chaitanyapotti deleted the feat/srp-flow-import branch June 13, 2025 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
@metamaskbot metamaskbot added the release-12.22.0 Issue or pull request that will be included in release 12.22.0 label Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding release-12.22.0 Issue or pull request that will be included in release 12.22.0 team-onboarding Onboarding team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants