fix: gracefully end sub-stream on port disconnect to prevent Premature close error #33470

salimtb · 2025-06-04T11:56:01Z

Description

This PR improves the resilience of the createCaipStream utility by gracefully handling stream shutdowns triggered by tab or iframe closures. Previously, when a user clicked an external link (e.g., to a help article) from within a MetaMask confirmation popup, the resulting tab load would create a CAIP stream, and when that tab closed, it triggered "Premature close" errors.

The fix listens for low-level portStream termination events (close, end, and onDisconnect) and explicitly ends the CAIP sub-stream, allowing the pipeline to close cleanly. This prevents noisy, non-actionable errors from polluting logs or Sentry reports, without affecting real error detection or functionality.

Related issues

Fixes: #26284

Manual testing steps

Choose any Solana account
Open the MetaMask confirmation popup (e.g., for adding a network).
Click a link in the link text "network scams and security risks"
A new tab will open.
Close the new tab.
✅ Observe: no “Premature close” error appears in the console or Sentry.

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…e close errors

github-actions · 2025-06-04T11:56:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-04T12:29:07Z

Builds ready [eb7c3ae]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1121	1433	63	1275	1339
			load	1071	967	1253	59	1115	1168
			domContentLoaded	1064	955	1245	59	1107	1163
			domInteractive	17	14	43	5	17	30
			firstPaint	778	141	1250	414	1093	1168
			backgroundConnect	8	4	27	4	8	15
			firstReactRender	20	17	38	3	21	25
			getState	14	6	29	7	20	27
			initialActions	0	0	1	0	0	1
			loadScripts	814	709	974	58	864	911
			setupStore	8	5	34	3	8	11
	Webpack	Home	uiStartup	2174	1657	2739	277	2359	2642
			load	1693	1295	2274	234	1824	2171
			domContentLoaded	1687	1291	2269	233	1817	2160
			domInteractive	16	11	79	11	14	42
			firstPaint	179	60	558	86	215	343
			backgroundConnect	23	9	66	9	27	41
			firstReactRender	142	44	408	107	140	360
			getState	13	5	72	9	15	29
			initialActions	3	1	7	1	3	5
			loadScripts	1684	1290	2267	232	1815	2145
			setupStore	35	6	332	69	19	286
Firefox	Browserify	Home	uiStartup	1363	1174	1749	131	1412	1697
			load	1200	1051	1542	100	1253	1428
			domContentLoaded	1199	1050	1541	100	1253	1428
			domInteractive	97	35	207	27	108	146
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	81	10	22	44
			firstReactRender	24	20	49	5	24	32
			getState	13	4	226	30	8	38
			initialActions	0	0	1	0	0	1
			loadScripts	1181	1038	1528	99	1235	1404
			setupStore	9	4	176	19	6	28
	Webpack	Home	uiStartup	1559	1379	2032	149	1632	1910
			load	1355	1196	1813	138	1436	1668
			domContentLoaded	1354	1195	1812	138	1436	1668
			domInteractive	77	51	141	19	81	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	68	7	23	39
			firstReactRender	42	31	75	6	44	50
			getState	10	5	163	16	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1335	1175	1796	137	1420	1652
			setupStore	10	5	250	24	8	11

Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2643 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2171 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2161 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 344 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 2146 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 286 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1697 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1668 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1668 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1652 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 983ms
Sum of all benchmark exceeds: 1003ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.29 KiB (-0.44%)
ui: 4 KiB (0.06%)
common: -7.74 KiB (-0.09%)

metamaskbot · 2025-06-04T14:04:22Z

Builds ready [2d2c797]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1117	1414	62	1250	1336
			load	1050	941	1207	56	1085	1160
			domContentLoaded	1042	937	1203	54	1076	1140
			domInteractive	17	13	66	6	16	29
			firstPaint	744	131	1182	406	1066	1148
			backgroundConnect	9	5	73	8	8	27
			firstReactRender	20	17	44	4	21	28
			getState	15	6	59	10	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	792	693	951	54	826	882
			setupStore	8	5	17	2	8	13
	Webpack	Home	uiStartup	2129	1575	2658	239	2268	2561
			load	1660	1225	2006	191	1786	1979
			domContentLoaded	1653	1221	1993	189	1782	1963
			domInteractive	16	12	63	11	13	53
			firstPaint	158	69	322	59	193	274
			backgroundConnect	22	13	41	7	25	37
			firstReactRender	131	44	370	99	116	357
			getState	11	4	31	4	13	17
			initialActions	3	1	5	1	3	4
			loadScripts	1651	1220	1982	188	1781	1952
			setupStore	38	7	319	78	18	299
Firefox	Browserify	Home	uiStartup	1349	1177	1914	132	1403	1624
			load	1190	1043	1787	114	1243	1433
			domContentLoaded	1190	1042	1786	114	1243	1433
			domInteractive	96	36	313	33	102	158
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	103	13	21	55
			firstReactRender	23	20	50	4	23	29
			getState	11	4	193	24	8	20
			initialActions	0	0	2	0	0	1
			loadScripts	1172	1027	1772	111	1226	1414
			setupStore	8	4	193	19	7	11
	Webpack	Home	uiStartup	1583	1359	2155	157	1655	1952
			load	1375	1188	1881	132	1448	1635
			domContentLoaded	1375	1187	1881	132	1448	1635
			domInteractive	76	32	156	17	83	107
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	15	288	28	23	48
			firstReactRender	41	28	60	5	44	48
			getState	10	5	88	12	9	22
			initialActions	1	0	2	1	1	2
			loadScripts	1355	1171	1862	131	1431	1606
			setupStore	9	5	90	9	8	18

Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2561 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 299 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1952 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Sum of mean exceeds: 11ms | Sum of p95 exceeds: 368ms
Sum of all benchmark exceeds: 379ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 326 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-05T08:11:17Z

Builds ready [29a7955]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1071	1404	73	1268	1369
			load	1059	940	1231	66	1106	1167
			domContentLoaded	1053	935	1224	66	1101	1160
			domInteractive	16	13	31	4	16	28
			firstPaint	748	129	1239	418	1078	1142
			backgroundConnect	8	4	24	4	8	18
			firstReactRender	21	16	68	7	20	34
			getState	14	6	40	8	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	806	688	964	64	858	908
			setupStore	8	5	25	3	8	11
	Webpack	Home	uiStartup	2230	1793	2744	212	2340	2617
			load	1759	1371	2135	198	1890	2059
			domContentLoaded	1752	1367	2130	195	1885	2048
			domInteractive	17	12	58	11	14	53
			firstPaint	174	64	729	81	198	295
			backgroundConnect	26	11	190	23	28	41
			firstReactRender	149	43	368	111	294	353
			getState	12	5	64	7	14	25
			initialActions	3	1	7	1	3	5
			loadScripts	1747	1365	2128	192	1883	2036
			setupStore	34	7	352	72	20	310
Firefox	Browserify	Home	uiStartup	1374	1184	2124	163	1427	1761
			load	1210	1050	1772	126	1256	1533
			domContentLoaded	1210	1050	1772	126	1256	1533
			domInteractive	100	34	242	30	113	151
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	13	474	56	22	39
			firstReactRender	24	20	57	5	24	30
			getState	13	4	240	33	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1189	1036	1750	120	1236	1379
			setupStore	8	3	72	9	7	20
	Webpack	Home	uiStartup	1607	1391	2089	149	1678	1924
			load	1398	1192	1829	140	1473	1700
			domContentLoaded	1398	1192	1829	140	1472	1700
			domInteractive	78	38	153	20	83	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	47	6	22	33
			firstReactRender	42	29	58	5	45	49
			getState	10	5	33	6	10	28
			initialActions	0	0	2	1	1	1
			loadScripts	1379	1165	1808	140	1456	1682
			setupStore	9	5	65	7	8	21

Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1760 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1752 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1747 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2617 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2059 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2048 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 2037 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1761 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1533 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1533 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1379 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1700 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1700 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1682 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 250ms | Sum of p95 exceeds: 861ms
Sum of all benchmark exceeds: 1111ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 326 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-05T12:27:46Z

Builds ready [936c2a4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1078	1519	69	1256	1332
			load	1058	948	1327	63	1087	1165
			domContentLoaded	1052	944	1323	63	1081	1156
			domInteractive	16	13	41	5	16	29
			firstPaint	763	75	1231	417	1075	1160
			backgroundConnect	8	4	32	5	8	22
			firstReactRender	21	16	51	6	21	37
			getState	15	6	41	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	805	702	1064	62	833	917
			setupStore	8	5	26	3	9	15
	Webpack	Home	uiStartup	2074	1593	2550	229	2216	2484
			load	1636	1255	1994	178	1756	1939
			domContentLoaded	1630	1251	1984	177	1751	1920
			domInteractive	15	11	54	8	13	39
			firstPaint	153	66	316	52	180	261
			backgroundConnect	24	9	327	31	24	38
			firstReactRender	114	43	350	92	93	344
			getState	12	4	155	15	11	19
			initialActions	6	1	309	31	3	4
			loadScripts	1628	1250	1983	175	1748	1909
			setupStore	31	6	312	68	17	299
Firefox	Browserify	Home	uiStartup	1436	1192	2210	185	1510	1873
			load	1262	1049	1779	140	1319	1562
			domContentLoaded	1262	1049	1778	140	1319	1562
			domInteractive	99	36	171	26	114	148
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	340	33	21	33
			firstReactRender	24	21	35	3	25	32
			getState	12	4	210	23	9	37
			initialActions	0	0	1	0	0	1
			loadScripts	1242	1038	1763	136	1302	1538
			setupStore	11	4	267	31	7	13
	Webpack	Home	uiStartup	1570	1358	2182	174	1668	1979
			load	1369	1177	1966	162	1461	1708
			domContentLoaded	1368	1177	1966	162	1461	1708
			domInteractive	79	43	568	51	81	111
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	56	6	22	30
			firstReactRender	40	28	53	4	43	48
			getState	8	4	29	4	8	16
			initialActions	0	0	2	1	1	1
			loadScripts	1351	1159	1946	162	1444	1689
			setupStore	10	4	286	28	7	13

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 299 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1262 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1262 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1242 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1873 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1562 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1562 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1538 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1979 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1708 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1708 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1689 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 91ms | Sum of p95 exceeds: 890ms
Sum of all benchmark exceeds: 981ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 326 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-05T12:50:54Z

Builds ready [2c3e0d8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1250 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1250	1101	1536	75	1291	1388
			load	1080	954	1324	70	1114	1206
			domContentLoaded	1072	949	1318	70	1106	1189
			domInteractive	19	13	114	13	17	31
			firstPaint	763	78	1223	428	1101	1195
			backgroundConnect	9	4	28	5	9	22
			firstReactRender	21	17	36	4	22	28
			getState	14	6	54	8	19	31
			initialActions	0	0	1	0	0	0
			loadScripts	823	704	1069	70	863	939
			setupStore	8	5	15	2	9	12
	Webpack	Home	uiStartup	2125	1586	2491	224	2290	2453
			load	1651	1237	1979	175	1771	1886
			domContentLoaded	1644	1233	1974	173	1762	1873
			domInteractive	14	12	40	6	13	36
			firstPaint	173	64	360	62	210	291
			backgroundConnect	23	9	105	14	24	50
			firstReactRender	137	43	359	103	145	341
			getState	19	5	334	45	12	48
			initialActions	3	1	7	1	3	4
			loadScripts	1641	1231	1972	172	1761	1862
			setupStore	28	6	311	59	17	174
Firefox	Browserify	Home	uiStartup	1372	1202	1737	111	1425	1678
			load	1212	1065	1555	97	1256	1409
			domContentLoaded	1212	1064	1555	97	1256	1408
			domInteractive	100	35	292	32	114	147
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	67	8	21	41
			firstReactRender	24	20	51	4	24	29
			getState	10	4	183	18	8	18
			initialActions	0	0	6	1	0	1
			loadScripts	1195	1047	1538	97	1238	1390
			setupStore	7	4	74	9	6	10
	Webpack	Home	uiStartup	1593	1386	2230	176	1694	2073
			load	1385	1192	2018	165	1473	1837
			domContentLoaded	1384	1192	2017	165	1472	1836
			domInteractive	76	33	182	19	83	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	83	8	23	34
			firstReactRender	42	31	55	4	45	50
			getState	10	5	31	6	9	28
			initialActions	0	0	2	1	1	1
			loadScripts	1365	1173	1995	165	1456	1816
			setupStore	10	5	227	22	8	11

Benchmark value 1250 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1207 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 174 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1678 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1366 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2073 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1837 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1836 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1816 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 59ms | Sum of p95 exceeds: 876ms
Sum of all benchmark exceeds: 935ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 326 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

fix: gracefully end sub-stream on port disconnect to prevent Prematur…

322a595

…e close errors

metamaskbot added the team-assets label Jun 4, 2025

fix: clean up

eb7c3ae

salimtb requested a review from jiexi June 4, 2025 12:10

salimtb marked this pull request as ready for review June 4, 2025 12:45

Prithpal-Sooriya approved these changes Jun 4, 2025

View reviewed changes

bergarces approved these changes Jun 4, 2025

View reviewed changes

Merge branch 'main' into fix/fix-premature-close-error

2d2c797

Merge branch 'main' into fix/fix-premature-close-error

29a7955

Merge branch 'main' into fix/fix-premature-close-error

936c2a4

Merge branch 'main' into fix/fix-premature-close-error

2c3e0d8

salimtb added this pull request to the merge queue Jun 5, 2025

Merged via the queue into main with commit 6191fa9 Jun 5, 2025
145 checks passed

salimtb deleted the fix/fix-premature-close-error branch June 5, 2025 13:29

github-actions bot locked and limited conversation to collaborators Jun 5, 2025

metamaskbot added the release-12.21.0 Issue or pull request that will be included in release 12.21.0 label Jun 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: gracefully end sub-stream on port disconnect to prevent Premature close error #33470

fix: gracefully end sub-stream on port disconnect to prevent Premature close error #33470

Uh oh!

salimtb commented Jun 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: gracefully end sub-stream on port disconnect to prevent Premature close error #33470

fix: gracefully end sub-stream on port disconnect to prevent Premature close error #33470

Uh oh!

Conversation

salimtb commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

salimtb commented Jun 4, 2025 •

edited

Loading