feat: MMS-2553 unified UI for swaps and bridges #33487

ghgoodreau · 2025-06-05T00:53:38Z

Description

Adds support for unified UI (swapping and bridging on a singular page). When isUnifiedUIEnabled is true, we provide swapping and bridging all within the prepare-bridge-page. When it is false, care was taken to ensure that functionality remains backwards-compatible.

Related issues

Closes: https://consensyssoftware.atlassian.net/browse/MMS-2553

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-05T00:53:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-05T00:55:43Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +127 -59)

📁 ui/
- 📁 hooks/
  - 📁 bridge/
    - 📄 useTokensWithFiltering.ts +7 -2
- 📁 pages/
  - 📁 bridge/
    - 📁 hooks/
      - 📄 useDestinationAccount.ts +26 -20
    - 📁 prepare/
      - 📄 prepare-bridge-page.tsx +94 -37

metamaskbot · 2025-06-05T01:16:19Z

Builds ready [27b891d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1104	1439	76	1284	1354
			load	1066	934	1267	72	1121	1201
			domContentLoaded	1060	930	1259	72	1114	1196
			domInteractive	16	13	31	3	16	26
			firstPaint	766	136	1229	412	1100	1174
			backgroundConnect	8	4	32	4	8	20
			firstReactRender	21	16	46	5	22	34
			getState	14	5	49	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	813	694	1012	71	865	953
			setupStore	8	5	21	2	8	12
	Webpack	Home	uiStartup	2087	1644	2583	238	2260	2471
			load	1630	1273	2035	191	1760	1919
			domContentLoaded	1624	1269	2031	189	1756	1908
			domInteractive	16	11	87	13	13	44
			firstPaint	160	63	355	57	180	298
			backgroundConnect	23	12	49	7	27	37
			firstReactRender	143	43	366	109	288	340
			getState	13	4	323	32	11	20
			initialActions	5	1	283	28	3	4
			loadScripts	1621	1267	2022	188	1755	1897
			setupStore	20	6	307	41	17	42
Firefox	Browserify	Home	uiStartup	1355	1157	1696	124	1422	1596
			load	1202	1017	1570	113	1272	1443
			domContentLoaded	1201	1017	1569	113	1272	1443
			domInteractive	99	38	331	40	102	163
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	55	5	20	27
			firstReactRender	23	20	32	2	24	28
			getState	12	4	185	28	8	11
			initialActions	0	0	5	1	0	1
			loadScripts	1185	1003	1555	113	1255	1423
			setupStore	7	4	72	9	6	12
	Webpack	Home	uiStartup	1606	1337	2193	170	1701	1986
			load	1395	1155	1963	154	1501	1744
			domContentLoaded	1394	1154	1962	154	1501	1744
			domInteractive	80	40	243	24	88	108
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	259	24	22	42
			firstReactRender	42	28	54	5	45	50
			getState	13	4	243	26	9	30
			initialActions	1	0	2	1	1	1
			loadScripts	1374	1137	1943	152	1480	1723
			setupStore	8	5	66	7	8	15

Benchmark value 1202 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1375 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1986 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1723 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 50ms | Sum of p95 exceeds: 374ms
Sum of all benchmark exceeds: 424ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 984 Bytes (0.02%)
ui: 1.28 KiB (0.02%)
common: -112 Bytes (0%)

metamaskbot · 2025-06-10T17:59:54Z

Builds ready [d51cba9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1235	1109	1528	66	1267	1343
			load	1067	949	1333	63	1096	1179
			domContentLoaded	1059	940	1309	63	1088	1173
			domInteractive	19	14	198	19	17	30
			firstPaint	765	73	1213	410	1085	1151
			backgroundConnect	8	5	29	5	9	24
			firstReactRender	22	16	47	6	22	38
			getState	15	6	36	8	21	32
			initialActions	0	0	3	0	0	0
			loadScripts	813	698	1058	62	848	924
			setupStore	8	5	27	3	8	14
	Webpack	Home	uiStartup	2813	2025	3464	250	2984	3204
			load	2274	1562	3060	303	2454	2820
			domContentLoaded	2264	1556	3053	302	2444	2810
			domInteractive	21	14	78	11	19	51
			firstPaint	206	76	485	75	245	362
			backgroundConnect	72	12	551	104	61	329
			firstReactRender	109	50	431	77	151	294
			getState	30	5	343	57	24	229
			initialActions	3	1	8	2	3	7
			loadScripts	2257	1555	3039	298	2439	2767
			setupStore	46	8	374	82	27	252
Firefox	Browserify	Home	uiStartup	1321	1158	1684	98	1369	1554
			load	1169	1036	1381	84	1223	1356
			domContentLoaded	1169	1036	1381	84	1222	1356
			domInteractive	92	32	207	28	102	140
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	183	20	21	46
			firstReactRender	22	20	54	3	22	24
			getState	12	4	326	32	8	36
			initialActions	0	0	1	0	0	1
			loadScripts	1149	1007	1368	82	1200	1327
			setupStore	8	4	113	13	6	12
	Webpack	Home	uiStartup	1553	1357	2012	143	1642	1851
			load	1342	1163	1679	126	1438	1584
			domContentLoaded	1342	1162	1679	127	1438	1584
			domInteractive	80	34	195	22	86	131
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	87	9	22	41
			firstReactRender	41	30	48	3	43	47
			getState	11	5	217	21	9	29
			initialActions	1	0	1	0	1	1
			loadScripts	1323	1144	1656	126	1423	1565
			setupStore	8	5	68	7	8	12

cc: @HowardBraham
Benchmark value 1235 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2814 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2275 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 2264 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 207 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 73 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2258 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 47 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 3205 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2820 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2811 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 362 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 330 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 229 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 2768 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 252 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 2368ms | Sum of p95 exceeds: 3652ms
Sum of all benchmark exceeds: 6020ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 531 Bytes (0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-10T23:01:47Z

Builds ready [d68ca52]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1232 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1232	1099	1424	67	1274	1364
			load	1067	944	1215	60	1103	1167
			domContentLoaded	1060	938	1209	61	1096	1158
			domInteractive	17	14	98	9	16	29
			firstPaint	745	82	1166	421	1094	1150
			backgroundConnect	9	4	30	5	8	23
			firstReactRender	20	16	45	3	20	24
			getState	13	6	45	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	814	701	957	59	853	909
			setupStore	8	5	14	2	8	13
	Webpack	Home	uiStartup	2037	1562	2735	242	2200	2445
			load	1584	1234	2056	186	1710	1860
			domContentLoaded	1579	1230	2049	185	1706	1838
			domInteractive	15	11	75	9	13	38
			firstPaint	162	59	383	68	208	333
			backgroundConnect	24	12	362	35	23	34
			firstReactRender	126	43	353	103	109	345
			getState	14	5	310	30	12	20
			initialActions	6	1	305	30	3	4
			loadScripts	1576	1228	2038	183	1704	1834
			setupStore	44	7	333	87	17	303
Firefox	Browserify	Home	uiStartup	1343	1150	1976	130	1372	1614
			load	1175	1026	1497	88	1210	1380
			domContentLoaded	1174	1026	1496	88	1210	1379
			domInteractive	97	36	469	44	102	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	108	13	21	51
			firstReactRender	24	20	52	5	24	30
			getState	18	4	227	41	8	162
			initialActions	0	0	1	0	0	1
			loadScripts	1155	1012	1478	88	1191	1355
			setupStore	9	4	170	18	6	15
	Webpack	Home	uiStartup	1510	1342	1964	123	1562	1799
			load	1306	1163	1741	110	1373	1523
			domContentLoaded	1306	1163	1741	110	1373	1523
			domInteractive	74	32	278	29	75	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	62	6	22	27
			firstReactRender	40	30	63	4	42	46
			getState	11	5	196	19	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1287	1142	1724	111	1354	1505
			setupStore	10	5	258	25	8	19

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 303 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 162 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 23ms | Sum of p95 exceeds: 382ms
Sum of all benchmark exceeds: 405ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.64 KiB (-0.45%)
ui: 631 Bytes (0.01%)
common: 7.32 KiB (0.09%)

metamaskbot · 2025-06-11T22:05:20Z

Builds ready [c8c7a3f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1104	1474	65	1249	1334
			load	1048	949	1287	59	1079	1150
			domContentLoaded	1042	935	1274	59	1074	1144
			domInteractive	17	13	52	5	16	31
			firstPaint	706	78	1174	410	1054	1133
			backgroundConnect	7	4	25	3	8	14
			firstReactRender	20	16	41	4	20	28
			getState	14	6	36	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	797	700	1003	57	830	900
			setupStore	8	5	16	2	8	14
	Webpack	Home	uiStartup	2144	1638	2533	195	2279	2506
			load	1662	1277	1959	162	1773	1912
			domContentLoaded	1656	1273	1955	161	1769	1904
			domInteractive	15	11	52	8	13	43
			firstPaint	157	61	635	76	174	275
			backgroundConnect	21	11	41	6	24	35
			firstReactRender	125	44	370	98	119	344
			getState	24	4	318	60	15	32
			initialActions	3	1	5	1	3	4
			loadScripts	1652	1271	1953	160	1767	1893
			setupStore	51	6	317	95	20	311
Firefox	Browserify	Home	uiStartup	1307	1166	1544	79	1353	1458
			load	1166	1042	1382	74	1206	1322
			domContentLoaded	1166	1041	1382	74	1205	1322
			domInteractive	101	34	251	35	111	178
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	72	8	20	35
			firstReactRender	23	20	51	4	23	27
			getState	7	4	36	4	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1149	1028	1356	74	1187	1306
			setupStore	6	3	21	3	6	10
	Webpack	Home	uiStartup	1535	1357	2053	139	1618	1781
			load	1334	1162	1847	139	1428	1580
			domContentLoaded	1334	1162	1847	139	1428	1579
			domInteractive	76	30	444	39	78	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	32	4	22	27
			firstReactRender	41	28	49	3	44	46
			getState	9	5	37	6	9	30
			initialActions	0	0	2	1	1	1
			loadScripts	1316	1146	1830	139	1410	1560
			setupStore	8	5	35	3	8	11

Benchmark value 52 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2506 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 311 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 298ms
Sum of all benchmark exceeds: 322ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -20.51 KiB (-0.39%)
ui: -30.55 KiB (-0.42%)
common: 10.15 KiB (0.12%)

metamaskbot · 2025-06-12T15:33:19Z

Builds ready [0187eda]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1103	1501	68	1251	1313
			load	1050	956	1328	66	1100	1162
			domContentLoaded	1044	938	1323	66	1091	1157
			domInteractive	17	13	35	4	17	30
			firstPaint	775	71	1196	399	1071	1158
			backgroundConnect	7	4	30	4	7	9
			firstReactRender	21	15	51	6	20	39
			getState	14	6	30	7	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	798	690	1070	64	845	915
			setupStore	7	5	16	2	8	13
	Webpack	Home	uiStartup	1997	1530	2450	219	2135	2361
			load	1550	1198	1958	175	1687	1844
			domContentLoaded	1545	1194	1954	175	1683	1835
			domInteractive	15	11	57	10	12	44
			firstPaint	151	59	299	46	180	252
			backgroundConnect	23	13	367	35	22	31
			firstReactRender	126	45	365	107	97	355
			getState	15	4	307	40	10	17
			initialActions	2	1	5	1	3	4
			loadScripts	1542	1193	1952	174	1680	1824
			setupStore	45	7	348	94	16	309
Firefox	Browserify	Home	uiStartup	1328	1177	1553	71	1368	1457
			load	1182	1048	1389	72	1226	1325
			domContentLoaded	1181	1047	1389	72	1226	1325
			domInteractive	101	35	187	29	117	157
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	49	4	20	26
			firstReactRender	23	20	60	5	23	27
			getState	8	5	40	4	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1164	1037	1373	71	1206	1306
			setupStore	7	4	36	5	6	11
	Webpack	Home	uiStartup	1486	1343	1724	96	1540	1681
			load	1296	1154	1537	99	1348	1508
			domContentLoaded	1295	1154	1536	99	1348	1508
			domInteractive	77	32	123	14	84	108
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	16	43	5	21	31
			firstReactRender	40	30	46	3	42	45
			getState	7	5	20	2	8	10
			initialActions	0	0	1	0	1	1
			loadScripts	1277	1139	1519	99	1331	1488
			setupStore	8	5	44	5	8	11

Benchmark value 46 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 309 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 244ms
Sum of all benchmark exceeds: 260ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 51.34 KiB (0.98%)
ui: -29.3 KiB (-0.41%)
common: 79.14 KiB (0.96%)

micaelae · 2025-06-12T16:00:17Z

ui/hooks/bridge/useTokensWithFiltering.ts

        // Yield topTokens from selected chain
        for (const token_ of topTokens) {
-          const matchedToken = tokenList?.[token_.address];
+          const matchedToken = tokenList?.[token_.address.toLowerCase()];


I think this breaks the Solana topTokens ordering bc those addresses are case-sensitive

metamaskbot · 2025-06-12T16:15:32Z

Builds ready [b438604]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 77 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1094	1422	77	1259	1364
			load	1057	952	1254	68	1104	1180
			domContentLoaded	1050	932	1244	69	1098	1173
			domInteractive	16	13	35	4	17	27
			firstPaint	733	123	1254	420	1078	1167
			backgroundConnect	7	4	26	5	7	24
			firstReactRender	19	16	24	2	20	23
			getState	13	6	36	7	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	806	689	995	69	854	925
			setupStore	7	4	13	2	7	12
	Webpack	Home	uiStartup	2105	1599	2595	219	2217	2506
			load	1647	1270	2008	185	1774	1966
			domContentLoaded	1641	1265	1994	185	1769	1956
			domInteractive	17	11	79	13	13	48
			firstPaint	153	63	342	50	169	266
			backgroundConnect	23	9	338	32	23	34
			firstReactRender	126	46	353	96	109	341
			getState	11	4	25	4	13	18
			initialActions	3	1	6	1	3	4
			loadScripts	1638	1263	1983	183	1767	1944
			setupStore	54	7	321	97	22	312
Firefox	Browserify	Home	uiStartup	1473	1289	1768	104	1526	1677
			load	1306	1131	1596	103	1356	1509
			domContentLoaded	1305	1131	1596	103	1356	1509
			domInteractive	106	37	182	25	117	155
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	149	16	25	34
			firstReactRender	26	22	66	4	26	29
			getState	8	4	28	3	9	12
			initialActions	0	0	1	0	0	1
			loadScripts	1282	1115	1579	103	1337	1478
			setupStore	7	5	20	2	7	12
	Webpack	Home	uiStartup	1517	1368	1789	102	1583	1725
			load	1319	1189	1585	99	1368	1529
			domContentLoaded	1318	1189	1585	99	1368	1528
			domInteractive	77	40	171	15	82	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	51	5	22	27
			firstReactRender	41	30	66	5	44	48
			getState	8	5	29	3	9	10
			initialActions	1	0	2	1	1	1
			loadScripts	1299	1171	1566	100	1351	1508
			setupStore	8	5	21	2	8	9

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 54 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2506 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1473 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1306 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1306 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 1283 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1478 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 277ms | Sum of p95 exceeds: 353ms
Sum of all benchmark exceeds: 630ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 431 Bytes (0.01%)
common: 0 Bytes (0%)

micaelae · 2025-06-12T16:54:30Z

ui/pages/bridge/prepare/prepare-bridge-page.tsx

+            : fromToken.address?.toLowerCase(),
+          // Ensure chainId is in CAIP format for proper comparison


Non-evm addresses can be case-sensitive so I'd suggest avoiding case-insensitive comparisons and not using toLowerCase unless necessary. Maybe you can remove the lowercase operations on lines 200-201 as well if this is not lowecased?

ui/pages/bridge/prepare/prepare-bridge-page.tsx

metamaskbot · 2025-06-12T20:44:59Z

Builds ready [1c83dfd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1222 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1222	1107	1492	67	1263	1338
			load	1061	957	1235	61	1103	1159
			domContentLoaded	1055	953	1226	61	1098	1150
			domInteractive	18	14	107	10	17	32
			firstPaint	714	127	1236	423	1090	1151
			backgroundConnect	7	4	27	4	7	11
			firstReactRender	20	16	58	5	21	25
			getState	13	6	33	7	20	27
			initialActions	0	0	1	0	0	1
			loadScripts	806	707	964	59	848	900
			setupStore	8	5	15	2	8	13
	Webpack	Home	uiStartup	2105	1619	2545	224	2249	2486
			load	1630	1220	1941	178	1745	1915
			domContentLoaded	1624	1214	1932	177	1737	1905
			domInteractive	16	11	54	10	13	48
			firstPaint	156	64	337	50	193	247
			backgroundConnect	24	10	370	35	24	33
			firstReactRender	163	46	396	121	315	351
			getState	11	4	22	4	13	20
			initialActions	5	1	289	29	3	4
			loadScripts	1621	1210	1927	175	1735	1893
			setupStore	47	7	319	92	19	306
Firefox	Browserify	Home	uiStartup	1346	1183	1664	91	1400	1544
			load	1200	1033	1506	90	1247	1395
			domContentLoaded	1199	1033	1505	91	1246	1395
			domInteractive	105	35	223	33	125	161
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	118	13	22	33
			firstReactRender	23	19	56	5	24	26
			getState	7	4	11	1	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1180	1019	1479	88	1216	1379
			setupStore	7	4	35	4	7	11
	Webpack	Home	uiStartup	1494	1342	1792	95	1535	1716
			load	1300	1165	1606	97	1334	1532
			domContentLoaded	1300	1165	1606	97	1333	1532
			domInteractive	78	52	120	14	86	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	48	5	22	28
			firstReactRender	40	30	47	3	42	45
			getState	9	5	32	6	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1281	1150	1586	97	1316	1515
			setupStore	8	5	29	4	8	20

Benchmark value 47 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 306 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 18ms | Sum of p95 exceeds: 273ms
Sum of all benchmark exceeds: 291ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1 Bytes (0%)
ui: 335 Bytes (0%)
common: 72 Bytes (0%)

metamaskbot · 2025-06-12T21:10:45Z

Builds ready [863fe7d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1218 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1104	1365	63	1252	1353
			load	1057	954	1209	60	1098	1179
			domContentLoaded	1051	949	1203	60	1092	1174
			domInteractive	16	14	32	3	17	25
			firstPaint	756	78	1187	408	1074	1163
			backgroundConnect	7	4	26	4	7	10
			firstReactRender	20	16	59	6	20	36
			getState	14	6	33	7	19	26
			initialActions	0	0	1	0	0	0
			loadScripts	804	706	947	58	847	928
			setupStore	8	5	23	2	8	13
	Webpack	Home	uiStartup	2083	1592	2515	213	2227	2464
			load	1613	1243	1917	164	1732	1876
			domContentLoaded	1607	1239	1908	163	1726	1867
			domInteractive	16	12	55	10	13	46
			firstPaint	154	63	458	61	172	259
			backgroundConnect	20	10	44	7	22	37
			firstReactRender	129	46	363	101	128	333
			getState	11	5	27	4	13	21
			initialActions	3	1	6	1	3	4
			loadScripts	1604	1237	1897	162	1725	1857
			setupStore	66	7	321	113	20	315
Firefox	Browserify	Home	uiStartup	1315	1189	1521	76	1352	1476
			load	1170	1060	1393	75	1210	1346
			domContentLoaded	1169	1060	1393	75	1209	1345
			domInteractive	99	35	181	28	106	159
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	50	6	20	29
			firstReactRender	24	21	61	6	23	29
			getState	7	4	38	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1152	1042	1364	74	1193	1329
			setupStore	6	4	38	4	6	11
	Webpack	Home	uiStartup	1474	1317	1709	98	1525	1669
			load	1286	1144	1536	99	1339	1490
			domContentLoaded	1286	1143	1536	100	1339	1490
			domInteractive	78	52	157	15	84	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	16	41	4	20	24
			firstReactRender	39	26	45	3	41	44
			getState	8	4	29	4	8	11
			initialActions	0	0	2	1	1	1
			loadScripts	1269	1128	1518	100	1321	1475
			setupStore	8	5	44	6	7	23

Benchmark value 67 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2464 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 36ms | Sum of p95 exceeds: 260ms
Sum of all benchmark exceeds: 296ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 7 Bytes (0%)
ui: 496 Bytes (0.01%)
common: 72 Bytes (0%)

ui/hooks/bridge/useTokensWithFiltering.ts

Co-authored-by: Micaela Estabillo <100321200+micaelae@users.noreply.github.com>

metamaskbot · 2025-06-12T22:27:45Z

Builds ready [b497908]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1186 ± 46 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1186	1085	1358	46	1213	1276
			load	1028	932	1185	48	1054	1112
			domContentLoaded	1022	926	1181	48	1049	1105
			domInteractive	16	13	32	4	16	31
			firstPaint	727	127	1156	398	1049	1079
			backgroundConnect	6	4	27	3	7	10
			firstReactRender	21	17	92	8	21	37
			getState	15	6	66	9	21	28
			initialActions	0	0	1	0	0	1
			loadScripts	777	681	931	47	805	854
			setupStore	8	5	25	3	8	13
	Webpack	Home	uiStartup	2147	1642	2604	216	2293	2488
			load	1671	1270	2097	183	1773	1939
			domContentLoaded	1665	1264	2093	182	1766	1935
			domInteractive	17	12	78	13	13	50
			firstPaint	159	62	507	67	175	292
			backgroundConnect	27	11	426	45	24	36
			firstReactRender	153	47	364	117	313	356
			getState	11	4	27	4	13	21
			initialActions	3	1	6	1	3	4
			loadScripts	1662	1261	2083	181	1765	1933
			setupStore	50	6	319	95	20	311
Firefox	Browserify	Home	uiStartup	1332	1163	1499	74	1388	1469
			load	1183	1034	1344	73	1222	1326
			domContentLoaded	1182	1034	1343	73	1222	1326
			domInteractive	101	36	295	35	111	167
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	49	6	22	30
			firstReactRender	24	20	63	6	24	27
			getState	8	5	40	4	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1165	1024	1330	72	1203	1309
			setupStore	7	4	59	7	6	11
	Webpack	Home	uiStartup	1561	1367	1890	126	1650	1780
			load	1355	1173	1689	123	1440	1598
			domContentLoaded	1354	1173	1688	123	1440	1598
			domInteractive	78	31	160	18	87	106
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	30	3	23	28
			firstReactRender	43	30	67	5	46	53
			getState	9	5	32	6	9	29
			initialActions	1	0	2	1	1	1
			loadScripts	1335	1155	1670	123	1424	1577
			setupStore	8	5	28	3	8	11

Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2489 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 311 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 284ms
Sum of all benchmark exceeds: 308ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 7 Bytes (0%)
ui: 494 Bytes (0.01%)
common: 72 Bytes (0%)

ghgoodreau added 2 commits June 4, 2025 16:22

WIP: unified bridge experience

5cbaefa

improve token logic in unified ui

27b891d

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jun 5, 2025

fix: merge conflicts

d51cba9

fix: destination account updates and edge cases

d68ca52

ghgoodreau changed the title ~~(DRAFT) feat: MMS-2553 unified UI for swaps and bridges~~ feat: MMS-2553 unified UI for swaps and bridges Jun 11, 2025

update hooks for isswap on prepare bridge page

c8c7a3f

fix: automated token setting removed for unified view

0187eda

ghgoodreau marked this pull request as ready for review June 12, 2025 15:29

ghgoodreau requested a review from a team as a code owner June 12, 2025 15:29

Merge branch 'main' into mms-2553-swaps-unified-ui

b438604

micaelae reviewed Jun 12, 2025

View reviewed changes

ui/pages/bridge/prepare/prepare-bridge-page.tsx Show resolved Hide resolved

micaelae reviewed Jun 12, 2025

View reviewed changes

ui/pages/bridge/prepare/prepare-bridge-page.tsx Outdated Show resolved Hide resolved

micaelae reviewed Jun 12, 2025

View reviewed changes

ui/pages/bridge/prepare/prepare-bridge-page.tsx Outdated Show resolved Hide resolved

fix: address some comments

1c83dfd

fix: token tolowercase only for evm

863fe7d

ghgoodreau enabled auto-merge June 12, 2025 21:46

GustavoRSSilva previously approved these changes Jun 12, 2025

View reviewed changes

micaelae reviewed Jun 12, 2025

View reviewed changes

ui/hooks/bridge/useTokensWithFiltering.ts Outdated Show resolved Hide resolved

Update ui/hooks/bridge/useTokensWithFiltering.ts

539111c

Co-authored-by: Micaela Estabillo <100321200+micaelae@users.noreply.github.com>

ghgoodreau dismissed GustavoRSSilva’s stale review via 539111c June 12, 2025 22:03

fix lint

b497908

micaelae approved these changes Jun 12, 2025

View reviewed changes

GustavoRSSilva approved these changes Jun 13, 2025

View reviewed changes

ghgoodreau added this pull request to the merge queue Jun 13, 2025

Merged via the queue into main with commit 05853aa Jun 13, 2025
145 checks passed

ghgoodreau deleted the mms-2553-swaps-unified-ui branch June 13, 2025 08:59

github-actions bot locked and limited conversation to collaborators Jun 13, 2025

metamaskbot added the release-12.22.0 Issue or pull request that will be included in release 12.22.0 label Jun 13, 2025

		: fromToken.address?.toLowerCase(),
		// Ensure chainId is in CAIP format for proper comparison

feat: MMS-2553 unified UI for swaps and bridges #33487

feat: MMS-2553 unified UI for swaps and bridges #33487

Uh oh!

Conversation

ghgoodreau commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 10, 2025

Uh oh!

metamaskbot commented Jun 10, 2025

Uh oh!

metamaskbot commented Jun 11, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

micaelae Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

micaelae Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ghgoodreau commented Jun 5, 2025 •

edited

Loading

metamaskbot commented Jun 5, 2025 •

edited

Loading

micaelae Jun 12, 2025 •

edited

Loading