Skip to content

Conversation

@matthiasgeihs
Copy link
Contributor

@matthiasgeihs matthiasgeihs commented Jun 13, 2025

Description

Testing update of @metamask/keyring-controller (MetaMask/core#5940).

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jun 13, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​keyring-controller@​22.0.2 ⏵ 22.0.2-preview-a272c5e1100 +4100100 +25100 +3100

View full report

@socket-security
Copy link

socket-security bot commented Jun 13, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@matthiasgeihs
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@matthiasgeihs matthiasgeihs force-pushed the mg/chore/update-keyring-controller branch from 5af5089 to eaba6c3 Compare June 13, 2025 15:07
@matthiasgeihs matthiasgeihs force-pushed the mg/chore/update-keyring-controller branch from eaba6c3 to 4651ed2 Compare June 13, 2025 16:07
@metamaskbot
Copy link
Collaborator

Builds ready [4651ed2]
UI Startup Metrics (1198 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1198108913895812361298
load103794012025310671138
domContentLoaded103193211995410601134
domInteractive16143631723
firstPaint740146114640010541119
backgroundConnect74314720
firstReactRender21175462139
getState1353681829
initialActions001001
loadScripts78669492853818893
setupStore85142812
WebpackHomeuiStartup21201618273222922512515
load16551215213218717691964
domContentLoaded16491211212318717651954
domInteractive1812187201348
firstPaint1646141371182343
backgroundConnect21104162434
firstReactRender15246380116308361
getState1042341217
initialActions315134
loadScripts16451210211218517631945
setupStore3563207419302
FirefoxBrowserifyHomeuiStartup1304117015357513471457
load1158104213897311961296
domContentLoaded1158104113887311961295
domInteractive963618024109141
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135052028
firstReactRender23205642326
getState7438389
initialActions001001
loadScripts1141102513737211771271
setupStore74486718
WebpackHomeuiStartup15711370191912316561811
load13661192170812314411624
domContentLoaded13651192170812314401624
domInteractive85361771993120
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21168082228
firstReactRender42365734447
getState85192911
initialActions102111
loadScripts13471175168912314251606
setupStore85464810
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2516 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 344 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 312ms
Sum of all benchmark exceeds: 320ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0%)
  • ui: 2.81 KiB (0.04%)
  • common: 3.03 KiB (0.04%)

@matthiasgeihs matthiasgeihs changed the title keyring controller preview build bump keyring controller Jun 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
@matthiasgeihs
Copy link
Contributor Author

Closed because testing complete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants