Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jun 20, 2025

Description

Support disabling enforced simulations via a new simulation settings modal.

Specifically:

  • Add enableEnforcedSimulations and enableEnforcedSimulationsForTransactions to AppStateController.
  • Add applyTransactionContainersExisting utility method to apply transaction containers to an existing transaction.
  • Add SimulationSettingsModal component to configure enforced simulation settings.
  • Add useIsEnforcedSimulationsSupported hook to determine if settings should be displayed.
  • Check AppStateController state in EnforceSimulationHook.

Open in GitHub Codespaces

Related issues

Fixes: #5173

Manual testing steps

Screenshots/Recordings

Before

After

Modal

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch from 18253fb to 1b8bc48 Compare June 20, 2025 10:40
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 20, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 20, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (12 files, +661 -112)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 info/
              • 📁 __snapshots__/
                • 📄 info.test.tsx.snap +24 -20
              • 📁 base-transaction-info/
                • 📁 __snapshots__/
                  • 📄 base-transaction-info.test.tsx.snap +24 -20
              • 📁 native-transfer/
                • 📁 __snapshots__/
                  • 📄 native-transfer.test.tsx.snap +24 -20
              • 📁 nft-token-transfer/
                • 📁 __snapshots__/
                  • 📄 nft-token-transfer.test.tsx.snap +24 -20
              • 📁 token-transfer/
                • 📁 __snapshots__/
                  • 📄 token-transfer.test.tsx.snap +24 -20
          • 📁 modals/
            • 📁 simulation-settings-modal/
              • 📄 simulation-settings-modal.stories.tsx +38 -0
              • 📄 simulation-settings-modal.test.tsx +198 -0
              • 📄 simulation-settings-modal.tsx +163 -0
          • 📁 simulation-details/
            • 📄 simulation-details.tsx +51 -12
        • 📁 hooks/
          • 📁 transactions/
            • 📄 useIsEnforcedSimulationsSupported.test.ts +67 -0
            • 📄 useIsEnforcedSimulationsSupported.ts +22 -0
        • 📁 selectors/
          • 📄 confirm.test.ts +2 -0

@metamaskbot
Copy link
Collaborator

Builds ready [6f60743]
UI Startup Metrics (1238 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1238113315926112691330
load107096013155510971160
domContentLoaded106495413115510901154
domInteractive18144671739
firstPaint70874131643110831154
backgroundConnect74253712
firstReactRender20153022125
getState1563282130
initialActions001001
loadScripts813705103753836897
setupStore85293815
WebpackHomeuiStartup22531759300318623352628
load17311330226916018041993
domContentLoaded17251327225715917981982
domInteractive1911130201471
firstPaint1636344871196303
backgroundConnect2313277262339
firstReactRender22390431100347394
getState144314311227
initialActions215134
loadScripts17221325224415917961970
setupStore217320391826
FirefoxBrowserifyHomeuiStartup1361121816539414011581
load1198106314147112441324
domContentLoaded1198106214137112441324
domInteractive1113551158125204
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113105122140
firstReactRender23203422428
getState94335924
initialActions001001
loadScripts1180104513987212251307
setupStore847910822
WebpackHomeuiStartup15901399231919216542026
load13721196203416514581702
domContentLoaded13721196203416514571702
domInteractive101315548588329
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23168692341
firstReactRender42335544448
getState125132161030
initialActions102111
loadScripts13521176201416414401682
setupStore95496823
Benchmark value 1239 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 2253 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1731 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1723 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2629 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1971 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2026 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 329 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1682 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 142ms | Sum of p95 exceeds: 623ms
Sum of all benchmark exceeds: 765ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.51 KiB (-0.03%)
  • ui: 8.74 KiB (0.12%)
  • common: 1.94 KiB (0.02%)

@metamaskbot
Copy link
Collaborator

Builds ready [10fe095]
UI Startup Metrics (1226 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1226110614275612671295
load106195412045411031148
domContentLoaded105494611965410981142
domInteractive17135771738
firstPaint725137114740910701133
backgroundConnect74304716
firstReactRender24155282446
getState1564182033
initialActions001001
loadScripts80770193853848891
setupStore95243916
WebpackHomeuiStartup22471792272818923482580
load17381319216016718041997
domContentLoaded17321316215416618001992
domInteractive1812119161458
firstPaint1666252579194317
backgroundConnect2210248242141
firstReactRender21489421106340398
getState1143961224
initialActions512952934
loadScripts17291314214416517931989
setupStore177297291726
FirefoxBrowserifyHomeuiStartup13511226181911313751635
load1189107115908812231381
domContentLoaded1188106915898812231381
domInteractive1103544167108302
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20135162129
firstReactRender24213422528
getState10511015926
initialActions002001
loadScripts1171105615738612041362
setupStore74365719
WebpackHomeuiStartup15381333204416616181957
load13301162173413114281616
domContentLoaded13301162173413114271616
domInteractive91313256088267
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20155052131
firstReactRender39304734144
getState1153891033
initialActions001011
loadScripts13131147170113014091592
setupStore10510414826
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 46 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 2247 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1738 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1733 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1730 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2581 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1989 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 302 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1957 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Sum of mean exceeds: 144ms | Sum of p95 exceeds: 420ms
Sum of all benchmark exceeds: 564ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.51 KiB (-0.03%)
  • ui: 8.74 KiB (0.12%)
  • common: 1.94 KiB (0.02%)

@metamaskbot
Copy link
Collaborator

Builds ready [0319545]
UI Startup Metrics (1252 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1252115015426413001365
load107696512795811041190
domContentLoaded106995412755810981184
domInteractive1914115111833
firstPaint66278121643410741176
backgroundConnect84335826
firstReactRender2417160152233
getState1563972029
initialActions001000
loadScripts81568899258846938
setupStore95234917
WebpackHomeuiStartup21851662271621223072603
load16521229204217217451943
domContentLoaded16461225203017117381925
domInteractive161261101342
firstPaint1687771284180318
backgroundConnect2511275272354
firstReactRender26188418123388401
getState1353961429
initialActions215134
loadScripts16431223202016917361916
setupStore187304291724
FirefoxBrowserifyHomeuiStartup13671225177710914221636
load1197107514988312461351
domContentLoaded1197107514988312461351
domInteractive1153645065125298
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515114152553
firstReactRender24213322429
getState12684141039
initialActions001001
loadScripts1176105814118112231334
setupStore946910823
WebpackHomeuiStartup15981396216718116832059
load13791193183615814761715
domContentLoaded13781192183615814761714
domInteractive98324837786300
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23175372442
firstReactRender41328664347
getState1358291231
initialActions001011
loadScripts13581174181715814581691
setupStore10610112924
Benchmark value 1252 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 1191 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2603 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2059 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1691 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 72ms | Sum of p95 exceeds: 749ms
Sum of all benchmark exceeds: 821ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.1 KiB (0.06%)
  • ui: 10.03 KiB (0.14%)
  • common: 1.01 KiB (0.01%)

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review June 20, 2025 21:20
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner June 20, 2025 21:20
@metamaskbot
Copy link
Collaborator

Builds ready [ce28a94]
UI Startup Metrics (1286 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1286113314416813431389
load111698213096611661224
domContentLoaded111097713046611611218
domInteractive19144861840
firstPaint748132122744511351196
backgroundConnect75262810
firstReactRender22175062339
getState1463272027
initialActions001001
loadScripts850733104263894945
setupStore95254820
WebpackHomeuiStartup21691631271419922692542
load16501223202017717591943
domContentLoaded16431219200917617541939
domInteractive161166121348
firstPaint1646537063190299
backgroundConnect2611408402345
firstReactRender23888532120367400
getState1253461526
initialActions215134
loadScripts16401217199817517511937
setupStore1574161824
FirefoxBrowserifyHomeuiStartup14091196179911214681643
load1234105415459312851398
domContentLoaded1234105415459312841398
domInteractive1203745567127310
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271491142758
firstReactRender24213022528
getState126127141034
initialActions001001
loadScripts1212103915279112681373
setupStore95116121020
WebpackHomeuiStartup15911357214417016962003
load13701163181414614831682
domContentLoaded13701161181314614831681
domInteractive93354836689286
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23167272541
firstReactRender423312094448
getState1365791234
initialActions002111
loadScripts13491146179614514671631
setupStore11670101035
Benchmark value 1286 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1117 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1111 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 850 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1224 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1219 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 946 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2542 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 310 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2003 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1631 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 196ms | Sum of p95 exceeds: 617ms
Sum of all benchmark exceeds: 813ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.1 KiB (0.06%)
  • ui: 10.03 KiB (0.14%)
  • common: 1.01 KiB (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [409d0f6]
UI Startup Metrics (1204 ± 47 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1204110913514712361288
load104395111584610771112
domContentLoaded103894511534610721107
domInteractive17134961631
firstPaint68380111841910611108
backgroundConnect649178
firstReactRender21166362126
getState1453271927
initialActions001000
loadScripts79069889445819862
setupStore85243814
WebpackHomeuiStartup21261605269122622362549
load16101196207319417061934
domContentLoaded16041192206919317001923
domInteractive171198151357
firstPaint1617048863172290
backgroundConnect2714346412346
firstReactRender23289427116370397
getState1354871330
initialActions214123
loadScripts16011187205919216971912
setupStore197306411721
FirefoxBrowserifyHomeuiStartup13631180180211413901632
load1195105014988512301359
domContentLoaded1195105014988512301359
domInteractive1163547871117292
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24158192640
firstReactRender24213822428
getState1167510927
initialActions001001
loadScripts1175103414778312101336
setupStore8411911713
WebpackHomeuiStartup15361355227518415781976
load13241162199615913941653
domContentLoaded13241161199615913931653
domInteractive96315097190282
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22174552435
firstReactRender39294634244
getState1463691533
initialActions102111
loadScripts13041144197415913751628
setupStore95285925
Benchmark value 2550 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 292 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1976 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 391ms
Sum of all benchmark exceeds: 399ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.11 KiB (0.06%)
  • ui: 10.03 KiB (0.14%)
  • common: 1.01 KiB (0.01%)

@matthewwalsh0 matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch 2 times, most recently from b0a00c5 to e54f79c Compare June 25, 2025 16:55
@metamaskbot
Copy link
Collaborator

Builds ready [e54f79c]
UI Startup Metrics (1234 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1234107614196012701339
load106094012165510921155
domContentLoaded105393412095510861149
domInteractive19146481740
firstPaint70781121641710781142
backgroundConnect84314812
firstReactRender22184052235
getState1563982131
initialActions001001
loadScripts83772998853865929
setupStore95234818
WebpackHomeuiStartup22481837273319223552650
load17281372213517518272024
domContentLoaded17211369212917418212010
domInteractive1912117171465
firstPaint1756665093211316
backgroundConnect2611290382539
firstReactRender24290424123391410
getState1243961324
initialActions215134
loadScripts17161367211917318092000
setupStore1674071929
FirefoxBrowserifyHomeuiStartup1377124617129614231581
load1210108314707912701344
domContentLoaded1210108314697912701344
domInteractive1173749063127281
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231376122552
firstReactRender24213322529
getState95315918
initialActions001001
loadScripts1190106214438012501325
setupStore947611730
WebpackHomeuiStartup16641433222416817352071
load14361225190614015271687
domContentLoaded14361225190513915271686
domInteractive97523445593293
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2517125122446
firstReactRender44335244750
getState158104121233
initialActions101011
loadScripts14151205187613815041664
setupStore106869922
Benchmark value 838 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2249 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1728 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1722 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 242 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2651 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2010 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 410 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2001 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 281 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1664 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1415 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2071 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1687 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1686 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1664 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 356ms | Sum of p95 exceeds: 733ms
Sum of all benchmark exceeds: 1089ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.62 KiB (0.03%)
  • ui: 5.77 KiB (0.08%)
  • common: 512 Bytes (0.01%)

@matthewwalsh0 matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch from e54f79c to d10e1e5 Compare June 26, 2025 11:09
@metamaskbot
Copy link
Collaborator

Builds ready [d10e1e5]
UI Startup Metrics (1154 ± 51 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1154104313325111891229
load99290411814810191051
domContentLoaded98689911574710151045
domInteractive17134261638
firstPaint73072109137010141040
backgroundConnect7425279
firstReactRender21164242133
getState1363071928
initialActions001001
loadScripts78669795246814844
setupStore85344816
WebpackHomeuiStartup22401759276320723562650
load17211320206417418041997
domContentLoaded17151316205517317941986
domInteractive181283151462
firstPaint1646138960187288
backgroundConnect2310242232440
firstReactRender22589413109360399
getState1244761323
initialActions214134
loadScripts17121314204417217921979
setupStore187321311927
FirefoxBrowserifyHomeuiStartup1343118517329713851545
load1182105314057112251331
domContentLoaded1182105314057112241331
domInteractive1063530249113188
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213172162138
firstReactRender24213022428
getState95759826
initialActions001001
loadScripts1163104313817012011303
setupStore947812821
WebpackHomeuiStartup15711388211216816531982
load13651184178114214591652
domContentLoaded13651184178114214591652
domInteractive97314506492270
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20154872141
firstReactRender40315444347
getState1173251224
initialActions002111
loadScripts13471170176514214411634
setupStore85385817
Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1712 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2651 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 399 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1979 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1982 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 270 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1634 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 87ms | Sum of p95 exceeds: 408ms
Sum of all benchmark exceeds: 495ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.17 KiB (0.04%)
  • ui: 5.78 KiB (0.08%)
  • common: 585 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

Builds ready [5e6e2a0]
UI Startup Metrics (1195 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1195106313555812331310
load101891211655110451117
domContentLoaded101190711575110401108
domInteractive18144761732
firstPaint67880111439910271079
backgroundConnect84325814
firstReactRender23185072343
getState1666492133
initialActions001001
loadScripts80470694349829892
setupStore95264822
WebpackHomeuiStartup21921635278622122922669
load16711228208318717691990
domContentLoaded16651224206818617651979
domInteractive171280121447
firstPaint1606346066168317
backgroundConnect21105992443
firstReactRender22391418105344400
getState1246581430
initialActions215134
loadScripts16621222205718417641968
setupStore228320411850
FirefoxBrowserifyHomeuiStartup14051162232517514541703
load12171030167510312791393
domContentLoaded12171029167410312791392
domInteractive1213450075123315
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect361210341072451
firstReactRender25215252631
getState17519932966
initialActions001001
loadScripts1194101815299312591369
setupStore94729827
WebpackHomeuiStartup15731370226119616552083
load13521174183615314411693
domContentLoaded13511174183515314411692
domInteractive97313996689290
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154652232
firstReactRender41304934347
getState155270351033
initialActions001011
loadScripts13331157181615314241679
setupStore13523827835
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2670 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1703 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 315 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 66 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2083 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 290 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1679 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 38ms | Sum of p95 exceeds: 860ms
Sum of all benchmark exceeds: 898ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.44 KiB (0.08%)
  • ui: 43.1 KiB (0.59%)
  • common: 368 Bytes (0%)

@matthewwalsh0 matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch from 5e6e2a0 to a1975b3 Compare July 3, 2025 13:39
@metamaskbot
Copy link
Collaborator

Builds ready [a1975b3]
UI Startup Metrics (1181 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1181107014365812171264
load100492711525010421092
domContentLoaded99892211414910301086
domInteractive18144361737
firstPaint67180115340010231073
backgroundConnect74182812
firstReactRender24155572639
getState1563482131
initialActions30204512
loadScripts79472093048825879
setupStore95223918
WebpackHomeuiStartup21871707278423422882679
load16501211221619617511983
domContentLoaded16441207220619517441972
domInteractive181295131456
firstPaint1676740171178374
backgroundConnect2411279272536
firstReactRender24489420115377402
getState1344171528
initialActions92378930
loadScripts16411205219619317421961
setupStore287310562169
FirefoxBrowserifyHomeuiStartup13801198174813314931646
load1199106515169512701374
domContentLoaded1199106515169512691374
domInteractive1233550283121332
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2613183242494
firstReactRender24215142431
getState105589929
initialActions7016122365
loadScripts1178103714959112541338
setupStore12417121755
WebpackHomeuiStartup17301453298322418012080
load14761257187913815731689
domContentLoaded14761257187913815721688
domInteractive1006137152101173
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3018395382943
firstReactRender44335954757
getState145118181039
initialActions10018925772
loadScripts14531237184513615511659
setupStore16633542922
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 245 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2680 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 374 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 69 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 332 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 65 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1730 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1476 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1454 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2080 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1689 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1688 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 173 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 72 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1659 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 467ms | Sum of p95 exceeds: 925.8ms
Sum of all benchmark exceeds: 1392.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.63 KiB (0.03%)
  • ui: 5.69 KiB (0.08%)
  • common: 899 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [01d33ef]
UI Startup Metrics (1197 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1197106614766712341322
load102092912785910401140
domContentLoaded101392312685810351132
domInteractive18137181734
firstPaint67086127740110301080
backgroundConnect84162813
firstReactRender23176062438
getState1664192232
initialActions40396716
loadScripts808719106055832928
setupStore96284919
WebpackHomeuiStartup21901671269520722872645
load16711262204516217481960
domContentLoaded16651258203016017441939
domInteractive181266131354
firstPaint183661943190190318
backgroundConnect2610284372442
firstReactRender24088421120374393
getState1246391230
initialActions92428931
loadScripts16621256201915917381928
setupStore187307301826
FirefoxBrowserifyHomeuiStartup14401235211915815041783
load12531084160610513181474
domContentLoaded12521083160610513171474
domInteractive1283650493126389
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22146982438
firstReactRender26223332731
getState13517121937
initialActions6023424229
loadScripts12331071158110512991451
setupStore12419522838
WebpackHomeuiStartup17161414214616518211968
load14911219180614515951714
domContentLoaded14911219180614615941714
domInteractive1093340165107311
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24176872541
firstReactRender43325244650
getState1043971033
initialActions7121828412
loadScripts14701200178314515731686
setupStore105497928
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 241 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2645 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1441 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1253 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1253 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 129 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1783 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 389 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 29 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1716 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1492 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1491 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1470 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1968 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 311 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1686 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 562ms | Sum of p95 exceeds: 985.8ms
Sum of all benchmark exceeds: 1547.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.82 KiB (0.03%)
  • ui: 5.74 KiB (0.08%)
  • common: 899 Bytes (0.01%)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admire that you never skip pushing storybook components 🙂

OGPoyraz
OGPoyraz previously approved these changes Jul 4, 2025
vinistevam
vinistevam previously approved these changes Jul 4, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jul 4, 2025
@matthewwalsh0 matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch from 01d33ef to f23cc17 Compare July 4, 2025 19:44
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [f23cc17]
UI Startup Metrics (1217 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217110415026812461358
load104794912796110841161
domContentLoaded104094412716010761155
domInteractive18144771739
firstPaint77272128440010621123
backgroundConnect84364815
firstReactRender22164352434
getState1565582030
initialActions607712625
loadScripts793707102058825900
setupStore85243816
WebpackHomeuiStartup22311808283420823352662
load16661338211116517551978
domContentLoaded16591334209816417431968
domInteractive181366121558
firstPaint1596649180177310
backgroundConnect24115982741
firstReactRender28688420115387408
getState1454581832
initialActions12228128932
loadScripts16551332208516217401955
setupStore187185182028
FirefoxBrowserifyHomeuiStartup13941220199114214411702
load1212105315089212701396
domContentLoaded1212105315089212701396
domInteractive1183540367125288
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313154182138
firstReactRender26215042733
getState13521924958
initialActions10019933264
loadScripts1193103414628812561362
setupStore10410414835
WebpackHomeuiStartup17521467262020618322191
load15171245196216616301845
domContentLoaded15171244196216616301844
domInteractive1174849179107324
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271898103042
firstReactRender44346754751
getState156102121634
initialActions7122823518
loadScripts14941224193516616041822
setupStore1156781130
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 25 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 286 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2663 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 32 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1702 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 288 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 58 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 64 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1753 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 118 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1495 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2191 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1845 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1844 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 324 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1822 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 702ms | Sum of p95 exceeds: 1541.8ms
Sum of all benchmark exceeds: 2243.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.63 KiB (0.03%)
  • ui: 5.69 KiB (0.08%)
  • common: 899 Bytes (0.01%)

@matthewwalsh0 matthewwalsh0 dismissed stale reviews from OGPoyraz and vinistevam via de17ad3 July 8, 2025 13:03
@metamaskbot
Copy link
Collaborator

Builds ready [de17ad3]
UI Startup Metrics (1245 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1245111314096913011363
load107596612306411221207
domContentLoaded106896012166411151197
domInteractive18145081740
firstPaint703153122443110871167
backgroundConnect84233912
firstReactRender22163742332
getState16688102127
initialActions40235414
loadScripts82171696162867940
setupStore85224917
WebpackHomeuiStartup23371937290922824642834
load17521410216819218742104
domContentLoaded17451405214719018692092
domInteractive2013109181666
firstPaint1736954977197324
backgroundConnect271571103245
firstReactRender26597440106374402
getState19684122244
initialActions10354101044
loadScripts17411403213418818652079
setupStore258231322650
FirefoxBrowserifyHomeuiStartup14391239205116614921884
load12511090162510813241430
domContentLoaded12511089162410813231430
domInteractive1303764099122339
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513164222261
firstReactRender25224742633
getState14420224946
initialActions9018530347
loadScripts12311073160810913071415
setupStore14420629843
WebpackHomeuiStartup16591402248120817682094
load14391213199616115551712
domContentLoaded14381212199616115551712
domInteractive107365037695282
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615246242542
firstReactRender41324844347
getState176286351134
initialActions6017420412
loadScripts14161185197115815321685
setupStore12423324923
Benchmark value 1245 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1207 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1198 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2337 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1753 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1746 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1742 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2834 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2104 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2092 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 44 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2079 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1440 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1251 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 130 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1231 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1884 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 339 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 46 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 47 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 43 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1660 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1417 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2094 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1712 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1712 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1685 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 666ms | Sum of p95 exceeds: 1682.8ms
Sum of all benchmark exceeds: 2348.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.49 KiB (0.05%)
  • ui: 6.46 KiB (0.09%)
  • common: 1.97 KiB (0.02%)

@metamaskbot
Copy link
Collaborator

Builds ready [3b9aef1]
UI Startup Metrics (1216 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1216108613686012561316
load104994511675510941123
domContentLoaded104294211585410881119
domInteractive17134161735
firstPaint735134116841110781121
backgroundConnect84213911
firstReactRender22165872433
getState1563272128
initialActions40739519
loadScripts79970091553841881
setupStore85274815
WebpackHomeuiStartup22021615273821522902667
load16631221202917017341985
domContentLoaded16571217201716917301973
domInteractive191282161463
firstPaint1526638960167282
backgroundConnect2510172182646
firstReactRender26688405120377395
getState15577111842
initialActions823161024
loadScripts16531215200416717281961
setupStore257399542034
FirefoxBrowserifyHomeuiStartup13991205204115714391712
load1212106814478712691368
domContentLoaded1212106814468712691368
domInteractive1163638761124322
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213178192149
firstReactRender25213732532
getState16425936973
initialActions11023038360
loadScripts1193105214328612521351
setupStore12417922955
WebpackHomeuiStartup16881411227020117822133
load14541219194816415631759
domContentLoaded14541219194816415621759
domInteractive1203354497102339
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2617117142650
firstReactRender42306454549
getState176171231433
initialActions9126534518
loadScripts14311198192316015381739
setupStore136249271026
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2668 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1712 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 73 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 60 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1689 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1455 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 120 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1431 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2133 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 339 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1739 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 405ms | Sum of p95 exceeds: 1299.8ms
Sum of all benchmark exceeds: 1704.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 5 KiB (0.09%)
  • ui: 7.42 KiB (0.1%)
  • common: 2.39 KiB (0.03%)

@matthewwalsh0 matthewwalsh0 enabled auto-merge July 9, 2025 13:38
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 177517c Jul 9, 2025
145 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/enforced-simulations-disable branch July 9, 2025 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants