-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: disable enforced simulations #33802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18253fb to
1b8bc48
Compare
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (12 files, +661 -112)
|
Collaborator
Builds ready [6f60743]
UI Startup Metrics (1238 ± 61 ms)
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 2253 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1731 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1723 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2629 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1971 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 2026 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 329 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1682 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 142ms | Sum of p95 exceeds: 623ms Sum of all benchmark exceeds: 765ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [10fe095]
UI Startup Metrics (1226 ± 56 ms)
Benchmark value 46 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 2247 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1738 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1733 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1730 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2581 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1989 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 302 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1957 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 144ms | Sum of p95 exceeds: 420ms Sum of all benchmark exceeds: 564ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [0319545]
UI Startup Metrics (1252 ± 64 ms)
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 1191 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2603 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 2059 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1691 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 72ms | Sum of p95 exceeds: 749ms Sum of all benchmark exceeds: 821ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ce28a94]
UI Startup Metrics (1286 ± 68 ms)
Benchmark value 1117 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1111 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 850 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1224 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1219 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 946 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2542 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 310 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 2003 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 286 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1631 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 196ms | Sum of p95 exceeds: 617ms Sum of all benchmark exceeds: 813ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [409d0f6]
UI Startup Metrics (1204 ± 47 ms)
Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 292 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1976 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 8ms | Sum of p95 exceeds: 391ms Sum of all benchmark exceeds: 399ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
b0a00c5 to
e54f79c
Compare
Collaborator
Builds ready [e54f79c]
UI Startup Metrics (1234 ± 60 ms)
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2249 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1728 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1722 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 242 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2651 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2010 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 410 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2001 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 281 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1664 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1415 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2071 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1687 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1686 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1664 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 356ms | Sum of p95 exceeds: 733ms Sum of all benchmark exceeds: 1089ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
e54f79c to
d10e1e5
Compare
Collaborator
Builds ready [d10e1e5]
UI Startup Metrics (1154 ± 51 ms)
Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1715 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1712 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2651 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 399 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1979 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1982 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 270 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1634 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 87ms | Sum of p95 exceeds: 408ms Sum of all benchmark exceeds: 495ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Collaborator
Builds ready [5e6e2a0]
UI Startup Metrics (1195 ± 58 ms)
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2670 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1703 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 315 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 66 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2083 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 290 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1679 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 38ms | Sum of p95 exceeds: 860ms Sum of all benchmark exceeds: 898ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
5e6e2a0 to
a1975b3
Compare
Collaborator
Builds ready [a1975b3]
UI Startup Metrics (1181 ± 58 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 245 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2680 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 374 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 69 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 332 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 65 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1730 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1476 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1454 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2080 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1689 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1688 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 173 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 72 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1659 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 467ms | Sum of p95 exceeds: 925.8ms Sum of all benchmark exceeds: 1392.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [01d33ef]
UI Startup Metrics (1197 ± 67 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 241 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2645 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1441 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1253 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1253 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 129 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1783 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 389 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 29 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1716 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1492 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1491 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1470 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1968 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 311 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1686 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 562ms | Sum of p95 exceeds: 985.8ms Sum of all benchmark exceeds: 1547.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
reviewed
Jul 4, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admire that you never skip pushing storybook components 🙂
OGPoyraz
previously approved these changes
Jul 4, 2025
vinistevam
previously approved these changes
Jul 4, 2025
01d33ef to
f23cc17
Compare
Collaborator
Builds ready [f23cc17]
UI Startup Metrics (1217 ± 68 ms)
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 25 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 286 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2663 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 32 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1702 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 288 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 58 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 64 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1753 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 118 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1495 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2191 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1845 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1844 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 324 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1822 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 702ms | Sum of p95 exceeds: 1541.8ms Sum of all benchmark exceeds: 2243.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [de17ad3]
UI Startup Metrics (1245 ± 69 ms)
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1207 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1198 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2337 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1753 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1746 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1742 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2834 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2104 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2092 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 44 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2079 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1440 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1251 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 130 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1231 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1884 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 339 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 46 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 47 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 43 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1660 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1417 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2094 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1712 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1712 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1685 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 666ms | Sum of p95 exceeds: 1682.8ms Sum of all benchmark exceeds: 2348.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3b9aef1]
UI Startup Metrics (1216 ± 60 ms)
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2668 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1712 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 322 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 73 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 60 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1689 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1455 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 120 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1431 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2133 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 339 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1739 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 405ms | Sum of p95 exceeds: 1299.8ms Sum of all benchmark exceeds: 1704.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Jul 9, 2025
vinistevam
approved these changes
Jul 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.0.0
Issue or pull request that will be included in release 13.0.0 (also called 12.24.0)
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support disabling enforced simulations via a new simulation settings modal.
Specifically:
enableEnforcedSimulationsandenableEnforcedSimulationsForTransactionstoAppStateController.applyTransactionContainersExistingutility method to apply transaction containers to an existing transaction.SimulationSettingsModalcomponent to configure enforced simulation settings.useIsEnforcedSimulationsSupportedhook to determine if settings should be displayed.AppStateControllerstate inEnforceSimulationHook.Related issues
Fixes: #5173
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist