chore: Improve performance of address formatting/validation #34152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot update-policies |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +8 -8)
📜 @MetaMask/policy-reviewers (4 files, +8 -8)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +8 -8)
|
Contributor
|
Since these functions now memoize the addresses they can slowly consume memory -- and if used in the background process they'll never let it go. It might not be a problem if the background never goes around checking random addresses as the user browses around. 🤔 Just something to think about before we merge this. |
Member
Author
|
Good point, this concern was raised here as well: MetaMask/core#6054 (comment) At least in this case the cached data is quite small in size, but it is technically unbounded. |
Collaborator
Builds ready [27d5308]
UI Startup Metrics (1238 ± 63 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2283 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1732 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1725 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 260 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 20 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1722 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2689 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 79 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 347 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1991 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1456 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1270 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1270 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1245 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1678 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 89 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 33 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1453 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2175 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1755 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1754 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1729 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 794ms | Sum of p95 exceeds: 1128.8ms Sum of all benchmark exceeds: 1922.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
update-controller-utils
branch
from
27d5308 to
0c26a9b
Compare
Collaborator
Builds ready [0c26a9b]
UI Startup Metrics (1194 ± 84 ms)
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2213 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 276 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2594 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 340 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1412 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1703 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 292 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 100 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1714 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 62 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 31 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1414 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2092 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1731 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1731 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 335 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1710 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 422ms | Sum of p95 exceeds: 1039.8ms Sum of all benchmark exceeds: 1461.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
update-controller-utils
branch
from
c84377e to
2609ad8
Compare
Collaborator
Builds ready [2609ad8]
UI Startup Metrics (1158 ± 65 ms)
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2242 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 264 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2628 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1408 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1784 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 262 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 57 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 48 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1960 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1633 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1633 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 120 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 74 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1607 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2522 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1977 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1977 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 375 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 87 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1954 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 78 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1294ms | Sum of p95 exceeds: 2379.8ms Sum of all benchmark exceeds: 3673.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
update-controller-utils
branch
from
2609ad8 to
8f53730
Compare
Collaborator
Builds ready [8f53730]
UI Startup Metrics (1177 ± 64 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2264 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1720 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1713 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 256 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1709 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2658 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2009 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1996 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1702 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 311 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 52 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 76 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1700 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1444 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1423 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2188 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1833 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1832 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 388 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1744 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 488ms | Sum of p95 exceeds: 1565.8ms Sum of all benchmark exceeds: 2053.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
update-controller-utils
branch
from
8f53730 to
4f61461
Compare
darioAnongba
approved these changes
Jul 18, 2025
Collaborator
Builds ready [4f61461]
UI Startup Metrics (1260 ± 66 ms)
Benchmark value 1082 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1075 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 869 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 959 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2396 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1898 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1888 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 59 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 1883 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2768 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2153 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2140 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 288 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 252 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2137 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1668 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1427 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1426 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 128 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1397 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1967 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1622 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1621 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 375 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 68 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 80 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 45 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1575 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 91 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1758 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1499 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1498 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1473 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2101 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1779 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1778 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1759 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2451ms | Sum of p95 exceeds: 2961.8ms Sum of all benchmark exceeds: 5412.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
update-controller-utils
branch
from
4f61461 to
989dcf8
Compare
Collaborator
Builds ready [989dcf8]
UI Startup Metrics (1300 ± 52 ms)
Benchmark value 1300 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1111 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1103 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 894 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1394 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1214 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1191 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1004 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2497 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2008 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1987 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 25 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 56 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1977 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2870 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2420 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2275 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 366 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 275 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 24 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2255 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 180 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1494 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1292 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1292 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1271 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1813 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1525 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1525 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 344 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 27 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1506 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1789 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1508 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1508 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1482 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 27 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2156 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 159 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1724 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 213 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2451ms | Sum of p95 exceeds: 3255.8ms Sum of all benchmark exceeds: 5706.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
approved these changes
Jul 21, 2025
Gudahtt
force-pushed
the
update-controller-utils
branch
from
989dcf8 to
a68cf51
Compare
Collaborator
Builds ready [a68cf51]
UI Startup Metrics (1276 ± 59 ms)
Benchmark value 1277 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1094 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1087 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 882 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1387 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 976 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2400 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1912 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1900 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 24 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 54 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1893 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2822 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2294 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2215 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 75 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 283 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2203 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1539 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1315 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1315 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1294 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1976 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1503 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1503 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 332 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 50 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 65 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1756 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1485 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1463 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2110 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1811 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1811 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 367 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 37 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1780 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2024ms | Sum of p95 exceeds: 3043.8ms Sum of all benchmark exceeds: 5067.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Update `@metamask/controller-utils` to v11.11.0, which includes this performance improvement to address validation and formatting: MetaMask/core#6054
Gudahtt
force-pushed
the
update-controller-utils
branch
from
a68cf51 to
e80f277
Compare
Collaborator
Builds ready [e80f277]
UI Startup Metrics (1334 ± 59 ms)
Benchmark value 1150 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1138 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 22 exceeds gate value 20 for chrome browserify home mean domInteractive Benchmark value 234 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 915 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1444 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1245 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1233 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1214 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 266 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1002 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2406 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1901 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1891 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 24 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 49 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 39 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1886 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2779 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2302 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2215 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 275 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 245 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2206 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1458 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1267 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1267 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1246 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1722 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 253 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 28 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1750 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1482 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1460 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2155 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1804 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1804 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 358 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1788 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1970ms | Sum of p95 exceeds: 2904.8ms Sum of all benchmark exceeds: 4874.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
@metamask/controller-utilsto v11.11.0, which includes this performance improvement to address validation and formatting: MetaMask/core#6054Changelog
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist