-
Notifications
You must be signed in to change notification settings - Fork 5.4k
test: add wallet details e2e tests #34276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gantunesr
merged 5 commits into
main
from
MUL-280-extension-develop-e-2-e-tests-for-wallet-details
Jul 21, 2025
Merged
test: add wallet details e2e tests #34276
gantunesr
merged 5 commits into
main
from
MUL-280-extension-develop-e-2-e-tests-for-wallet-details
Jul 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +83 -0)
🖥️ @MetaMask/wallet-ux (1 files, +1 -0)
|
Collaborator
Builds ready [aaded72]
UI Startup Metrics (1220 ± 70 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2228 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 260 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2665 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1682 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 328 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 62 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1751 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 113 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1434 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 19 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2264 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 76 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1743 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 94 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 734ms | Sum of p95 exceeds: 1634.8ms Sum of all benchmark exceeds: 2368.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [9215996]
UI Startup Metrics (1225 ± 56 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2243 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 266 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2647 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 26 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 125 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1709 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 448 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 69 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1759 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1488 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1487 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 118 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1468 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2247 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1880 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1880 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 342 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1859 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 867ms | Sum of p95 exceeds: 2064.8ms Sum of all benchmark exceeds: 2931.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_62de5db7-e513-4a62-b938-acb5dc91f529). |
d7bdc73 to
ed23cf7
Compare
Collaborator
Builds ready [ed23cf7]
UI Startup Metrics (1279 ± 60 ms)
Benchmark value 1096 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1090 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 266 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1396 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1191 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 293 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2200 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 246 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2630 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1445 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1244 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1813 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 349 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 69 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1777 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1454 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 23 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2242 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1797 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1796 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 363 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 62 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1759 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 137 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 957ms | Sum of p95 exceeds: 2055.8ms Sum of all benchmark exceeds: 3012.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bdea407]
UI Startup Metrics (1244 ± 66 ms)
Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 267 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2259 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 256 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2692 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1978 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1551 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1335 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1334 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 124 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1312 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1882 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 434 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 76 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 176 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1477 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1681 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1389 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2053 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 982ms | Sum of p95 exceeds: 1503.8ms Sum of all benchmark exceeds: 2485.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [33d3dc1]
UI Startup Metrics (1243 ± 60 ms)
Benchmark value 255 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 271 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2250 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 271 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2635 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 385 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1482 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1264 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1264 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 9 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1242 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1973 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 336 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 43 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1728 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1433 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2200 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1860 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1860 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 403 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 57 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1840 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 885ms | Sum of p95 exceeds: 2226.8ms Sum of all benchmark exceeds: 3111.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
david0xd
approved these changes
Jul 16, 2025
montelaidev
approved these changes
Jul 16, 2025
vinnyhoward
approved these changes
Jul 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.1.0
Issue or pull request that will be included in release 13.1.0
team-accounts-framework
Accounts Framework team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds e2e tests for new wallet details page, added as part of multichain accounts initiative.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Jita ticket: https://consensyssoftware.atlassian.net/browse/MUL-280
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist