fix: unified swaps label #34467
Merged
fix: unified swaps label #34467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +11 -2)
|
Collaborator
Builds ready [d0b1652]
UI Startup Metrics (1262 ± 59 ms)
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 869 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2340 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1836 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1827 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1823 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2532 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2114 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2108 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 35 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2097 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1491 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1284 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1283 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1262 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1754 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 336 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 63 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1770 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1489 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1489 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1465 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 23 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2172 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1845 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1844 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1814 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 211 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1563ms | Sum of p95 exceeds: 2154.8ms Sum of all benchmark exceeds: 3717.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
SteP-n-s
previously approved these changes
Jul 22, 2025
micaelae
reviewed
Jul 22, 2025
ui/pages/bridge/index.tsx
Outdated
| }; | ||
|
|
||
| const isSwap = useIsMultichainSwap(); | ||
| const chainId = useSelector(getCurrentChainId); |
Member
There was a problem hiding this comment.
Does this return non-EVM chainIds as well?
micaelae
approved these changes
Jul 22, 2025
Collaborator
Builds ready [74a9050]
UI Startup Metrics (1281 ± 61 ms)
Benchmark value 1099 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1092 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 885 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1384 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1215 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1207 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 225 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1003 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2427 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1931 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1921 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 60 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1913 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2840 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2267 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2241 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 297 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2228 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1473 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1269 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1268 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1246 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1715 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 266 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 44 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1783 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1518 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1518 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1494 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2107 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1813 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1813 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 244 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 59 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1780 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2035ms | Sum of p95 exceeds: 2626.8ms Sum of all benchmark exceeds: 4661.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
SteP-n-s
approved these changes
Jul 22, 2025
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the 'Bridge' copy in some cases to 'Swaps' where we missed it in the Unified Swaps experience.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist