feat(base branch): make it possible to define name of release PR base branch #35194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| semver-version: ${{ inputs.semver-version }} | ||
| previous-version-tag: ${{ inputs.previous-version-ref }} | ||
| github-tools-version: dde6d530bebae07d1e50180894ab2cac64170a2c | ||
| github-tools-version: 75cfa5085bee4804dadaa2516a47c4ff37278b35 |
There was a problem hiding this comment.
Bug: Workflow Version Mismatch Causes Issues
The create-release-pr.yml workflow's uses reference points to an older github-tools version than the github-tools-version parameter it passes. This mismatch means the workflow runs an outdated version that may not support newer inputs like release-pr-base-branch, potentially leading to unexpected behavior or failures.
Contributor
Author
There was a problem hiding this comment.
I don't understand this comment: release-pr-base-branch input parameter is supported in version 75cfa5085bee4804dadaa2516a47c4ff37278b35 of github-tools.
Member
There was a problem hiding this comment.
The coment is talking about line 22 above; we're still using dde6d530bebae07d1e50180894ab2cac64170a2c
Member
There was a problem hiding this comment.
Oh I see, addressed here: https://github.com/MetaMask/metamask-extension/pull/35197/files
Collaborator
Builds ready [b7b92c0]
UI Startup Metrics (1177 ± 72 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 236 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2610 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 240 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 286ms | Sum of p95 exceeds: 620.8ms Sum of all benchmark exceeds: 906.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vpintorico
approved these changes
Aug 19, 2025
vpintorico
approved these changes
Aug 19, 2025
jvbriones
approved these changes
Aug 19, 2025
metamaskbot
added
the
release-13.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release PR base branch is currently hardcoded to
mainwhich is not convenient, as it should be set tomasterfor Extension.This PR makes it possible to manually define the name of release PR base branch. It leverages changes introduced on github-tools repo in this PR.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist