Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Aug 25, 2025

Description

Adds Metamask Shield Entry point modal UI for users to subscribe to metamask shield.

https://www.figma.com/design/HTAO1SrmixV4ppv7qIvLoa/MetaMask-Shield---Phase-1?node-id=10393-173520&t=h6Rb20hua95hevDR-4

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Added metamask shield entry point modal

Related issues

Fixes:

Manual testing steps

  1. N/A - there is no logic yet to show the modal

Screenshots/Recordings

Before

After

Screenshot 2025-08-26 at 12 59 08 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 25, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Aug 25, 2025

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (2 files, +15 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 home/
        • 📄 home.component.js +13 -0
        • 📄 home.container.js +2 -0

@metamaskbot
Copy link
Collaborator

Builds ready [755802b]
UI Startup Metrics (1216 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1216107414557612601374
load104091912646910811184
domContentLoaded103291312566910731176
domInteractive17134561635
firstPaint633134126442310471151
backgroundConnect2342202566237245
firstReactRender23144162437
getState1153571428
initialActions30457312
loadScripts806692102669850948
setupStore84303813
WebpackHomeuiStartup21881697255118122832486
load16541220188314817351843
domContentLoaded16441215186615117291832
domInteractive16117491437
firstPaint1606430753189277
backgroundConnect2813301292754
firstReactRender18086400100176383
getState3743068111280
initialActions52203513
loadScripts16401212185315017271820
setupStore3463037714297
FirefoxBrowserifyHomeuiStartup13651162182512213961612
load1172101715008312311327
domContentLoaded1172101615008312311326
domInteractive1023229552105238
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3017122173273
firstReactRender26214942835
getState10217821648
initialActions5017618218
loadScripts1149100214347712091284
setupStore11319523748
WebpackHomeuiStartup15791365201713616561819
load13231134161211113991538
domContentLoaded13221133161111113991538
domInteractive1023228154105255
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect281985103144
firstReactRender59488976369
getState62274614
initialActions30163310
loadScripts13011112159110913801505
setupStore104719825
Benchmark value 234 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 245 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 948 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 383 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 297 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 238 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 73 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 48 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 255 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 282ms | Sum of p95 exceeds: 856.8ms
Sum of all benchmark exceeds: 1138.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 1.76 KiB (0.04%)
  • ui: 13.68 KiB (0.18%)
  • common: -10.27 KiB (-0.14%)

@metamaskbot
Copy link
Collaborator

Builds ready [e90d440]
UI Startup Metrics (1253 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1253110314707012981375
load106694412616511071175
domContentLoaded105893912536411001166
domInteractive17134451730
firstPaint728167126342010851161
backgroundConnect2392272606243251
firstReactRender24174252536
getState1353881828
initialActions40548320
loadScripts827707102464872939
setupStore95808916
WebpackHomeuiStartup22341829255513423172488
load16821311190410817331849
domContentLoaded16741304188010617271833
domInteractive16115391443
firstPaint1696542066218290
backgroundConnect2913276282963
firstReactRender20488483109320394
getState3442887611272
initialActions822972969
loadScripts16701299187710517251828
setupStore2863076913294
FirefoxBrowserifyHomeuiStartup13711160182112614041638
load1180102314318412371327
domContentLoaded1180102314318412371326
domInteractive1013332451106227
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2815145143037
firstReactRender26225142935
getState9213517628
initialActions5018719214
loadScripts1159100514088212151301
setupStore9310613734
WebpackHomeuiStartup16031376205713716631902
load13401141164611413991582
domContentLoaded13391140164611413991582
domInteractive1073340161107274
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30206693348
firstReactRender60468766471
getState10312115825
initialActions31224313
loadScripts13181115161211313761559
setupStore11515215922
Benchmark value 1253 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 240 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 252 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2488 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 272 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 274 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 350ms | Sum of p95 exceeds: 834.8ms
Sum of all benchmark exceeds: 1184.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 1.76 KiB (0.04%)
  • ui: 16.29 KiB (0.22%)
  • common: -10.27 KiB (-0.14%)

@metamaskbot
Copy link
Collaborator

Builds ready [9bba701]
UI Startup Metrics (1196 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1196106213516812421301
load105493512026611001165
domContentLoaded104793111956610931158
domInteractive17136581639
firstPaint63882120343310631154
backgroundConnect2352232566238246
firstReactRender24164762540
getState1146691224
initialActions30356314
loadScripts81868896267867928
setupStore85283913
WebpackHomeuiStartup21671574262522822872523
load16681208195017217811877
domContentLoaded16591205189416917731864
domInteractive161283111438
firstPaint1707042161201269
backgroundConnect3215330343156
firstReactRender22092420109363390
getState3342857412271
initialActions7217817510
loadScripts16551203188016717711851
setupStore1272641424
FirefoxBrowserifyHomeuiStartup13141148188911513481518
load1163100015318412081326
domContentLoaded116399915318412081325
domInteractive993229250101226
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2816169182943
firstReactRender25223932833
getState62558520
initialActions4020520211
loadScripts114198513697711831300
setupStore83518629
WebpackHomeuiStartup15431347184612416361807
load13151155162911214201522
domContentLoaded13151155162811114201521
domInteractive993128650104263
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28184363341
firstReactRender60488066372
getState82659723
initialActions31183310
loadScripts12941133160211213951501
setupStore943051121
Benchmark value 235 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 246 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2523 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 268ms | Sum of p95 exceeds: 587.8ms
Sum of all benchmark exceeds: 855.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 175 Bytes (0%)
  • ui: 13.36 KiB (0.18%)
  • common: 682 Bytes (0.01%)

@lionellbriones lionellbriones marked this pull request as ready for review August 27, 2025 16:23
@lionellbriones lionellbriones requested a review from a team as a code owner August 27, 2025 16:23
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [caee7b4]
UI Startup Metrics (1207 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207108613496312561314
load105795212106310951168
domContentLoaded105094612056310831159
domInteractive17136471733
firstPaint68470120442310621156
backgroundConnect2392232698244259
firstReactRender24165572741
getState1153761221
initialActions30839311
loadScripts81769398363849930
setupStore84253917
WebpackHomeuiStartup21401626262124222762545
load16571253199418217571895
domContentLoaded16501246197018117511884
domInteractive171294131448
firstPaint1756538163192320
backgroundConnect26135892747
firstReactRender20891410105331393
getState3143127211268
initialActions721941969
loadScripts16461243195717917481871
setupStore176291381423
FirefoxBrowserifyHomeuiStartup13821202186312814281686
load1210105815128212631391
domContentLoaded1209105715108212631390
domInteractive1013427750106229
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect35172162732105
firstReactRender27224042936
getState827310629
initialActions5019620311
loadScripts1181103814087312401310
setupStore11319422853
WebpackHomeuiStartup16631408205516117771964
load14201202181114415421660
domContentLoaded14201201181114415411660
domInteractive1143231154116287
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31216783347
firstReactRender62469476476
getState72297726
initialActions30193312
loadScripts13971180178214315171641
setupStore115123141127
Benchmark value 240 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2545 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1686 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 229 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 105 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1663 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 62 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1964 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 76 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 469ms | Sum of p95 exceeds: 781.8ms
Sum of all benchmark exceeds: 1250.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 3.63 KiB (0.05%)
  • common: 619 Bytes (0.01%)

@lionellbriones lionellbriones self-assigned this Aug 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4c8e780]
UI Startup Metrics (1192 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1192106815066712291313
load104494513216010741142
domContentLoaded103793913156010691134
domInteractive18135071739
firstPaint706145115340210601119
backgroundConnect2392272617242253
firstReactRender25175782841
getState1257691428
initialActions40628421
loadScripts805713106659837903
setupStore942841020
WebpackHomeuiStartup21451601277322022672485
load16511198204217017451853
domContentLoaded16441194199916817401850
domInteractive171190121444
firstPaint1666345268192295
backgroundConnect2714102122848
firstReactRender21690405110334393
getState2842836712266
initialActions5217268
loadScripts16391192198716717371838
setupStore217288421535
FirefoxBrowserifyHomeuiStartup13981214187210714491586
load1234107414608212941371
domContentLoaded1233107314598212931370
domInteractive1213444260134269
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect321985123363
firstReactRender26233932831
getState52223610
initialActions30345310
loadScripts1209105314328012681350
setupStore10420521729
WebpackHomeuiStartup15741364202114516331860
load13381165163311514141572
domContentLoaded13381165163211514131572
domInteractive1103336557109263
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect29208283439
firstReactRender58448576270
getState72366725
initialActions41234413
loadScripts13161143161211513951550
setupStore11572101127
Benchmark value 239 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 21 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 269 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 297ms | Sum of p95 exceeds: 606.8ms
Sum of all benchmark exceeds: 903.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 3.64 KiB (0.05%)
  • common: 559 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [b672a15]
UI Startup Metrics (1192 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1192103513866412311293
load104290012385810751126
domContentLoaded103589212305910691120
domInteractive18135481637
firstPaint70983124441010541116
backgroundConnect2382242849241254
firstReactRender2516170162538
getState13588111634
initialActions30305312
loadScripts804669101258836885
setupStore85223915
WebpackHomeuiStartup21271567256320922392479
load16351206190615917141856
domContentLoaded16281201189915817081844
domInteractive161278111344
firstPaint1716843261193308
backgroundConnect3012367352955
firstReactRender22688397115363385
getState3132767012265
initialActions52364612
loadScripts16231197189215717021831
setupStore2573095515157
FirefoxBrowserifyHomeuiStartup13351167173211213951601
load1169102813217012291289
domContentLoaded1169102713207012281289
domInteractive1093429849117222
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3218168223360
firstReactRender27214752937
getState8213014624
initialActions407110314
loadScripts1146100813016712001262
setupStore1039315748
WebpackHomeuiStartup16261401208514117071884
load13891195167412014681599
domContentLoaded13891195167412014681598
domInteractive1063029550112264
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30214873443
firstReactRender60487466471
getState62657618
initialActions7118223315
loadScripts13661177165412014461578
setupStore1053261024
Benchmark value 238 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2479 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 157 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1389 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1389 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1367 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 264 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 325ms | Sum of p95 exceeds: 656.8ms
Sum of all benchmark exceeds: 981.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 3.64 KiB (0.05%)
  • common: 559 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [198ca7c]
UI Startup Metrics (1212 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212104414846712501316
load106593713156411001173
domContentLoaded105793213096510941164
domInteractive17135361738
firstPaint69190119342510731136
backgroundConnect2382232678243252
firstReactRender24175072542
getState1052441220
initialActions30395312
loadScripts827710107464865938
setupStore84303814
WebpackHomeuiStartup21801655275923622982578
load16731257198417917671917
domContentLoaded16661249196917817581907
domInteractive171194141456
firstPaint1696034768206325
backgroundConnect291588122959
firstReactRender1999140596191391
getState3443077612275
initialActions10229133615
loadScripts16611247195617617541894
setupStore2783126215252
FirefoxBrowserifyHomeuiStartup13811172171810714511592
load1221103014879312651392
domContentLoaded1220102914879312651392
domInteractive1133329647122227
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3318121163568
firstReactRender27225352836
getState728812525
initialActions2013227
loadScripts1196101114389012441373
setupStore937112834
WebpackHomeuiStartup15971370203114316861850
load13611167164611814561579
domContentLoaded13611167164611814551579
domInteractive1083331551108262
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30198383443
firstReactRender58488576173
getState72275723
initialActions40234415
loadScripts13391137162811814311554
setupStore953151017
Benchmark value 238 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2578 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 252 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 7 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 73 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 293ms | Sum of p95 exceeds: 852.8ms
Sum of all benchmark exceeds: 1145.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 3.64 KiB (0.05%)
  • common: 559 Bytes (0.01%)

@lionellbriones lionellbriones requested a review from a team as a code owner August 29, 2025 06:28
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: c67ed22 | Date: 8/29/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.27s (±57ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 961ms (±50ms) 🟢 | historical mean value: 992ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 83ms (±14ms) 🟢 | historical mean value: 93ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.27s 57ms 1.25s 1.79s 1.32s 1.79s
domContentLoaded 961ms 50ms 937ms 1.43s 997ms 1.43s
firstPaint 83ms 14ms 72ms 180ms 112ms 180ms
firstContentfulPaint 83ms 14ms 72ms 180ms 112ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [5dbb544]
UI Startup Metrics (1194 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1194105813946912391329
load105493412476610941188
domContentLoaded104792812396510851181
domInteractive17134461636
firstPaint66677124543310621183
backgroundConnect2352212607239253
firstReactRender22174352336
getState1143561321
initialActions30738313
loadScripts818706102066860958
setupStore75172811
WebpackHomeuiStartup21161603267021722442432
load17021318205015617951916
domContentLoaded16961314203815517901897
domInteractive181290131548
firstPaint1656330154194281
backgroundConnect3213293333162
firstReactRender1153544096111325
getState3142786913266
initialActions822662679
loadScripts16901311202515117871873
setupStore196265321727
FirefoxBrowserifyHomeuiStartup14081209177911214681644
load1239107414908612981397
domContentLoaded1238107414908612981397
domInteractive1183330357134275
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3416115193594
firstReactRender27225453034
getState62506617
initialActions6024625222
loadScripts1212105614438112711366
setupStore1038813836
WebpackHomeuiStartup15301340192713816141845
load13231145170712214181553
domContentLoaded13231144170712214171553
domInteractive1123131365107287
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect29207673438
firstReactRender41336154450
getState72317825
initialActions40687414
loadScripts13021122168912214011531
setupStore952751120
Benchmark value 236 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1408 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 275 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 22 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 287ms | Sum of p95 exceeds: 618.8ms
Sum of all benchmark exceeds: 905.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 197 Bytes (0%)
  • ui: 7.43 KiB (0.1%)
  • common: 805 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 6f229ec | Date: 9/2/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±58ms) 🟡 | historical mean value: 1.29s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 963ms (±51ms) 🟢 | historical mean value: 979ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±17ms) 🟢 | historical mean value: 93ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 58ms 1.25s 1.82s 1.33s 1.82s
domContentLoaded 963ms 51ms 936ms 1.44s 1.02s 1.44s
firstPaint 84ms 17ms 72ms 232ms 104ms 232ms
firstContentfulPaint 84ms 17ms 72ms 232ms 104ms 232ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [93c2a6b]
UI Startup Metrics (1206 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206108113486512531320
load104691612066310941155
domContentLoaded103790612006410871148
domInteractive17135451624
firstPaint69798120842110571151
backgroundConnect24522933714247264
firstReactRender23155572436
getState1457691631
initialActions40304513
loadScripts80067796464853904
setupStore952341017
WebpackHomeuiStartup19651498249026621592440
load15821215198620217311880
domContentLoaded15721202197420217211865
domInteractive181181151467
firstPaint1706434561209298
backgroundConnect3217340323154
firstReactRender79373345280230
getState2743056313262
initialActions7217617610
loadScripts15681199196420117171852
setupStore1162631318
FirefoxBrowserifyHomeuiStartup13711193179211914321625
load1190105314708912561364
domContentLoaded1190105214698912561364
domInteractive1133339764114263
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3418206253390
firstReactRender27226062740
getState52354511
initialActions5118518310
loadScripts1163101713948312221314
setupStore1149114848
WebpackHomeuiStartup15331357213714416401818
load13041146168011813951534
domContentLoaded13041145168011813951534
domInteractive101303105097251
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect331893103742
firstReactRender42355644549
getState63122610
initialActions4111411310
loadScripts12791128165911913751515
setupStore95294918
Benchmark value 245 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 262 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 263 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 90 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 251 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 279ms | Sum of p95 exceeds: 557.8ms
Sum of all benchmark exceeds: 836.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -199.65 KiB (-4.3%)
  • ui: 33.66 KiB (0.44%)
  • common: 139.29 KiB (1.86%)

Copy link
Contributor

@lwin-kyaw lwin-kyaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Sep 2, 2025
@chaitanyapotti chaitanyapotti removed the request for review from a team September 2, 2025 08:42
Merged via the queue into main with commit 0d7e5ce Sep 2, 2025
151 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/shield-entry-modal branch September 2, 2025 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2025
@metamaskbot metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.4.0 Issue or pull request that will be included in release 13.4.0 size-M team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants