-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: shield entry modal #35347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: shield entry modal #35347
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (2 files, +15 -0)
|
Builds ready [755802b]
UI Startup Metrics (1216 ± 76 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 245 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 948 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 383 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 297 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 238 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 73 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 48 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 255 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 282ms | Sum of p95 exceeds: 856.8ms Sum of all benchmark exceeds: 1138.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [e90d440]
UI Startup Metrics (1253 ± 70 ms)
Benchmark value 240 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 252 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2488 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 272 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 274 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 350ms | Sum of p95 exceeds: 834.8ms Sum of all benchmark exceeds: 1184.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [9bba701]
UI Startup Metrics (1196 ± 68 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 246 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2523 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 268ms | Sum of p95 exceeds: 587.8ms Sum of all benchmark exceeds: 855.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [caee7b4]
UI Startup Metrics (1207 ± 63 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2545 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1686 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 229 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 105 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1663 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 62 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1964 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 76 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 469ms | Sum of p95 exceeds: 781.8ms Sum of all benchmark exceeds: 1250.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4c8e780]
UI Startup Metrics (1192 ± 67 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 21 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 269 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 297ms | Sum of p95 exceeds: 606.8ms Sum of all benchmark exceeds: 903.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b672a15]
UI Startup Metrics (1192 ± 64 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2479 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 157 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1389 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1389 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1367 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 264 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 325ms | Sum of p95 exceeds: 656.8ms Sum of all benchmark exceeds: 981.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [198ca7c]
UI Startup Metrics (1212 ± 67 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2578 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 252 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 7 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 73 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 293ms | Sum of p95 exceeds: 852.8ms Sum of all benchmark exceeds: 1145.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5dbb544]
UI Startup Metrics (1194 ± 69 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1408 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 275 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 22 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 287ms | Sum of p95 exceeds: 618.8ms Sum of all benchmark exceeds: 905.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [93c2a6b]
UI Startup Metrics (1206 ± 65 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 262 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 263 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 90 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 251 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 279ms | Sum of p95 exceeds: 557.8ms Sum of all benchmark exceeds: 836.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
lwin-kyaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds Metamask Shield Entry point modal UI for users to subscribe to metamask shield.
https://www.figma.com/design/HTAO1SrmixV4ppv7qIvLoa/MetaMask-Shield---Phase-1?node-id=10393-173520&t=h6Rb20hua95hevDR-4
Changelog
CHANGELOG entry: Added metamask shield entry point modal
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist