feat: add e2e tests for trezor ERC721 NFT deployment and management. #35383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit consolidates polling for native and ERC20 tokens into a single RPC request, streamlining the process and reducing the number of RPC calls. Additionally, all RPC requests across account addresses are now batched through the `multicall3` contract, enhancing performance.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dawnseeker8
added
hardware-trezor
e2e-test
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [b0bab65]
UI Startup Metrics (1254 ± 101 ms)
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 239 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 839 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1443 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1290 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1280 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1251 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 256 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1043 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2284 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1728 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1719 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 1715 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2579 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 265 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 459ms | Sum of p95 exceeds: 1127.8ms Sum of all benchmark exceeds: 1586.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This commit changes the test suite description from 'Ledger Hardware' to 'Trezor Hardware' in the Trezor ERC-721 specification test file, ensuring clarity and accuracy in the test context.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [2d1cb10]
UI Startup Metrics (1224 ± 67 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1387 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 246 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2268 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2612 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 384 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 62 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 266 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 76 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 363ms | Sum of p95 exceeds: 762.8ms Sum of all benchmark exceeds: 1125.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [d5574bf]
UI Startup Metrics (1240 ± 64 ms)
Benchmark value 240 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 36 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 250 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1671 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1397 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1397 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 62 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1372 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2074 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1716 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1716 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 252 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 73 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1668 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 406ms | Sum of p95 exceeds: 886.8ms Sum of all benchmark exceeds: 1292.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [15c6edb]
UI Startup Metrics (1251 ± 63 ms)
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 256 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2234 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 45 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2560 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 312 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 81 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 56 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 254 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 360ms | Sum of p95 exceeds: 882.8ms Sum of all benchmark exceeds: 1242.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [2dee941]
UI Startup Metrics (1251 ± 71 ms)
Benchmark value 237 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 255 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 24 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2267 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 46 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2589 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 79 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 284 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1429 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 415ms | Sum of p95 exceeds: 756.8ms Sum of all benchmark exceeds: 1171.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e4ef478]
UI Startup Metrics (1244 ± 64 ms)
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 257 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2319 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1737 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1729 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1724 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2660 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 250 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 292 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 248 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1665 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 64 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 81 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 572ms | Sum of p95 exceeds: 1052.8ms Sum of all benchmark exceeds: 1624.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [2f026ff]
UI Startup Metrics (1247 ± 72 ms)
Benchmark value 238 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 251 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 27 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2238 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 41 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2505 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 386 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 221 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 87 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 347ms | Sum of p95 exceeds: 626.8ms Sum of all benchmark exceeds: 973.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [3f31036]
UI Startup Metrics (1229 ± 59 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 250 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2459 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 374 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 159 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1439 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1745 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 241 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 57 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1623 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 2066 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 80 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 346ms | Sum of p95 exceeds: 940.8ms Sum of all benchmark exceeds: 1286.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [45b4b55]
UI Startup Metrics (1250 ± 79 ms)
Benchmark value 242 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2232 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 264 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 206 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 336ms | Sum of p95 exceeds: 642.8ms Sum of all benchmark exceeds: 978.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [9829447]
UI Startup Metrics (1249 ± 69 ms)
Benchmark value 238 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1193 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 249 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2227 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2543 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1424 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1699 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 241 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 257 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 354ms | Sum of p95 exceeds: 723.8ms Sum of all benchmark exceeds: 1077.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [f73c3a8]
UI Startup Metrics (1204 ± 70 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 247 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2520 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 383 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 2023 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 267 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 68 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 285ms | Sum of p95 exceeds: 753.8ms Sum of all benchmark exceeds: 1038.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [4f1072d]
UI Startup Metrics (1233 ± 69 ms)
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 840 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 253 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2527 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 221 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 315ms | Sum of p95 exceeds: 595.8ms Sum of all benchmark exceeds: 910.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [0daec3f]
UI Startup Metrics (1193 ± 69 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 252 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 49 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2522 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 228 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 281ms | Sum of p95 exceeds: 619.8ms Sum of all benchmark exceeds: 900.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
reviewed
Aug 28, 2025
Member
seaona
left a comment
seaona
left a comment
There was a problem hiding this comment.
Could we split this into 4 tests:
- deploy ERC
- mint
- approve
- setApprovalForAll
This way, each test is validating a specific functionality and they are isolated from one another (one can fail while the rest pass, etC)
for the first one, leave it as is, the rest of specs can use the fixture to inject the contract: see this example https://github.com/MetaMask/metamask-extension/blob/main/test/e2e/tests/confirmations/transactions/transaction-decoding-redesign.spec.ts#L21
Member
|
Spec is failing on FF. It seems the dialog was not opened, though I can see how the tx was added in the wallet. This should be debugged further:
|
Collaborator
Builds ready [88bc948]
UI Startup Metrics (1272 ± 69 ms)
Benchmark value 1116 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1108 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 861 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1398 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1219 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1220 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 269 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 966 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2559 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 74 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 380 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 260 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 72 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 40 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 466ms | Sum of p95 exceeds: 830.8ms Sum of all benchmark exceeds: 1296.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [05e0fdf]
UI Startup Metrics (1190 ± 59 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2536 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 270 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1738 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1479 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1479 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 122 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 65 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1455 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2007 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1719 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1719 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 74 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1693 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 721ms | Sum of p95 exceeds: 910.8ms Sum of all benchmark exceeds: 1631.8ms |
…approval actions - Added tests for deploying, minting, and approving ERC-721 tokens using Trezor hardware wallets. - Refactored existing test structure to improve clarity and maintainability. - Integrated smart contract and DApp URL into test fixtures for better configuration. - Ensured proper validation of account balances and transaction confirmations throughout the test cases.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [1dac0e1]
UI Startup Metrics (1238 ± 68 ms)
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 832 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 263 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 292ms | Sum of p95 exceeds: 510.8ms Sum of all benchmark exceeds: 802.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…FT minting - Introduced helper functions for deploying ERC-721 contracts and minting NFTs to enhance test readability and maintainability. - Updated test cases to utilize the new functions, streamlining the process of deploying and interacting with ERC-721 tokens. - Ensured proper validation of transaction activities and NFT display in the user interface.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [c01599a]
UI Startup Metrics (1179 ± 61 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 259 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 25 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2475 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 265 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 281ms | Sum of p95 exceeds: 591.8ms Sum of all benchmark exceeds: 872.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Akaryatrh
approved these changes
Sep 2, 2025
dawnseeker8
commented
Sep 2, 2025
| ); | ||
| }); | ||
|
|
||
| it('approves an ERC-721 token', async function () { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, the approve e2e tests are difference due to approve will check against the ownership of contract, the SMART_CONTRACTS.NFT contract doesnt belong to ledger account, that is why i need to do deployment, mint and then approve in this tests.
Member
There was a problem hiding this comment.
Oh I see, good point! I think we could enhance our testing framework to support this. I'll open a ticket for that for the QA team. Thank you!!
metamaskbot
added
the
release-13.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to this plan Trezor ERC712
This PR has implemented a e2e tests for trezor ERC721 NFT deployment and management.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/968
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist