feat: Add SRP backup to Multichain Account Details #35518

david0xd · 2025-08-29T14:49:32Z

Description

This PR adds SRP reveal/backup item to the Multichain Account List page.

Notes:

Reveal SRP process and JSX template is extracted into a new component to reduce code duplication.
Some minor refactoring is done to Wallet Details and Account Details pages to improve maintainability.
Some minor UI adjustments are done in order to match the design specification from Figma.

Changelog

CHANGELOG entry: Added SRP backup process to Multichain Account Details

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-701

Manual testing steps

Build extension with multichain accounts state 2 feature flag enabled.
Open extension > account list > account details.
Check that account details contains SRP backup row.
Use SRP backup process by clicking on the SRP backup row and test.
Check the same process on wallet details.
Check the same process for new fresh wallet (single wallet) for which backup of SRP is skipped on creation. Make sure that backup text is red and the process links to the SRP backup page instead to a modal.

Screenshots/Recordings

Before

SRP reveal/backup was not available on the account details page before, so nothing important to show here. Please have a look at the "After" section and confirm that everything is as expected and by design.

After

Screen.Recording.2025-09-01.at.17.24.38.mov

Screen.Recording.2025-09-01.at.17.33.08.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-08-29T14:49:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-08-29T14:51:43Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (12 files, +337 -99)

📁 ui/
- 📁 components/
  - 📁 multichain-accounts/
    - 📁 account-details-row/
      - 📄 account-details-row.tsx +1 -1
      - 📄 index.scss +1 -0
    - 📁 multichain-srp-backup/
      - 📄 index.scss +5 -0
      - 📄 index.ts +1 -0
      - 📄 multichain-srp-backup.stories.tsx +71 -0
      - 📄 multichain-srp-backup.test.tsx +110 -0
      - 📄 multichain-srp-backup.tsx +97 -0
      - 📄 multichain-accounts.scss +1 -0
- 📁 pages/
  - 📁 multichain-accounts/
    - 📁 multichain-account-details-page/
      - 📄 index.scss +8 -1
      - 📄 multichain-account-details-page.test.tsx +1 -2
      - 📄 multichain-account-details-page.tsx +34 -29
    - 📁 wallet-details-page/
      - 📄 wallet-details-page.tsx +7 -66

metamaskbot · 2025-08-29T15:07:40Z

📊 Page Load Benchmark Results

Current Commit: a83ebd3 | Date: 8/29/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.31s (±102ms) 🟡 | historical mean value: 1.30s ⬆️ (historical data)
domContentLoaded-> current mean value: 981ms (±67ms) 🟢 | historical mean value: 979ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 89ms (±27ms) 🟢 | historical mean value: 90ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.31s	102ms	1.26s	2.04s	1.43s	2.04s
domContentLoaded	981ms	67ms	942ms	1.42s	1.07s	1.42s
firstPaint	89ms	27ms	72ms	232ms	148ms	232ms
firstContentfulPaint	89ms	27ms	72ms	232ms	148ms	232ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-01T15:54:56Z

📊 Page Load Benchmark Results

Current Commit: 5f0f215 | Date: 9/1/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.28s (±130ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
domContentLoaded-> current mean value: 969ms (±105ms) 🟢 | historical mean value: 983ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±47ms) 🟢 | historical mean value: 93ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.28s	130ms	1.24s	2.39s	1.32s	2.39s
domContentLoaded	969ms	105ms	931ms	1.78s	1.01s	1.78s
firstPaint	90ms	47ms	68ms	440ms	124ms	440ms
firstContentfulPaint	90ms	47ms	68ms	440ms	124ms	440ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-01T16:01:36Z

Builds ready [500de51]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1210 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1210	1096	1439	71	1232	1373
			load	1051	942	1295	70	1082	1208
			domContentLoaded	1045	936	1288	70	1075	1200
			domInteractive	17	13	52	7	17	38
			firstPaint	709	73	1296	429	1054	1206
			backgroundConnect	236	224	250	6	240	245
			firstReactRender	22	16	46	5	23	35
			getState	13	5	78	9	15	27
			initialActions	4	0	20	3	6	12
			loadScripts	815	707	1059	70	842	977
			setupStore	9	6	25	3	10	14
	Webpack	Home	uiStartup	2008	1468	2613	265	2211	2461
			load	1609	1192	2036	197	1736	1896
			domContentLoaded	1595	1183	2020	194	1724	1871
			domInteractive	18	12	92	17	14	75
			firstPaint	172	69	541	69	207	310
			backgroundConnect	46	15	342	67	34	330
			firstReactRender	99	38	340	78	89	308
			getState	40	4	320	84	15	286
			initialActions	8	2	277	27	7	11
			loadScripts	1591	1172	2010	193	1721	1865
			setupStore	12	6	33	4	14	21
Firefox	Browserify	Home	uiStartup	1388	1178	1875	116	1437	1646
			load	1203	1034	1496	81	1258	1347
			domContentLoaded	1203	1034	1496	81	1258	1347
			domInteractive	110	32	341	52	110	235
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	39	19	197	28	39	92
			firstReactRender	27	21	52	4	29	35
			getState	7	2	203	20	6	13
			initialActions	3	1	43	4	3	8
			loadScripts	1173	1016	1331	74	1231	1307
			setupStore	10	4	75	11	8	27
	Webpack	Home	uiStartup	1535	1360	1982	142	1611	1864
			load	1321	1158	1655	120	1397	1600
			domContentLoaded	1320	1158	1654	120	1397	1599
			domInteractive	105	31	436	61	100	280
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	20	48	6	35	38
			firstReactRender	41	35	66	4	43	49
			getState	7	3	135	13	6	9
			initialActions	5	1	138	14	3	15
			loadScripts	1299	1137	1631	121	1378	1574
			setupStore	9	5	86	9	8	16

Benchmark value 237 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1208 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1207 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 245 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 47 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2461 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 331 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 40 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 92 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 280 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 292ms | Sum of p95 exceeds: 915.8ms
Sum of all benchmark exceeds: 1207.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 2.82 KiB (0.04%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-01T17:15:35Z

📊 Page Load Benchmark Results

Current Commit: fec58d3 | Date: 9/1/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±138ms) 🟡 | historical mean value: 1.30s ⬆️ (historical data)
domContentLoaded-> current mean value: 981ms (±108ms) 🟢 | historical mean value: 981ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 93ms (±46ms) 🟢 | historical mean value: 92ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	138ms	1.25s	2.35s	1.51s	2.35s
domContentLoaded	981ms	108ms	936ms	1.61s	1.18s	1.61s
firstPaint	93ms	46ms	68ms	324ms	236ms	324ms
firstContentfulPaint	93ms	46ms	68ms	324ms	236ms	324ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-01T17:22:41Z

Builds ready [73d8ee8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1092	1392	68	1285	1360
			load	1079	947	1240	65	1120	1191
			domContentLoaded	1072	943	1230	65	1111	1184
			domInteractive	18	14	45	7	17	40
			firstPaint	638	73	1234	439	1075	1184
			backgroundConnect	239	227	261	6	243	250
			firstReactRender	23	17	50	6	24	40
			getState	13	5	44	7	16	26
			initialActions	6	0	74	9	6	15
			loadScripts	840	715	993	65	876	948
			setupStore	9	6	31	3	10	13
	Webpack	Home	uiStartup	2012	1521	2559	269	2193	2459
			load	1620	1248	1940	196	1759	1882
			domContentLoaded	1611	1237	1929	194	1748	1870
			domInteractive	16	11	94	12	14	42
			firstPaint	165	61	504	69	202	282
			backgroundConnect	29	16	85	12	30	54
			firstReactRender	96	38	331	72	91	304
			getState	35	4	312	76	15	273
			initialActions	9	2	172	24	7	20
			loadScripts	1607	1234	1917	193	1742	1857
			setupStore	18	6	288	37	15	24
Firefox	Browserify	Home	uiStartup	1347	1175	1745	109	1411	1546
			load	1169	1014	1416	81	1230	1304
			domContentLoaded	1169	1014	1416	81	1229	1303
			domInteractive	114	33	425	63	118	280
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	19	93	11	36	57
			firstReactRender	26	22	52	5	28	36
			getState	8	2	80	12	6	25
			initialActions	4	1	69	10	3	11
			loadScripts	1145	997	1391	80	1207	1274
			setupStore	10	4	89	11	8	28
	Webpack	Home	uiStartup	1553	1387	1900	131	1665	1846
			load	1336	1186	1644	117	1424	1570
			domContentLoaded	1336	1186	1642	117	1424	1570
			domInteractive	105	31	304	54	106	277
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	53	7	36	43
			firstReactRender	43	35	54	4	45	49
			getState	6	3	17	2	6	11
			initialActions	4	0	109	11	3	7
			loadScripts	1313	1168	1619	118	1405	1551
			setupStore	8	5	20	3	9	17

Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 239 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 840 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1192 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 250 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 948 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2460 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 273 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 280 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 322ms | Sum of p95 exceeds: 583.8ms
Sum of all benchmark exceeds: 905.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 3.06 KiB (0.04%)
common: 10 Bytes (0%)

gantunesr

Looks good, left two minor comments. One is about a text color that @eriknson mentioned last week

ui/components/multichain-accounts/multichain-srp-backup/multichain-srp-backup.tsx

Add storybook and tests Add some changes to fix the UI and make it by design

gantunesr · 2025-09-01T18:41:17Z

Looks good but still pending confirmation of #35518 (comment)

metamaskbot · 2025-09-01T18:54:07Z

📊 Page Load Benchmark Results

Current Commit: 57c8095 | Date: 9/1/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.29s (±58ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
domContentLoaded-> current mean value: 974ms (±50ms) 🟢 | historical mean value: 981ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±20ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.29s	58ms	1.25s	1.80s	1.34s	1.80s
domContentLoaded	974ms	50ms	941ms	1.43s	1.02s	1.43s
firstPaint	88ms	20ms	72ms	192ms	140ms	192ms
firstContentfulPaint	88ms	20ms	72ms	192ms	140ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-01T19:01:04Z

Builds ready [badb9fc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1182 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1182	1068	1368	54	1212	1286
			load	1030	928	1206	57	1065	1139
			domContentLoaded	1023	920	1196	57	1053	1128
			domInteractive	17	13	45	7	16	37
			firstPaint	647	79	1129	410	1030	1076
			backgroundConnect	235	222	259	7	238	249
			firstReactRender	22	15	43	5	23	33
			getState	12	5	32	6	14	23
			initialActions	4	1	67	7	5	11
			loadScripts	795	682	967	58	823	905
			setupStore	9	5	20	3	10	15
	Webpack	Home	uiStartup	1922	1475	2560	267	2097	2376
			load	1562	1189	2000	201	1712	1844
			domContentLoaded	1552	1178	1978	200	1702	1820
			domInteractive	16	11	74	10	14	41
			firstPaint	162	80	371	49	187	253
			backgroundConnect	28	18	67	8	29	49
			firstReactRender	86	37	321	59	81	274
			getState	30	4	317	69	13	274
			initialActions	5	2	24	3	6	9
			loadScripts	1548	1175	1967	199	1699	1808
			setupStore	14	6	262	25	13	26
Firefox	Browserify	Home	uiStartup	1364	1168	1832	124	1423	1599
			load	1184	1027	1459	90	1237	1360
			domContentLoaded	1183	1026	1459	90	1236	1360
			domInteractive	108	34	313	47	110	217
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	106	15	34	67
			firstReactRender	26	22	51	4	28	32
			getState	7	3	88	10	6	15
			initialActions	4	1	51	7	3	12
			loadScripts	1160	1005	1406	86	1211	1338
			setupStore	10	4	74	12	8	29
	Webpack	Home	uiStartup	1549	1356	1900	145	1648	1834
			load	1328	1161	1682	126	1422	1570
			domContentLoaded	1328	1161	1681	126	1421	1570
			domInteractive	110	34	309	64	99	296
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	22	52	6	36	41
			firstReactRender	42	34	69	5	44	50
			getState	6	3	13	2	6	10
			initialActions	5	1	104	13	3	8
			loadScripts	1305	1134	1663	127	1401	1546
			setupStore	9	5	67	7	9	19

Benchmark value 235 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 250 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 217 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 296 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 268ms | Sum of p95 exceeds: 502.8ms
Sum of all benchmark exceeds: 770.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 2.76 KiB (0.04%)
common: 10 Bytes (0%)

david0xd self-assigned this Aug 29, 2025

david0xd added the team-accounts-framework Accounts Framework team label Aug 29, 2025

github-actions bot added the size-M label Aug 29, 2025

david0xd force-pushed the dd/add-srp-backup-account-details branch 2 times, most recently from f4857c3 to 444474a Compare September 1, 2025 15:26

david0xd marked this pull request as ready for review September 1, 2025 17:38

david0xd requested a review from a team as a code owner September 1, 2025 17:38

This comment was marked as outdated.

Sign in to view

gantunesr reviewed Sep 1, 2025

View reviewed changes

ui/components/multichain-accounts/multichain-srp-backup/multichain-srp-backup.tsx Outdated Show resolved Hide resolved

ui/components/multichain-accounts/multichain-srp-backup/multichain-srp-backup.tsx Outdated Show resolved Hide resolved

david0xd added 6 commits September 1, 2025 20:35

Add SRP backup to Multichain Account Details

269003f

Add storybook and tests Add some changes to fix the UI and make it by design

Refactor some stuff in account details

f331015

Fix background color

9da23fa

Fix unit test

daca220

Add useCallback for srp handling functions

5211c12

Update backup text color

badb9fc

david0xd force-pushed the dd/add-srp-backup-account-details branch from 181d374 to badb9fc Compare September 1, 2025 18:35

gantunesr approved these changes Sep 1, 2025

View reviewed changes

montelaidev approved these changes Sep 2, 2025

View reviewed changes

david0xd added this pull request to the merge queue Sep 2, 2025

Merged via the queue into main with commit 469e570 Sep 2, 2025
145 checks passed

david0xd deleted the dd/add-srp-backup-account-details branch September 2, 2025 09:24

github-actions bot locked and limited conversation to collaborators Sep 2, 2025

metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 2, 2025

feat: Add SRP backup to Multichain Account Details #35518

feat: Add SRP backup to Multichain Account Details #35518

Uh oh!

Conversation

david0xd commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

metamaskbot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Aug 29, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 1, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gantunesr commented Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

david0xd commented Aug 29, 2025 •

edited

Loading

metamaskbot commented Aug 29, 2025 •

edited

Loading