test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 #35552

seaona · 2025-09-01T09:35:10Z

Description

As a follow-up of this PR, which separated the logic for setting up the Websocket, from the test steps, now this PR separates the logic for handling mocked wss requests from the setup websocket server.

This means that now we can pass an array of websocket mocks.

Note, that the websocket mocks are different from the regular Http mocks, they look like this:

export interface WebSocketMessageMock {
  messageIncludes: string | string[];
  response: object;
  delay?: number;
  logMessage?: string;
}

and the logic for handling the mocks is also different, as we are handling this in our local websocket server. Meaning:

From Mocktt default mocks --> we check if we need a Websocket Solana server, if so, we re-route any wss to the local wss
We setup the local Websocket server
We add 'onMessage' listeners to intercept the requests we want to mock, and we send back the desired response

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-01T09:35:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-09-01T09:38:06Z

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (2 files, +10 -9)

📁 test/
- 📁 e2e/
  - 📄 helpers.js +8 -7
  - 📄 mock-e2e.js +2 -2

seaona · 2025-09-01T09:40:13Z

test/e2e/helpers.js

    ethConversionInUsd,
    monConversionInUsd,
    manifestFlags,
-    withSolanaWebSocket = false,


In the first part of the refactor, the Websocket mock logic was joint with the Websocket setup.
As a second stage of this refactor, we now separate the 2, allowing flexibility

seaona · 2025-09-01T09:46:53Z

test/e2e/helpers.js

      localWebSocketServer = LocalWebSocketServer.getServerInstance();
      localWebSocketServer.start();
-      // All specs use the same ws mocks.
-      // If we need custom ws mocks we can expand logic for supporting custom ws mocks like with http


logic has been updated, to be able to pass a mocks array with websocket mocks

cursor · 2025-09-01T09:51:42Z

test/e2e/helpers.js

+    withSolanaWebSocket = {
+      server: false,
+      mocks: [],
+    },


Bug: WebSocket Server Setup Skipped

The withSolanaWebSocket parameter's type changed from a boolean to an object. If existing calls pass true, the Solana WebSocket server setup is silently skipped because true.server is undefined. This can cause unexpected test failures.

Additional Locations (2)

test/e2e/helpers.js#L266-L270

test/e2e/mock-e2e.js#L948-L949

If existing calls pass true, the Solana WebSocket server setup is silently skipped because true.server is undefined. This can caus

ℹ️ there are no existing calls as I've updated all the old references

metamaskbot · 2025-09-01T10:06:41Z

📊 Page Load Benchmark Results

Current Commit: 74d9386 | Date: 9/1/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±110ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
domContentLoaded-> current mean value: 983ms (±107ms) 🟢 | historical mean value: 984ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 93ms (±47ms) 🟢 | historical mean value: 91ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	110ms	1.25s	1.94s	1.50s	1.94s
domContentLoaded	983ms	107ms	943ms	1.61s	1.18s	1.61s
firstPaint	93ms	47ms	68ms	340ms	240ms	340ms
firstContentfulPaint	93ms	47ms	68ms	340ms	240ms	340ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-01T10:13:48Z

Builds ready [d8cca1a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1068	1363	62	1247	1304
			load	1039	947	1210	57	1080	1141
			domContentLoaded	1032	939	1201	57	1075	1132
			domInteractive	17	13	45	5	17	26
			firstPaint	592	68	1209	427	1041	1115
			backgroundConnect	235	222	266	8	239	253
			firstReactRender	23	16	42	6	24	37
			getState	12	5	49	6	14	24
			initialActions	5	0	69	7	6	13
			loadScripts	803	711	970	56	845	898
			setupStore	9	5	21	3	10	16
	Webpack	Home	uiStartup	1995	1463	2450	236	2161	2401
			load	1600	1175	2005	175	1697	1850
			domContentLoaded	1591	1172	1995	174	1690	1831
			domInteractive	16	11	84	11	13	40
			firstPaint	169	58	347	58	207	285
			backgroundConnect	30	16	325	31	29	47
			firstReactRender	97	35	333	79	87	315
			getState	33	4	323	74	14	283
			initialActions	5	2	13	2	7	9
			loadScripts	1587	1169	1985	173	1686	1823
			setupStore	12	6	26	4	14	24
Firefox	Browserify	Home	uiStartup	1367	1180	1858	120	1407	1638
			load	1186	1043	1498	77	1242	1315
			domContentLoaded	1185	1043	1498	77	1241	1315
			domInteractive	110	29	287	51	114	258
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	111	13	32	43
			firstReactRender	26	22	54	4	28	34
			getState	7	3	92	10	6	15
			initialActions	5	1	175	18	3	11
			loadScripts	1163	1026	1483	75	1214	1294
			setupStore	12	4	204	24	8	43
	Webpack	Home	uiStartup	1629	1425	2066	143	1719	1915
			load	1396	1199	1762	128	1481	1626
			domContentLoaded	1396	1199	1762	128	1481	1626
			domInteractive	113	31	330	64	107	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	63	7	38	43
			firstReactRender	45	37	61	5	47	55
			getState	7	3	139	13	6	11
			initialActions	4	1	65	7	3	11
			loadScripts	1372	1178	1736	129	1462	1602
			setupStore	9	5	45	5	9	18

Benchmark value 236 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 254 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 258 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 43 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1630 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1396 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1396 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 113 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1372 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 340ms | Sum of p95 exceeds: 581.8ms
Sum of all benchmark exceeds: 921.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

DDDDDanica · 2025-09-01T14:12:59Z

LGTM !

davibroc

LGTM

wss mock setup

ddcb592

metamaskbot added the team-qa QA team label Sep 1, 2025

github-actions bot added the size-M label Sep 1, 2025

seaona commented Sep 1, 2025

View reviewed changes

seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 1, 2025

seaona self-assigned this Sep 1, 2025

seaona commented Sep 1, 2025

View reviewed changes

fix lint

d8cca1a

seaona marked this pull request as ready for review September 1, 2025 09:48

seaona requested a review from a team as a code owner September 1, 2025 09:48

cursor bot reviewed Sep 1, 2025

View reviewed changes

DDDDDanica approved these changes Sep 1, 2025

View reviewed changes

seaona enabled auto-merge September 1, 2025 16:41

HowardBraham approved these changes Sep 1, 2025

View reviewed changes

davibroc approved these changes Sep 2, 2025

View reviewed changes

seaona added this pull request to the merge queue Sep 2, 2025

Merged via the queue into main with commit d6c9db2 Sep 2, 2025
145 of 146 checks passed

seaona deleted the test-wss-mocks-solana branch September 2, 2025 11:16

github-actions bot locked and limited conversation to collaborators Sep 2, 2025

metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 2, 2025

gauthierpetetin changed the title ~~test: split Solana WebSocket Mock setup logic from Websocket Mocks~~ test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 Sep 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 #35552

test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 #35552

Uh oh!

seaona commented Sep 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

seaona Sep 1, 2025

Uh oh!

seaona Sep 1, 2025

Uh oh!

cursor bot Sep 1, 2025

Uh oh!

seaona Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

DDDDDanica commented Sep 1, 2025

Uh oh!

davibroc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 #35552

test: split Solana WebSocket Mock setup logic from Websocket Mocks cp-13.3.1 #35552

Uh oh!

Conversation

seaona commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

metamaskbot commented Sep 1, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

seaona Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

seaona Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Sep 1, 2025

Choose a reason for hiding this comment

Bug: WebSocket Server Setup Skipped

Uh oh!

seaona Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 1, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 1, 2025

Uh oh!

DDDDDanica commented Sep 1, 2025

Uh oh!

davibroc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

seaona commented Sep 1, 2025 •

edited

Loading