Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 5, 2025

Description

Bump @metamask/message-manager dependency:

- **BREAKING:** `AbstractMessageManager` now expects a `Name extends string` generic parameter to define the name of the message manager ([#6469](https://github.com/MetaMask/core/pull/6469))
  - The type is used as namespace for `BaseController` and `Messenger` events and actions.
- Bump `@metamask/base-controller` from `^8.0.1` to `^8.3.0` ([#6284](https://github.com/MetaMask/core/pull/6284), [#6355](https://github.com/MetaMask/core/pull/6355), [#6465](https://github.com/MetaMask/core/pull/6465))
- Bump `@metamask/controller-utils` from `^11.11.0` to `^11.12.0` ([#6303](https://github.com/MetaMask/core/pull/6303))

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: To be created once major version is published

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Sep 5, 2025
@socket-security
Copy link

socket-security bot commented Sep 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​message-manager@​12.0.1 ⏵ 13.0.0100 +7100100 +26100 +7100

View full report

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: fa32a7d | Date: 9/5/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±23ms) 🟡 | historical mean value: 1.32s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 964ms (±19ms) 🟢 | historical mean value: 996ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 87ms (±15ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 23ms 1.26s 1.37s 1.35s 1.37s
domContentLoaded 964ms 19ms 942ms 1.05s 1.01s 1.05s
firstPaint 87ms 15ms 72ms 168ms 120ms 168ms
firstContentfulPaint 87ms 15ms 72ms 168ms 120ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [5c2d13d]
UI Startup Metrics (1219 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1219110513655512561302
load105695911815210921138
domContentLoaded104895311735210861133
domInteractive18135071739
firstPaint63187118642410541126
backgroundConnect2442282668249263
firstReactRender22175552331
getState13592101623
initialActions507110612
loadScripts81272491650848898
setupStore961821014
WebpackHomeuiStartup19461526245626921552415
load15581221188320017041849
domContentLoaded15491208187520016971834
domInteractive161160101439
firstPaint1615844760195268
backgroundConnect3618325423265
firstReactRender88373286979311
getState3253057213273
initialActions62183716
loadScripts15451206186319916941823
setupStore176282361331
FirefoxBrowserifyHomeuiStartup13911181180911614731621
load1209103714808912521372
domContentLoaded1209103514808912521372
domInteractive1073243462116236
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320110143661
firstReactRender27225752936
getState738211617
initialActions3038438
loadScripts1185101914548612321340
setupStore1059014842
WebpackHomeuiStartup15111328201015015981864
load12941131172612513871526
domContentLoaded12941130172512513861525
domInteractive98312955791269
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30208193644
firstReactRender41316554448
getState63697610
initialActions3114238
loadScripts12711104169712413661495
setupStore10513214921
Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 263 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 273 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 269 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 271ms | Sum of p95 exceeds: 523.8ms
Sum of all benchmark exceeds: 794.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 103 Bytes (0%)

@mikesposito mikesposito force-pushed the mikesposito/update-message-manager branch from 6ede84a to 5c2d13d Compare September 9, 2025 13:12
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 5c2d13d | Date: 9/9/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.35s (±97ms) 🟡 | historical mean value: 1.31s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 1.02s (±96ms) 🟢 | historical mean value: 987ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 96ms (±40ms) 🟢 | historical mean value: 95ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.35s 97ms 1.30s 2.02s 1.40s 2.02s
domContentLoaded 1.02s 96ms 981ms 1.68s 1.06s 1.68s
firstPaint 96ms 40ms 72ms 296ms 172ms 296ms
firstContentfulPaint 96ms 40ms 72ms 296ms 172ms 296ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [5c2d13d]
UI Startup Metrics (1269 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1269113214727113041417
load109896912766911331239
domContentLoaded108895912697211261232
domInteractive18156661827
firstPaint687164127943810981215
backgroundConnect25824033813262281
firstReactRender2617151152841
getState1465071629
initialActions50355515
loadScripts840708102073874995
setupStore962431015
WebpackHomeuiStartup19751494251626221522410
load16021213204321117571907
domContentLoaded15901207202620917501889
domInteractive171289131457
firstPaint1646044169189314
backgroundConnect3417344453154
firstReactRender80373315079250
getState3143007013279
initialActions62244613
loadScripts15861205201520817471877
setupStore156291281326
FirefoxBrowserifyHomeuiStartup13901186186411814411593
load1202103714097912621336
domContentLoaded1201103714087912621336
domInteractive1003332147107207
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3418183213767
firstReactRender27226052936
getState737210620
initialActions40697311
loadScripts1176101913797512381306
setupStore1047612833
WebpackHomeuiStartup15561362202416416561928
load13341146171214414521623
domContentLoaded13331146171114414521623
domInteractive104323145598258
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32194973745
firstReactRender42325144549
getState6322369
initialActions411131136
loadScripts13101128169314514301601
setupStore1058811917
Benchmark value 1269 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1098 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1089 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 258 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 840 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1417 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1240 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1232 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1216 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 281 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 995 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 258 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 395ms | Sum of p95 exceeds: 744.8ms
Sum of all benchmark exceeds: 1139.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.55 KiB (0.1%)
  • ui: 65.37 KiB (0.85%)
  • common: 3.32 KiB (0.04%)

@mikesposito mikesposito marked this pull request as ready for review September 23, 2025 15:17
@mikesposito mikesposito changed the title chore: bump @metamask/message-manager chore: bump @metamask/message-manager to 13.0.0 Sep 23, 2025
@mikesposito mikesposito changed the title chore: bump @metamask/message-manager to 13.0.0 chore: bump @metamask/message-manager to ^13.0.0 Sep 23, 2025
@Gudahtt
Copy link
Member

Gudahtt commented Sep 23, 2025

For the changelog entry, this should be null I think, since there are no user-facing changes

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 2f414a1 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 744ms (±73ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 75ms 1.02s 1.35s 1.30s 1.35s
domContentLoaded 744ms 73ms 705ms 1.03s 969ms 1.03s
firstPaint 77ms 12ms 60ms 176ms 88ms 176ms
firstContentfulPaint 77ms 12ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [2f414a1]
UI Startup Metrics (1214 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1214105714367712681347
load104993912697311021181
domContentLoaded104293012627310971175
domInteractive17134251735
firstPaint638143127941810411167
backgroundConnect2131992345215221
firstReactRender25184462739
getState1252851524
initialActions4119358
loadScripts836726105673893969
setupStore952331014
WebpackHomeuiStartup1165932137211012411322
load977769117310610551118
domContentLoaded972765116910710501115
domInteractive171260101445
firstPaint1496439755172241
backgroundConnect16103261830
firstReactRender37339793645
getState741931013
initialActions62184814
loadScripts969763116710610461113
setupStore86212912
FirefoxBrowserifyHomeuiStartup14381252204613215091705
load1244109415179313011419
domContentLoaded1244109315179313011419
domInteractive1083135050125211
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect322087123452
firstReactRender29234453139
getState9318621613
initialActions501821839
loadScripts1219107414869012811358
setupStore11420922828
WebpackHomeuiStartup15901392197414816991887
load13571183163112414761561
domContentLoaded13571183163012414761561
domInteractive1103430665108292
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31205373641
firstReactRender46369674858
getState63445710
initialActions411321336
loadScripts13341160160912514541542
setupStore12520421921
Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 222 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 970 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1438 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1244 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 300ms | Sum of p95 exceeds: 464.8ms
Sum of all benchmark exceeds: 764.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 126 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt enabled auto-merge September 24, 2025 12:10
@Gudahtt Gudahtt added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit 9134f6b Sep 24, 2025
153 of 156 checks passed
@Gudahtt Gudahtt deleted the mikesposito/update-message-manager branch September 24, 2025 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.5.0 Issue or pull request that will be included in release 13.5.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants