-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: bump @metamask/message-manager to ^13.0.0
#35701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5c2d13d]
UI Startup Metrics (1219 ± 55 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 263 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 273 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 269 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 271ms | Sum of p95 exceeds: 523.8ms Sum of all benchmark exceeds: 794.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
6ede84a to
5c2d13d
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5c2d13d]
UI Startup Metrics (1269 ± 71 ms)
Benchmark value 1098 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1089 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 258 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 840 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1417 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1240 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1232 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1216 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 281 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 995 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 258 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 395ms | Sum of p95 exceeds: 744.8ms Sum of all benchmark exceeds: 1139.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@metamask/message-manager@metamask/message-manager to 13.0.0
@metamask/message-manager to 13.0.0@metamask/message-manager to ^13.0.0
|
For the changelog entry, this should be |
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [2f414a1]
UI Startup Metrics (1214 ± 77 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 222 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 970 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1438 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1244 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 211 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 300ms | Sum of p95 exceeds: 464.8ms Sum of all benchmark exceeds: 764.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Bump
@metamask/message-managerdependency:Changelog
CHANGELOG entry: null
Related issues
Fixes: To be created once major version is published
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist