test: Add new test job for dist tests #35906
+33
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,14 +2,14 @@ import os from 'os'; | |
| import path from 'path'; | ||
| import fs from 'fs-extra'; | ||
| import level from 'level'; | ||
| import { Driver } from '../webdriver/driver'; | ||
| import { WALLET_PASSWORD, WINDOW_TITLES, withFixtures } from '../helpers'; | ||
| import HeaderNavbar from '../page-objects/pages/header-navbar'; | ||
| import HomePage from '../page-objects/pages/home/homepage'; | ||
| import PrivacySettings from '../page-objects/pages/settings/privacy-settings'; | ||
| import SettingsPage from '../page-objects/pages/settings/settings-page'; | ||
| import VaultDecryptorPage from '../page-objects/pages/vault-decryptor-page'; | ||
| import { completeCreateNewWalletOnboardingFlowWithCustomSettings } from '../page-objects/flows/onboarding.flow'; | ||
|
|
||
| const VAULT_DECRYPTOR_PAGE = 'https://metamask.github.io/vault-decryptor'; | ||
|
|
||
|
|
@@ -165,6 +165,10 @@ async function closePopoverIfPresent(driver: Driver) { | |
|
|
||
| describe('Vault Decryptor Page', function () { | ||
| it('is able to decrypt the vault uploading the log file in the vault-decryptor webapp', async function () { | ||
| if (process.env.SELENIUM_BROWSER !== 'chrome') { | ||
| // TODO: Get this working on Firefox | ||
| this.skip(); | ||
| } | ||
|
Comment on lines
+168
to
+171
There was a problem hiding this comment. We're going to skip ALL of the tests in the There was a problem hiding this comment. These changes were split from this PR, which has a test that would run on Firefox: #31435 I can certainly omit the Firefox workflow until that PR though, so it doesn't spin up a VM that does nothing. Good point. There was a problem hiding this comment. If it's coming very soon, it matters a little less. There was a problem hiding this comment. Removed here: 3e45984 I'll re-add it in the PR that adds the first test |
||
| await withFixtures( | ||
| { | ||
| disableServerMochaToBackground: true, | ||
|
|
@@ -223,6 +227,10 @@ describe('Vault Decryptor Page', function () { | |
| }); | ||
|
|
||
| it('is able to decrypt the vault pasting the text in the vault-decryptor webapp', async function () { | ||
| if (process.env.SELENIUM_BROWSER !== 'chrome') { | ||
| // TODO: Get this working on Firefox | ||
| this.skip(); | ||
| } | ||
| await withFixtures( | ||
| { | ||
| disableServerMochaToBackground: true, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this happens to be a little unfortunate, because you're adding the longest build process as a
needsbefore the longest test suite. So this definitely adds time to the workflow as a whole. Possible solutions include:test-e2e-firefox-browserifyandtest-e2e-firefox-flasktest-e2e-firefox-distout ofe2e-firefox.ymland rework how the YML files call each other and are organized, but I think that's not worth itEdit: hmmmm and then I noticed that
test-e2e-firefox-distis running zero tests....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Firefox substantially slower than Chrome to build and/or run tests? I had thought the difference was fairly small
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the build step, it's the
distbuild that's slower.build-dist-browserifyandbuild-dist-mv2-browserifytake the same amount of time. But thisneedsdid not have adistbuild in the list before.For the E2E tests, the
test-e2e-firefox-browserifyshards take 12-14 minutes, but thetest-e2e-firefox-browserifytake 9-11 minutes. I have not done any additional investigation as to why it's slower. If we can't make it faster, we could also increase the number of Firefox shards.