Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 22, 2025

Description

Bumping @metamask/smart-transactions-controller:

## [19.2.0]

### Added

- Add missing constants and helpers exports ([#538](https://github.com/MetaMask/smart-transactions-controller/pull/538))
  - `MetaMetricsEventCategory`
  - `MetaMetricsEventName`
  - `getSmartTransactionMetricsProperties`
  - `getSmartTransactionMetricsSensitiveProperties`

## [19.1.0]

### Added

- Add missing exports for types ([#537](https://github.com/MetaMask/smart-transactions-controller/pull/537))
  - `Fee`
  - `Fees`
  - `IndividualTxFees`
  - `FeatureFlags`
  - `SmartTransactionMinedTx`
  - `SmartTransaction`
  - `SmartTransactionCancellationReason`
  - `SmartTransactionStatuses`
  - `ClientId`

## [19.0.0]

### Added

- This package can now be used in ESM environments as well as CommonJS ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
- Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](https://github.com/MetaMask/smart-transactions-controller/pull/531))

### Changed

- **BREAKING:** Disallow subpath exports ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
- **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](https://github.com/MetaMask/smart-transactions-controller/pull/532), [#534](https://github.com/MetaMask/smart-transactions-controller/pull/534))
- **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](https://github.com/MetaMask/smart-transactions-controller/pull/534))
  - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist:
    - `TransactionController:getNonceLock`
    - `TransactionController:confirmExternalTransaction`
    - `TransactionController:getTransactions`
    - `TransactionController:updateTransaction`
- Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))
- Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))

### Removed

- **BREAKING:** Remove default export ([#535](https://github.com/MetaMask/smart-transactions-controller/pull/535))
  - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Checkout this branch
  2. Try submitting a smart transaction

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrades @metamask/smart-transactions-controller to v19.2.1, replaces deprecated default/subpath imports, and shifts TransactionController integration to messenger-based actions with updated allowlists and tests.

  • Smart Transactions Controller upgrade
    • Bump @metamask/smart-transactions-controller to ^19.2.1 and align with ESM/no-default export (remove subpath imports like dist/types).
  • Messenger-based integration
    • Add TransactionController actions to SmartTransactionsController messenger allowlist: getNonceLock, confirmExternalTransaction, getTransactions, updateTransaction in controller-init/messengers/smart-transactions-controller-messenger.ts.
    • Refactor SmartTransactionsControllerInit to stop passing getNonceLock, confirmExternalTransaction, getTransactions, updateTransaction via constructor; rely on messenger; update constructor typing to use restricted messenger directly.
    • Remove/adjust related unit tests that asserted constructor-wired functions; keep MetaMetrics wiring tests.
  • Import and type updates
    • Switch all imports to named exports from @metamask/smart-transactions-controller (e.g., SmartTransactionsController, SmartTransactionStatuses, SmartTransaction, ClientId, IndividualTxFees, etc.).
  • Policy updates
    • Update LavaMoat policies to reflect new polling-controller pathing and minor globals; adjust dependencies accordingly.

Written by Cursor Bugbot for commit 74fa4dd. This will update automatically on new commits. Configure here.

@mikesposito mikesposito requested review from a team as code owners September 22, 2025 13:29
@metamaskbot metamaskbot added the team-core-platform Core Platform team label Sep 22, 2025
@socket-security
Copy link

socket-security bot commented Sep 22, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​jridgewell/​trace-mapping@​0.3.31 ⏵ 0.3.30100 +1100100 +187 +4100
Updated@​metamask/​smart-transactions-controller@​18.1.0 ⏵ 19.2.198 +210092 +196 -150

View full report

@metamaskbot
Copy link
Collaborator

metamaskbot commented Sep 22, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +4 -2)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 confirmations/
          • 📄 transaction-controller-init.ts +4 -2

🧩 @MetaMask/extension-devs (5 files, +7 -114)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -22
      • 📁 experimental/
        • 📄 policy.json +1 -22
      • 📁 flask/
        • 📄 policy.json +1 -22
      • 📁 main/
        • 📄 policy.json +1 -22
    • 📁 webpack/
      • 📄 policy.json +3 -26

📜 @MetaMask/policy-reviewers (5 files, +7 -114)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -22
      • 📁 experimental/
        • 📄 policy.json +1 -22
      • 📁 flask/
        • 📄 policy.json +1 -22
      • 📁 main/
        • 📄 policy.json +1 -22
    • 📁 webpack/
      • 📄 policy.json +3 -26

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.


🔗 @MetaMask/supply-chain (5 files, +7 -114)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -22
      • 📁 experimental/
        • 📄 policy.json +1 -22
      • 📁 flask/
        • 📄 policy.json +1 -22
      • 📁 main/
        • 📄 policy.json +1 -22
    • 📁 webpack/
      • 📄 policy.json +3 -26

🔄 @MetaMask/swaps-engineers (1 files, +1 -1)
  • 📁 ui/
    • 📁 pages/
      • 📁 swaps/
        • 📄 swaps.util.ts +1 -1

💸 @MetaMask/transactions (4 files, +36 -118)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 smart-transactions/
          • 📄 smart-transactions-controller-init.test.ts +4 -77
          • 📄 smart-transactions-controller-init.ts +5 -23
      • 📁 lib/
        • 📁 smart-transaction/
          • 📄 smart-transactions.test.ts +21 -11
          • 📄 smart-transactions.ts +6 -7

languageName: node
linkType: hard

"@metamask/base-controller@npm:^7.0.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mikesposito mikesposito marked this pull request as draft September 22, 2025 16:25
@github-actions github-actions bot added size-M and removed size-S labels Sep 22, 2025
@@ -0,0 +1,77 @@
diff --git a/dist/index.cjs b/dist/index.cjs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 934471b | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±71ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 741ms (±69ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 71ms 1.02s 1.34s 1.27s 1.34s
domContentLoaded 741ms 69ms 708ms 1.02s 942ms 1.02s
firstPaint 77ms 11ms 60ms 176ms 88ms 176ms
firstContentfulPaint 77ms 11ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [934471b]
UI Startup Metrics (1187 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1187107713946712181341
load102392911966010521168
domContentLoaded101792211895910461158
domInteractive18134671740
firstPaint66487120341010381084
backgroundConnect2122012306215223
firstReactRender24174252535
getState1353661626
initialActions40193511
loadScripts81171198458836943
setupStore96253916
WebpackHomeuiStartup1179925137711012581324
load991761113910110701119
domContentLoaded986758113510210651115
domInteractive16125081439
firstPaint1576358068184264
backgroundConnect16103761530
firstReactRender36335133642
getState74213713
initialActions62194915
loadScripts983756113210110631112
setupStore96374914
FirefoxBrowserifyHomeuiStartup14021192180311314741595
load1215104714148312811335
domContentLoaded1214104714148312811335
domInteractive1023329750107224
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3020130133343
firstReactRender30236573243
getState63697610
initialActions4074839
loadScripts1191102913928212601313
setupStore12520723837
WebpackHomeuiStartup15951382217017916842060
load13581169191315214521646
domContentLoaded13581169191315214521646
domInteractive100323315597292
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect312092103650
firstReactRender46356654955
getState7214715615
initialActions5119620314
loadScripts13351150188815214331615
setupStore105869923
Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2060 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 245ms | Sum of p95 exceeds: 551.8ms
Sum of all benchmark exceeds: 796.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -72.89 KiB (-1.63%)
  • ui: 838 Bytes (0.01%)
  • common: 57.76 KiB (0.74%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 858b9be | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±68ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 1.00s 1.31s 1.24s 1.31s
domContentLoaded 729ms 68ms 695ms 994ms 931ms 994ms
firstPaint 76ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 76ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [858b9be]
UI Startup Metrics (1247 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1247111314768212941428
load107190213008411241249
domContentLoaded106189512928511171241
domInteractive19145681845
firstPaint65890131143310761150
backgroundConnect21820230914220238
firstReactRender2819135172944
getState1355681628
initialActions50285713
loadScripts8526841082859081034
setupStore1054251018
WebpackHomeuiStartup1167923142211212481322
load981758114910310541121
domContentLoaded976755114110310501114
domInteractive171266111447
firstPaint1616232956186281
backgroundConnect16113561631
firstReactRender36335543643
getState64223613
initialActions62194814
loadScripts973753113810310481111
setupStore86192914
FirefoxBrowserifyHomeuiStartup14541238178410915161677
load1255108713947913201370
domContentLoaded1255108713947913201369
domInteractive1093337561115264
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3421119163585
firstReactRender30245263245
getState9323825716
initialActions51648321
loadScripts1228105113707812951341
setupStore13517420945
WebpackHomeuiStartup15811377200414316851845
load13511163169713314531598
domContentLoaded13511163169713314531598
domInteractive1063233764103293
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31215173643
firstReactRender45345954855
getState721681669
initialActions4166836
loadScripts13281137167213414271576
setupStore10611011919
Benchmark value 1247 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 219 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 853 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1429 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1249 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1241 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 45 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1034 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1454 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1256 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1255 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 264 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 85 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 381ms | Sum of p95 exceeds: 805.8ms
Sum of all benchmark exceeds: 1186.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.75 KiB (-1.6%)
  • ui: 1.01 KiB (0.01%)
  • common: 58.02 KiB (0.74%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: b1cbbf0 | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±73ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±70ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±14ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 73ms 1.00s 1.33s 1.30s 1.33s
domContentLoaded 731ms 70ms 694ms 995ms 973ms 995ms
firstPaint 75ms 14ms 56ms 192ms 84ms 192ms
firstContentfulPaint 75ms 14ms 56ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [b1cbbf0]
UI Startup Metrics (1205 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1205107813766012491308
load103692911795310721128
domContentLoaded102992311735310661121
domInteractive18134881743
firstPaint609143113540710361102
backgroundConnect2152002355217224
firstReactRender26175172845
getState1454081930
initialActions50395614
loadScripts82172095952856914
setupStore952231017
WebpackHomeuiStartup1165929137910912411301
load979766115410310491125
domContentLoaded974763115110310451121
domInteractive15124471434
firstPaint1496236057176247
backgroundConnect16104161631
firstReactRender36335943642
getState74264717
initialActions62183813
loadScripts971761114810310431119
setupStore86182911
FirefoxBrowserifyHomeuiStartup14941276203712115511735
load1291110915398713491451
domContentLoaded1290110815398713491451
domInteractive1083440765116286
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect38212122636108
firstReactRender31244973345
getState9319121714
initialActions41487312
loadScripts1263108715168413101424
setupStore11610412929
WebpackHomeuiStartup16051405197514517061877
load13801201170213414851619
domContentLoaded13801201170113414851618
domInteractive1143534874106302
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30215573540
firstReactRender45376154955
getState63384611
initialActions3010136
loadScripts13581177168213514641595
setupStore96233918
Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1494 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1291 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1291 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1263 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1735 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 286 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 108 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 487ms | Sum of p95 exceeds: 597.8ms
Sum of all benchmark exceeds: 1084.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.75 KiB (-1.6%)
  • ui: 1.01 KiB (0.01%)
  • common: 58.02 KiB (0.74%)

@mikesposito mikesposito marked this pull request as ready for review September 22, 2025 18:29
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 9724c1b | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±76ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 740ms (±74ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 76ms 1.01s 1.36s 1.32s 1.36s
domContentLoaded 740ms 74ms 696ms 1.02s 1.00s 1.02s
firstPaint 77ms 12ms 60ms 172ms 92ms 172ms
firstContentfulPaint 77ms 12ms 60ms 172ms 92ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [9724c1b]
UI Startup Metrics (1229 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1229110514066312691340
load106196012275711021153
domContentLoaded105695812235710961147
domInteractive1914136131737
firstPaint63581117643910761152
backgroundConnect2522392879257272
firstReactRender25194452540
getState1153151323
initialActions40486411
loadScripts80971797055844902
setupStore95324916
WebpackHomeuiStartup803697108363819935
load61857892658624723
domContentLoaded61057291458617716
domInteractive15114771436
firstPaint21156917202193698
backgroundConnect21104462431
firstReactRender26165593047
getState833341014
initialActions2013235
loadScripts60857090356616705
setupStore84253911
FirefoxBrowserifyHomeuiStartup14641259181612115391720
load1251108715589213151398
domContentLoaded1251108615589213151398
domInteractive1053435258104246
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311884103452
firstReactRender31266153242
getState63566613
initialActions4111913211
loadScripts1228106815309012921378
setupStore84527724
WebpackHomeuiStartup15411360224514215831811
load1343120316169113901535
domContentLoaded1343120316159113901535
domInteractive98304396697295
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3518288293573
firstReactRender34257793657
getState9213619542
initialActions30234213
loadScripts1319117715868813661512
setupStore1139817755
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -72.54 KiB (-1.6%)
  • ui: -51 Bytes (0%)
  • common: 56.83 KiB (0.68%)

@Gudahtt
Copy link
Member

Gudahtt commented Oct 13, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: ec303f0 | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±69ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 71ms 1.01s 1.31s 1.27s 1.31s
domContentLoaded 731ms 69ms 694ms 1.00s 942ms 1.00s
firstPaint 75ms 11ms 56ms 156ms 88ms 156ms
firstContentfulPaint 75ms 11ms 56ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [ec303f0]
UI Startup Metrics (1226 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1226110913986112561352
load105696111985610861187
domContentLoaded105195511935510811181
domInteractive18136481737
firstPaint65873120243010681152
backgroundConnect2522402857257265
firstReactRender25206172542
getState1153761427
initialActions50376516
loadScripts80471295155835938
setupStore96324919
WebpackHomeuiStartup809693108365819979
load62257193165625832
domContentLoaded61556692264618825
domInteractive15114871436
firstPaint18854858191165596
backgroundConnect21114262531
firstReactRender27165993136
getState831431011
initialActions2011236
loadScripts61356491161616813
setupStore84182912
FirefoxBrowserifyHomeuiStartup14731280194912915301749
load1253110414518413061400
domContentLoaded1253110414518413061400
domInteractive1073530556108248
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3120105133553
firstReactRender31267053243
getState9326026624
initialActions10022934251
loadScripts1228108414238212831379
setupStore956010736
WebpackHomeuiStartup15461281215814216071813
load1350114316299814191566
domContentLoaded1350114316289814191566
domInteractive993135154112195
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3217124193581
firstReactRender352580133676
getState62446513
initialActions20173211
loadScripts1325112915589213961522
setupStore12420725746
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -72.37 KiB (-1.59%)
  • ui: -43 Bytes (0%)
  • common: 84.2 KiB (1.01%)

@Gudahtt
Copy link
Member

Gudahtt commented Oct 13, 2025

CI indicates that a yarn dedupe is needed

@Gudahtt
Copy link
Member

Gudahtt commented Oct 14, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 44e7fd0 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±66ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 69ms 1.00s 1.30s 1.25s 1.30s
domContentLoaded 728ms 66ms 694ms 992ms 927ms 992ms
firstPaint 75ms 13ms 60ms 188ms 88ms 188ms
firstContentfulPaint 75ms 13ms 60ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [44e7fd0]
UI Startup Metrics (1243 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1243114114735912791356
load106097811995010921154
domContentLoaded105393311955110861149
domInteractive17144141825
firstPaint64289116542410631126
backgroundConnect25524038615258272
firstReactRender2617108102739
getState14584131635
initialActions40325516
loadScripts80568594649835902
setupStore95313913
WebpackHomeuiStartup8117031087708201016
load62457293076625866
domContentLoaded61756692375617856
domInteractive15115081336
firstPaint19653883202191631
backgroundConnect2194462433
firstReactRender26165073033
getState831731013
initialActions208236
loadScripts61456591373616845
setupStore84112911
FirefoxBrowserifyHomeuiStartup14081210187814114611775
load1199104814299412761366
domContentLoaded1198104814299412761366
domInteractive993134955100244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3019146163349
firstReactRender29256142933
getState10319225553
initialActions4019019211
loadScripts1177103314089112541341
setupStore11414219751
WebpackHomeuiStartup15551357194712416321810
load1357121116079114251537
domContentLoaded1357121016079114251537
domInteractive953437446100184
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3218128133647
firstReactRender332681103559
getState7213116513
initialActions30285212
loadScripts1333119415799013971506
setupStore1147914746
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -72.54 KiB (-1.6%)
  • ui: -37 Bytes (0%)
  • common: 56.83 KiB (0.68%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 74fa4dd | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 977ms (±67ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 684ms (±65ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 977ms 67ms 939ms 1.23s 1.21s 1.23s
domContentLoaded 684ms 65ms 652ms 925ms 895ms 925ms
firstPaint 74ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 74ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [74fa4dd]
UI Startup Metrics (1132 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1132101113375911791219
load9608591136549951046
domContentLoaded9548511128539881039
domInteractive1913125131643
firstPaint6257810693849831040
backgroundConnect1971852267200212
firstReactRender2817125123140
getState1655581934
initialActions606610628
loadScripts76265592352792851
setupStore962531115
WebpackHomeuiStartup8417131147838561024
load64157696979645829
domContentLoaded63357095878633810
domInteractive16115481437
firstPaint18857867181192602
backgroundConnect22115582739
firstReactRender261692113236
getState841831113
initialActions3016236
loadScripts63056894876631808
setupStore951831114
FirefoxBrowserifyHomeuiStartup14951310208214415481816
load1241109715188812971377
domContentLoaded1241109715188812971377
domInteractive1033430153105229
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3523115143853
firstReactRender31274633237
getState136199251021
initialActions7213214426
loadScripts1218107714488512781354
setupStore186240341163
WebpackHomeuiStartup16191443219413116481910
load1377124416558614161576
domContentLoaded1377124316548614161576
domInteractive1033537759111199
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3822112164370
firstReactRender34278293544
getState113119141047
initialActions6119119413
loadScripts1352122415987913911536
setupStore146220241151
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -72.54 KiB (-1.6%)
  • ui: -46 Bytes (0%)
  • common: 56.83 KiB (0.68%)

@mikesposito mikesposito added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 7f423c4 Oct 16, 2025
170 checks passed
@mikesposito mikesposito deleted the mikesposito/deps/smart-transaction-controller branch October 16, 2025 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2025
@metamaskbot metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.6.0 Issue or pull request that will be included in release 13.6.0 size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.