-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: bump @metamask/smart-transactions-controller
#36167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @metamask/smart-transactions-controller
#36167
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +4 -2)
🧩 @MetaMask/extension-devs (5 files, +7 -114)
📜 @MetaMask/policy-reviewers (5 files, +7 -114)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +7 -114)
🔄 @MetaMask/swaps-engineers (1 files, +1 -1)
💸 @MetaMask/transactions (4 files, +36 -118)
|
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@metamask/base-controller@npm:^7.0.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
app/scripts/controller-init/smart-transactions/smart-transactions-controller-init.ts
Show resolved
Hide resolved
| @@ -0,0 +1,77 @@ | |||
| diff --git a/dist/index.cjs b/dist/index.cjs | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream PR: MetaMask/smart-transactions-controller#541
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [934471b]
UI Startup Metrics (1187 ± 67 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 2060 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 245ms | Sum of p95 exceeds: 551.8ms Sum of all benchmark exceeds: 796.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [858b9be]
UI Startup Metrics (1247 ± 82 ms)
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 219 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 853 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1429 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1249 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1241 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 45 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1034 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1454 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1256 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1255 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 264 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 85 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 381ms | Sum of p95 exceeds: 805.8ms Sum of all benchmark exceeds: 1186.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b1cbbf0]
UI Startup Metrics (1205 ± 60 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1494 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1291 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1291 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1263 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1735 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 286 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 108 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 487ms | Sum of p95 exceeds: 597.8ms Sum of all benchmark exceeds: 1084.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
app/scripts/controller-init/messengers/smart-transactions-controller-messenger.ts
Outdated
Show resolved
Hide resolved
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [9724c1b]
UI Startup Metrics (1229 ± 63 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ec303f0]
UI Startup Metrics (1226 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
CI indicates that a yarn dedupe is needed |
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [44e7fd0]
UI Startup Metrics (1243 ± 59 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [74fa4dd]
UI Startup Metrics (1132 ± 59 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Bumping
@metamask/smart-transactions-controller:Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Upgrades
@metamask/smart-transactions-controllerto v19.2.1, replaces deprecated default/subpath imports, and shifts TransactionController integration to messenger-based actions with updated allowlists and tests.@metamask/smart-transactions-controllerto^19.2.1and align with ESM/no-default export (remove subpath imports likedist/types).SmartTransactionsControllermessenger allowlist:getNonceLock,confirmExternalTransaction,getTransactions,updateTransactionincontroller-init/messengers/smart-transactions-controller-messenger.ts.SmartTransactionsControllerInitto stop passinggetNonceLock,confirmExternalTransaction,getTransactions,updateTransactionvia constructor; rely on messenger; update constructor typing to use restrictedmessengerdirectly.@metamask/smart-transactions-controller(e.g.,SmartTransactionsController,SmartTransactionStatuses,SmartTransaction,ClientId,IndividualTxFees, etc.).Written by Cursor Bugbot for commit 74fa4dd. This will update automatically on new commits. Configure here.