fix: existing EVM permissions removed when a Solana Wallet Standard connection is rejected #36283

ffmcgee725 · 2025-09-24T11:09:55Z

Description

When a dapp connects to MetaMask via EVM and the user rejects a subsequent connection request for SVM, the existing EVM connection is closed. This can potentially break dapp flows and edge cases where maintaining the EVM connection is critical.

To fix this, we implemented partial revoking into the wallet_revokeSession handler on MetaMask/core#6668 so that we can then update our solana wallet-standard provider would only revoke the solana scopes when it is asked to disconnect, here MetaMask/solana-wallet-standard#53.

This PR bumps all necessary packages for this to take place, fixing the undesired EVM permissions revoke when a solana wallet standard connection is refused.

Changelog

CHANGELOG entry: Fixes existing EVM permissions removed when a Solana Wallet Standard connection is rejected

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-413

Manual testing steps

Go to https://orca.so
On dev tools console, call window.ethereum.enable()
Proceed with permission (make sure NO PERMISSIONS for Solana are checked) and confirm
Click "Connect Wallet" button, choose "MetaMask" and proceed.
When wallet UI prompts to accept connection, click "Cancel" button.
Now, on dev tools console, call

await window.ethereum.request({
 "method": "wallet_getPermissions",
 "params": [],
});

Permission for eth_accounts should still be present with the permitted account in caveats array.

Screenshots/Recordings

Before

Screen.Recording.2025-09-18.at.6.18.40.PM.mov

After

Screen.Recording.2025-09-23.at.15.45.34.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

ffmcgee725 · 2025-09-24T11:15:42Z

@metamaskbot update-policies

socket-security · 2025-09-24T11:16:24Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@metamask/eth-json-rpc-provider@5.0.0
@metamask/chain-agnostic-permission@1.1.0 ⏵ 1.1.1
@metamask/multichain-api-middleware@1.0.0 ⏵ 1.1.0	⁺²	⁺²	⁺⁴
@metamask/network-controller@24.1.0 ⏵ 24.2.0	⁺¹	⁺¹	⁺⁵
@metamask/json-rpc-engine@10.0.3 ⏵ 10.1.0			⁺⁷
@metamask/solana-wallet-standard@0.5.1 ⏵ 0.6.0	⁺⁴	⁺¹	^-2
@metamask/multichain-api-client@0.6.5 ⏵ 0.7.0	⁺³	⁺¹	⁺⁵

View full report

metamaskbot · 2025-09-24T11:31:00Z

No policy changes

metamaskbot · 2025-09-24T11:41:07Z

📊 Page Load Benchmark Results

Current Commit: 6e6800b | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 726ms (±68ms) 🟢 | historical mean value: 744ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.00s	1.30s	1.29s	1.30s
domContentLoaded	726ms	68ms	694ms	984ms	943ms	984ms
firstPaint	74ms	12ms	56ms	176ms	84ms	176ms
firstContentfulPaint	74ms	12ms	56ms	176ms	84ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T11:41:17Z

Builds ready [6e6800b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 79 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1070	1431	79	1259	1400
			load	1045	909	1258	79	1070	1240
			domContentLoaded	1038	903	1248	79	1066	1230
			domInteractive	17	13	47	6	17	26
			firstPaint	603	96	1256	424	1049	1162
			backgroundConnect	214	204	244	7	217	227
			firstReactRender	25	17	82	8	26	40
			getState	12	5	29	6	17	25
			initialActions	5	1	44	5	5	11
			loadScripts	831	691	1041	79	858	1024
			setupStore	9	6	28	3	9	12
	Webpack	Home	uiStartup	1126	913	1319	99	1209	1250
			load	945	747	1127	93	1008	1067
			domContentLoaded	941	743	1123	93	1003	1059
			domInteractive	16	12	52	8	14	38
			firstPaint	145	64	283	50	174	241
			backgroundConnect	15	10	34	6	14	28
			firstReactRender	35	32	48	3	35	40
			getState	6	4	19	3	6	16
			initialActions	6	2	17	4	8	13
			loadScripts	938	741	1120	93	999	1054
			setupStore	8	6	21	3	8	12
Firefox	Browserify	Home	uiStartup	1535	1338	1912	107	1594	1737
			load	1329	1154	1532	86	1396	1463
			domContentLoaded	1328	1154	1532	86	1396	1463
			domInteractive	108	36	359	53	116	233
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	23	110	15	39	64
			firstReactRender	32	25	56	7	34	51
			getState	7	3	55	7	7	13
			initialActions	4	1	67	7	3	6
			loadScripts	1300	1128	1512	85	1371	1430
			setupStore	10	5	79	9	9	18
	Webpack	Home	uiStartup	1702	1401	2232	184	1817	2079
			load	1441	1184	1830	150	1551	1703
			domContentLoaded	1440	1184	1830	150	1551	1702
			domInteractive	120	34	363	67	115	299
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	21	77	8	40	46
			firstReactRender	49	37	66	6	52	63
			getState	9	4	172	18	7	20
			initialActions	5	1	86	11	4	11
			loadScripts	1416	1159	1801	152	1528	1680
			setupStore	12	6	93	10	11	28

Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 831 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1400 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1240 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1231 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1024 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1536 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1329 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1329 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1301 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1737 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 233 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1703 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1441 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1441 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 121 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1416 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2079 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1703 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1702 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1680 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 926ms | Sum of p95 exceeds: 1008.8ms
Sum of all benchmark exceeds: 1934.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 735 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

wenfix

LGTM

metamaskbot · 2025-09-24T14:27:33Z

📊 Page Load Benchmark Results

Current Commit: e4ab92d | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.09s (±74ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 765ms (±71ms) 🟢 | historical mean value: 743ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±12ms) 🟢 | historical mean value: 81ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.09s	74ms	1.05s	1.37s	1.32s	1.37s
domContentLoaded	765ms	71ms	723ms	1.03s	990ms	1.03s
firstPaint	81ms	12ms	64ms	184ms	88ms	184ms
firstContentfulPaint	81ms	12ms	64ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T14:27:42Z

Builds ready [e4ab92d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1081	1414	72	1255	1358
			load	1049	929	1225	68	1088	1181
			domContentLoaded	1042	926	1219	68	1083	1174
			domInteractive	18	14	52	7	16	39
			firstPaint	674	88	1216	428	1065	1154
			backgroundConnect	214	201	224	5	217	222
			firstReactRender	25	18	51	7	27	40
			getState	13	5	31	6	17	24
			initialActions	5	0	60	6	6	11
			loadScripts	835	719	1003	67	877	964
			setupStore	9	6	28	3	10	16
	Webpack	Home	uiStartup	1219	961	1469	117	1304	1366
			load	1024	791	1287	110	1098	1162
			domContentLoaded	1018	788	1282	111	1093	1157
			domInteractive	17	12	50	9	15	45
			firstPaint	153	65	276	50	186	239
			backgroundConnect	17	11	42	7	17	31
			firstReactRender	38	33	60	4	38	46
			getState	7	4	25	3	7	13
			initialActions	6	2	21	4	9	15
			loadScripts	1015	786	1280	111	1090	1154
			setupStore	9	6	26	3	9	13
Firefox	Browserify	Home	uiStartup	1387	1204	1795	112	1445	1632
			load	1197	1059	1413	77	1258	1337
			domContentLoaded	1197	1058	1413	77	1258	1337
			domInteractive	96	34	242	39	102	192
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	121	13	32	43
			firstReactRender	29	24	66	7	30	42
			getState	7	3	91	11	6	15
			initialActions	5	1	99	12	3	19
			loadScripts	1174	1041	1394	77	1240	1316
			setupStore	11	4	173	19	8	35
	Webpack	Home	uiStartup	1663	1427	2233	151	1754	1908
			load	1420	1209	1737	121	1501	1632
			domContentLoaded	1419	1209	1737	121	1500	1631
			domInteractive	111	45	324	58	110	310
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	21	54	6	36	41
			firstReactRender	48	36	71	6	51	61
			getState	6	3	48	5	6	10
			initialActions	5	1	181	18	3	9
			loadScripts	1397	1185	1711	121	1478	1603
			setupStore	12	6	165	18	10	29

Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 222 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 964 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1664 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1398 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 310 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 433ms | Sum of p95 exceeds: 443.8ms
Sum of all benchmark exceeds: 876.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 735 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-24T14:55:59Z

📊 Page Load Benchmark Results

Current Commit: 27b6c37 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±67ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	69ms	1.00s	1.32s	1.24s	1.32s
domContentLoaded	728ms	67ms	696ms	996ms	920ms	996ms
firstPaint	75ms	13ms	60ms	192ms	88ms	192ms
firstContentfulPaint	75ms	13ms	60ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T14:56:06Z

Builds ready [27b6c37]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1049	1327	60	1230	1321
			load	1027	917	1159	54	1058	1130
			domContentLoaded	1020	911	1152	54	1052	1122
			domInteractive	17	13	46	6	16	34
			firstPaint	651	114	1160	411	1046	1118
			backgroundConnect	211	200	241	6	214	219
			firstReactRender	25	18	47	6	27	39
			getState	14	5	86	11	16	30
			initialActions	6	0	66	7	7	13
			loadScripts	815	717	946	53	845	915
			setupStore	9	5	32	4	9	18
	Webpack	Home	uiStartup	1159	923	1456	115	1245	1300
			load	974	758	1282	109	1048	1101
			domContentLoaded	969	754	1277	109	1045	1097
			domInteractive	16	12	49	8	14	42
			firstPaint	151	62	329	58	191	247
			backgroundConnect	16	10	32	6	17	29
			firstReactRender	36	32	46	3	36	43
			getState	7	4	18	3	7	13
			initialActions	6	2	20	4	8	14
			loadScripts	966	752	1275	108	1042	1095
			setupStore	8	6	21	2	9	12
Firefox	Browserify	Home	uiStartup	1449	1225	1952	147	1506	1821
			load	1241	1064	1445	88	1318	1386
			domContentLoaded	1240	1064	1444	88	1318	1386
			domInteractive	106	34	350	57	119	245
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	20	174	26	35	89
			firstReactRender	29	24	55	6	31	42
			getState	7	3	52	7	6	15
			initialActions	8	1	266	28	4	25
			loadScripts	1215	1049	1369	82	1281	1359
			setupStore	15	5	204	30	9	39
	Webpack	Home	uiStartup	1620	1383	2223	154	1710	1903
			load	1381	1176	1748	132	1463	1640
			domContentLoaded	1381	1175	1747	132	1462	1639
			domInteractive	108	34	367	61	107	275
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	59	8	37	46
			firstReactRender	47	32	73	6	51	57
			getState	6	3	26	3	7	11
			initialActions	7	1	214	29	4	10
			loadScripts	1358	1159	1719	132	1439	1617
			setupStore	10	6	34	4	10	19

Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1450 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1821 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 89 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1621 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 48 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 326ms | Sum of p95 exceeds: 620.8ms
Sum of all benchmark exceeds: 946.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 735 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-24T16:57:10Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-09-24T17:08:13Z

📊 Page Load Benchmark Results

Current Commit: 23df428 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 741ms (±70ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	73ms	1.01s	1.35s	1.26s	1.35s
domContentLoaded	741ms	70ms	704ms	1.03s	938ms	1.03s
firstPaint	77ms	12ms	60ms	180ms	88ms	180ms
firstContentfulPaint	77ms	12ms	60ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T17:08:25Z

Builds ready [23df428]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1241 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1241	1118	1403	58	1273	1342
			load	1075	967	1190	55	1113	1174
			domContentLoaded	1066	956	1181	56	1108	1166
			domInteractive	18	13	52	8	17	38
			firstPaint	703	90	1195	426	1094	1167
			backgroundConnect	255	241	361	13	259	272
			firstReactRender	26	16	57	7	29	40
			getState	13	5	33	7	17	27
			initialActions	5	0	44	6	6	16
			loadScripts	819	692	933	55	861	909
			setupStore	9	6	21	3	10	18
	Webpack	Home	uiStartup	1152	914	1415	108	1225	1296
			load	969	752	1170	102	1040	1094
			domContentLoaded	964	749	1158	102	1035	1090
			domInteractive	16	12	55	9	14	40
			firstPaint	158	65	359	60	186	277
			backgroundConnect	15	9	32	5	17	28
			firstReactRender	36	33	60	4	36	45
			getState	7	4	21	3	7	15
			initialActions	6	2	21	4	8	15
			loadScripts	961	747	1148	102	1029	1088
			setupStore	8	6	16	2	8	12
Firefox	Browserify	Home	uiStartup	1449	1274	1865	113	1514	1641
			load	1248	1100	1431	81	1313	1372
			domContentLoaded	1248	1100	1430	81	1313	1371
			domInteractive	107	34	379	55	117	260
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	19	116	15	35	66
			firstReactRender	29	24	64	6	30	37
			getState	5	3	21	3	6	12
			initialActions	8	1	354	35	4	12
			loadScripts	1221	1081	1415	80	1283	1352
			setupStore	12	5	124	17	9	48
	Webpack	Home	uiStartup	1615	1364	2040	169	1752	1931
			load	1377	1152	1751	148	1500	1617
			domContentLoaded	1377	1150	1750	148	1500	1617
			domInteractive	107	33	343	57	106	285
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	22	88	9	37	43
			firstReactRender	47	37	71	6	49	58
			getState	6	2	20	3	7	13
			initialActions	5	1	165	16	4	10
			loadScripts	1354	1130	1729	149	1479	1593
			setupStore	11	6	40	6	11	28

Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 272 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1450 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1248 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1248 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 260 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 380ms | Sum of p95 exceeds: 518.8ms
Sum of all benchmark exceeds: 898.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 735 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

adonesky1

LGTM

ffmcgee725 added 2 commits September 24, 2025 12:58

feat: support partial wallet_revokeSession

e7e6a90

merge main fix conflicts

6e6800b

github-actions bot added the size-XS label Sep 24, 2025

ffmcgee725 added the team-wallet-integrations Wallet Integrations team label Sep 24, 2025

wenfix previously approved these changes Sep 24, 2025

View reviewed changes

Merge branch 'main' into jc/WAPI-728

e4ab92d

merge main fix conflicts

7a9f009

ffmcgee725 dismissed wenfix’s stale review via 7a9f009 September 24, 2025 14:27

dedupe

27b6c37

wenfix previously approved these changes Sep 24, 2025

View reviewed changes

ffmcgee725 added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Sep 24, 2025

merge main fix conflicts

1574d60

ffmcgee725 dismissed wenfix’s stale review via 1574d60 September 24, 2025 16:24

Merge branch 'main' into jc/WAPI-728

23df428

ffmcgee725 added team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead and removed team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead labels Sep 24, 2025

adonesky1 approved these changes Sep 24, 2025

View reviewed changes

adonesky1 enabled auto-merge September 24, 2025 17:58

wenfix approved these changes Sep 24, 2025

View reviewed changes

adonesky1 added this pull request to the merge queue Sep 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2025

ffmcgee725 added this pull request to the merge queue Sep 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2025

ffmcgee725 added this pull request to the merge queue Sep 24, 2025

Merged via the queue into main with commit 0e035f9 Sep 24, 2025
281 of 284 checks passed

ffmcgee725 deleted the jc/WAPI-728 branch September 24, 2025 19:42

github-actions bot locked and limited conversation to collaborators Sep 24, 2025

metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 24, 2025

fix: existing EVM permissions removed when a Solana Wallet Standard connection is rejected #36283

fix: existing EVM permissions removed when a Solana Wallet Standard connection is rejected #36283

Conversation

ffmcgee725 commented Sep 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

ffmcgee725 commented Sep 24, 2025

Uh oh!

socket-security bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

wenfix left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ffmcgee725 commented Sep 24, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Sep 24, 2025 •

edited

Loading