fix: dynamic parameters via sig_params #37086

itsyoboieltr · 2025-10-22T21:20:56Z

Description

Adds support for sig_params in deeplinks

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6017

Manual testing steps

sig_params should work according to the agreed spec

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduce sig_params support in deep link canonicalization, parsing, signing, and tests to allow selectively signed/forwarded query params.

Deep Links:
- Canonicalization: Enhance canonicalize to honor sig_params — keep only listed query params (preserving repeats), append sig_params, sort, and remove sig; fallback to previous behavior when sig_params is absent.
- Parsing: Use canonicalized URL, strip sig_params before invoking route handlers, and verify against the original URL.
- Constants: Add SIG_PARAMS_PARAM (sig_params).
Tests:
- Unit: Add cases for sig_params filtering, repetition preservation, non-mutation; adjust parse tests to pass empty params to handlers when only signature present.
- E2E: Expand scenarios for signed-with/without sig_params and unsigned; add assertions that only allowed params flow through; add getHashParams helper; update redirects to ignore query in expectations.
Helpers:
- Update signDeepLink to optionally append sig_params (derived from current params) and sign the full URL; add imports and sorting adjustments.

^{Written by Cursor Bugbot for commit f889979. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-22T21:21:11Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-22T21:48:17Z

📊 Page Load Benchmark Results

Current Commit: 1f7b1ef | Date: 10/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±68ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.01s	1.32s	1.26s	1.32s
domContentLoaded	731ms	68ms	698ms	996ms	945ms	996ms
firstPaint	76ms	13ms	60ms	188ms	88ms	188ms
firstContentfulPaint	76ms	13ms	60ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-22T21:48:23Z

Builds ready [1f7b1ef]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1194 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1194	997	1417	93	1251	1360
			load	1018	858	1244	86	1072	1167
			domContentLoaded	1011	854	1238	85	1062	1161
			domInteractive	19	14	55	9	18	45
			firstPaint	694	108	1251	404	1027	1164
			backgroundConnect	198	174	245	16	206	236
			firstReactRender	29	17	55	9	34	46
			getState	18	4	104	15	18	45
			initialActions	7	0	63	11	8	33
			loadScripts	820	679	1035	81	867	970
			setupStore	11	6	26	4	12	20
	Browserify	Power User Home	uiStartup	2189	1875	3117	440	2651	3117
			load	1090	927	1690	235	1336	1690
			domContentLoaded	1082	922	1681	231	1332	1681
			domInteractive	27	15	70	18	50	70
			firstPaint	690	123	1713	531	1050	1713
			backgroundConnect	245	221	312	21	257	312
			firstReactRender	22	19	27	2	23	27
			getState	189	171	225	14	202	225
			initialActions	9	2	58	14	6	58
			loadScripts	848	700	1424	218	1089	1424
			setupStore	15	8	33	8	22	33
	Webpack	Standard Home	uiStartup	837	727	1102	68	849	1000
			load	635	583	922	70	638	839
			domContentLoaded	627	577	915	70	629	832
			domInteractive	15	11	48	8	14	38
			firstPaint	187	54	918	198	180	817
			backgroundConnect	23	11	47	7	27	38
			firstReactRender	27	17	45	7	31	35
			getState	9	3	20	3	11	14
			initialActions	3	0	13	2	4	6
			loadScripts	624	574	902	68	627	821
			setupStore	9	5	18	2	11	13
	Webpack	Power User Home	uiStartup	1632	1220	2402	350	1999	2402
			load	723	614	1118	139	843	1118
			domContentLoaded	689	602	1065	121	786	1065
			domInteractive	20	12	46	11	26	46
			firstPaint	420	60	1121	340	810	1121
			backgroundConnect	110	19	315	104	215	315
			firstReactRender	21	19	22	1	22	22
			getState	194	149	367	59	179	367
			initialActions	7	1	39	11	9	39
			loadScripts	684	600	1050	117	775	1050
			setupStore	24	6	200	47	11	200
Firefox	Browserify	Standard Home	uiStartup	1423	1256	1942	120	1475	1712
			load	1212	1094	1498	77	1253	1351
			domContentLoaded	1211	1093	1498	77	1253	1351
			domInteractive	113	34	274	46	124	219
			firstPaint	-	-	-	-	-	-
			backgroundConnect	33	21	68	10	39	49
			firstReactRender	25	21	51	6	24	43
			getState	8	4	82	8	8	15
			initialActions	9	1	189	30	3	11
			loadScripts	1190	1075	1464	75	1231	1323
			setupStore	13	5	202	20	10	30
	Browserify	Power User Home	uiStartup	2569	2208	3268	256	2670	3268
			load	1392	1119	1813	198	1582	1813
			domContentLoaded	1392	1118	1813	198	1582	1813
			domInteractive	143	42	305	90	279	305
			firstPaint	-	-	-	-	-	-
			backgroundConnect	137	27	558	164	299	558
			firstReactRender	39	27	51	8	48	51
			getState	165	89	221	38	205	221
			initialActions	11	1	56	16	10	56
			loadScripts	1343	1098	1627	160	1544	1627
			setupStore	25	5	67	22	53	67
	Webpack	Standard Home	uiStartup	1634	1458	2318	142	1657	1988
			load	1402	1247	1743	95	1454	1592
			domContentLoaded	1401	1247	1743	95	1453	1592
			domInteractive	118	32	460	75	118	392
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	23	150	22	46	93
			firstReactRender	29	22	68	7	32	40
			getState	10	4	112	12	9	16
			initialActions	6	1	123	13	4	15
			loadScripts	1372	1226	1723	90	1421	1555
			setupStore	16	6	190	26	11	58
	Webpack	Power User Home	uiStartup	2592	2247	3036	223	2871	3036
			load	1548	1300	1842	167	1686	1842
			domContentLoaded	1547	1300	1842	167	1685	1842
			domInteractive	162	45	361	82	232	361
			firstPaint	-	-	-	-	-	-
			backgroundConnect	100	25	190	58	172	190
			firstReactRender	42	26	111	22	44	111
			getState	141	94	215	27	148	215
			initialActions	7	1	38	11	5	38
			loadScripts	1505	1261	1746	155	1657	1746
			setupStore	29	5	112	36	37	112

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 1.92 KiB (0.02%)

metamaskbot · 2025-10-22T22:46:15Z

📊 Page Load Benchmark Results

Current Commit: 73add40 | Date: 10/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 732ms (±68ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	72ms	1.00s	1.32s	1.30s	1.32s
domContentLoaded	732ms	68ms	693ms	1.00s	959ms	1.00s
firstPaint	76ms	12ms	60ms	176ms	88ms	176ms
firstContentfulPaint	76ms	12ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-22T22:46:32Z

Builds ready [73add40]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 82 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1247	1099	1513	82	1298	1374
			load	1070	934	1316	78	1117	1192
			domContentLoaded	1064	929	1309	77	1111	1185
			domInteractive	19	14	47	7	17	40
			firstPaint	586	77	1206	431	1074	1154
			backgroundConnect	230	218	256	8	234	248
			firstReactRender	27	19	65	8	28	41
			getState	16	5	94	11	18	34
			initialActions	6	0	43	7	6	18
			loadScripts	840	715	1091	77	887	961
			setupStore	10	6	32	4	10	18
	Browserify	Power User Home	uiStartup	2190	1830	3409	497	2465	3409
			load	1088	914	1622	248	1422	1622
			domContentLoaded	1080	907	1617	247	1408	1617
			domInteractive	30	14	78	25	65	78
			firstPaint	768	178	1529	427	983	1529
			backgroundConnect	248	222	315	25	262	315
			firstReactRender	22	20	24	1	23	24
			getState	205	177	268	26	213	268
			initialActions	13	2	147	35	6	147
			loadScripts	842	682	1325	227	1106	1325
			setupStore	12	8	27	5	14	27
	Webpack	Standard Home	uiStartup	846	722	1077	67	862	1017
			load	642	587	916	72	647	857
			domContentLoaded	634	581	908	72	642	850
			domInteractive	16	11	64	9	14	36
			firstPaint	191	58	913	175	198	608
			backgroundConnect	23	11	45	7	28	36
			firstReactRender	26	17	55	7	32	34
			getState	9	4	23	3	11	13
			initialActions	3	0	10	2	4	7
			loadScripts	631	578	897	69	639	837
			setupStore	10	5	16	3	12	14
	Webpack	Power User Home	uiStartup	1693	1238	2202	336	2049	2202
			load	740	617	1018	148	899	1018
			domContentLoaded	715	604	983	136	848	983
			domInteractive	24	14	51	13	39	51
			firstPaint	378	68	1008	332	614	1008
			backgroundConnect	132	12	362	135	323	362
			firstReactRender	23	20	41	5	22	41
			getState	173	41	279	45	181	279
			initialActions	13	1	113	27	17	113
			loadScripts	710	602	970	131	834	970
			setupStore	10	5	25	5	12	25
Firefox	Browserify	Standard Home	uiStartup	1487	1276	1964	111	1567	1646
			load	1262	1085	1447	81	1319	1398
			domContentLoaded	1262	1084	1447	81	1318	1398
			domInteractive	117	34	290	49	129	245
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	23	142	23	45	105
			firstReactRender	27	22	82	8	26	45
			getState	12	4	172	22	11	27
			initialActions	4	2	42	4	4	10
			loadScripts	1233	1067	1421	78	1293	1360
			setupStore	12	6	53	8	12	31
	Browserify	Power User Home	uiStartup	2663	2234	3318	345	2965	3318
			load	1468	1199	1907	234	1668	1907
			domContentLoaded	1468	1199	1907	234	1668	1907
			domInteractive	189	45	491	138	314	491
			firstPaint	-	-	-	-	-	-
			backgroundConnect	141	23	502	164	224	502
			firstReactRender	35	26	57	9	43	57
			getState	147	70	222	40	164	222
			initialActions	8	1	50	12	10	50
			loadScripts	1419	1180	1855	208	1596	1855
			setupStore	31	6	94	29	55	94
	Webpack	Standard Home	uiStartup	1610	1379	1977	124	1683	1904
			load	1382	1216	1722	102	1437	1575
			domContentLoaded	1382	1215	1721	102	1436	1574
			domInteractive	107	33	387	56	116	212
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	22	142	22	44	92
			firstReactRender	29	22	71	7	33	41
			getState	10	4	62	8	12	16
			initialActions	9	1	163	24	4	52
			loadScripts	1354	1198	1692	98	1408	1540
			setupStore	12	6	72	10	11	30
	Webpack	Power User Home	uiStartup	2575	2333	3012	215	2764	3012
			load	1543	1372	1963	169	1612	1963
			domContentLoaded	1543	1371	1962	169	1612	1962
			domInteractive	170	39	563	119	228	563
			firstPaint	-	-	-	-	-	-
			backgroundConnect	92	29	393	95	104	393
			firstReactRender	40	27	56	9	46	56
			getState	158	106	241	39	192	241
			initialActions	6	1	18	5	10	18
			loadScripts	1512	1339	1943	167	1572	1943
			setupStore	17	5	47	13	29	47

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 2.02 KiB (0.02%)

shared/lib/deep-links/parse.ts

shared/lib/deep-links/canonicalize.ts

metamaskbot · 2025-10-27T20:16:49Z

📊 Page Load Benchmark Results

Current Commit: 306e213 | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 727ms (±62ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±42ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.34s	1.08s	1.34s
domContentLoaded	727ms	62ms	698ms	1.29s	755ms	1.29s
firstPaint	80ms	42ms	60ms	500ms	84ms	500ms
firstContentfulPaint	80ms	42ms	60ms	500ms	84ms	500ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-27T20:17:05Z

Builds ready [306e213]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1257 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1257	1124	1486	67	1296	1364
			load	1075	963	1263	62	1112	1179
			domContentLoaded	1070	958	1257	61	1107	1175
			domInteractive	20	14	57	9	19	48
			firstPaint	577	80	1262	434	1091	1181
			backgroundConnect	233	220	250	6	237	245
			firstReactRender	28	18	48	7	32	43
			getState	22	8	103	14	24	41
			initialActions	5	1	36	6	6	16
			loadScripts	842	732	1038	61	882	945
			setupStore	10	6	27	3	11	16
	Browserify	Power User Home	uiStartup	2246	1823	3378	596	3121	3378
			load	1177	935	1881	323	1598	1881
			domContentLoaded	1166	929	1874	318	1592	1874
			domInteractive	30	15	74	23	66	74
			firstPaint	458	182	1169	328	934	1169
			backgroundConnect	254	224	369	37	260	369
			firstReactRender	25	23	29	2	27	29
			getState	179	155	275	33	195	275
			initialActions	7	2	23	6	6	23
			loadScripts	926	705	1517	292	1343	1517
			setupStore	11	8	23	3	11	23
	Webpack	Standard Home	uiStartup	892	744	1236	96	932	1140
			load	670	594	973	85	686	850
			domContentLoaded	662	588	964	83	680	838
			domInteractive	16	12	49	8	14	43
			firstPaint	201	57	937	221	168	836
			backgroundConnect	27	11	175	18	31	47
			firstReactRender	29	16	307	29	33	36
			getState	12	6	25	4	14	19
			initialActions	3	1	15	3	4	11
			loadScripts	658	586	952	81	678	827
			setupStore	10	5	18	3	12	15
	Webpack	Power User Home	uiStartup	1744	1474	2366	313	2192	2366
			load	728	625	1143	145	846	1143
			domContentLoaded	685	607	946	105	776	946
			domInteractive	22	12	58	13	36	58
			firstPaint	470	126	949	301	791	949
			backgroundConnect	141	23	424	146	362	424
			firstReactRender	26	22	33	3	26	33
			getState	155	136	187	14	161	187
			initialActions	12	1	58	16	14	58
			loadScripts	680	605	936	101	764	936
			setupStore	22	8	55	15	36	55
Firefox	Browserify	Standard Home	uiStartup	1476	1271	1838	105	1533	1672
			load	1257	1078	1468	82	1312	1407
			domContentLoaded	1257	1078	1468	82	1312	1406
			domInteractive	119	36	356	52	127	257
			firstPaint	-	-	-	-	-	-
			backgroundConnect	40	24	96	14	46	76
			firstReactRender	25	21	46	4	25	33
			getState	7	4	26	3	8	11
			initialActions	6	0	184	20	3	9
			loadScripts	1232	1061	1446	80	1284	1380
			setupStore	14	7	210	21	12	39
	Browserify	Power User Home	uiStartup	2663	2143	3769	418	2845	3769
			load	1399	1162	2038	191	1452	2038
			domContentLoaded	1398	1162	2038	191	1452	2038
			domInteractive	169	97	303	75	270	303
			firstPaint	-	-	-	-	-	-
			backgroundConnect	200	39	997	251	398	997
			firstReactRender	45	30	64	9	52	64
			getState	142	75	196	37	181	196
			initialActions	9	1	32	9	12	32
			loadScripts	1340	1134	1689	129	1407	1689
			setupStore	31	6	91	23	46	91
	Webpack	Standard Home	uiStartup	1620	1404	2355	129	1668	1868
			load	1389	1218	1906	104	1447	1582
			domContentLoaded	1389	1218	1906	104	1446	1581
			domInteractive	108	37	462	63	109	246
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	25	161	21	52	80
			firstReactRender	27	22	40	3	29	34
			getState	9	4	70	9	10	15
			initialActions	3	1	14	2	3	7
			loadScripts	1361	1200	1816	98	1413	1555
			setupStore	13	6	53	7	13	20
	Webpack	Power User Home	uiStartup	2788	2309	3549	382	3222	3549
			load	1612	1307	1971	195	1772	1971
			domContentLoaded	1612	1306	1970	195	1772	1970
			domInteractive	156	86	352	67	202	352
			firstPaint	-	-	-	-	-	-
			backgroundConnect	201	49	573	178	322	573
			firstReactRender	41	30	52	8	49	52
			getState	129	85	178	27	156	178
			initialActions	9	2	26	8	17	26
			loadScripts	1549	1281	1898	180	1695	1898
			setupStore	37	10	96	29	57	96

Bundle size diffs [🚀 Bundle size reduced!]

background: 5.61 KiB (0.12%)
ui: 528.62 KiB (8.08%)
common: -7.17 KiB (-0.08%)

metamaskbot · 2025-10-27T20:39:45Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-10-27T20:51:35Z

📊 Page Load Benchmark Results

Current Commit: 294355c | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 719ms (±36ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	719ms	36ms	699ms	990ms	749ms	990ms
firstPaint	77ms	11ms	64ms	172ms	84ms	172ms
firstContentfulPaint	77ms	11ms	64ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-29T22:20:41Z

📊 Page Load Benchmark Results

Current Commit: 5eeae0b | Date: 10/29/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±37ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	717ms	37ms	691ms	993ms	741ms	993ms
firstPaint	76ms	11ms	60ms	164ms	84ms	164ms
firstContentfulPaint	76ms	11ms	60ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-29T22:20:57Z

Builds ready [5eeae0b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1271 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1271	1125	1600	86	1326	1418
			load	1088	952	1419	84	1137	1245
			domContentLoaded	1081	947	1407	83	1129	1237
			domInteractive	20	14	64	9	19	43
			firstPaint	652	105	1416	443	1095	1217
			backgroundConnect	230	216	262	8	233	250
			firstReactRender	27	19	47	6	29	41
			getState	19	9	94	10	23	34
			initialActions	6	1	85	10	6	17
			loadScripts	858	735	1179	82	902	1015
			setupStore	9	6	19	2	10	13
			numNetworkReqs	8	6	26	5	6	24
	Browserify	Power User Home	uiStartup	2213	1794	3416	567	3006	3416
			load	1170	947	1821	293	1569	1821
			domContentLoaded	1162	939	1791	290	1562	1791
			domInteractive	41	15	210	47	54	210
			firstPaint	643	95	1826	528	1062	1826
			backgroundConnect	265	225	581	84	267	581
			firstReactRender	25	22	29	2	26	29
			getState	175	152	216	18	192	216
			initialActions	5	3	13	3	7	13
			loadScripts	919	712	1392	259	1316	1392
			setupStore	10	8	13	1	11	13
			numNetworkReqs	403	191	732	198	691	732
	Webpack	Standard Home	uiStartup	840	717	1090	71	860	1032
			load	631	580	904	67	638	838
			domContentLoaded	623	574	891	66	634	830
			domInteractive	15	11	60	8	14	40
			firstPaint	197	57	879	195	196	614
			backgroundConnect	21	11	51	7	24	35
			firstReactRender	27	17	109	11	32	34
			getState	12	6	29	4	14	20
			initialActions	3	0	17	3	4	8
			loadScripts	620	572	880	64	632	819
			setupStore	10	5	21	3	11	14
			numNetworkReqs	8	6	29	6	6	27
	Webpack	Power User Home	uiStartup	1697	1391	2212	296	2149	2212
			load	722	618	999	136	891	999
			domContentLoaded	689	604	919	111	791	919
			domInteractive	19	12	42	9	30	42
			firstPaint	495	74	950	295	681	950
			backgroundConnect	130	28	408	139	322	408
			firstReactRender	27	23	53	7	27	53
			getState	154	127	204	15	155	204
			initialActions	7	0	44	12	6	44
			loadScripts	684	602	909	107	780	909
			setupStore	15	6	54	13	24	54
			numNetworkReqs	320	191	565	133	514	565
Firefox	Browserify	Standard Home	uiStartup	1414	1231	1826	101	1461	1602
			load	1207	1055	1418	75	1260	1333
			domContentLoaded	1206	1055	1418	75	1260	1333
			domInteractive	114	34	326	49	121	214
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	24	109	15	46	71
			firstReactRender	25	21	49	5	25	42
			getState	9	4	136	17	7	17
			initialActions	3	1	38	4	3	4
			loadScripts	1181	1034	1399	72	1233	1303
			setupStore	12	7	30	4	12	22
			numNetworkReqs	8	6	30	5	7	21
	Browserify	Power User Home	uiStartup	2527	2166	3710	455	2632	3710
			load	1338	1172	1591	123	1495	1591
			domContentLoaded	1337	1172	1591	123	1495	1591
			domInteractive	145	81	296	68	205	296
			firstPaint	-	-	-	-	-	-
			backgroundConnect	193	31	708	190	334	708
			firstReactRender	34	25	47	7	43	47
			getState	119	72	179	27	141	179
			initialActions	9	1	60	14	10	60
			loadScripts	1282	1095	1535	118	1427	1535
			setupStore	32	8	91	23	52	91
			numNetworkReqs	257	142	520	107	296	520
	Webpack	Standard Home	uiStartup	1762	1554	2283	142	1818	2110
			load	1493	1286	1801	102	1563	1698
			domContentLoaded	1492	1286	1800	102	1562	1698
			domInteractive	121	37	418	77	119	352
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	26	132	21	58	95
			firstReactRender	32	23	89	13	33	80
			getState	9	5	43	5	11	15
			initialActions	7	1	141	18	4	30
			loadScripts	1460	1267	1766	99	1517	1673
			setupStore	19	6	210	24	15	58
			numNetworkReqs	8	6	29	6	7	24
	Webpack	Power User Home	uiStartup	2747	2323	3447	342	3022	3447
			load	1594	1313	2205	225	1763	2205
			domContentLoaded	1593	1313	2204	224	1763	2204
			domInteractive	155	61	242	66	231	242
			firstPaint	-	-	-	-	-	-
			backgroundConnect	201	36	621	186	287	621
			firstReactRender	44	29	76	12	52	76
			getState	155	72	294	61	195	294
			initialActions	7	2	15	4	10	15
			loadScripts	1529	1280	1950	189	1676	1950
			setupStore	27	8	58	14	36	58
			numNetworkReqs	268	148	507	116	329	507

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 60.76 KiB (1.33%)
ui: 6.82 KiB (0.1%)
common: -60.55 KiB (-0.69%)

metamaskbot · 2025-10-30T18:13:15Z

📊 Page Load Benchmark Results

Current Commit: 1c9ed70 | Date: 10/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±40ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 748ms (±37ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	40ms	1.04s	1.37s	1.11s	1.37s
domContentLoaded	748ms	37ms	723ms	1.02s	775ms	1.02s
firstPaint	81ms	11ms	68ms	176ms	92ms	176ms
firstContentfulPaint	81ms	11ms	68ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-30T18:13:30Z

Builds ready [1c9ed70]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1291 ± 85 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1291	1143	1490	85	1336	1456
			load	1104	967	1284	81	1158	1242
			domContentLoaded	1098	962	1278	80	1152	1238
			domInteractive	20	14	48	7	20	43
			firstPaint	715	75	1275	456	1137	1235
			backgroundConnect	232	219	254	7	237	245
			firstReactRender	29	18	58	9	35	49
			getState	21	9	48	7	23	38
			initialActions	6	1	67	8	7	19
			loadScripts	873	740	1053	79	920	1009
			setupStore	10	7	22	3	11	17
			numNetworkReqs	9	6	32	7	6	30
	Browserify	Power User Home	uiStartup	2247	1793	4035	617	2464	4035
			load	1194	917	1912	339	1702	1912
			domContentLoaded	1187	910	1893	337	1694	1893
			domInteractive	29	16	67	19	57	67
			firstPaint	457	161	1901	449	426	1901
			backgroundConnect	289	218	935	170	264	935
			firstReactRender	26	23	30	2	28	30
			getState	178	155	258	23	184	258
			initialActions	7	1	46	10	7	46
			loadScripts	937	699	1476	294	1344	1476
			setupStore	12	8	32	7	11	32
			numNetworkReqs	382	205	722	182	547	722
	Webpack	Standard Home	uiStartup	876	743	1149	80	891	1068
			load	648	601	936	65	658	823
			domContentLoaded	641	594	924	64	652	814
			domInteractive	15	11	50	7	15	39
			firstPaint	208	55	928	213	185	748
			backgroundConnect	24	11	58	9	29	39
			firstReactRender	30	17	239	23	33	41
			getState	13	6	45	5	15	23
			initialActions	3	0	16	3	4	8
			loadScripts	638	592	913	62	649	803
			setupStore	11	5	19	3	13	17
			numNetworkReqs	9	6	36	8	6	32
	Webpack	Power User Home	uiStartup	1749	1459	2473	324	2184	2473
			load	746	623	1059	149	875	1059
			domContentLoaded	697	607	870	95	843	870
			domInteractive	21	14	43	10	31	43
			firstPaint	425	72	880	320	857	880
			backgroundConnect	134	27	436	148	357	436
			firstReactRender	25	22	38	3	25	38
			getState	171	134	254	30	178	254
			initialActions	15	1	66	21	31	66
			loadScripts	692	605	859	91	831	859
			setupStore	26	6	107	29	34	107
			numNetworkReqs	375	191	736	146	521	736
Firefox	Browserify	Standard Home	uiStartup	1424	1246	1840	108	1476	1683
			load	1213	1078	1379	69	1255	1360
			domContentLoaded	1213	1078	1379	69	1255	1360
			domInteractive	104	37	330	43	119	213
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	24	119	20	47	95
			firstReactRender	24	20	40	4	24	35
			getState	9	3	194	20	8	25
			initialActions	3	1	13	2	4	8
			loadScripts	1185	1056	1353	68	1230	1311
			setupStore	13	7	221	21	11	19
			numNetworkReqs	9	6	33	7	7	30
	Browserify	Power User Home	uiStartup	3084	2113	5487	930	3213	5487
			load	1452	1278	1897	165	1511	1897
			domContentLoaded	1451	1276	1897	165	1511	1897
			domInteractive	246	107	879	182	299	879
			firstPaint	-	-	-	-	-	-
			backgroundConnect	518	48	2378	663	478	2378
			firstReactRender	45	25	90	16	58	90
			getState	150	32	244	55	191	244
			initialActions	20	2	130	31	19	130
			loadScripts	1378	1143	1745	157	1463	1745
			setupStore	38	15	87	21	51	87
			numNetworkReqs	259	155	414	71	319	414
	Webpack	Standard Home	uiStartup	1610	1451	1937	92	1670	1803
			load	1383	1218	1606	86	1441	1567
			domContentLoaded	1383	1217	1606	87	1441	1567
			domInteractive	106	40	262	42	116	231
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	27	135	18	53	76
			firstReactRender	35	22	86	17	33	75
			getState	9	5	72	9	8	16
			initialActions	4	1	54	5	4	10
			loadScripts	1354	1198	1580	85	1404	1540
			setupStore	12	7	40	5	13	18
			numNetworkReqs	9	6	29	6	7	25
	Webpack	Power User Home	uiStartup	2814	2272	3736	431	3191	3736
			load	1634	1331	2249	249	1876	2249
			domContentLoaded	1634	1331	2249	249	1876	2249
			domInteractive	148	80	424	93	175	424
			firstPaint	-	-	-	-	-	-
			backgroundConnect	213	57	812	232	352	812
			firstReactRender	39	29	60	10	52	60
			getState	126	67	222	36	137	222
			initialActions	9	1	52	12	10	52
			loadScripts	1581	1303	2134	230	1782	2134
			setupStore	22	6	67	15	33	67
			numNetworkReqs	284	139	577	122	346	577

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 462 Bytes (0.01%)

metamaskbot · 2025-10-30T20:01:50Z

📊 Page Load Benchmark Results

Current Commit: f889979 | Date: 10/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 718ms (±37ms) 🟢 | historical mean value: 732ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.01s	1.30s	1.07s	1.30s
domContentLoaded	718ms	37ms	697ms	977ms	746ms	977ms
firstPaint	76ms	11ms	60ms	164ms	84ms	164ms
firstContentfulPaint	76ms	11ms	60ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-30T20:01:58Z

Builds ready [f889979]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1253 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1253	1105	1481	86	1315	1431
			load	1070	941	1278	82	1126	1227
			domContentLoaded	1063	914	1264	82	1122	1220
			domInteractive	20	14	82	10	18	42
			firstPaint	591	87	1283	429	1059	1189
			backgroundConnect	230	216	320	14	232	248
			firstReactRender	28	17	93	10	32	46
			getState	23	10	113	15	25	46
			initialActions	5	1	28	5	6	16
			loadScripts	841	691	1037	82	906	1003
			setupStore	10	7	23	3	11	17
			numNetworkReqs	9	6	32	7	6	31
	Browserify	Power User Home	uiStartup	2262	1787	4128	693	3062	4128
			load	1167	927	2066	366	1660	2066
			domContentLoaded	1157	916	2038	360	1646	2038
			domInteractive	28	15	77	20	39	77
			firstPaint	857	171	2072	620	1660	2072
			backgroundConnect	272	217	804	139	266	804
			firstReactRender	27	24	35	3	28	35
			getState	176	150	214	16	186	214
			initialActions	10	2	71	16	13	71
			loadScripts	916	700	1561	314	1391	1561
			setupStore	11	9	25	4	12	25
			numNetworkReqs	365	188	681	189	661	681
	Webpack	Standard Home	uiStartup	850	737	1129	71	867	1007
			load	636	587	932	68	643	832
			domContentLoaded	628	579	920	67	638	823
			domInteractive	15	11	39	6	14	32
			firstPaint	191	60	926	202	185	728
			backgroundConnect	22	11	46	7	25	39
			firstReactRender	27	17	55	8	32	35
			getState	12	5	22	4	14	17
			initialActions	3	1	13	2	4	8
			loadScripts	625	576	909	64	636	808
			setupStore	10	5	23	3	12	14
			numNetworkReqs	9	6	33	8	8	32
	Webpack	Power User Home	uiStartup	1678	1432	2202	270	2086	2202
			load	719	618	1033	131	876	1033
			domContentLoaded	681	605	917	108	743	917
			domInteractive	18	13	45	9	19	45
			firstPaint	489	85	1024	322	750	1024
			backgroundConnect	127	25	468	141	150	468
			firstReactRender	25	23	29	2	25	29
			getState	150	112	167	12	158	167
			initialActions	9	1	51	13	15	51
			loadScripts	676	603	905	104	732	905
			setupStore	15	5	29	8	23	29
			numNetworkReqs	359	198	690	150	540	690
Firefox	Browserify	Standard Home	uiStartup	1440	1260	1825	94	1473	1635
			load	1229	1093	1477	60	1257	1339
			domContentLoaded	1228	1093	1476	60	1256	1338
			domInteractive	113	35	308	38	124	196
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	26	135	15	45	63
			firstReactRender	25	21	50	6	24	42
			getState	8	4	56	9	7	22
			initialActions	4	2	23	3	4	8
			loadScripts	1205	1077	1453	59	1231	1310
			setupStore	13	7	180	17	12	21
			numNetworkReqs	9	6	33	8	7	32
	Browserify	Power User Home	uiStartup	3111	2524	4266	516	3173	4266
			load	1596	1407	1933	151	1741	1933
			domContentLoaded	1596	1407	1932	151	1740	1932
			domInteractive	166	90	283	55	219	283
			firstPaint	-	-	-	-	-	-
			backgroundConnect	325	51	901	226	519	901
			firstReactRender	49	27	86	14	58	86
			getState	137	95	199	32	172	199
			initialActions	11	3	21	6	16	21
			loadScripts	1518	1367	1771	138	1647	1771
			setupStore	55	11	149	33	79	149
			numNetworkReqs	310	174	564	116	400	564
	Webpack	Standard Home	uiStartup	1659	1427	2302	142	1699	1965
			load	1410	1246	1872	95	1476	1556
			domContentLoaded	1410	1246	1871	95	1475	1556
			domInteractive	106	35	446	57	108	226
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	23	132	19	57	90
			firstReactRender	34	23	83	15	32	77
			getState	9	4	78	12	8	17
			initialActions	4	1	21	3	4	9
			loadScripts	1381	1227	1837	93	1446	1527
			setupStore	15	7	223	22	14	27
			numNetworkReqs	9	6	34	7	8	30
	Webpack	Power User Home	uiStartup	2935	2376	4814	690	3091	4814
			load	1628	1349	2063	229	1818	2063
			domContentLoaded	1628	1349	2063	229	1818	2063
			domInteractive	129	39	213	46	178	213
			firstPaint	-	-	-	-	-	-
			backgroundConnect	244	30	1104	336	159	1104
			firstReactRender	48	32	102	19	51	102
			getState	142	82	206	37	187	206
			initialActions	17	2	80	24	14	80
			loadScripts	1566	1322	1913	192	1785	1913
			setupStore	24	8	75	21	31	75
			numNetworkReqs	288	153	629	154	412	629

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 462 Bytes (0.01%)

itsyoboieltr added 2 commits October 23, 2025 00:58

feat: migrate changes from link signer app

a4c639e

feat: copied from kylan

1f7b1ef

metamaskbot added the team-extension-platform Extension Platform team label Oct 22, 2025

github-actions bot added the size-M label Oct 22, 2025

davidmurdoch changed the title ~~feat: dynamic parameters via sig_params~~ fix: dynamic parameters via sig_params Oct 22, 2025

itsyoboieltr self-assigned this Oct 22, 2025

itsyoboieltr added this to PR review queue Oct 22, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Oct 22, 2025

itsyoboieltr moved this from Needs dev review to Needs more work from the author in PR review queue Oct 22, 2025

itsyoboieltr added 4 commits October 23, 2025 01:54

Update canonicalize.ts

c6fef6a

Update canonicalize.ts

d91a409

fix: tests

b3afc1a

Update helpers.ts

8c16234

github-actions bot added size-S and removed size-M labels Oct 22, 2025

itsyoboieltr added 2 commits October 23, 2025 02:10

Update canonicalize.ts

a97d5f4

Update parse.ts

73add40

davidmurdoch reviewed Oct 27, 2025

View reviewed changes

shared/lib/deep-links/parse.ts Outdated Show resolved Hide resolved

davidmurdoch reviewed Oct 27, 2025

View reviewed changes

shared/lib/deep-links/canonicalize.ts Outdated Show resolved Hide resolved

Update canonicalize.ts

306e213

Update parse.ts

294355c

itsyoboieltr added 2 commits October 30, 2025 01:49

Update deep-link.spec.ts

82efa0f

Update deep-link.spec.ts

5eeae0b

itsyoboieltr requested a review from davidmurdoch October 29, 2025 22:09

itsyoboieltr moved this from Needs more work from the author to Review in progress in PR review queue Oct 29, 2025

davidmurdoch approved these changes Oct 30, 2025

View reviewed changes

david0xd self-requested a review October 30, 2025 14:59

david0xd approved these changes Oct 30, 2025

View reviewed changes

github-project-automation bot moved this from Review in progress to Review finalised - Ready to be merged in PR review queue Oct 30, 2025

itsyoboieltr added this pull request to the merge queue Oct 30, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025

itsyoboieltr added this pull request to the merge queue Oct 30, 2025

itsyoboieltr removed this pull request from the merge queue due to a manual request Oct 30, 2025

itsyoboieltr added this pull request to the merge queue Oct 30, 2025

itsyoboieltr removed this pull request from the merge queue due to a manual request Oct 30, 2025

Merge branch 'main' into feat/dynamic-parameters

1c9ed70

itsyoboieltr enabled auto-merge October 30, 2025 17:49

Merge branch 'main' into feat/dynamic-parameters

f889979

itsyoboieltr added this pull request to the merge queue Oct 30, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025

davidmurdoch merged commit 6a349a3 into main Oct 30, 2025
329 of 331 checks passed

davidmurdoch deleted the feat/dynamic-parameters branch October 30, 2025 22:11

github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Oct 30, 2025

github-actions bot locked and limited conversation to collaborators Oct 30, 2025

metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Oct 30, 2025

fix: dynamic parameters via sig_params #37086

fix: dynamic parameters via sig_params #37086

Conversation

itsyoboieltr commented Oct 22, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

metamaskbot commented Oct 22, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 22, 2025

Uh oh!

metamaskbot commented Oct 22, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 27, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 27, 2025

Uh oh!

metamaskbot commented Oct 27, 2025

Uh oh!

metamaskbot commented Oct 27, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 29, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 30, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 30, 2025

Uh oh!

metamaskbot commented Oct 30, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

itsyoboieltr commented Oct 22, 2025 •

edited by cursor bot

Loading