fix(perf): nonfunctional memoization in `getInternalAccounts` selector #37147

MajorLift · 2025-10-23T19:19:55Z

Description

// ❌ BROKEN: this will not memoize correctly, and does nothing useful!
const brokenSelector = createSelector(
  state => state.todos,
  todos => todos
)
Any "output selector" that just returns its inputs is incorrect! The output selector should always have the transformation logic.

Similarly, a memoized selector should never use state => state as an input! That will force the selector to always recalculate.

-- https://redux.js.org/usage/deriving-data-selectors#createselector-overview

See: fix: add connection status back #36423 (comment)
Also fixes incorrect logic due to code drift in JavaScript selector file.

Changelog

CHANGELOG entry:

Related issues

Closes https://github.com/MetaMask/MetaMask-planning/issues/6343

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-10-23T19:20:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-23T19:22:27Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (3 files, +5 -18)

📁 ui/
- 📁 hooks/
  - 📁 snaps/
    - 📄 useDisplayName.ts +2 -2
- 📁 pages/
  - 📁 snaps/
    - 📁 snap-view/
      - 📄 snap-settings.js +2 -2
- 📁 selectors/
  - 📁 snaps/
    - 📄 accounts.ts +1 -14

metamaskbot · 2025-10-23T19:47:41Z

📊 Page Load Benchmark Results

Current Commit: 109550a | Date: 10/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±76ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 743ms (±72ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±16ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	76ms	1.02s	1.42s	1.30s	1.42s
domContentLoaded	743ms	72ms	704ms	1.06s	959ms	1.06s
firstPaint	79ms	16ms	60ms	232ms	84ms	232ms
firstContentfulPaint	79ms	16ms	60ms	232ms	84ms	232ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-23T19:47:58Z

Builds ready [109550a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1238	1102	1433	73	1294	1370
			load	1064	945	1265	72	1116	1178
			domContentLoaded	1058	942	1259	72	1109	1172
			domInteractive	19	13	96	10	17	39
			firstPaint	645	89	1194	435	1085	1168
			backgroundConnect	228	217	267	8	231	244
			firstReactRender	26	17	47	6	27	39
			getState	19	7	80	10	22	34
			initialActions	6	0	68	9	6	12
			loadScripts	836	722	1035	71	888	946
			setupStore	10	6	31	3	10	15
	Browserify	Power User Home	uiStartup	2223	1859	3562	517	2497	3562
			load	1168	927	2021	353	1627	2021
			domContentLoaded	1158	921	2006	351	1623	2006
			domInteractive	34	14	124	32	53	124
			firstPaint	775	188	2014	535	979	2014
			backgroundConnect	257	224	473	57	252	473
			firstReactRender	22	19	26	2	22	26
			getState	203	158	244	22	217	244
			initialActions	7	2	36	8	5	36
			loadScripts	912	703	1542	310	1377	1542
			setupStore	11	7	26	4	11	26
	Webpack	Standard Home	uiStartup	901	763	1184	73	913	1082
			load	671	614	986	71	678	867
			domContentLoaded	663	607	974	69	670	859
			domInteractive	17	12	70	9	15	41
			firstPaint	191	58	978	198	175	769
			backgroundConnect	26	14	65	9	30	45
			firstReactRender	29	17	49	8	35	38
			getState	13	6	22	4	15	20
			initialActions	4	1	15	2	5	8
			loadScripts	659	605	960	67	667	846
			setupStore	11	5	20	3	13	16
	Webpack	Power User Home	uiStartup	1858	1424	2661	403	2476	2661
			load	800	631	1395	226	1029	1395
			domContentLoaded	752	617	1256	174	912	1256
			domInteractive	26	13	96	21	42	96
			firstPaint	533	71	1260	382	949	1260
			backgroundConnect	128	21	453	150	328	453
			firstReactRender	22	20	24	1	23	24
			getState	189	121	234	23	202	234
			initialActions	9	1	81	19	5	81
			loadScripts	747	615	1243	170	900	1243
			setupStore	18	7	47	12	25	47
Firefox	Browserify	Standard Home	uiStartup	1562	1331	2014	129	1619	1810
			load	1328	1152	1633	89	1385	1482
			domContentLoaded	1327	1152	1633	89	1385	1482
			domInteractive	123	37	338	53	140	247
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	24	151	19	50	90
			firstReactRender	27	22	67	7	27	39
			getState	9	4	176	17	9	16
			initialActions	4	1	16	2	4	9
			loadScripts	1300	1134	1598	85	1355	1439
			setupStore	15	7	211	21	13	28
	Browserify	Power User Home	uiStartup	2742	2329	3990	416	2858	3990
			load	1432	1186	1995	183	1501	1995
			domContentLoaded	1432	1185	1995	183	1500	1995
			domInteractive	150	40	393	91	236	393
			firstPaint	-	-	-	-	-	-
			backgroundConnect	230	46	912	230	411	912
			firstReactRender	35	26	64	10	42	64
			getState	166	75	343	56	191	343
			initialActions	6	1	20	5	8	20
			loadScripts	1357	1135	1659	133	1439	1659
			setupStore	41	7	133	38	76	133
	Webpack	Standard Home	uiStartup	1597	1426	2210	118	1636	1855
			load	1369	1213	1585	79	1421	1518
			domContentLoaded	1368	1212	1585	79	1420	1518
			domInteractive	104	31	375	46	112	189
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	24	146	22	48	105
			firstReactRender	28	21	77	10	27	59
			getState	12	3	162	24	10	56
			initialActions	4	1	53	7	3	17
			loadScripts	1339	1193	1516	72	1392	1476
			setupStore	17	7	187	21	13	56
	Webpack	Power User Home	uiStartup	2907	2398	3923	418	3053	3923
			load	1627	1332	2179	222	1785	2179
			domContentLoaded	1626	1332	2178	222	1784	2178
			domInteractive	151	36	384	100	210	384
			firstPaint	-	-	-	-	-	-
			backgroundConnect	235	39	977	263	303	977
			firstReactRender	37	28	47	7	45	47
			getState	148	86	220	36	158	220
			initialActions	7	1	30	7	12	30
			loadScripts	1571	1289	2008	200	1738	2008
			setupStore	32	8	104	31	45	104

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.24 KiB (0.05%)
ui: 1.43 KiB (0.02%)
common: -425 Bytes (0%)

metamaskbot · 2025-10-23T20:30:58Z

📊 Page Load Benchmark Results

Current Commit: 2578a44 | Date: 10/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±71ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	73ms	1.01s	1.32s	1.30s	1.32s
domContentLoaded	735ms	71ms	697ms	1.00s	969ms	1.00s
firstPaint	76ms	13ms	56ms	188ms	84ms	188ms
firstContentfulPaint	76ms	13ms	56ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-23T20:31:03Z

Builds ready [2578a44]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1269 ± 85 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1269	1091	1514	85	1326	1412
			load	1089	955	1295	81	1149	1232
			domContentLoaded	1081	927	1289	82	1141	1224
			domInteractive	20	14	74	10	18	47
			firstPaint	686	77	1286	453	1128	1225
			backgroundConnect	235	220	368	17	236	257
			firstReactRender	28	17	102	11	32	46
			getState	20	7	86	10	22	37
			initialActions	5	1	35	5	7	19
			loadScripts	854	697	1062	82	914	997
			setupStore	10	6	21	3	10	16
	Browserify	Power User Home	uiStartup	2332	1929	3996	606	2805	3996
			load	1204	955	2011	344	1649	2011
			domContentLoaded	1195	948	2002	341	1638	2002
			domInteractive	43	16	215	50	58	215
			firstPaint	729	174	1756	515	1008	1756
			backgroundConnect	270	224	583	88	263	583
			firstReactRender	25	20	45	6	25	45
			getState	207	181	265	22	223	265
			initialActions	18	3	106	27	29	106
			loadScripts	952	720	1627	311	1386	1627
			setupStore	14	7	35	8	14	35
	Webpack	Standard Home	uiStartup	861	736	1146	72	886	1000
			load	643	595	929	63	649	787
			domContentLoaded	635	587	920	63	641	781
			domInteractive	16	11	60	8	15	37
			firstPaint	178	57	887	168	193	619
			backgroundConnect	23	11	44	6	27	36
			firstReactRender	28	16	66	9	33	42
			getState	12	5	24	4	15	17
			initialActions	3	0	14	3	5	7
			loadScripts	632	584	907	61	638	770
			setupStore	10	5	25	4	12	17
	Webpack	Power User Home	uiStartup	1743	1336	2512	351	2221	2512
			load	699	614	941	109	840	941
			domContentLoaded	673	597	846	91	799	846
			domInteractive	20	13	52	11	23	52
			firstPaint	454	74	858	311	812	858
			backgroundConnect	108	22	348	114	266	348
			firstReactRender	22	19	30	2	22	30
			getState	175	139	203	15	179	203
			initialActions	7	0	30	10	13	30
			loadScripts	668	595	833	86	787	833
			setupStore	22	6	70	21	26	70
Firefox	Browserify	Standard Home	uiStartup	1604	1413	2062	126	1650	1946
			load	1343	1171	1519	71	1396	1476
			domContentLoaded	1343	1170	1519	71	1396	1476
			domInteractive	119	36	350	44	127	202
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	27	141	20	56	89
			firstReactRender	28	23	52	6	28	42
			getState	11	5	198	23	10	17
			initialActions	6	2	201	20	4	14
			loadScripts	1312	1149	1481	68	1351	1446
			setupStore	19	7	193	24	15	81
	Browserify	Power User Home	uiStartup	2787	2358	3709	352	3029	3709
			load	1445	1195	1749	161	1609	1749
			domContentLoaded	1445	1194	1749	162	1609	1749
			domInteractive	145	52	273	75	225	273
			firstPaint	-	-	-	-	-	-
			backgroundConnect	186	36	534	182	449	534
			firstReactRender	36	28	50	7	45	50
			getState	169	94	413	70	189	413
			initialActions	11	1	71	19	10	71
			loadScripts	1403	1170	1668	150	1553	1668
			setupStore	30	5	118	28	46	118
	Webpack	Standard Home	uiStartup	1692	1464	2534	151	1762	1970
			load	1451	1256	1808	108	1535	1645
			domContentLoaded	1450	1256	1808	108	1534	1645
			domInteractive	123	35	479	79	126	364
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	26	123	17	52	81
			firstReactRender	30	22	85	10	30	41
			getState	11	4	221	22	10	17
			initialActions	7	1	210	22	4	19
			loadScripts	1422	1229	1774	106	1496	1619
			setupStore	14	6	55	7	14	26
	Webpack	Power User Home	uiStartup	3000	2398	4333	583	3619	4333
			load	1678	1391	2110	254	2017	2110
			domContentLoaded	1678	1390	2110	254	2016	2110
			domInteractive	124	51	224	51	171	224
			firstPaint	-	-	-	-	-	-
			backgroundConnect	255	35	903	306	710	903
			firstReactRender	35	27	47	6	39	47
			getState	162	66	240	48	216	240
			initialActions	8	2	26	7	13	26
			loadScripts	1599	1365	1944	189	1727	1944
			setupStore	44	7	249	57	64	249

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.24 KiB (0.05%)
ui: 1.42 KiB (0.02%)
common: -576 Bytes (-0.01%)

See: https://redux.js.org/usage/deriving-data-selectors#createselector-overview

…instead of array)

… identity-function output selectors

… nested state updates

metamaskbot · 2025-11-14T20:51:40Z

Builds ready [836d106]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1267 ± 104 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1267	1097	1666	104	1346	1423
			load	1100	947	1362	98	1178	1252
			domContentLoaded	1093	928	1345	98	1171	1248
			domInteractive	23	15	89	17	19	75
			firstPaint	620	87	1322	444	1114	1211
			backgroundConnect	239	223	335	12	242	254
			firstReactRender	30	20	85	9	32	50
			getState	21	7	69	10	24	35
			initialActions	1	0	8	1	1	2
			loadScripts	861	690	1088	98	945	1014
			setupStore	11	6	23	3	12	17
			numNetworkReqs	13	6	75	19	6	71
	Browserify	Power User Home	uiStartup	2252	1710	3124	301	2418	3124
			load	1180	991	1859	240	1395	1859
			domContentLoaded	1160	975	1845	243	1388	1845
			domInteractive	60	17	209	62	123	209
			firstPaint	668	212	1881	509	1048	1881
			backgroundConnect	253	232	298	18	262	298
			firstReactRender	74	51	125	19	83	125
			getState	257	162	359	57	314	359
			initialActions	1	0	2	1	2	2
			loadScripts	930	752	1576	234	1156	1576
			setupStore	28	7	40	8	34	40
			numNetworkReqs	125	100	191	28	150	191
	Webpack	Standard Home	uiStartup	836	710	1189	95	835	1071
			load	609	560	958	72	607	824
			domContentLoaded	601	555	927	68	602	795
			domInteractive	18	11	70	13	15	54
			firstPaint	192	60	887	173	198	583
			backgroundConnect	25	10	76	15	31	62
			firstReactRender	37	19	317	38	36	62
			getState	11	5	44	4	12	16
			initialActions	1	0	3	1	1	1
			loadScripts	598	553	916	65	599	782
			setupStore	12	5	34	6	13	31
			numNetworkReqs	13	6	75	19	8	71
	Webpack	Power User Home	uiStartup	1118	928	1612	236	1425	1612
			load	671	575	1017	141	789	1017
			domContentLoaded	652	565	978	130	752	978
			domInteractive	32	13	89	31	81	89
			firstPaint	353	66	982	289	575	982
			backgroundConnect	58	16	167	59	146	167
			firstReactRender	41	36	53	4	43	53
			getState	144	93	191	28	164	191
			initialActions	1	0	1	0	1	1
			loadScripts	648	563	968	127	742	968
			setupStore	13	6	26	8	25	26
			numNetworkReqs	84	63	138	28	129	138
Firefox	Browserify	Standard Home	uiStartup	1481	1312	1982	134	1528	1774
			load	1249	1131	1600	97	1290	1478
			domContentLoaded	1249	1131	1600	97	1290	1478
			domInteractive	55	33	206	38	54	165
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	24	166	21	48	88
			firstReactRender	27	23	47	5	28	41
			getState	12	7	100	10	11	20
			initialActions	2	0	8	1	2	2
			loadScripts	1225	1113	1564	91	1263	1437
			setupStore	13	7	66	10	13	31
			numNetworkReqs	12	6	73	16	7	56
	Browserify	Power User Home	uiStartup	3259	2606	4610	606	3911	4610
			load	1513	1264	1826	196	1769	1826
			domContentLoaded	1512	1263	1826	196	1769	1826
			domInteractive	276	94	577	184	547	577
			firstPaint	-	-	-	-	-	-
			backgroundConnect	563	108	1274	425	1034	1274
			firstReactRender	89	65	118	14	103	118
			getState	180	108	532	100	187	532
			initialActions	2	1	3	1	2	3
			loadScripts	1472	1228	1771	192	1742	1771
			setupStore	118	14	530	138	122	530
			numNetworkReqs	127	80	230	57	222	230
	Webpack	Standard Home	uiStartup	1644	1480	2438	203	1632	2257
			load	1374	1229	1698	104	1396	1670
			domContentLoaded	1373	1228	1698	104	1396	1669
			domInteractive	55	31	204	28	63	120
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	22	406	53	53	149
			firstReactRender	33	25	83	9	35	43
			getState	17	8	208	31	11	49
			initialActions	2	1	7	1	2	3
			loadScripts	1341	1185	1625	89	1374	1570
			setupStore	23	7	253	45	12	107
			numNetworkReqs	13	6	69	18	7	65
	Webpack	Power User Home	uiStartup	3315	2665	4172	457	3741	4172
			load	1670	1457	2054	192	1882	2054
			domContentLoaded	1670	1457	2053	191	1881	2053
			domInteractive	221	78	538	165	454	538
			firstPaint	-	-	-	-	-	-
			backgroundConnect	438	115	947	241	670	947
			firstReactRender	90	52	143	23	107	143
			getState	180	117	478	84	219	478
			initialActions	5	1	35	8	3	35
			loadScripts	1628	1411	1986	193	1853	1986
			setupStore	91	38	158	38	127	158
			numNetworkReqs	126	77	231	57	215	231

📊 Page Load Benchmark Results

Current Commit: 836d106 | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 724ms (±36ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.02s	1.33s	1.09s	1.33s
domContentLoaded	724ms	36ms	706ms	988ms	763ms	988ms
firstPaint	77ms	12ms	60ms	176ms	92ms	176ms
firstContentfulPaint	77ms	12ms	60ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -134 Bytes (0%)
common: -105 Bytes (0%)

metamaskbot · 2025-11-25T14:47:43Z

Builds ready [4bbda9a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1377 ± 132 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1377	1099	1778	132	1456	1621
			load	1102	907	1346	108	1168	1303
			domContentLoaded	1096	901	1339	107	1154	1297
			domInteractive	30	15	142	28	23	109
			firstPaint	480	103	1350	405	969	1278
			backgroundConnect	226	198	278	14	231	256
			firstReactRender	37	23	72	9	42	54
			getState	63	20	167	25	73	125
			initialActions	1	0	6	1	1	4
			loadScripts	877	698	1090	103	943	1060
			setupStore	15	7	46	7	17	30
			numNetworkReqs	41	28	145	33	30	142
	Browserify	Power User Home	uiStartup	2294	1884	3597	297	2424	2853
			load	1046	911	2073	172	1043	1434
			domContentLoaded	1031	897	2062	172	1025	1414
			domInteractive	41	17	224	44	33	152
			firstPaint	578	79	2071	424	974	1429
			backgroundConnect	268	210	690	108	249	547
			firstReactRender	94	45	163	24	112	134
			getState	199	140	820	86	203	252
			initialActions	1	0	5	1	1	2
			loadScripts	818	696	1852	172	810	1206
			setupStore	23	10	68	12	27	51
			numNetworkReqs	140	70	385	72	183	293
	Webpack	Standard Home	uiStartup	855	727	1155	98	877	1104
			load	635	557	883	80	667	835
			domContentLoaded	631	553	875	79	662	827
			domInteractive	26	15	105	22	22	92
			firstPaint	244	99	881	168	233	621
			backgroundConnect	9	5	30	4	10	17
			firstReactRender	37	20	186	25	37	100
			getState	51	18	140	27	64	102
			initialActions	1	0	8	1	1	3
			loadScripts	628	551	866	77	660	819
			setupStore	15	5	62	10	18	38
			numNetworkReqs	41	27	148	34	30	145
	Webpack	Power User Home	uiStartup	1869	1448	2455	238	2022	2324
			load	679	587	1018	102	683	942
			domContentLoaded	668	580	1013	103	672	934
			domInteractive	36	17	224	33	33	120
			firstPaint	322	79	957	210	421	699
			backgroundConnect	90	8	624	174	28	568
			firstReactRender	93	48	158	23	112	125
			getState	176	129	721	59	180	219
			initialActions	1	0	3	1	1	2
			loadScripts	666	578	1004	101	670	932
			setupStore	21	6	56	13	24	48
			numNetworkReqs	152	68	398	74	195	369
Firefox	Browserify	Standard Home	uiStartup	1407	1173	2138	191	1514	1809
			load	1057	935	1335	93	1120	1237
			domContentLoaded	1056	931	1335	93	1120	1236
			domInteractive	53	30	171	28	72	103
			firstPaint	-	-	-	-	-	-
			backgroundConnect	65	25	458	63	63	171
			firstReactRender	28	19	74	10	33	53
			getState	28	9	185	27	27	69
			initialActions	1	0	5	1	2	2
			loadScripts	1031	921	1315	83	1081	1202
			setupStore	24	11	139	20	24	60
			numNetworkReqs	40	28	128	27	32	122
	Browserify	Power User Home	uiStartup	2679	2078	4631	476	2755	4057
			load	1127	954	2317	182	1154	1444
			domContentLoaded	1126	954	2317	182	1153	1444
			domInteractive	113	33	445	85	109	367
			firstPaint	-	-	-	-	-	-
			backgroundConnect	124	30	572	92	141	379
			firstReactRender	86	38	321	41	90	126
			getState	269	57	900	190	298	724
			initialActions	2	0	7	1	2	3
			loadScripts	1094	934	2246	174	1107	1400
			setupStore	171	6	728	193	189	665
			numNetworkReqs	101	61	309	62	80	254
	Webpack	Standard Home	uiStartup	1633	1376	2072	175	1747	1978
			load	1273	1081	1512	103	1341	1468
			domContentLoaded	1272	1081	1512	103	1341	1468
			domInteractive	59	28	216	34	80	108
			firstPaint	-	-	-	-	-	-
			backgroundConnect	62	22	177	30	65	136
			firstReactRender	33	22	164	17	34	46
			getState	25	8	196	24	24	85
			initialActions	2	1	3	1	2	3
			loadScripts	1246	1065	1488	96	1314	1429
			setupStore	26	10	265	35	19	93
			numNetworkReqs	39	28	128	27	33	122
	Webpack	Power User Home	uiStartup	3027	2242	5470	777	3107	4935
			load	1525	1137	3448	541	1508	2886
			domContentLoaded	1525	1137	3448	541	1507	2886
			domInteractive	184	30	1624	294	111	1038
			firstPaint	-	-	-	-	-	-
			backgroundConnect	174	23	1342	259	146	1032
			firstReactRender	87	39	287	37	91	144
			getState	334	27	1181	268	553	866
			initialActions	2	0	35	3	2	3
			loadScripts	1431	1117	2975	415	1481	2577
			setupStore	123	5	663	147	131	470
			numNetworkReqs	101	61	314	63	78	252

📊 Page Load Benchmark Results

Current Commit: 4bbda9a | Date: 11/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±38ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	41ms	1.00s	1.36s	1.05s	1.36s
domContentLoaded	717ms	38ms	695ms	1.02s	731ms	1.02s
firstPaint	76ms	10ms	56ms	160ms	84ms	160ms
firstContentfulPaint	76ms	10ms	56ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 10.6 KiB (0.23%)
ui: -371.41 KiB (-5.01%)
common: 40.19 KiB (0.46%)

metamaskbot added the team-extension-platform Extension Platform team label Oct 23, 2025

github-actions bot added the size-M label Oct 23, 2025

MajorLift changed the title ~~fix: non-functional memoization in getInternalAccounts selector~~ fix(perf): nonfunctional memoization in getInternalAccounts selector Oct 23, 2025

PatrykLucka mentioned this pull request Oct 27, 2025

fix: add connection status back #36423

Merged

7 tasks

MajorLift added 7 commits November 14, 2025 15:25

Fix identity-function output selectors that do not provide memoization

af1afb8

See: https://redux.js.org/usage/deriving-data-selectors#createselector-overview

Fix getInternalAccounts usage that expects incorrect shape (object …

8f285ff

…instead of array)

Remove redundant and nonfunctional "memoized" selector functions with…

6639f7f

… identity-function output selectors

Improve memoization in downstream selectors

6a2037b

Revert changes that affect correctness

40cb400

Use createDeepEqualSelector for getInternalAccounts to respond to…

8ee9b4f

… nested state updates

restore code fence

4bbda9a

MajorLift force-pushed the jongsun/perf/redux/251023-fix-reselect-selectors-accounts branch from 2578a44 to 836d106 Compare November 14, 2025 20:27

MajorLift force-pushed the jongsun/perf/redux/251023-fix-reselect-selectors-accounts branch from 836d106 to 4bbda9a Compare November 25, 2025 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(perf): nonfunctional memoization in `getInternalAccounts` selector #37147

fix(perf): nonfunctional memoization in `getInternalAccounts` selector #37147

MajorLift commented Oct 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Nov 14, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 25, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(perf): nonfunctional memoization in getInternalAccounts selector #37147

Are you sure you want to change the base?

fix(perf): nonfunctional memoization in getInternalAccounts selector #37147

Conversation

MajorLift commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Oct 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 23, 2025

Uh oh!

metamaskbot commented Nov 14, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 25, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(perf): nonfunctional memoization in `getInternalAccounts` selector #37147

fix(perf): nonfunctional memoization in `getInternalAccounts` selector #37147

MajorLift commented Oct 23, 2025 •

edited

Loading

metamaskbot commented Oct 23, 2025 •

edited

Loading