chore: no useless fallback #37370
Merged
chore: no useless fallback #37370
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +1 -1)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [0c2cd9d]
UI Startup Metrics (1255 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
previously approved these changes
Oct 30, 2025
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7ec8907]
UI Startup Metrics (1255 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Oct 31, 2025
salimtb
approved these changes
Oct 31, 2025
metamaskbot
added
the
release-13.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup the useless fallbacks in spread
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes unnecessary
?? {}fallbacks in object spread operations across controllers, tests, and UI code.app/scripts/controllers/onboarding.ts: Replace{ ...(this.state ?? {}) }with{ ...this.state }inregisterOnboarding.app/scripts/controllers/preferences-controller.ts: Initialize reducer accumulator with{ ...lostIdentities }instead of{ ...(lostIdentities ?? {}) }.mockRequestsdirectly (remove?? {}) in multiple files undertest/integration, including transaction confirmations, NFTs, DeFi, notifications, and swaps.ui/components/app/modals/new-account-modal/new-account-modal.container.js: Spreadstate.appState.modal.modalState.propsdirectly.ui/components/multichain/app-header/app-header.test.js: SpreadstateChangesdirectly during store setup.Written by Cursor Bugbot for commit 7ec8907. This will update automatically on new commits. Configure here.