fix: flaky test Account syncing - Multiple SRPs adds accounts across multiple SRPs and sync them

[seaona]

Description

A PR which changes the text from Create Account to Add Account was merged yesterday:
#37288

This introduces flakiness in our e2e, as we had a condition to mitigate flakiness, which relied on Creating Account message which now has changed.

This PR updates the copy, so we mitigate the flakiness again.

See in the logs how we waited for Creating account .. and since this message is never there anymore, we jump into the next step causing the spec to fail. We should wait until the account creating has completed, by using the new copy.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Updates e2e selector to check for Adding account... instead of Creating account... before opening the multichain account menu.

• Tests (e2e)
  • In test/e2e/page-objects/pages/account-list-page.ts:
    • Replace creatingAccountMessage with addingAccountMessage ('Creating account...' -> 'Adding account...').
    • Update openMultichainAccountMenu to assert absence of addingAccountMessage before proceeding.

^{Written by Cursor Bugbot for commit 2a8f851. This will update automatically on new commits. Configure here.}

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +6 -6)

• 📁 test/
  • 📁 e2e/
    • 📁 page-objects/
      • 📁 pages/
        • 📄 account-list-page.ts +6 -6

[seaona]

I've also re-ordered the selector, to follow alphabetic order with the new name

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: 2a8f851 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.02s (±43ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 713ms (±39ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	43ms	1000ms	1.33s	1.05s	1.33s
domContentLoaded	713ms	39ms	689ms	991ms	737ms	991ms
firstPaint	75ms	13ms	60ms	184ms	88ms	184ms
firstContentfulPaint	75ms	13ms	60ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [2a8f851]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1278 ± 88 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1278	1127	1527	88	1331	1455
			load	1090	961	1309	83	1143	1264
			domContentLoaded	1083	949	1301	83	1135	1258
			domInteractive	19	14	52	8	19	46
			firstPaint	677	90	1291	450	1111	1227
			backgroundConnect	234	218	338	13	237	254
			firstReactRender	30	18	79	9	35	47
			getState	23	8	95	13	25	40
			initialActions	7	1	70	9	7	25
			loadScripts	857	710	1060	82	910	1018
			setupStore	10	6	18	3	11	16
			numNetworkReqs	9	6	32	7	6	31
	Browserify	Power User Home	uiStartup	2284	1846	4533	728	2843	4533
			load	1191	954	1959	343	1553	1959
			domContentLoaded	1178	947	1912	333	1543	1912
			domInteractive	32	15	96	23	51	96
			firstPaint	743	170	1957	547	1024	1957
			backgroundConnect	305	223	1188	229	270	1188
			firstReactRender	26	23	32	3	27	32
			getState	195	137	339	48	207	339
			initialActions	7	3	30	7	8	30
			loadScripts	920	719	1494	276	1266	1494
			setupStore	11	9	15	2	13	15
			numNetworkReqs	342	189	695	187	582	695
	Webpack	Standard Home	uiStartup	854	730	1161	82	869	1068
			load	638	588	958	75	643	886
			domContentLoaded	631	582	951	74	636	875
			domInteractive	15	11	40	7	13	34
			firstPaint	208	59	959	211	185	607
			backgroundConnect	22	12	56	7	24	44
			firstReactRender	27	17	46	7	32	35
			getState	12	6	26	4	15	20
			initialActions	3	1	16	2	4	7
			loadScripts	627	580	941	71	634	863
			setupStore	10	5	25	3	12	15
			numNetworkReqs	9	6	36	8	8	31
	Webpack	Power User Home	uiStartup	1677	1266	2554	386	2162	2554
			load	757	612	1289	196	846	1289
			domContentLoaded	717	600	1169	157	830	1169
			domInteractive	19	12	50	10	21	50
			firstPaint	433	124	1174	339	709	1174
			backgroundConnect	126	19	438	152	200	438
			firstReactRender	25	23	36	3	26	36
			getState	152	104	227	25	156	227
			initialActions	16	0	159	39	9	159
			loadScripts	712	598	1159	154	818	1159
			setupStore	17	6	64	15	24	64
			numNetworkReqs	328	162	709	165	538	709
Firefox	Browserify	Standard Home	uiStartup	1462	1292	1847	113	1528	1710
			load	1236	1094	1488	80	1291	1386
			domContentLoaded	1236	1094	1487	80	1291	1386
			domInteractive	114	33	380	53	121	245
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	26	131	18	50	83
			firstReactRender	26	21	50	6	26	42
			getState	10	4	217	22	7	24
			initialActions	5	2	75	9	4	7
			loadScripts	1210	1073	1467	78	1259	1355
			setupStore	14	7	254	24	13	20
			numNetworkReqs	9	6	32	7	7	27
	Browserify	Power User Home	uiStartup	2553	2188	3270	317	2767	3270
			load	1327	1136	1524	119	1453	1524
			domContentLoaded	1327	1136	1524	119	1453	1524
			domInteractive	165	64	307	71	236	307
			firstPaint	-	-	-	-	-	-
			backgroundConnect	157	34	457	142	221	457
			firstReactRender	39	29	50	7	48	50
			getState	129	58	191	33	153	191
			initialActions	8	1	30	8	15	30
			loadScripts	1294	1118	1491	114	1421	1491
			setupStore	38	6	145	41	50	145
			numNetworkReqs	242	152	340	68	321	340
	Webpack	Standard Home	uiStartup	1635	1438	1991	118	1708	1907
			load	1403	1211	1771	102	1460	1633
			domContentLoaded	1402	1211	1771	103	1460	1633
			domInteractive	109	34	372	54	112	248
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	24	108	19	59	85
			firstReactRender	32	22	84	14	32	73
			getState	8	4	49	6	8	14
			initialActions	7	1	189	20	4	18
			loadScripts	1375	1195	1738	102	1434	1612
			setupStore	12	7	64	7	13	20
			numNetworkReqs	9	6	34	7	8	28
	Webpack	Power User Home	uiStartup	2764	2400	3894	449	2966	3894
			load	1612	1333	2202	226	1777	2202
			domContentLoaded	1612	1332	2201	226	1776	2201
			domInteractive	148	78	314	70	198	314
			firstPaint	-	-	-	-	-	-
			backgroundConnect	124	38	403	101	200	403
			firstReactRender	41	31	56	8	48	56
			getState	145	84	209	36	181	209
			initialActions	8	2	51	12	7	51
			loadScripts	1573	1300	2138	220	1734	2138
			setupStore	50	8	251	73	45	251
			numNetworkReqs	241	137	444	91	302	444

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 68 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)