chore: remove supported chainIds constant from utils #37416
Draft
+1,637
−1,347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
4 tasks
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (4 files, +27 -3)
👨🔧 @MetaMask/core-extension-ux (1 files, +3 -0)
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [dadac0c]
UI Startup Metrics (1285 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7503529]
UI Startup Metrics (1255 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [c565efb]
UI Startup Metrics (1274 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [d527bb0]
UI Startup Metrics (1298 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [3fe22ff]
UI Startup Metrics (1278 ± 95 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [f104363]
UI Startup Metrics (1259 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [8be7c16]
UI Startup Metrics (1280 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [dd8e99a]
UI Startup Metrics (1224 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [315f915]
UI Startup Metrics (1256 ± 84 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3629c41]
UI Startup Metrics (1270 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [ee2999d]
UI Startup Metrics (1247 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [2438382]
UI Startup Metrics (1189 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [7c0da5b]
UI Startup Metrics (1210 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [374fccb]
UI Startup Metrics (1211 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [32a0515]
UI Startup Metrics (1220 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [7dd1133]
UI Startup Metrics (1208 ± 78 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
commented
Nov 5, 2025
| "@metamask/announcement-controller": "^8.0.0", | ||
| "@metamask/approval-controller": "^8.0.0", | ||
| "@metamask/assets-controllers": "^86.0.0", | ||
| "@metamask/assets-controllers": "npm:@metamask-previews/assets-controllers@87.0.0-preview-8315c2ec", |
Contributor
Author
There was a problem hiding this comment.
Needs to be changed after new version is released
| */ | ||
| export const chainSupportsPricing = (chainId: Hex) => | ||
| (SUPPORTED_CHAIN_IDS as readonly string[]).includes(chainId); | ||
| /* export const chainSupportsPricing = (chainId: Hex) => |
Contributor
There was a problem hiding this comment.
Nice, lets remove this.
Contributor
Prithpal-Sooriya
left a comment
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
Changes look good! Can re-review once this PR is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After removing the static supportedChainIds array from core; this PR uses the new state property.
Do not merge before this MetaMask/core#7005
Changelog
CHANGELOG entry: No user facing changes are expected after this PR. This PR deals with breaking changes coming from core PR that removes the static supported chainIds in favor of pulling the list from API.
Related issues
Fixes:
Manual testing steps
No user facing/ functionality changes are expected after this PR.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist