chore: unnecessary if's

[n3ps]

Description

No need for a nested if without else

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Consolidates nested conditionals and adds minimal guard checks across background, controllers, services, streams, tests, UI, and selectors without altering behavior.

• Background
  • Simplify phishing test bypass check in app/scripts/background.js by merging nested conditions.
• Controllers
  • Streamline addPollingToken in app/scripts/controllers/app-state-controller.ts (combine checks and call updater directly).
• Services
  • Tighten success URL match with optional chaining and simplify listener logic in app/scripts/services/subscription/subscription-service.ts.
• Streams
  • Collapse legacy notification method remap conditional in app/scripts/streams/provider-stream.ts.
• Tests
  • Flatten error-handling call generation logic in test/e2e/api-specs/MultichainAuthorizationConfirmationErrors.ts.
• UI
  • Add onNetworkChange guard and merge conditions on multiselect submit in ui/components/.../asset-picker.tsx.
• Selectors
  • Simplify connected-account selection logic in ui/selectors/selectors.js (ensure selected address not already connected).

^{Written by Cursor Bugbot for commit fdc88d2. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +5 -6)

• 📁 ui/
  • 📁 components/
    • 📁 multichain/
      • 📁 asset-picker-amount/
        • 📁 asset-picker/
          • 📄 asset-picker.tsx +5 -6

[metamaskbot]

Builds ready [fdc88d2]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1230 ± 77 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1230	1077	1479	77	1289	1360
			load	1050	892	1247	75	1104	1190
			domContentLoaded	1042	886	1239	76	1095	1182
			domInteractive	20	14	105	13	18	49
			firstPaint	639	86	1247	416	1057	1142
			backgroundConnect	227	216	358	15	228	244
			firstReactRender	28	17	94	11	29	45
			getState	21	8	52	8	25	38
			initialActions	7	0	64	10	7	21
			loadScripts	823	673	1018	75	878	966
			setupStore	11	6	24	4	12	18
			numNetworkReqs	9	6	32	7	6	31
	Browserify	Power User Home	uiStartup	2096	1662	3515	573	2785	3515
			load	1111	850	2016	378	1442	2016
			domContentLoaded	1101	843	1981	373	1424	1981
			domInteractive	25	14	66	16	39	66
			firstPaint	907	124	2029	477	965	2029
			backgroundConnect	282	175	946	204	275	946
			firstReactRender	26	22	38	4	28	38
			getState	171	137	222	22	197	222
			initialActions	5	2	15	3	7	15
			loadScripts	875	674	1605	303	1101	1605
			setupStore	11	8	25	5	12	25
			numNetworkReqs	325	160	707	205	647	707
	Webpack	Standard Home	uiStartup	847	706	1580	116	872	1073
			load	629	559	1386	119	618	884
			domContentLoaded	620	552	1335	115	612	879
			domInteractive	15	11	49	7	14	39
			firstPaint	231	53	1343	245	188	723
			backgroundConnect	25	12	114	12	29	42
			firstReactRender	27	17	163	15	32	35
			getState	11	5	29	4	14	17
			initialActions	3	1	15	3	4	8
			loadScripts	617	550	1297	112	610	877
			setupStore	10	5	20	3	12	15
			numNetworkReqs	9	6	34	8	6	31
	Webpack	Power User Home	uiStartup	1705	1254	2482	398	2272	2482
			load	760	624	1290	207	924	1290
			domContentLoaded	716	610	1126	160	885	1126
			domInteractive	18	12	38	8	23	38
			firstPaint	452	70	1131	370	922	1131
			backgroundConnect	138	19	496	166	296	496
			firstReactRender	24	20	29	2	25	29
			getState	153	106	224	25	151	224
			initialActions	6	0	54	13	3	54
			loadScripts	711	608	1116	157	873	1116
			setupStore	15	6	56	14	24	56
			numNetworkReqs	341	186	693	160	561	693
Firefox	Browserify	Standard Home	uiStartup	1444	1280	1857	96	1501	1617
			load	1234	1086	1520	78	1288	1361
			domContentLoaded	1233	1086	1519	78	1288	1361
			domInteractive	117	34	269	46	132	212
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	26	140	18	51	76
			firstReactRender	26	21	50	5	26	39
			getState	6	4	13	2	7	10
			initialActions	3	1	38	4	3	5
			loadScripts	1207	1071	1497	76	1254	1340
			setupStore	11	7	45	4	11	15
			numNetworkReqs	9	6	30	6	7	27
	Browserify	Power User Home	uiStartup	2756	2348	4181	462	2918	4181
			load	1437	1291	1951	158	1529	1951
			domContentLoaded	1436	1291	1951	158	1529	1951
			domInteractive	166	107	294	68	258	294
			firstPaint	-	-	-	-	-	-
			backgroundConnect	202	44	906	211	253	906
			firstReactRender	43	29	89	14	47	89
			getState	148	72	308	54	180	308
			initialActions	10	2	40	10	17	40
			loadScripts	1378	1204	1638	112	1477	1638
			setupStore	32	5	80	24	56	80
			numNetworkReqs	252	153	560	109	312	560
	Webpack	Standard Home	uiStartup	1600	1438	1946	97	1657	1847
			load	1379	1232	1634	86	1431	1567
			domContentLoaded	1378	1232	1633	86	1430	1567
			domInteractive	104	33	408	47	107	215
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	26	108	15	49	78
			firstReactRender	32	23	80	14	30	73
			getState	9	4	143	15	8	16
			initialActions	5	1	71	9	3	17
			loadScripts	1353	1215	1604	85	1405	1535
			setupStore	12	7	34	4	13	22
			numNetworkReqs	9	6	36	7	7	27
	Webpack	Power User Home	uiStartup	2861	2341	3701	484	3494	3701
			load	1660	1323	2260	300	2012	2260
			domContentLoaded	1660	1323	2260	300	2012	2260
			domInteractive	159	69	474	110	218	474
			firstPaint	-	-	-	-	-	-
			backgroundConnect	225	33	597	201	451	597
			firstReactRender	43	30	104	17	47	104
			getState	126	66	197	34	156	197
			initialActions	9	1	54	12	12	54
			loadScripts	1584	1282	1992	246	1891	1992
			setupStore	27	7	93	21	38	93
			numNetworkReqs	287	153	574	139	374	574

📊 Page Load Benchmark Results

Current Commit: fdc88d2 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
• domContentLoaded-> current mean value: 730ms (±36ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	38ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	730ms	36ms	699ms	1.00s	752ms	1.00s
firstPaint	77ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	77ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 93 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)