refactor: accumulator spread in reduce #37435
Merged
+133
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +34 -32)
🧪 @MetaMask/qa (1 files, +10 -12)
|
Collaborator
Builds ready [d33409b]
UI Startup Metrics (1218 ± 71 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [41a2b7f]
UI Startup Metrics (1222 ± 68 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinnyhoward
approved these changes
Nov 3, 2025
Contributor
vinnyhoward
left a comment
vinnyhoward
left a comment
There was a problem hiding this comment.
Nice work. I might do the same thing for mobile if similar patterns exist. Approved
ameliejyc
approved these changes
Nov 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve readability and performance
Spreading the accumulator can generally be slower than a simple for loop, not to mention less readable
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors multiple reducers using spread into explicit loops/Object.assign for building maps, arrays, and initial state across controllers, selectors, UI, tests, and constants.
app/scripts/constants/sentry-state.ts: Replacereduce+ spread with loop andObject.assignto buildflattenedBackgroundStateMask.app/scripts/controller-init/assets/network-enablement-controller-init.ts: BuildallEnabledNetworksvia loop andObject.assign.app/scripts/controllers/metametrics-controller.ts: Rework#buildValidTraitsto usefor...ofaccumulation; preserve validation and return shape.app/scripts/lib/ComposableObservableStore.js: UseObject.assignwhen merging child states ingetFlatState.shared/constants/tokens.js: BuildSTATIC_MAINNET_TOKEN_LISTvia loop; switch to named export after declaration.shared/modules/selectors/networks.ts: BuildclientIdsByChainvia loop; ingetNetworksByScopes, useconcatinstead of array spread.ui/selectors/multichain/networks.ts: Construct EVM multichain config map via loop.ui/selectors/selectors.js: Mutate accumulator object in accounts reduce instead of returning new object each iteration.ui/components/app/contact-list/contact-list.component.js: Group contacts by letter using explicit loops and pre-allocated buckets.ui/components/multichain/.../asset-picker-modal-network.tsx: Initialize and updatecheckedChainIdsvia loops; rework "select all" toggle to build a new map.test/e2e/fixture-builder.js: BuildoptionalScopesfor multichain test dapp using a loop.Written by Cursor Bugbot for commit 41a2b7f. This will update automatically on new commits. Configure here.