chore: remove selectors from spec file #37439

bergarces · 2025-11-01T09:49:15Z

Description

Remove selectors from spec page and replace them with page specific checks.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replace selector-based confirmation with Activity List page-object checks in snap account transfer e2e tests.

Tests (e2e):
- Update test/e2e/tests/account/snap-account-transfers.spec.ts:
  - Replace selector-based confirmation (.transaction-status-label--confirmed) with Activity List verification via ActivityListPage.checkConfirmedTxNumberDisplayedInActivity(1) in both sync and async approve flows.
  - Instantiate ActivityListPage to perform confirmation checks after sending transactions.

^{Written by Cursor Bugbot for commit 092cd07. This will update automatically on new commits. Configure here.}

github-actions · 2025-11-01T09:49:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-11-01T10:13:51Z

Builds ready [784dee9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1230 ± 113 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1230	1035	1610	113	1300	1414
			load	1051	874	1411	105	1107	1238
			domContentLoaded	1044	868	1398	104	1101	1230
			domInteractive	20	13	71	12	18	59
			firstPaint	677	81	1411	419	1067	1187
			backgroundConnect	197	178	222	10	207	215
			firstReactRender	33	18	55	9	39	51
			getState	21	8	88	10	23	41
			initialActions	7	0	45	8	9	29
			loadScripts	854	687	1204	103	918	1025
			setupStore	11	7	31	4	12	22
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2090	1787	3195	439	2592	3195
			load	1100	937	1798	256	1416	1798
			domContentLoaded	1091	925	1779	255	1410	1779
			domInteractive	28	15	73	19	48	73
			firstPaint	883	256	1784	387	974	1784
			backgroundConnect	242	225	296	21	237	296
			firstReactRender	27	25	34	3	29	34
			getState	186	166	245	20	193	245
			initialActions	8	2	46	11	6	46
			loadScripts	860	708	1497	239	1154	1497
			setupStore	13	8	28	6	13	28
			numNetworkReqs	155	100	315	88	305	315
	Webpack	Standard Home	uiStartup	802	675	1149	89	807	1030
			load	585	535	911	76	588	795
			domContentLoaded	578	529	896	74	582	780
			domInteractive	15	11	34	6	13	32
			firstPaint	227	51	900	233	168	785
			backgroundConnect	25	12	74	13	27	60
			firstReactRender	29	17	153	15	32	46
			getState	12	5	20	4	14	18
			initialActions	3	0	13	2	4	8
			loadScripts	575	527	889	72	580	772
			setupStore	10	5	26	4	12	17
			numNetworkReqs	14	6	77	20	8	75
	Webpack	Power User Home	uiStartup	1357	1160	1854	242	1673	1854
			load	679	604	1002	117	769	1002
			domContentLoaded	660	593	893	97	748	893
			domInteractive	25	12	74	20	46	74
			firstPaint	259	62	900	224	248	900
			backgroundConnect	65	12	235	78	144	235
			firstReactRender	27	25	37	3	26	37
			getState	154	109	301	42	157	301
			initialActions	3	1	16	4	2	16
			loadScripts	656	591	882	94	737	882
			setupStore	12	6	26	7	22	26
			numNetworkReqs	150	94	279	73	265	279
Firefox	Browserify	Standard Home	uiStartup	1462	1232	2052	127	1540	1700
			load	1235	1067	1458	84	1300	1385
			domContentLoaded	1235	1067	1456	84	1300	1385
			domInteractive	117	34	322	49	127	219
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	25	155	21	51	78
			firstReactRender	25	21	48	4	25	32
			getState	8	4	38	6	7	14
			initialActions	5	1	76	10	3	15
			loadScripts	1208	1050	1397	79	1272	1347
			setupStore	13	7	209	20	12	29
			numNetworkReqs	12	6	66	16	7	58
	Browserify	Power User Home	uiStartup	2337	2012	3045	298	2568	3045
			load	1313	1124	1701	183	1534	1701
			domContentLoaded	1313	1123	1701	184	1534	1701
			domInteractive	180	89	455	120	321	455
			firstPaint	-	-	-	-	-	-
			backgroundConnect	125	31	399	119	227	399
			firstReactRender	37	27	52	8	44	52
			getState	128	72	251	41	151	251
			initialActions	16	1	144	35	16	144
			loadScripts	1271	1105	1647	159	1471	1647
			setupStore	27	7	85	21	37	85
			numNetworkReqs	138	65	295	73	218	295
	Webpack	Standard Home	uiStartup	1634	1443	2270	146	1660	1936
			load	1388	1203	1818	107	1429	1618
			domContentLoaded	1388	1202	1817	107	1428	1618
			domInteractive	99	32	295	36	108	162
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	26	145	24	53	111
			firstReactRender	35	22	81	16	35	78
			getState	9	4	99	11	8	14
			initialActions	5	1	47	7	4	19
			loadScripts	1357	1184	1780	97	1391	1544
			setupStore	15	7	71	13	13	53
			numNetworkReqs	13	6	71	17	7	64
	Webpack	Power User Home	uiStartup	2592	2153	3380	423	3118	3380
			load	1504	1266	1867	194	1729	1867
			domContentLoaded	1504	1265	1867	195	1729	1867
			domInteractive	181	68	437	133	362	437
			firstPaint	-	-	-	-	-	-
			backgroundConnect	97	44	277	70	159	277
			firstReactRender	46	33	87	17	49	87
			getState	136	96	204	35	178	204
			initialActions	12	1	96	23	11	96
			loadScripts	1463	1243	1827	191	1707	1827
			setupStore	49	11	159	51	70	159
			numNetworkReqs	137	66	345	104	274	345

📊 Page Load Benchmark Results

Current Commit: 784dee9 | Date: 11/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±37ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	41ms	1.01s	1.31s	1.08s	1.31s
domContentLoaded	716ms	37ms	695ms	977ms	756ms	977ms
firstPaint	75ms	12ms	56ms	180ms	84ms	180ms
firstContentfulPaint	75ms	12ms	56ms	180ms	84ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T12:20:22Z

Builds ready [66dc6be]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1281 ± 104 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1281	1105	1505	104	1342	1485
			load	1094	921	1294	93	1161	1270
			domContentLoaded	1087	913	1286	94	1156	1261
			domInteractive	21	13	69	12	18	55
			firstPaint	706	166	1296	432	1117	1250
			backgroundConnect	231	218	333	12	234	245
			firstReactRender	30	18	63	9	36	46
			getState	23	8	86	13	25	50
			initialActions	8	0	75	11	8	29
			loadScripts	864	688	1065	93	931	1030
			setupStore	11	7	33	5	11	25
			numNetworkReqs	13	6	72	19	6	69
	Browserify	Power User Home	uiStartup	2044	1836	2801	291	2364	2801
			load	1092	961	1503	191	1306	1503
			domContentLoaded	1081	952	1495	190	1293	1495
			domInteractive	29	15	82	21	40	82
			firstPaint	790	200	1468	444	1018	1468
			backgroundConnect	239	224	268	12	247	268
			firstReactRender	26	25	28	1	27	28
			getState	182	161	235	20	203	235
			initialActions	4	2	8	2	6	8
			loadScripts	854	723	1255	186	1066	1255
			setupStore	12	9	28	4	11	28
			numNetworkReqs	152	102	313	81	265	313
	Webpack	Standard Home	uiStartup	868	735	1394	115	868	1118
			load	645	585	1190	94	642	879
			domContentLoaded	637	580	1181	92	636	864
			domInteractive	15	11	48	7	14	34
			firstPaint	201	59	1184	208	200	605
			backgroundConnect	27	11	97	17	28	70
			firstReactRender	29	17	140	14	33	39
			getState	12	7	32	4	14	20
			initialActions	3	1	15	3	5	8
			loadScripts	633	578	1170	90	634	854
			setupStore	11	5	23	4	12	21
			numNetworkReqs	13	6	76	20	6	71
	Webpack	Power User Home	uiStartup	1352	1167	1856	247	1695	1856
			load	657	598	886	85	742	886
			domContentLoaded	640	587	849	75	709	849
			domInteractive	22	12	70	16	41	70
			firstPaint	390	66	741	235	595	741
			backgroundConnect	78	17	257	85	189	257
			firstReactRender	26	24	31	2	28	31
			getState	149	112	164	16	158	164
			initialActions	2	1	16	4	2	16
			loadScripts	635	585	838	72	698	838
			setupStore	11	6	24	6	14	24
			numNetworkReqs	146	99	280	69	193	280
Firefox	Browserify	Standard Home	uiStartup	1547	1332	1904	126	1621	1799
			load	1301	1135	1537	90	1375	1448
			domContentLoaded	1301	1134	1537	90	1374	1448
			domInteractive	118	38	369	53	126	220
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	27	184	23	56	103
			firstReactRender	28	23	68	8	28	52
			getState	10	5	97	13	10	21
			initialActions	7	2	197	20	5	19
			loadScripts	1271	1112	1516	86	1326	1412
			setupStore	15	8	129	13	13	32
			numNetworkReqs	13	6	69	17	8	64
	Browserify	Power User Home	uiStartup	2433	2105	2952	243	2704	2952
			load	1372	1170	1626	143	1533	1626
			domContentLoaded	1371	1169	1626	144	1533	1626
			domInteractive	198	92	553	132	293	553
			firstPaint	-	-	-	-	-	-
			backgroundConnect	107	29	343	94	131	343
			firstReactRender	41	31	89	14	44	89
			getState	140	85	223	37	183	223
			initialActions	10	1	71	17	15	71
			loadScripts	1337	1137	1568	136	1475	1568
			setupStore	24	8	68	17	39	68
			numNetworkReqs	133	70	219	59	195	219
	Webpack	Standard Home	uiStartup	1651	1371	2092	142	1672	1974
			load	1402	1203	1756	101	1439	1619
			domContentLoaded	1401	1203	1756	101	1438	1619
			domInteractive	104	33	344	39	118	169
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	25	202	34	59	130
			firstReactRender	32	23	86	13	32	74
			getState	9	4	57	8	10	17
			initialActions	7	1	163	18	4	28
			loadScripts	1368	1186	1669	93	1410	1565
			setupStore	15	8	82	14	13	43
			numNetworkReqs	13	6	69	17	8	65
	Webpack	Power User Home	uiStartup	2529	2131	3589	412	2518	3589
			load	1491	1264	1900	208	1707	1900
			domContentLoaded	1491	1264	1899	208	1706	1899
			domInteractive	215	50	621	177	317	621
			firstPaint	-	-	-	-	-	-
			backgroundConnect	88	38	196	47	127	196
			firstReactRender	41	31	61	10	50	61
			getState	136	96	206	29	141	206
			initialActions	11	1	97	23	11	97
			loadScripts	1455	1235	1865	203	1668	1865
			setupStore	42	10	232	62	58	232
			numNetworkReqs	137	63	356	104	224	356

📊 Page Load Benchmark Results

Current Commit: 66dc6be | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 719ms (±38ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	42ms	1.00s	1.33s	1.09s	1.33s
domContentLoaded	719ms	38ms	695ms	986ms	749ms	986ms
firstPaint	76ms	13ms	60ms	184ms	84ms	184ms
firstContentfulPaint	76ms	13ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T16:42:19Z

Builds ready [84e537d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1273 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1273	1097	1490	94	1330	1445
			load	1091	938	1271	85	1146	1248
			domContentLoaded	1084	933	1263	83	1139	1235
			domInteractive	20	14	112	14	17	53
			firstPaint	600	146	1266	434	1093	1186
			backgroundConnect	229	216	268	7	232	239
			firstReactRender	29	19	58	8	34	48
			getState	22	6	105	15	24	44
			initialActions	6	0	35	6	7	18
			loadScripts	861	720	1039	83	925	1010
			setupStore	11	6	29	4	11	20
			numNetworkReqs	13	6	76	19	6	70
	Browserify	Power User Home	uiStartup	1981	1769	2613	265	2102	2613
			load	1070	932	1547	205	1310	1547
			domContentLoaded	1062	925	1543	205	1301	1543
			domInteractive	35	14	156	39	29	156
			firstPaint	662	174	1470	432	962	1470
			backgroundConnect	232	220	251	9	241	251
			firstReactRender	26	24	30	2	26	30
			getState	182	159	224	18	197	224
			initialActions	5	3	13	3	6	13
			loadScripts	840	704	1320	202	1080	1320
			setupStore	10	8	15	1	11	15
			numNetworkReqs	151	101	311	72	227	311
	Webpack	Standard Home	uiStartup	886	752	1134	76	904	1049
			load	654	603	918	64	666	822
			domContentLoaded	646	597	902	62	660	804
			domInteractive	16	12	52	9	15	39
			firstPaint	216	56	906	216	208	772
			backgroundConnect	28	12	91	15	31	69
			firstReactRender	29	18	65	8	35	38
			getState	13	7	48	5	15	18
			initialActions	3	1	15	3	4	9
			loadScripts	642	594	892	59	657	793
			setupStore	11	6	22	3	13	16
			numNetworkReqs	13	6	75	18	8	70
	Webpack	Power User Home	uiStartup	1313	1160	1753	203	1535	1753
			load	682	600	1003	132	754	1003
			domContentLoaded	656	586	885	101	719	885
			domInteractive	21	13	64	14	30	64
			firstPaint	304	58	888	252	596	888
			backgroundConnect	66	13	210	66	108	210
			firstReactRender	27	24	44	5	26	44
			getState	142	108	160	17	152	160
			initialActions	5	1	38	9	8	38
			loadScripts	652	583	873	98	709	873
			setupStore	10	6	24	6	10	24
			numNetworkReqs	144	97	277	65	192	277
Firefox	Browserify	Standard Home	uiStartup	1479	1244	1892	120	1545	1697
			load	1251	1072	1489	86	1318	1389
			domContentLoaded	1251	1072	1488	86	1318	1389
			domInteractive	120	35	304	50	138	225
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	26	146	24	49	97
			firstReactRender	25	21	46	3	25	29
			getState	8	4	39	5	8	15
			initialActions	6	1	185	19	4	17
			loadScripts	1224	1055	1470	80	1289	1360
			setupStore	13	7	60	8	12	34
			numNetworkReqs	12	6	62	16	7	60
	Browserify	Power User Home	uiStartup	2373	2124	3200	301	2544	3200
			load	1350	1107	1819	205	1579	1819
			domContentLoaded	1350	1106	1818	205	1579	1818
			domInteractive	171	77	493	118	265	493
			firstPaint	-	-	-	-	-	-
			backgroundConnect	85	33	202	57	160	202
			firstReactRender	39	28	63	10	46	63
			getState	121	98	211	28	128	211
			initialActions	7	1	14	4	11	14
			loadScripts	1312	1086	1718	189	1484	1718
			setupStore	35	7	114	30	43	114
			numNetworkReqs	135	71	332	85	190	332
	Webpack	Standard Home	uiStartup	1551	1341	2145	141	1584	1922
			load	1329	1162	1745	107	1368	1569
			domContentLoaded	1329	1162	1745	107	1368	1569
			domInteractive	100	33	357	44	111	161
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	20	198	33	51	119
			firstReactRender	32	22	86	17	30	78
			getState	9	4	188	18	7	14
			initialActions	4	1	25	5	3	15
			loadScripts	1299	1146	1648	95	1344	1484
			setupStore	13	7	73	12	11	37
			numNetworkReqs	13	6	71	17	7	62
	Webpack	Power User Home	uiStartup	2918	2405	4345	538	3248	4345
			load	1696	1358	2380	275	1860	2380
			domContentLoaded	1695	1358	2380	276	1860	2380
			domInteractive	215	84	693	182	353	693
			firstPaint	-	-	-	-	-	-
			backgroundConnect	144	39	485	141	272	485
			firstReactRender	52	36	110	18	57	110
			getState	191	115	316	55	238	316
			initialActions	19	2	101	29	18	101
			loadScripts	1648	1334	2239	252	1832	2239
			setupStore	33	8	135	33	57	135
			numNetworkReqs	136	69	329	91	225	329

📊 Page Load Benchmark Results

Current Commit: 84e537d | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.34s	1.07s	1.34s
domContentLoaded	722ms	36ms	696ms	995ms	748ms	995ms
firstPaint	75ms	11ms	56ms	160ms	84ms	160ms
firstContentfulPaint	75ms	11ms	56ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T18:50:29Z

Builds ready [092cd07]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1311 ± 95 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1311	1138	1497	95	1377	1475
			load	1121	977	1300	88	1183	1275
			domContentLoaded	1114	974	1292	87	1179	1262
			domInteractive	22	14	84	12	21	54
			firstPaint	670	87	1299	449	1110	1251
			backgroundConnect	236	221	282	9	240	252
			firstReactRender	33	21	52	9	41	47
			getState	20	8	63	8	23	33
			initialActions	7	1	81	10	8	22
			loadScripts	884	739	1067	87	956	1039
			setupStore	11	6	33	3	12	16
			numNetworkReqs	13	6	74	19	6	71
	Browserify	Power User Home	uiStartup	2018	1770	2700	310	2463	2700
			load	1072	930	1435	200	1383	1435
			domContentLoaded	1061	926	1429	195	1325	1429
			domInteractive	29	13	75	21	44	75
			firstPaint	599	152	1373	394	972	1373
			backgroundConnect	239	220	284	16	249	284
			firstReactRender	26	24	31	2	27	31
			getState	180	152	226	20	197	226
			initialActions	5	3	10	2	5	10
			loadScripts	836	711	1186	184	1105	1186
			setupStore	11	9	23	3	11	23
			numNetworkReqs	154	100	308	75	229	308
	Webpack	Standard Home	uiStartup	863	735	1263	102	866	1177
			load	649	590	1011	88	649	925
			domContentLoaded	641	584	991	86	643	907
			domInteractive	16	12	54	8	14	35
			firstPaint	212	62	994	197	199	645
			backgroundConnect	27	12	97	17	29	77
			firstReactRender	27	17	58	8	33	36
			getState	12	6	26	4	14	18
			initialActions	3	0	17	3	4	11
			loadScripts	638	582	980	83	641	895
			setupStore	10	5	32	4	12	21
			numNetworkReqs	13	6	75	19	8	73
	Webpack	Power User Home	uiStartup	1368	1174	1899	257	1537	1899
			load	702	605	978	139	829	978
			domContentLoaded	678	586	928	121	797	928
			domInteractive	24	12	62	18	45	62
			firstPaint	382	121	932	307	605	932
			backgroundConnect	88	17	375	109	214	375
			firstReactRender	27	24	32	2	29	32
			getState	148	103	178	20	157	178
			initialActions	2	0	7	2	3	7
			loadScripts	673	584	917	117	786	917
			setupStore	9	6	23	4	10	23
			numNetworkReqs	145	89	275	61	193	275
Firefox	Browserify	Standard Home	uiStartup	1471	1297	1981	119	1544	1680
			load	1248	1090	1420	84	1309	1402
			domContentLoaded	1248	1090	1420	84	1309	1402
			domInteractive	120	34	314	54	132	268
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	26	136	20	49	88
			firstReactRender	26	21	51	6	26	45
			getState	8	4	60	7	8	21
			initialActions	4	2	27	4	3	13
			loadScripts	1221	1072	1401	81	1281	1367
			setupStore	12	6	60	9	12	28
			numNetworkReqs	12	6	63	16	7	60
	Browserify	Power User Home	uiStartup	2341	1889	2699	244	2517	2699
			load	1382	1141	1758	170	1547	1758
			domContentLoaded	1381	1141	1758	171	1547	1758
			domInteractive	222	86	658	195	427	658
			firstPaint	-	-	-	-	-	-
			backgroundConnect	86	28	282	64	104	282
			firstReactRender	38	30	54	6	42	54
			getState	129	56	191	36	168	191
			initialActions	12	1	61	18	13	61
			loadScripts	1348	1123	1677	162	1510	1677
			setupStore	36	6	209	52	40	209
			numNetworkReqs	127	62	237	64	173	237
	Webpack	Standard Home	uiStartup	1526	1363	2187	155	1532	1912
			load	1309	1152	1665	108	1330	1571
			domContentLoaded	1308	1152	1664	108	1330	1570
			domInteractive	97	31	249	34	113	171
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	20	186	27	49	117
			firstReactRender	29	21	70	11	29	64
			getState	9	4	78	9	8	24
			initialActions	5	1	46	6	3	18
			loadScripts	1281	1135	1595	98	1305	1494
			setupStore	19	7	245	32	12	70
			numNetworkReqs	13	6	71	18	7	67
	Webpack	Power User Home	uiStartup	2451	2163	3125	277	2655	3125
			load	1460	1236	1841	198	1640	1841
			domContentLoaded	1460	1236	1841	198	1640	1841
			domInteractive	147	36	403	122	315	403
			firstPaint	-	-	-	-	-	-
			backgroundConnect	91	32	198	59	158	198
			firstReactRender	44	32	95	17	51	95
			getState	136	75	272	44	137	272
			initialActions	8	1	45	11	10	45
			loadScripts	1422	1219	1799	188	1612	1799
			setupStore	24	6	96	25	25	96
			numNetworkReqs	133	60	253	71	201	253

📊 Page Load Benchmark Results

Current Commit: 092cd07 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±37ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 745ms (±34ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	37ms	1.03s	1.33s	1.10s	1.33s
domContentLoaded	745ms	34ms	718ms	991ms	777ms	991ms
firstPaint	79ms	12ms	64ms	188ms	88ms	188ms
firstContentfulPaint	79ms	12ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

chore: remove selectors from spec file

784dee9

metamaskbot added the team-assets label Nov 1, 2025

github-actions bot added the size-XS label Nov 1, 2025

juanmigdr approved these changes Nov 3, 2025

View reviewed changes

sahar-fehri approved these changes Nov 3, 2025

View reviewed changes

Prithpal-Sooriya approved these changes Nov 3, 2025

View reviewed changes

Merge branch 'main' into remove-selectors-from-spec

66dc6be

bergarces enabled auto-merge November 3, 2025 12:13

bergarces added this pull request to the merge queue Nov 3, 2025

bergarces removed this pull request from the merge queue due to a manual request Nov 3, 2025

Merge branch 'main' into remove-selectors-from-spec

84e537d

bergarces enabled auto-merge November 3, 2025 16:16

Merge branch 'main' into remove-selectors-from-spec

092cd07

bergarces added this pull request to the merge queue Nov 3, 2025

Merged via the queue into main with commit a90ccb4 Nov 3, 2025
481 of 485 checks passed

bergarces deleted the remove-selectors-from-spec branch November 3, 2025 20:44

github-actions bot locked and limited conversation to collaborators Nov 3, 2025

metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove selectors from spec file #37439

chore: remove selectors from spec file #37439

bergarces commented Nov 1, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

metamaskbot commented Nov 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: remove selectors from spec file #37439

chore: remove selectors from spec file #37439

Conversation

bergarces commented Nov 1, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

metamaskbot commented Nov 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bergarces commented Nov 1, 2025 •

edited by cursor bot

Loading