feat: Activate `batch` transaction re-simulations when on window focus #37452

OGPoyraz · 2025-11-03T08:41:18Z

Description

This PR aims to activate re-simulation feature when user focus the active extension window for batch transactions.

Changelog

CHANGELOG entry: null

Related issues

Fixes: Batch transaction resimulation

Manual testing steps

Batch transaction simulation network requests (sentinel) should be visible in the network tab when focused in the active window.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds TransactionType.batch to FOCUSABLE_TYPES to enable batch tx re-simulation on window focus.

Confirmations UI
- Update ui/pages/confirmations/hooks/useTransactionFocusEffect.ts:
  - Add TransactionType.batch to FOCUSABLE_TYPES so batch transactions toggle active state on window focus.

^{Written by Cursor Bugbot for commit 6d7c6da. This will update automatically on new commits. Configure here.}

metamaskbot · 2025-11-03T08:43:49Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +1 -0)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 hooks/
      - 📄 useTransactionFocusEffect.ts +1 -0

metamaskbot · 2025-11-03T09:05:20Z

Builds ready [5361652]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1264 ± 89 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1264	1100	1523	89	1339	1396
			load	1089	953	1317	84	1166	1206
			domContentLoaded	1083	948	1303	83	1158	1198
			domInteractive	21	14	83	13	18	54
			firstPaint	640	90	1311	442	1105	1200
			backgroundConnect	229	216	253	7	233	241
			firstReactRender	28	18	50	7	33	46
			getState	20	7	51	7	23	35
			initialActions	5	1	21	4	6	13
			loadScripts	860	729	1076	83	937	984
			setupStore	10	6	25	3	10	17
			numNetworkReqs	13	6	74	19	6	72
	Browserify	Power User Home	uiStartup	2023	1806	2807	310	2408	2807
			load	1094	938	1736	247	1421	1736
			domContentLoaded	1085	932	1730	248	1410	1730
			domInteractive	27	15	64	18	52	64
			firstPaint	666	179	1738	519	960	1738
			backgroundConnect	237	219	272	12	241	272
			firstReactRender	26	24	29	1	27	29
			getState	178	162	201	12	192	201
			initialActions	4	2	7	1	5	7
			loadScripts	860	707	1485	241	1181	1485
			setupStore	12	9	26	4	11	26
			numNetworkReqs	157	103	313	88	304	313
	Webpack	Standard Home	uiStartup	882	740	1157	86	900	1109
			load	653	600	931	76	658	885
			domContentLoaded	646	594	916	73	651	868
			domInteractive	16	12	67	9	15	38
			firstPaint	186	57	882	186	185	626
			backgroundConnect	26	12	78	14	28	64
			firstReactRender	30	18	57	8	35	39
			getState	12	6	22	3	15	18
			initialActions	3	1	14	2	4	8
			loadScripts	642	591	905	71	649	858
			setupStore	11	5	20	3	13	17
			numNetworkReqs	13	6	75	19	8	70
	Webpack	Power User Home	uiStartup	1332	1168	2014	249	1603	2014
			load	681	605	1004	122	765	1004
			domContentLoaded	653	594	960	99	731	960
			domInteractive	23	12	64	16	39	64
			firstPaint	274	73	966	239	357	966
			backgroundConnect	63	18	215	73	98	215
			firstReactRender	26	24	28	1	26	28
			getState	147	109	162	15	157	162
			initialActions	4	1	25	6	4	25
			loadScripts	649	592	950	95	721	950
			setupStore	12	6	24	7	22	24
			numNetworkReqs	146	97	279	68	193	279
Firefox	Browserify	Standard Home	uiStartup	1550	1330	2149	126	1617	1740
			load	1309	1145	1524	85	1380	1454
			domContentLoaded	1309	1145	1524	85	1379	1454
			domInteractive	121	36	328	48	126	224
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	28	355	38	53	116
			firstReactRender	28	22	57	8	27	49
			getState	8	4	39	6	8	19
			initialActions	7	1	208	21	4	14
			loadScripts	1279	1123	1481	84	1342	1422
			setupStore	14	7	55	9	13	36
			numNetworkReqs	13	6	69	17	7	63
	Browserify	Power User Home	uiStartup	2467	2135	3270	376	3018	3270
			load	1405	1175	1855	223	1652	1855
			domContentLoaded	1405	1174	1854	223	1651	1854
			domInteractive	180	91	406	113	254	406
			firstPaint	-	-	-	-	-	-
			backgroundConnect	107	40	352	95	196	352
			firstReactRender	39	29	62	9	46	62
			getState	132	94	280	44	158	280
			initialActions	14	1	139	33	14	139
			loadScripts	1365	1138	1821	214	1617	1821
			setupStore	36	6	150	42	43	150
			numNetworkReqs	150	68	343	85	219	343
	Webpack	Standard Home	uiStartup	1573	1411	1990	145	1637	1891
			load	1344	1189	1694	108	1393	1582
			domContentLoaded	1343	1189	1694	108	1392	1581
			domInteractive	99	32	265	41	109	165
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	23	122	22	53	110
			firstReactRender	31	22	72	13	30	69
			getState	10	3	166	17	9	17
			initialActions	5	1	29	6	3	26
			loadScripts	1315	1170	1668	98	1365	1519
			setupStore	16	4	88	18	13	75
			numNetworkReqs	13	6	71	18	8	67
	Webpack	Power User Home	uiStartup	2748	2193	3675	426	3180	3675
			load	1596	1261	1939	216	1837	1939
			domContentLoaded	1596	1261	1939	216	1837	1939
			domInteractive	183	45	451	131	331	451
			firstPaint	-	-	-	-	-	-
			backgroundConnect	118	34	266	68	182	266
			firstReactRender	44	32	106	17	50	106
			getState	131	80	215	27	137	215
			initialActions	13	2	63	14	19	63
			loadScripts	1554	1241	1889	209	1771	1889
			setupStore	47	6	268	62	45	268
			numNetworkReqs	179	64	359	94	248	359

📊 Page Load Benchmark Results

Current Commit: 5361652 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±72ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 746ms (±70ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	72ms	1.02s	1.35s	1.28s	1.35s
domContentLoaded	746ms	70ms	704ms	1.04s	950ms	1.04s
firstPaint	77ms	10ms	60ms	156ms	88ms	156ms
firstContentfulPaint	77ms	10ms	60ms	156ms	88ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 24 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T12:32:17Z

Builds ready [6d7c6da]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1268 ± 97 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1268	1117	1657	97	1318	1438
			load	1083	967	1379	83	1134	1221
			domContentLoaded	1076	962	1355	81	1126	1213
			domInteractive	22	14	129	18	19	64
			firstPaint	703	90	1396	433	1110	1219
			backgroundConnect	232	217	294	11	235	253
			firstReactRender	29	19	56	9	36	48
			getState	22	9	66	9	25	40
			initialActions	6	1	58	7	7	13
			loadScripts	851	737	1106	78	903	984
			setupStore	10	6	33	4	11	17
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2033	1810	2787	305	2411	2787
			load	1072	941	1419	181	1345	1419
			domContentLoaded	1064	935	1413	181	1337	1413
			domInteractive	28	16	76	20	54	76
			firstPaint	661	212	1433	431	974	1433
			backgroundConnect	240	221	262	11	255	262
			firstReactRender	27	25	33	2	28	33
			getState	186	167	256	21	197	256
			initialActions	6	3	15	3	6	15
			loadScripts	835	716	1191	179	1098	1191
			setupStore	11	9	12	1	12	12
			numNetworkReqs	155	103	306	83	281	306
	Webpack	Standard Home	uiStartup	937	784	1300	94	962	1154
			load	691	622	1043	87	691	918
			domContentLoaded	681	614	1023	84	685	904
			domInteractive	18	12	67	10	16	40
			firstPaint	193	61	908	176	205	649
			backgroundConnect	30	14	87	17	31	81
			firstReactRender	31	19	137	14	38	41
			getState	13	7	24	3	16	19
			initialActions	4	1	20	3	5	10
			loadScripts	678	612	1011	82	682	893
			setupStore	12	7	24	4	14	19
			numNetworkReqs	13	6	74	19	8	68
	Webpack	Power User Home	uiStartup	1337	1154	1962	262	1490	1962
			load	673	595	1012	127	725	1012
			domContentLoaded	656	584	977	117	697	977
			domInteractive	22	12	62	16	39	62
			firstPaint	207	114	593	117	265	593
			backgroundConnect	71	18	285	83	113	285
			firstReactRender	26	24	36	3	26	36
			getState	146	108	158	16	156	158
			initialActions	4	1	17	5	7	17
			loadScripts	652	582	965	114	686	965
			setupStore	12	6	40	9	14	40
			numNetworkReqs	143	99	279	65	196	279
Firefox	Browserify	Standard Home	uiStartup	1537	1322	2128	145	1600	1788
			load	1297	1140	1529	92	1366	1455
			domContentLoaded	1297	1140	1529	92	1366	1454
			domInteractive	123	36	336	52	133	228
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	28	151	22	51	99
			firstReactRender	26	21	48	5	27	41
			getState	11	4	196	21	8	30
			initialActions	4	2	37	4	3	13
			loadScripts	1268	1120	1511	88	1338	1423
			setupStore	16	4	214	27	11	38
			numNetworkReqs	12	6	71	16	7	60
	Browserify	Power User Home	uiStartup	2580	2174	3483	332	2826	3483
			load	1441	1208	2073	206	1571	2073
			domContentLoaded	1441	1207	2072	206	1571	2072
			domInteractive	233	97	545	167	486	545
			firstPaint	-	-	-	-	-	-
			backgroundConnect	126	32	434	105	189	434
			firstReactRender	41	32	56	8	48	56
			getState	134	104	193	24	150	193
			initialActions	15	1	118	28	27	118
			loadScripts	1404	1187	1958	191	1543	1958
			setupStore	32	10	180	41	38	180
			numNetworkReqs	139	70	292	71	219	292
	Webpack	Standard Home	uiStartup	1684	1491	2324	157	1755	1981
			load	1424	1237	1877	116	1468	1667
			domContentLoaded	1424	1236	1877	116	1468	1667
			domInteractive	103	35	224	34	111	176
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	22	224	35	59	126
			firstReactRender	36	23	82	17	36	78
			getState	8	4	48	5	10	14
			initialActions	8	1	163	22	4	28
			loadScripts	1391	1220	1831	108	1440	1623
			setupStore	14	7	80	12	12	35
			numNetworkReqs	13	6	70	17	8	66
	Webpack	Power User Home	uiStartup	2549	2139	3151	279	2812	3151
			load	1507	1240	1992	199	1633	1992
			domContentLoaded	1507	1240	1992	199	1633	1992
			domInteractive	196	39	490	144	344	490
			firstPaint	-	-	-	-	-	-
			backgroundConnect	90	33	238	68	131	238
			firstReactRender	46	31	99	16	51	99
			getState	145	88	218	43	195	218
			initialActions	14	1	77	22	19	77
			loadScripts	1470	1221	1932	190	1578	1932
			setupStore	38	8	147	40	79	147
			numNetworkReqs	156	66	329	79	202	329

📊 Page Load Benchmark Results

Current Commit: 6d7c6da | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±39ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	42ms	1.01s	1.36s	1.06s	1.36s
domContentLoaded	717ms	39ms	698ms	1.03s	737ms	1.03s
firstPaint	77ms	12ms	60ms	184ms	84ms	184ms
firstContentfulPaint	77ms	12ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 24 Bytes (0%)
common: 10 Bytes (0%)

Activate batch transaction resimulations

5361652

OGPoyraz requested a review from a team as a code owner November 3, 2025 08:41

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 3, 2025

github-actions bot added the size-XS label Nov 3, 2025

OGPoyraz changed the title ~~feat: Activate batch transaction resimulations~~ feat: Activate batch transaction re-simulations when window is focused Nov 3, 2025

OGPoyraz changed the title ~~feat: Activate batch transaction re-simulations when window is focused~~ feat: Activate batch transaction re-simulations when on window focus Nov 3, 2025

vinistevam approved these changes Nov 3, 2025

View reviewed changes

OGPoyraz enabled auto-merge November 3, 2025 09:31

pedronfigueiredo approved these changes Nov 3, 2025

View reviewed changes

Merge branch 'main' into activate-batch-transaction-resimulations

6d7c6da

OGPoyraz added this pull request to the merge queue Nov 3, 2025

auto-merge was automatically disabled November 3, 2025 15:51
Pull Request is not mergeable

Merged via the queue into main with commit a37a298 Nov 3, 2025
480 of 485 checks passed

OGPoyraz deleted the activate-batch-transaction-resimulations branch November 3, 2025 16:04

github-actions bot locked and limited conversation to collaborators Nov 3, 2025

metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Activate `batch` transaction re-simulations when on window focus #37452

feat: Activate `batch` transaction re-simulations when on window focus #37452

OGPoyraz commented Nov 3, 2025 •

edited by cursor bot

Loading

Uh oh!

metamaskbot commented Nov 3, 2025

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Activate batch transaction re-simulations when on window focus #37452

feat: Activate batch transaction re-simulations when on window focus #37452

Conversation

OGPoyraz commented Nov 3, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Nov 3, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Activate `batch` transaction re-simulations when on window focus #37452

feat: Activate `batch` transaction re-simulations when on window focus #37452

OGPoyraz commented Nov 3, 2025 •

edited by cursor bot

Loading