fix: flaky test Update modal should disappear when closed

[seaona]

Description

The timeout in clickElementAndWaitToDisappear has a default max value of 2seconds. This is insufficient in the update modal test, where sometimes the spec fails as the element didn't disappear yet:

This increases the default timeout to 3 seconds at the driver method level. This won't mean that we will always wait until the full 3 seconds but that now, we have a bigger window to wait.
I chose to change this at the driver method, to help stabilize all ci in general, not just for that case, as 3 seconds still seams a reasonable amount of time (in the case we need to fully wait for them).

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Check ci. I edited the spec file to trigger the quality gate and run the Update Modal spec 5 more times x4 (each build), so it was run 20+4 times and it passed (other specs failed due to existing flakiness, being fixed in different PRs)

0b857c0

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Increase default timeout from 2s to 3s in clickElementAndWaitToDisappear to improve reliability of disappearing elements.

• Tests (E2E):
  • test/e2e/webdriver/driver.js:
    • clickElementAndWaitToDisappear: default timeout increased 2000ms → 3000ms.

^{Written by Cursor Bugbot for commit 919feab. This will update automatically on new commits. Configure here.}

[metamaskbot]

Builds ready [0b857c0]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1269 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1269	1098	1661	93	1315	1431
			load	1085	949	1461	86	1129	1219
			domContentLoaded	1079	944	1451	85	1124	1210
			domInteractive	21	14	81	13	18	56
			firstPaint	648	78	1271	432	1096	1199
			backgroundConnect	230	218	251	7	233	244
			firstReactRender	30	18	48	8	38	45
			getState	21	10	65	8	25	36
			initialActions	7	1	73	9	8	19
			loadScripts	855	725	1210	82	904	978
			setupStore	10	7	27	3	11	19
			numNetworkReqs	13	6	76	19	6	71
	Browserify	Power User Home	uiStartup	2197	1924	3211	408	2639	3211
			load	1156	981	1659	228	1432	1659
			domContentLoaded	1145	976	1650	224	1418	1650
			domInteractive	32	15	84	23	58	84
			firstPaint	764	93	1657	504	1063	1657
			backgroundConnect	256	235	311	17	265	311
			firstReactRender	29	25	33	2	31	33
			getState	189	169	231	17	206	231
			initialActions	6	2	12	3	8	12
			loadScripts	904	750	1394	219	1169	1394
			setupStore	14	9	32	6	12	32
			numNetworkReqs	156	100	318	88	298	318
	Webpack	Standard Home	uiStartup	855	733	1247	80	868	1016
			load	635	583	1002	71	640	787
			domContentLoaded	627	577	957	66	635	771
			domInteractive	16	11	75	10	14	36
			firstPaint	200	58	1002	197	189	608
			backgroundConnect	26	13	92	15	27	70
			firstReactRender	28	17	42	7	34	36
			getState	12	6	18	3	14	16
			initialActions	3	1	15	3	4	10
			loadScripts	623	575	945	64	633	761
			setupStore	11	5	22	3	13	16
			numNetworkReqs	13	6	75	19	8	71
	Webpack	Power User Home	uiStartup	1262	1103	1763	219	1457	1763
			load	629	554	817	88	747	817
			domContentLoaded	611	543	799	79	709	799
			domInteractive	22	12	59	14	35	59
			firstPaint	369	72	802	275	712	802
			backgroundConnect	75	12	286	90	204	286
			firstReactRender	26	24	31	2	26	31
			getState	136	92	166	21	146	166
			initialActions	5	1	19	7	7	19
			loadScripts	607	541	789	76	701	789
			setupStore	13	6	27	8	22	27
			numNetworkReqs	149	99	292	66	195	292
Firefox	Browserify	Standard Home	uiStartup	1582	1361	2142	140	1632	1868
			load	1330	1164	1553	84	1391	1478
			domContentLoaded	1330	1164	1553	84	1390	1478
			domInteractive	121	38	380	52	130	234
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	27	224	32	62	126
			firstReactRender	28	23	55	5	28	40
			getState	9	5	55	6	9	20
			initialActions	6	2	44	6	5	17
			loadScripts	1296	1144	1468	77	1351	1436
			setupStore	17	9	234	24	14	36
			numNetworkReqs	13	6	68	17	7	62
	Browserify	Power User Home	uiStartup	2530	2111	3364	344	2736	3364
			load	1380	1147	1816	210	1603	1816
			domContentLoaded	1379	1147	1816	210	1602	1816
			domInteractive	195	92	557	144	199	557
			firstPaint	-	-	-	-	-	-
			backgroundConnect	127	32	479	127	190	479
			firstReactRender	46	28	101	17	52	101
			getState	145	91	206	32	170	206
			initialActions	10	1	35	10	15	35
			loadScripts	1336	1127	1786	182	1571	1786
			setupStore	43	6	192	51	57	192
			numNetworkReqs	140	70	318	78	214	318
	Webpack	Standard Home	uiStartup	1749	1565	2618	163	1791	2087
			load	1473	1298	1766	100	1526	1687
			domContentLoaded	1473	1297	1765	100	1526	1687
			domInteractive	105	34	305	37	117	157
			firstPaint	-	-	-	-	-	-
			backgroundConnect	60	29	546	56	61	127
			firstReactRender	40	26	94	19	40	83
			getState	8	4	27	4	9	16
			initialActions	7	2	211	21	5	20
			loadScripts	1438	1279	1684	86	1496	1621
			setupStore	17	9	79	13	15	43
			numNetworkReqs	13	6	69	18	7	66
	Webpack	Power User Home	uiStartup	2558	2246	3108	287	2920	3108
			load	1561	1293	1967	219	1770	1967
			domContentLoaded	1561	1293	1966	219	1770	1966
			domInteractive	202	45	414	135	380	414
			firstPaint	-	-	-	-	-	-
			backgroundConnect	82	31	241	55	107	241
			firstReactRender	44	32	55	8	53	55
			getState	125	75	197	33	139	197
			initialActions	10	1	74	18	7	74
			loadScripts	1528	1262	1892	212	1737	1892
			setupStore	29	9	143	34	39	143
			numNetworkReqs	134	60	312	85	227	312

📊 Page Load Benchmark Results

Current Commit: 0b857c0 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.00s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 694ms (±36ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.00s	39ms	974ms	1.28s	1.03s	1.28s
domContentLoaded	694ms	36ms	669ms	963ms	714ms	963ms
firstPaint	78ms	12ms	64ms	188ms	84ms	188ms
firstContentfulPaint	78ms	12ms	64ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 68 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)

[metamaskbot]

Builds ready [919feab]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1321 ± 101 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1321	1145	1560	101	1396	1505
			load	1130	980	1313	92	1205	1289
			domContentLoaded	1124	977	1303	91	1198	1284
			domInteractive	23	15	71	13	21	57
			firstPaint	624	79	1311	452	1118	1278
			backgroundConnect	237	219	273	9	241	255
			firstReactRender	33	18	70	10	40	48
			getState	22	9	93	12	24	43
			initialActions	7	0	102	11	8	19
			loadScripts	894	755	1075	90	969	1055
			setupStore	11	7	31	4	12	19
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2035	1782	3223	423	2464	3223
			load	1075	909	1765	262	1372	1765
			domContentLoaded	1066	902	1749	260	1363	1749
			domInteractive	28	14	78	20	50	78
			firstPaint	711	180	1754	492	976	1754
			backgroundConnect	242	216	307	20	249	307
			firstReactRender	27	24	40	4	28	40
			getState	174	152	246	23	188	246
			initialActions	5	2	15	3	5	15
			loadScripts	843	689	1457	245	1127	1457
			setupStore	10	8	11	1	11	11
			numNetworkReqs	154	85	313	87	281	313
	Webpack	Standard Home	uiStartup	872	737	1268	95	885	1154
			load	649	592	989	83	651	932
			domContentLoaded	641	586	975	80	645	908
			domInteractive	16	12	46	8	14	38
			firstPaint	194	58	978	193	185	636
			backgroundConnect	27	12	105	17	29	75
			firstReactRender	29	18	117	11	34	38
			getState	12	7	23	3	14	17
			initialActions	3	1	23	4	4	13
			loadScripts	638	584	964	77	643	897
			setupStore	11	6	24	3	12	18
			numNetworkReqs	13	6	74	19	8	70
	Webpack	Power User Home	uiStartup	1430	1226	2105	290	1799	2105
			load	724	621	1008	137	768	1008
			domContentLoaded	705	610	959	123	742	959
			domInteractive	27	14	86	23	47	86
			firstPaint	284	73	959	251	420	959
			backgroundConnect	73	13	238	89	218	238
			firstReactRender	27	25	29	1	28	29
			getState	149	110	169	18	160	169
			initialActions	2	1	9	2	4	9
			loadScripts	700	608	948	119	732	948
			setupStore	12	6	26	7	23	26
			numNetworkReqs	141	81	282	70	175	282
Firefox	Browserify	Standard Home	uiStartup	1484	1247	2189	142	1554	1710
			load	1253	1081	1526	90	1325	1407
			domContentLoaded	1253	1081	1526	90	1324	1407
			domInteractive	115	34	339	48	128	227
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	26	327	34	50	87
			firstReactRender	25	21	58	5	26	30
			getState	9	4	91	10	8	23
			initialActions	4	1	19	4	4	15
			loadScripts	1225	1063	1412	84	1290	1383
			setupStore	13	7	177	17	11	30
			numNetworkReqs	13	6	73	17	7	62
	Browserify	Power User Home	uiStartup	2575	2175	3550	366	2752	3550
			load	1440	1140	1873	202	1653	1873
			domContentLoaded	1439	1140	1873	202	1653	1873
			domInteractive	240	101	688	200	460	688
			firstPaint	-	-	-	-	-	-
			backgroundConnect	117	41	368	92	161	368
			firstReactRender	43	32	76	10	49	76
			getState	133	86	245	37	139	245
			initialActions	13	1	97	23	17	97
			loadScripts	1397	1109	1843	204	1572	1843
			setupStore	37	7	227	53	47	227
			numNetworkReqs	132	69	313	80	180	313
	Webpack	Standard Home	uiStartup	1628	1436	2136	152	1705	1981
			load	1380	1195	1702	114	1460	1606
			domContentLoaded	1380	1194	1702	114	1459	1605
			domInteractive	99	32	314	41	104	186
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	24	134	25	59	111
			firstReactRender	32	22	78	13	30	72
			getState	9	4	91	11	9	19
			initialActions	5	1	56	7	4	17
			loadScripts	1348	1178	1628	105	1417	1573
			setupStore	15	7	157	17	12	46
			numNetworkReqs	13	6	69	18	8	67
	Webpack	Power User Home	uiStartup	2590	2156	3696	486	2729	3696
			load	1511	1257	1946	230	1823	1946
			domContentLoaded	1510	1257	1946	230	1823	1946
			domInteractive	193	37	638	184	438	638
			firstPaint	-	-	-	-	-	-
			backgroundConnect	96	32	287	71	141	287
			firstReactRender	43	32	98	16	51	98
			getState	123	76	208	39	136	208
			initialActions	9	0	56	13	9	56
			loadScripts	1476	1237	1893	223	1782	1893
			setupStore	45	7	230	60	47	230
			numNetworkReqs	137	66	341	92	212	341

📊 Page Load Benchmark Results

Current Commit: 919feab | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±45ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 728ms (±64ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 79ms (±42ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	45ms	1.01s	1.37s	1.06s	1.37s
domContentLoaded	728ms	64ms	701ms	1.31s	742ms	1.31s
firstPaint	79ms	42ms	60ms	496ms	88ms	496ms
firstContentfulPaint	79ms	42ms	60ms	496ms	88ms	496ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 68 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 10 Bytes (0%)