feat: update swap transaction depending on user selection #37528
+415
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (10 files, +415 -164)
|
Collaborator
Builds ready [0355e59]
UI Startup Metrics (1206 ± 81 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [75538f8]
UI Startup Metrics (1211 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx
Show resolved
Hide resolved
Collaborator
Builds ready [c8fedc9]
UI Startup Metrics (1212 ± 80 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [b7ae186]
UI Startup Metrics (1254 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [933ebfb]
UI Startup Metrics (1240 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Nov 6, 2025
vinistevam
approved these changes
Nov 6, 2025
metamaskbot
added
the
release-13.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to select quoted swap.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6108
Manual testing steps
Screenshots/Recordings
TODO
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds swap selection on the confirmation screen to switch between dapp’s current swap and a MetaMask-quoted swap, updating txParams/batch via remote-flagged UI, with quote detection, metric fixes, tests, and minor styling.
ui/pages/.../dapp-swap-comparison-banner.tsx: Add "Current" vs "Save + Earn" selection; dispatchupdateTransactionto swap between original dapp tx and selected quote (txParams,batchTransactions,txParamsOriginal); auto-select MetaMask when it’s a quoted swap; gate with remote flagdappSwapUi.enabled/threshold; allow test origin; minor style token update inindex.scss.useSwapCheckto detect quoted swaps (diffstxParamsOriginalvstxParams).useDappSwapComparisonInfo: now returnsselectedQuote; reads fromtxParamsOriginalwhen present; refines quote timing; no-op safety tweaks; metric capture ordering updates.useDappSwapComparisonLatencyMetrics: fix quote request latency calculation.EditGasFeesRow: hide edit-gas button whenisQuotedSwapis true; tests added.DAPP_SWAP_SHIELD_ENABLEDfrombuilds.ymland test env.Written by Cursor Bugbot for commit 933ebfb. This will update automatically on new commits. Configure here.