fix: add missing metrics to import SRP flow and grouped Import SRP events #37567
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +12 -0)
👨🔧 @MetaMask/core-extension-ux (1 files, +5 -2)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [f4bc00e]
UI Startup Metrics (1286 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [65f1078]
UI Startup Metrics (1219 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
previously approved these changes
Nov 7, 2025
smgv
changed the title
Contributor
|
Not related to the metrics at all but I noticed the paste button is not working as expected. Manually pasting works though. Screen.Recording.2025-11-07.at.4.52.13.PM.mov |
Contributor
|
This is the sequence of events I see when I click on the import flow and then import and SRP.... Screen.Recording.2025-11-07.at.4.57.36.PM.movGiven that the event |
ui/components/multichain-accounts/add-wallet-modal/add-wallet-modal.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [aae863d]
UI Startup Metrics (1246 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bf83eb1]
UI Startup Metrics (1207 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
previously approved these changes
Nov 12, 2025
lwin-kyaw
reviewed
Nov 12, 2025
ui/components/multichain-accounts/add-wallet-modal/add-wallet-modal.tsx
Outdated
Show resolved
Hide resolved
lwin-kyaw
previously approved these changes
Nov 12, 2025
Collaborator
Builds ready [4a49e18]
UI Startup Metrics (1194 ± 82 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
smgv
changed the title
Collaborator
Builds ready [b1ce786]
UI Startup Metrics (1237 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [b1ca69d]
UI Startup Metrics (1210 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
chaitanyapotti
approved these changes
Nov 13, 2025
owencraston
approved these changes
Nov 13, 2025
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, added missing track event for SRP import: click event in Add Wallet modal and completion event with hd_entropy_index on import.
Metrics
Import Secret Recovery Phrase Clicked:
This event needs to be added
It should fire when the user clicks the import wallet button on the account list.
Import Secret Recovery Phrase Continue Button Clicked:
It should fire when the user finishes importing an SRP (they click continue)
Also we've enhanced our tracking by grouping the Import Secret Recovery Phrase event with specific status properties: 'started', 'continue_button_clicked', and 'completed', along with location data. This provides visibility into the full workflow timeline from initiation to completion.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-277
Segment Schema PR: https://github.com/Consensys/segment-schema/pull/367/files
Changelog
CHANGELOG entry: added missing metrics to import SRP flow
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Unifies SRP import tracking into a single event with start/continue/completed statuses and adds hd_entropy_index and discovered account counts on completion.
ImportSecretRecoveryPhraseClicked/CompletedintoImportSecretRecoveryPhrasewith status-based phases (started,continue_button_clicked,completed).app/scripts/metamask-controller.js):ImportSecretRecoveryPhrasewithhd_entropy_index,number_of_solana_accounts_discovered, andnumber_of_bitcoin_accounts_discovered.ui/components/multichain-accounts/add-wallet-modal/add-wallet-modal.tsx: TrackImportSecretRecoveryPhrasewithstatus: 'started'when selecting "Import a wallet" (location: Add Wallet Modal).ui/components/multichain/account-menu/account-menu.tsx: TrackImportSecretRecoveryPhrasewithstatus: 'started'when clicking SRP import (location: Account Menu).ui/pages/multi-srp/import-srp/import-srp.tsx: TrackImportSecretRecoveryPhrasewithstatus: 'continue_button_clicked'on continue (location: Multi SRP Import).Written by Cursor Bugbot for commit b1ca69d. This will update automatically on new commits. Configure here.