fix: stop reloading of animation & browser back option cp-13.9.0 #37581
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgv
added
area-onboarding
needs-qa
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (5 files, +37 -15)
|
Collaborator
Builds ready [9ed7994]
UI Startup Metrics (1217 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
added
QA Passed
and removed
needs-qa
|
|
||
| useEffect(() => { | ||
| setShowLoginOptions(Boolean(loginParam)); | ||
| }, [loginParam]); |
There was a problem hiding this comment.
Bug: State mismatch on browser back navigation restoring login options
When the user navigates back using the browser back button, the useEffect sets showLoginOptions based on the URL parameter but does not restore the loginOption state. This causes a state inconsistency where showLoginOptions is true but loginOption is null, which breaks the rendering condition at line 119 (showLoginOptions && loginOption). The component will show the wrong UI (the initial buttons instead of the login options) when the user navigates back, even though the URL parameter indicates login options should be shown. The useEffect should also set setLoginOption(loginParam as LoginOptionType) to properly restore the component state from the URL.
smgv
changed the title
smgv
changed the title
Collaborator
Builds ready [709317b]
UI Startup Metrics (1221 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
approved these changes
Nov 7, 2025
chaitanyapotti
changed the title
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have added the logic to stop the animation once completed. Also added a browser back logic for login options.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-278
Changelog
CHANGELOG entry: stopped reloading of animation once completed
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-11-06.at.8.16.37.PM.mov
Screen.Recording.2025-11-06.at.11.00.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Persists Rive animation completion to skip replays, switches welcome flow to context-based skipping, and syncs login option visibility via the
?loginquery param; updates navigation and tests.animationCompletedmap andsetIsAnimationCompletedtoRiveWasmContext(ui/contexts/rive-wasm/index.tsx).MetamaskWordMarkAnimationsets completion on unmount and consumes the new setter; updates effect deps (ui/pages/onboarding-flow/welcome/metamask-wordmark-animation.tsx).welcomeusesanimationCompleted.MetamaskWordMarkAnimationto decideshouldSkipAnimation(replaces URL-based check) (ui/pages/onboarding-flow/welcome/welcome.js).WelcomeLoginreads?login=to control option view and writes it on selection vianavigate(ui/pages/onboarding-flow/welcome/welcome-login.tsx).AccountExistreturns toONBOARDING_WELCOME_ROUTEwithout?from=...; tests updated accordingly (ui/pages/onboarding-flow/account-exist/*).Written by Cursor Bugbot for commit 709317b. This will update automatically on new commits. Configure here.