fix: Consider client active once it is open and unlocked #37607

FrederikBolding · 2025-11-07T09:27:28Z

Description

We recently changed it so onActive fires once the client has been unlocked. This PR adjusts the hook that provides the active flag to the same behavior.

Changelog

CHANGELOG entry: null

Note

Updates client activity to require both UI open and wallet unlocked, and adjusts Snap client-status E2E test expectations.

Snaps / Controller:
- Update getIsActive in app/scripts/metamask-controller.js to return this._isClientOpen && isUnlocked (was only this._isClientOpen).
Tests:
- Adjust test/e2e/snaps/test-snap-clientstatus.spec.ts to expect active: false when locked: true.

^{Written by Cursor Bugbot for commit 29c0bf4. This will update automatically on new commits. Configure here.}

app/scripts/metamask-controller.js

metamaskbot · 2025-11-07T09:51:50Z

Builds ready [07d9fc5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1228 ± 103 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1228	1066	1712	103	1282	1424
			load	1059	926	1489	98	1126	1233
			domContentLoaded	1053	921	1482	97	1119	1227
			domInteractive	21	13	94	14	18	57
			firstPaint	665	87	1495	431	1065	1194
			backgroundConnect	228	215	272	8	231	241
			firstReactRender	26	17	54	7	28	41
			getState	22	8	73	11	26	48
			initialActions	0	0	1	0	0	1
			loadScripts	831	701	1262	97	902	1011
			setupStore	11	7	28	3	12	17
			numNetworkReqs	13	6	75	20	6	73
	Browserify	Power User Home	uiStartup	1953	1732	2499	206	2049	2499
			load	1043	902	1389	171	1264	1389
			domContentLoaded	1035	894	1377	170	1258	1377
			domInteractive	31	16	84	23	57	84
			firstPaint	691	96	1351	445	960	1351
			backgroundConnect	240	224	262	10	243	262
			firstReactRender	29	26	38	3	31	38
			getState	182	158	216	19	200	216
			initialActions	0	0	1	0	1	1
			loadScripts	806	676	1147	167	1028	1147
			setupStore	14	10	29	7	13	29
			numNetworkReqs	118	73	250	59	157	250
	Webpack	Standard Home	uiStartup	826	701	1174	86	832	1057
			load	607	559	925	76	602	837
			domContentLoaded	599	549	909	73	595	810
			domInteractive	15	12	47	8	14	38
			firstPaint	190	58	907	185	171	696
			backgroundConnect	25	12	74	15	28	65
			firstReactRender	29	17	59	8	33	37
			getState	11	5	29	3	12	16
			initialActions	0	0	1	0	0	1
			loadScripts	596	547	899	70	592	800
			setupStore	11	5	29	5	12	27
			numNetworkReqs	14	6	78	20	8	73
	Webpack	Power User Home	uiStartup	1284	1149	1895	222	1332	1895
			load	654	572	945	127	732	945
			domContentLoaded	637	561	927	119	696	927
			domInteractive	23	13	68	17	39	68
			firstPaint	295	67	895	262	572	895
			backgroundConnect	57	10	248	70	80	248
			firstReactRender	27	24	29	2	28	29
			getState	141	100	156	19	152	156
			initialActions	0	0	1	0	1	1
			loadScripts	633	559	916	116	686	916
			setupStore	17	6	28	9	27	28
			numNetworkReqs	111	72	229	47	165	229
Firefox	Browserify	Standard Home	uiStartup	1428	1278	2022	125	1478	1690
			load	1217	1100	1558	83	1261	1377
			domContentLoaded	1216	1100	1557	83	1261	1376
			domInteractive	98	36	197	29	111	150
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	25	172	23	50	89
			firstReactRender	24	20	45	4	25	38
			getState	7	4	35	4	7	17
			initialActions	0	0	1	0	0	1
			loadScripts	1190	1078	1450	77	1232	1346
			setupStore	14	8	75	9	14	29
			numNetworkReqs	14	6	78	20	7	75
	Browserify	Power User Home	uiStartup	2370	2091	2748	224	2563	2748
			load	1354	1170	1737	170	1511	1737
			domContentLoaded	1353	1170	1736	170	1510	1736
			domInteractive	211	92	652	186	340	652
			firstPaint	-	-	-	-	-	-
			backgroundConnect	112	31	411	113	130	411
			firstReactRender	45	31	81	14	52	81
			getState	111	64	155	26	130	155
			initialActions	0	0	1	0	1	1
			loadScripts	1316	1129	1657	159	1430	1657
			setupStore	23	5	101	24	27	101
			numNetworkReqs	134	71	212	59	194	212
	Webpack	Standard Home	uiStartup	1627	1430	2479	198	1643	2153
			load	1378	1208	1768	107	1412	1615
			domContentLoaded	1378	1207	1768	107	1411	1614
			domInteractive	104	35	365	45	115	169
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	22	239	36	50	142
			firstReactRender	29	20	82	10	30	41
			getState	10	3	191	21	8	34
			initialActions	0	0	2	0	0	1
			loadScripts	1350	1184	1741	98	1390	1572
			setupStore	19	7	241	34	14	70
			numNetworkReqs	13	6	70	18	7	68
	Webpack	Power User Home	uiStartup	2599	2169	3285	375	3026	3285
			load	1549	1284	1884	205	1809	1884
			domContentLoaded	1548	1284	1884	205	1808	1884
			domInteractive	197	39	585	160	371	585
			firstPaint	-	-	-	-	-	-
			backgroundConnect	106	30	398	97	171	398
			firstReactRender	40	31	50	6	47	50
			getState	120	86	192	27	124	192
			initialActions	0	0	1	0	1	1
			loadScripts	1513	1256	1853	197	1762	1853
			setupStore	59	6	318	86	113	318
			numNetworkReqs	135	70	315	86	234	315

📊 Page Load Benchmark Results

Current Commit: 07d9fc5 | Date: 11/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±35ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	38ms	1.02s	1.33s	1.07s	1.33s
domContentLoaded	730ms	35ms	707ms	988ms	742ms	988ms
firstPaint	79ms	12ms	64ms	180ms	88ms	180ms
firstContentfulPaint	79ms	12ms	64ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 150 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

metamaskbot · 2025-11-07T10:03:33Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +1 -1)

📁 test/
- 📁 e2e/
  - 📁 snaps/
    - 📄 test-snap-clientstatus.spec.ts +1 -1

metamaskbot · 2025-11-07T10:26:48Z

Builds ready [29c0bf4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1204 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1204	1054	1438	90	1257	1363
			load	1039	864	1270	87	1091	1202
			domContentLoaded	1030	857	1264	89	1086	1194
			domInteractive	20	14	79	13	18	58
			firstPaint	671	145	1270	407	1058	1203
			backgroundConnect	229	214	326	15	230	248
			firstReactRender	25	17	87	8	27	34
			getState	20	6	66	10	25	36
			initialActions	0	0	1	0	0	1
			loadScripts	810	639	1026	88	865	971
			setupStore	11	6	77	7	11	17
			numNetworkReqs	13	6	74	19	6	73
	Browserify	Power User Home	uiStartup	1913	1736	2434	229	2092	2434
			load	1021	900	1382	177	1282	1382
			domContentLoaded	1012	889	1362	174	1277	1362
			domInteractive	27	15	64	18	52	64
			firstPaint	799	227	1371	389	953	1371
			backgroundConnect	240	224	267	12	253	267
			firstReactRender	26	24	31	2	27	31
			getState	178	152	216	20	200	216
			initialActions	0	0	1	0	1	1
			loadScripts	786	670	1112	168	1045	1112
			setupStore	11	9	15	2	12	15
			numNetworkReqs	120	76	250	65	181	250
	Webpack	Standard Home	uiStartup	851	710	1407	123	847	1168
			load	621	556	1187	107	605	926
			domContentLoaded	614	551	1174	103	598	901
			domInteractive	17	11	83	12	14	48
			firstPaint	219	56	1178	237	187	898
			backgroundConnect	25	11	80	14	25	59
			firstReactRender	29	17	72	9	34	38
			getState	11	6	25	3	13	17
			initialActions	0	0	2	0	0	1
			loadScripts	611	549	1163	101	596	891
			setupStore	11	6	38	4	12	18
			numNetworkReqs	13	6	73	19	8	71
	Webpack	Power User Home	uiStartup	1231	1124	1646	147	1261	1646
			load	644	569	944	121	778	944
			domContentLoaded	624	556	912	109	742	912
			domInteractive	22	12	56	15	38	56
			firstPaint	435	67	920	278	578	920
			backgroundConnect	71	9	320	83	87	320
			firstReactRender	25	24	27	1	26	27
			getState	137	95	156	20	149	156
			initialActions	0	0	1	0	1	1
			loadScripts	620	554	902	106	732	902
			setupStore	11	6	38	8	10	38
			numNetworkReqs	108	70	166	39	165	166
Firefox	Browserify	Standard Home	uiStartup	1425	1247	1733	107	1469	1644
			load	1215	1078	1435	85	1273	1391
			domContentLoaded	1215	1078	1435	85	1272	1391
			domInteractive	116	34	423	58	121	245
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	24	104	13	46	64
			firstReactRender	24	20	40	3	26	28
			getState	7	4	22	3	7	14
			initialActions	0	0	2	0	0	1
			loadScripts	1192	1062	1408	84	1250	1356
			setupStore	13	6	70	10	13	32
			numNetworkReqs	12	6	61	15	7	56
	Browserify	Power User Home	uiStartup	2646	2092	4318	519	2880	4318
			load	1509	1141	1992	244	1657	1992
			domContentLoaded	1509	1141	1991	244	1656	1991
			domInteractive	218	83	581	177	438	581
			firstPaint	-	-	-	-	-	-
			backgroundConnect	141	27	590	150	143	590
			firstReactRender	46	33	78	12	53	78
			getState	133	71	252	41	165	252
			initialActions	1	0	5	1	1	5
			loadScripts	1463	1121	1948	223	1627	1948
			setupStore	29	6	98	29	42	98
			numNetworkReqs	134	73	324	76	200	324
	Webpack	Standard Home	uiStartup	1617	1399	1982	135	1668	1940
			load	1383	1222	1703	106	1425	1621
			domContentLoaded	1383	1222	1703	106	1425	1620
			domInteractive	100	34	372	41	112	152
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	22	142	23	54	115
			firstReactRender	31	23	77	12	31	70
			getState	9	4	145	15	8	20
			initialActions	0	0	1	0	0	1
			loadScripts	1352	1204	1666	98	1392	1536
			setupStore	15	7	67	12	13	45
			numNetworkReqs	13	6	70	17	8	65
	Webpack	Power User Home	uiStartup	2399	2129	2921	225	2614	2921
			load	1485	1267	1868	184	1665	1868
			domContentLoaded	1484	1266	1868	184	1663	1868
			domInteractive	129	41	434	105	201	434
			firstPaint	-	-	-	-	-	-
			backgroundConnect	86	30	332	88	88	332
			firstReactRender	47	31	91	18	48	91
			getState	118	66	215	35	142	215
			initialActions	1	0	1	1	1	1
			loadScripts	1455	1247	1824	176	1627	1824
			setupStore	34	8	155	42	33	155
			numNetworkReqs	130	63	272	63	189	272

📊 Page Load Benchmark Results

Current Commit: 29c0bf4 | Date: 11/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 717ms (±39ms) 🟢 | historical mean value: 716ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	42ms	1.01s	1.35s	1.06s	1.35s
domContentLoaded	717ms	39ms	697ms	1.02s	744ms	1.02s
firstPaint	76ms	15ms	60ms	216ms	88ms	216ms
firstContentfulPaint	76ms	15ms	60ms	216ms	88ms	216ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 150 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

fix: Consider client active once it is open and unlocked

07d9fc5

metamaskbot added team-core-platform Core Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 7, 2025

cursor bot reviewed Nov 7, 2025

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

github-actions bot added the size-XS label Nov 7, 2025

Mrtenz previously approved these changes Nov 7, 2025

View reviewed changes

Tweak E2E

29c0bf4

FrederikBolding dismissed Mrtenz’s stale review via 29c0bf4 November 7, 2025 10:02

FrederikBolding requested a review from a team as a code owner November 7, 2025 10:02

FrederikBolding requested a review from Mrtenz November 7, 2025 10:03

Mrtenz approved these changes Nov 7, 2025

View reviewed changes

GuillaumeRx approved these changes Nov 7, 2025

View reviewed changes

FrederikBolding enabled auto-merge November 7, 2025 10:13

FrederikBolding added this pull request to the merge queue Nov 7, 2025

Merged via the queue into main with commit f581837 Nov 7, 2025
349 of 375 checks passed

FrederikBolding deleted the fb/is-active-includes-unlocked branch November 7, 2025 11:15

github-actions bot locked and limited conversation to collaborators Nov 7, 2025

metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Consider client active once it is open and unlocked #37607

fix: Consider client active once it is open and unlocked #37607

FrederikBolding commented Nov 7, 2025 •

edited by cursor bot

Loading

Uh oh!

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 7, 2025

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: Consider client active once it is open and unlocked #37607

fix: Consider client active once it is open and unlocked #37607

Conversation

FrederikBolding commented Nov 7, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Uh oh!

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 7, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Nov 7, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FrederikBolding commented Nov 7, 2025 •

edited by cursor bot

Loading