-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: removed unused error calls from sentry cp-13.9.0 #37649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [1f9a476]
UI Startup Metrics (1152 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm QA
lwin-kyaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM!
Description
In this PR, Downgrades Rive file load errors to warnings and removes redundant error logging in social backup restore, adding a new @rive-app/canvas patch reference.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Downgrades Rive file load errors to warnings and removes redundant error logging in social backup restore, adding a new @rive-app/canvas patch reference.
rive.jsby commenting outfireLoadError/throwpaths and usingconsole.warn; add early return when missing source.log.errorlines inrestoreSocialBackupAndGetSeedPhrase(background and UI) to reduce noisy reports.@rive-app-canvas-patch-03752f0c3b.patchand updatepackage.json/yarn.lockto chain patches for@rive-app/canvas@2.31.5.Written by Cursor Bugbot for commit 1f9a476. This will update automatically on new commits. Configure here.