Skip to content

Conversation

@smgv
Copy link
Contributor

@smgv smgv commented Nov 10, 2025

Description

In this PR, Downgrades Rive file load errors to warnings and removes redundant error logging in social backup restore, adding a new @rive-app/canvas patch reference.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Downgrades Rive file load errors to warnings and removes redundant error logging in social backup restore, adding a new @rive-app/canvas patch reference.

  • Animations (@rive-app/canvas patch):
    • Suppress hard failures in rive.js by commenting out fireLoadError/throw paths and using console.warn; add early return when missing source.
  • Error Logging:
    • Remove log.error lines in restoreSocialBackupAndGetSeedPhrase (background and UI) to reduce noisy reports.
  • Dependencies:
    • Add new yarn patch @rive-app-canvas-patch-03752f0c3b.patch and update package.json/yarn.lock to chain patches for @rive-app/canvas@2.31.5.

Written by Cursor Bugbot for commit 1f9a476. This will update automatically on new commits. Configure here.

@smgv smgv self-assigned this Nov 10, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@smgv smgv linked an issue Nov 10, 2025 that may be closed by this pull request
9 tasks
@metamaskbot metamaskbot added the team-onboarding Onboarding team label Nov 10, 2025
@smgv smgv changed the title fix: removed unused error calls from sentry fix: removed unused error calls from sentry cp-13.9.0 Nov 10, 2025
@smgv smgv requested a review from LeVinhGithub November 10, 2025 10:04
@smgv smgv added the needs-qa Label will automate into QA workspace label Nov 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [1f9a476]
UI Startup Metrics (1152 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1152999149010012041382
load98584412598910381172
domContentLoaded97883912438810301165
domInteractive201496131855
firstPaint61214412513799731120
backgroundConnect1891732429194207
firstReactRender22174242432
getState1875382232
initialActions001001
loadScripts795668105285854978
setupStore1061921013
numNetworkReqs1367620674
BrowserifyPower User HomeuiStartup18931517236722822022367
load1032907147017712751470
domContentLoaded1022900145917512501459
domInteractive271562175362
firstPaint5879712954139491295
backgroundConnect2332222527235252
firstReactRender28243732937
getState17515720013188200
initialActions001011
loadScripts799677122617410331226
setupStore1191311113
numNetworkReqs1207425268171252
WebpackStandard HomeuiStartup8477191325978531103
load617569112489608884
domContentLoaded610561111186599863
domInteractive16126191444
firstPaint205591114203202626
backgroundConnect261172133160
firstReactRender3218215213554
getState1163441317
initialActions001001
loadScripts607558110084597853
setupStore1262941319
numNetworkReqs1367719870
WebpackPower User HomeuiStartup12721127190121714611901
load67256110391648431039
domContentLoaded652551987149819987
domInteractive231365174365
firstPaint37479992289577992
backgroundConnect57171986275198
firstReactRender25232712727
getState1389016022151160
initialActions001001
loadScripts648549977146808977
setupStore1362682526
numNetworkReqs1086616840164168
FirefoxBrowserifyStandard HomeuiStartup14561270199112015191700
load1235110515068312811379
domContentLoaded1235110515068312801378
domInteractive1053434047111213
firstPaint------
backgroundConnect4325103175083
firstReactRender25214242632
getState8310912716
initialActions001001
loadScripts1211108614858012531362
setupStore166207281430
numNetworkReqs1266615756
BrowserifyPower User HomeuiStartup23702112302626625573026
load13391144186021915151860
domContentLoaded13391144186021915151860
domInteractive18084502147367502
firstPaint------
backgroundConnect10828328102225328
firstReactRender442988134888
getState1197019334152193
initialActions101011
loadScripts13021126183521514741835
setupStore24684243384
numNetworkReqs1336923864208238
WebpackStandard HomeuiStartup16031423214815016261970
load13701194171811214021632
domContentLoaded13701193171711214021631
domInteractive1023034346109179
firstPaint------
backgroundConnect50222143054128
firstReactRender292285102940
getState9419119715
initialActions001001
loadScripts13371172168110213651559
setupStore14780101333
numNetworkReqs1266816762
WebpackPower User HomeuiStartup25942224359841327473598
load15161296202919917342029
domContentLoaded15151296202919917332029
domInteractive16572457129314457
firstPaint------
backgroundConnect983136189101361
firstReactRender46346495564
getState1329427542152275
initialActions106116
loadScripts14811273197419617041974
setupStore3261394052139
numNetworkReqs1316831391234313
📊 Page Load Benchmark Results

Current Commit: 1f9a476 | Date: 11/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±74ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 740ms (±71ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 74ms 1.02s 1.39s 1.27s 1.39s
domContentLoaded 740ms 71ms 703ms 1.04s 949ms 1.04s
firstPaint 77ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -7 Bytes (0%)
  • ui: -15 Bytes (0%)
  • common: 70 Bytes (0%)

@LeVinhGithub LeVinhGithub added QA Passed and removed needs-qa Label will automate into QA workspace labels Nov 10, 2025
Copy link
Contributor

@LeVinhGithub LeVinhGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm QA

Copy link
Contributor

@lwin-kyaw lwin-kyaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 7686502 Nov 10, 2025
192 of 202 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/removing-unused-errors branch November 10, 2025 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
@metamaskbot metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed release-13.10.0 Issue or pull request that will be included in release 13.10.0 size-S team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mitigate the Unhandled Exceptions (and error logs)

6 participants