Skip to content

Conversation

@aganglada
Copy link
Contributor

@aganglada aganglada commented Nov 10, 2025

Description

Upgrading bitcoin to 1.4.5

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: #37616

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrade @metamask/bitcoin-wallet-snap from 1.4.4 to 1.4.5 in package.json and yarn.lock.

Written by Cursor Bugbot for commit 9bb76cf. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aganglada aganglada changed the title chore: bump bitcoin 1.4.5 chore: cp-13.9.0 bump bitcoin 1.4.5 Nov 10, 2025
@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Nov 10, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.4.4 ⏵ 1.4.5100 +110083 +197 +1100

View full report

@aganglada aganglada enabled auto-merge November 10, 2025 12:09
@metamaskbot
Copy link
Collaborator

Builds ready [9bb76cf]
UI Startup Metrics (1219 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1219106316339412721392
load104989213488511041203
domContentLoaded104288213398410961189
domInteractive2214109181966
firstPaint637143124041710461216
backgroundConnect2282152567231242
firstReactRender2417141132439
getState1977692231
initialActions001001
loadScripts820658110883875962
setupStore1072531119
numNetworkReqs1367419671
BrowserifyPower User HomeuiStartup19321709272528822442725
load1035893155819912641558
domContentLoaded1028883155119912531551
domInteractive281572205372
firstPaint54985954340921954
backgroundConnect24022428319239283
firstReactRender28253532835
getState18115421516193215
initialActions001011
loadScripts798666127318910271273
setupStore12102131121
numNetworkReqs1187324771228247
WebpackStandard HomeuiStartup95879514141169711228
load674616113592666939
domContentLoaded665608110887657917
domInteractive201395151755
firstPaint208681112218176798
backgroundConnect341496174167
firstReactRender3920442424050
getState1373441522
initialActions001001
loadScripts661605109784655906
setupStore1574861624
numNetworkReqs1367519870
WebpackPower User HomeuiStartup12481145146210513181462
load643564877104758877
domContentLoaded62855584196745841
domInteractive231361163761
firstPaint26062805209357805
backgroundConnect511018156101181
firstReactRender27233432834
getState1367417728150177
initialActions001011
loadScripts62455383093734830
setupStore1262682426
numNetworkReqs1086917039161170
FirefoxBrowserifyStandard HomeuiStartup14511251173110915111661
load1233107314598912861412
domContentLoaded1232107214588912861412
domInteractive1053531449110213
firstPaint------
backgroundConnect4224138184976
firstReactRender26206672642
getState84849815
initialActions001001
loadScripts1207105614188612591375
setupStore1375281432
numNetworkReqs1266616759
BrowserifyPower User HomeuiStartup25222181315825627103158
load14671149194726718791947
domContentLoaded14661149194626718781946
domInteractive18874567157369567
firstPaint------
backgroundConnect1082933386159333
firstReactRender463369115669
getState1188118630136186
initialActions102112
loadScripts14181128188323716661883
setupStore18644133044
numNetworkReqs1346930171202301
WebpackStandard HomeuiStartup15991402205813316361900
load1363118516599914141577
domContentLoaded1363118516599914141577
domInteractive953833839106160
firstPaint------
backgroundConnect49251282454112
firstReactRender29228783139
getState10415118723
initialActions002001
loadScripts1331115916209113791516
setupStore17788171573
numNetworkReqs1367017765
WebpackPower User HomeuiStartup25152184365936527593659
load14911263190021516771900
domContentLoaded14901263189921516771899
domInteractive16667546157283546
firstPaint------
backgroundConnect10629404107129404
firstReactRender473599144799
getState1248319834147198
initialActions101011
loadScripts14541242184419916491844
setupStore4162506660250
numNetworkReqs1295624969215249
📊 Page Load Benchmark Results

Current Commit: 9bb76cf | Date: 11/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±69ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 72ms 1.01s 1.33s 1.27s 1.33s
domContentLoaded 734ms 69ms 697ms 1.00s 936ms 1.00s
firstPaint 77ms 14ms 60ms 196ms 88ms 196ms
firstContentfulPaint 77ms 14ms 60ms 196ms 88ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -7 Bytes (0%)
  • ui: -68 Bytes (0%)
  • common: 70 Bytes (0%)

@aganglada aganglada added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 031dda4 Nov 10, 2025
186 of 193 checks passed
@aganglada aganglada deleted the feat/bump-bitcoin-1-4-5 branch November 10, 2025 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
@metamaskbot metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.10.0 Issue or pull request that will be included in release 13.10.0 size-XS team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Infinite spinner on send flow when sending very low BTC

5 participants