fix: hide account menu in dapp connection flow #37704

fabiobozzo · 2025-11-11T12:31:17Z

Description

Fixes a bug where clicking the account details menu (3 dots) in the Connect to dapp screen does nothing. The menu should not be displayed in this flow since users are selecting accounts via checkboxes, not accessing account details.

Changes:

Hide the account menu (MultichainAccountMenu) in MultichainAccountList when in account selection mode (showAccountCheckbox is true)
Added test coverage to verify the menu is properly hidden during account selection

Changelog

CHANGELOG entry: Fixed account details menu appearing in dapp connection account selection

Related issues

Fixes: #37604

Manual testing steps

Go to the test dapp (https://metamask.github.io/test-dapp/)
Click "Connect" button
Click "Edit Accounts" in the connection modal
Verify that the 3 dots menu is NOT visible next to each account
Close the edit accounts modal
Open the main account menu from the extension
Verify that the 3 dots menu IS visible in the normal account list

Screenshots/Recordings

Before

Account menu (3 dots) was visible but non-functional in the edit accounts flow during dapp connection (see bug).

After

Account menu (3 dots) is now hidden in the edit accounts flow, only checkboxes are shown for account selection:

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Hide the per-account menu when showAccountCheckbox is true in MultichainAccountList, with tests verifying the menu is not rendered.

Frontend
- ui/components/multichain-accounts/multichain-account-list/multichain-account-list.tsx:
  - Conditionally render MultichainAccountMenu only when showAccountCheckbox is false (showAccountMenu = !showAccountCheckbox).
Tests
- multichain-account-list.test.tsx:
  - Add test to assert the 3-dots account menu is hidden when showAccountCheckbox is true.

^{Written by Cursor Bugbot for commit 40b264c. This will update automatically on new commits. Configure here.}

Added a test to verify that the account menu (three dots) is hidden when the `showAccountCheckbox` prop is set to true in the `MultichainAccountList` component. Updated the component logic to conditionally render the account menu based on this prop.

github-actions · 2025-11-11T12:31:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-11-11T12:31:54Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +35 -7)

📁 ui/
- 📁 components/
  - 📁 multichain-accounts/
    - 📁 multichain-account-list/
      - 📄 multichain-account-list.test.tsx +24 -0
      - 📄 multichain-account-list.tsx +11 -7

metamaskbot · 2025-11-11T12:55:07Z

Builds ready [b93d88b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1217	1071	1633	86	1265	1373
			load	1047	889	1372	80	1103	1177
			domContentLoaded	1040	885	1365	80	1098	1161
			domInteractive	21	13	93	15	17	59
			firstPaint	598	82	1201	420	1057	1170
			backgroundConnect	230	216	322	12	233	243
			firstReactRender	27	17	121	11	30	40
			getState	22	8	52	9	28	39
			initialActions	0	0	1	0	0	1
			loadScripts	817	664	1129	80	872	941
			setupStore	12	5	34	6	13	25
			numNetworkReqs	13	6	76	19	6	71
	Browserify	Power User Home	uiStartup	1773	1577	2226	200	1926	2226
			load	938	785	1318	172	1170	1318
			domContentLoaded	930	778	1309	171	1164	1309
			domInteractive	25	15	58	14	39	58
			firstPaint	699	167	1232	343	867	1232
			backgroundConnect	193	176	226	13	201	226
			firstReactRender	27	22	35	3	31	35
			getState	158	139	182	14	169	182
			initialActions	1	0	1	0	1	1
			loadScripts	747	615	1109	161	971	1109
			setupStore	12	9	26	5	11	26
			numNetworkReqs	153	73	298	82	246	298
	Webpack	Standard Home	uiStartup	840	714	1215	93	857	1105
			load	614	559	1005	82	610	866
			domContentLoaded	607	554	974	78	604	851
			domInteractive	16	12	67	9	14	37
			firstPaint	205	59	1006	200	201	597
			backgroundConnect	24	12	71	13	24	60
			firstReactRender	30	18	70	10	34	53
			getState	12	6	18	3	14	16
			initialActions	0	0	1	0	0	1
			loadScripts	604	552	963	76	602	841
			setupStore	12	6	42	5	14	19
			numNetworkReqs	13	6	78	19	8	70
	Webpack	Power User Home	uiStartup	1277	1152	1638	144	1429	1638
			load	676	569	1032	161	703	1032
			domContentLoaded	661	560	1007	155	691	1007
			domInteractive	37	13	165	45	65	165
			firstPaint	422	68	1010	335	694	1010
			backgroundConnect	39	17	128	30	55	128
			firstReactRender	27	26	32	1	28	32
			getState	139	98	159	20	151	159
			initialActions	0	0	1	0	0	1
			loadScripts	657	557	997	152	681	997
			setupStore	13	7	27	8	25	27
			numNetworkReqs	107	70	209	46	165	209
Firefox	Browserify	Standard Home	uiStartup	1488	1275	1840	128	1572	1770
			load	1260	1094	1508	93	1336	1423
			domContentLoaded	1260	1094	1507	93	1335	1422
			domInteractive	107	35	377	48	115	196
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	25	105	13	51	65
			firstReactRender	26	21	59	6	27	40
			getState	9	4	67	9	8	17
			initialActions	0	0	1	0	0	1
			loadScripts	1234	1076	1480	91	1313	1387
			setupStore	15	7	122	15	13	34
			numNetworkReqs	12	6	66	16	7	59
	Browserify	Power User Home	uiStartup	2314	2064	3032	257	2317	3032
			load	1306	1108	1646	169	1440	1646
			domContentLoaded	1306	1108	1646	169	1439	1646
			domInteractive	188	73	599	173	304	599
			firstPaint	-	-	-	-	-	-
			backgroundConnect	87	26	333	82	95	333
			firstReactRender	44	30	79	14	47	79
			getState	123	65	180	33	159	180
			initialActions	1	0	6	1	1	6
			loadScripts	1271	1092	1586	153	1395	1586
			setupStore	20	5	85	21	31	85
			numNetworkReqs	134	69	324	86	204	324
	Webpack	Standard Home	uiStartup	1534	1367	2104	145	1540	1879
			load	1318	1171	1719	103	1334	1562
			domContentLoaded	1318	1170	1719	103	1334	1562
			domInteractive	93	30	430	43	103	144
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	174	23	47	101
			firstReactRender	29	20	76	11	28	66
			getState	9	4	147	16	7	23
			initialActions	0	0	1	0	0	1
			loadScripts	1290	1155	1699	94	1315	1501
			setupStore	15	5	209	22	12	44
			numNetworkReqs	13	6	73	18	7	67
	Webpack	Power User Home	uiStartup	2561	2155	3966	546	2797	3966
			load	1483	1232	1952	228	1557	1952
			domContentLoaded	1483	1232	1951	228	1557	1951
			domInteractive	209	69	706	215	315	706
			firstPaint	-	-	-	-	-	-
			backgroundConnect	91	30	347	88	107	347
			firstReactRender	51	29	128	25	52	128
			getState	118	80	181	30	159	181
			initialActions	1	0	5	1	1	5
			loadScripts	1452	1214	1910	222	1527	1910
			setupStore	42	6	219	66	48	219
			numNetworkReqs	136	65	337	103	278	337

📊 Page Load Benchmark Results

Current Commit: b93d88b | Date: 11/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±60ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±126ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.01s	1.37s	1.06s	1.37s
domContentLoaded	730ms	60ms	696ms	1.28s	742ms	1.28s
firstPaint	90ms	126ms	64ms	1.34s	88ms	1.34s
firstContentfulPaint	90ms	126ms	64ms	1.34s	88ms	1.34s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 12 Bytes (0%)
common: 10 Bytes (0%)

ui/components/multichain-accounts/multichain-account-list/multichain-account-list.tsx

metamaskbot · 2025-11-12T11:35:42Z

Builds ready [40b264c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1220	1063	1616	93	1278	1371
			load	1055	882	1377	87	1111	1193
			domContentLoaded	1048	876	1353	86	1104	1189
			domInteractive	23	15	98	16	18	65
			firstPaint	644	92	1363	420	1033	1190
			backgroundConnect	232	218	257	7	235	245
			firstReactRender	27	18	123	11	30	42
			getState	22	9	55	10	27	42
			initialActions	0	0	1	0	0	1
			loadScripts	823	652	1115	85	879	964
			setupStore	11	7	28	4	13	21
			numNetworkReqs	13	6	74	19	6	72
	Browserify	Power User Home	uiStartup	1642	1466	2239	236	1933	2239
			load	1037	906	1396	186	1323	1396
			domContentLoaded	1028	898	1368	183	1318	1368
			domInteractive	37	15	107	33	81	107
			firstPaint	799	156	1405	411	952	1405
			backgroundConnect	238	226	263	11	244	263
			firstReactRender	28	24	33	2	28	33
			getState	173	151	221	17	179	221
			initialActions	0	0	1	0	0	1
			loadScripts	800	671	1136	179	1087	1136
			setupStore	11	9	24	3	12	24
			numNetworkReqs	120	73	260	75	243	260
	Webpack	Standard Home	uiStartup	853	710	1233	100	865	1122
			load	626	567	1004	86	622	890
			domContentLoaded	619	561	983	82	613	868
			domInteractive	18	11	126	16	14	52
			firstPaint	198	60	986	207	189	836
			backgroundConnect	25	10	65	13	29	56
			firstReactRender	30	18	62	8	35	38
			getState	12	7	30	3	14	17
			initialActions	0	0	1	0	0	1
			loadScripts	616	559	973	80	610	857
			setupStore	12	6	35	5	14	20
			numNetworkReqs	13	6	75	20	8	72
	Webpack	Power User Home	uiStartup	1034	859	1684	245	1260	1684
			load	630	571	822	83	728	822
			domContentLoaded	614	561	784	72	700	784
			domInteractive	31	13	86	28	72	86
			firstPaint	306	63	787	224	568	787
			backgroundConnect	59	9	187	64	139	187
			firstReactRender	28	23	46	5	28	46
			getState	137	95	159	23	152	159
			initialActions	0	0	1	0	1	1
			loadScripts	610	559	774	68	690	774
			setupStore	12	6	25	8	24	25
			numNetworkReqs	110	65	227	55	164	227
Firefox	Browserify	Standard Home	uiStartup	1537	1323	1985	141	1580	1862
			load	1286	1133	1553	92	1344	1500
			domContentLoaded	1286	1132	1553	92	1344	1500
			domInteractive	109	35	320	54	110	253
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	26	180	21	50	73
			firstReactRender	29	21	61	8	30	49
			getState	13	8	98	12	13	20
			initialActions	0	0	2	0	0	1
			loadScripts	1259	1112	1515	87	1307	1446
			setupStore	16	7	127	18	15	35
			numNetworkReqs	12	6	67	16	7	62
	Browserify	Power User Home	uiStartup	2252	1909	3386	479	2443	3386
			load	1426	1200	1880	221	1747	1880
			domContentLoaded	1426	1200	1880	221	1747	1880
			domInteractive	205	71	567	174	439	567
			firstPaint	-	-	-	-	-	-
			backgroundConnect	100	36	293	81	145	293
			firstReactRender	49	30	90	14	56	90
			getState	138	66	214	38	180	214
			initialActions	1	0	2	1	1	2
			loadScripts	1386	1177	1833	216	1711	1833
			setupStore	39	8	140	39	57	140
			numNetworkReqs	149	68	314	82	208	314
	Webpack	Standard Home	uiStartup	1590	1387	2140	140	1608	1890
			load	1358	1216	1749	99	1386	1584
			domContentLoaded	1358	1216	1749	99	1386	1584
			domInteractive	94	32	186	29	108	150
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	24	241	27	47	108
			firstReactRender	33	24	80	11	33	72
			getState	13	7	144	16	11	42
			initialActions	0	0	1	0	0	1
			loadScripts	1332	1194	1721	90	1364	1538
			setupStore	16	6	72	13	14	48
			numNetworkReqs	13	6	67	18	7	65
	Webpack	Power User Home	uiStartup	2333	1896	3438	509	2994	3438
			load	1529	1298	1941	225	1849	1941
			domContentLoaded	1528	1297	1940	225	1849	1940
			domInteractive	183	40	522	163	360	522
			firstPaint	-	-	-	-	-	-
			backgroundConnect	90	32	281	65	102	281
			firstReactRender	53	33	104	19	60	104
			getState	123	95	232	32	127	232
			initialActions	3	0	34	8	1	34
			loadScripts	1496	1270	1908	221	1815	1908
			setupStore	35	5	217	53	43	217
			numNetworkReqs	135	66	331	102	238	331

📊 Page Load Benchmark Results

Current Commit: 40b264c | Date: 11/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 726ms (±60ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±42ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	726ms	60ms	699ms	1.28s	746ms	1.28s
firstPaint	80ms	42ms	60ms	492ms	84ms	492ms
firstContentfulPaint	80ms	42ms	60ms	492ms	84ms	492ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 3.19 KiB (0.07%)
ui: 26.39 KiB (0.36%)
common: 3.64 KiB (0.04%)

fabiobozzo requested a review from a team as a code owner November 11, 2025 12:31

metamaskbot added the team-accounts-framework Accounts Framework team label Nov 11, 2025

fabiobozzo requested review from ccharly, danroc, gantunesr, hmalik88, mathieuartu, montelaidev and owencraston November 11, 2025 12:31

github-actions bot added the size-S label Nov 11, 2025

montelaidev reviewed Nov 11, 2025

View reviewed changes

ui/components/multichain-accounts/multichain-account-list/multichain-account-list.tsx Outdated Show resolved Hide resolved

gantunesr reviewed Nov 11, 2025

View reviewed changes

ui/components/multichain-accounts/multichain-account-list/multichain-account-list.tsx Outdated Show resolved Hide resolved

address pr feedback

40b264c

fabiobozzo requested review from gantunesr and montelaidev November 12, 2025 11:10

gantunesr approved these changes Nov 12, 2025

View reviewed changes

fabiobozzo enabled auto-merge November 12, 2025 12:22

montelaidev approved these changes Nov 12, 2025

View reviewed changes

fabiobozzo added this pull request to the merge queue Nov 12, 2025

Merged via the queue into main with commit 4b68601 Nov 12, 2025
173 checks passed

fabiobozzo deleted the fix/MUL-1244-hide-kebab-account-details-connect-dapp branch November 12, 2025 13:13

github-actions bot locked and limited conversation to collaborators Nov 12, 2025

metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: hide account menu in dapp connection flow #37704

fix: hide account menu in dapp connection flow #37704

fabiobozzo commented Nov 11, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

metamaskbot commented Nov 11, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Nov 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 12, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: hide account menu in dapp connection flow #37704

fix: hide account menu in dapp connection flow #37704

Conversation

fabiobozzo commented Nov 11, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

metamaskbot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Nov 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 12, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fabiobozzo commented Nov 11, 2025 •

edited by cursor bot

Loading

metamaskbot commented Nov 11, 2025 •

edited

Loading