Skip to content

Conversation

@aganglada
Copy link
Contributor

@aganglada aganglada commented Nov 12, 2025

Description

Updates bitcoin to 1.5.0, which places accounts info under encrypted state

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Update dependency @metamask/bitcoin-wallet-snap from 1.4.5 to 1.5.0.

Written by Cursor Bugbot for commit e3002b9. This will update automatically on new commits. Configure here.

@aganglada aganglada self-assigned this Nov 12, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Nov 12, 2025
@aganglada aganglada changed the title fix: bump bitcoin fix: cp-13.9.0 bump bitcoin Nov 12, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.4.5 ⏵ 1.5.010010083 +197 +1100

View full report

@aganglada aganglada enabled auto-merge November 12, 2025 17:13
@metamaskbot
Copy link
Collaborator

Builds ready [e3002b9]
UI Startup Metrics (1224 ± 85 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1224107615218512681405
load105593012707610991203
domContentLoaded105092712607510941193
domInteractive221377151966
firstPaint54988122640910411177
backgroundConnect2322212526235246
firstReactRender25185062739
getState227132162347
initialActions001001
loadScripts824702102474877960
setupStore1163141219
numNetworkReqs1367519671
BrowserifyPower User HomeuiStartup17041487237628020152376
load1067918155821113391558
domContentLoaded1060912155121113311551
domInteractive42151314397131
firstPaint595226964315945964
backgroundConnect24122027015255270
firstReactRender28233432834
getState17515821717186217
initialActions001001
loadScripts830698128819910841288
setupStore11101411114
numNetworkReqs1207225468167254
WebpackStandard HomeuiStartup83070211981028251145
load61356295789604905
domContentLoaded60655693485597884
domInteractive171261111447
firstPaint21660937221201875
backgroundConnect251167132959
firstReactRender29176193446
getState1163031316
initialActions001001
loadScripts60355492482595874
setupStore1252851324
numNetworkReqs1367720672
WebpackPower User HomeuiStartup1072860177929714281779
load67357010181468471018
domContentLoaded647559928121732928
domInteractive33121233577123
firstPaint43367932283634932
backgroundConnect601021471157214
firstReactRender27233222732
getState1409616924156169
initialActions001011
loadScripts643558918118722918
setupStore1562582525
numNetworkReqs1106822760165227
FirefoxBrowserifyStandard HomeuiStartup14811312187512215371752
load1262114315518913101446
domContentLoaded1261114315518913091445
domInteractive1103631643118200
firstPaint------
backgroundConnect45271262051107
firstReactRender26206072648
getState1276271225
initialActions001001
loadScripts1234112015228412851400
setupStore1476391436
numNetworkReqs1367719772
BrowserifyPower User HomeuiStartup22031765327845924443278
load14391151224927016412249
domContentLoaded14391150224927016412249
domInteractive21989540176480540
firstPaint------
backgroundConnect983126881160268
firstReactRender42306494964
getState1189816315123163
initialActions30287128
loadScripts14011131221926816052219
setupStore3671644561164
numNetworkReqs1367231876213318
WebpackStandard HomeuiStartup16081423210114216311939
load13721211178910414021625
domContentLoaded13721210178910414011625
domInteractive963044645105164
firstPaint------
backgroundConnect47241282351115
firstReactRender332494133279
getState148144191220
initialActions001001
loadScripts1343119217669613691548
setupStore13671101236
numNetworkReqs1366918866
WebpackPower User HomeuiStartup23231922306841428373068
load15641307208723018192087
domContentLoaded15631307208723018182087
domInteractive21241733220336733
firstPaint------
backgroundConnect873124366138243
firstReactRender52321082154108
getState1358519434171194
initialActions101011
loadScripts15291288203021917432030
setupStore4762966965296
numNetworkReqs1366832691226326
📊 Page Load Benchmark Results

Current Commit: e3002b9 | Date: 11/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±68ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 71ms 1.00s 1.33s 1.26s 1.33s
domContentLoaded 732ms 68ms 695ms 1.00s 932ms 1.00s
firstPaint 77ms 12ms 60ms 180ms 88ms 180ms
firstContentfulPaint 77ms 12ms 60ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -1.63 KiB (-0.04%)
  • ui: 530 Bytes (0.01%)
  • common: 3.53 KiB (0.04%)

@aganglada aganglada added this pull request to the merge queue Nov 12, 2025
auto-merge was automatically disabled November 12, 2025 18:18

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
@aganglada aganglada added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit de21015 Nov 12, 2025
338 of 346 checks passed
@aganglada aganglada deleted the chore/bump-bitcoin-1-5-0 branch November 12, 2025 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
@metamaskbot metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.10.0 Issue or pull request that will be included in release 13.10.0 size-XS team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants