Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 13, 2025

Description

BTC redeposits not shown in individual asset activity section

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix BTC redeposits not shown in individual asset
activity

Related issues

Fixes:
https://consensys.slack.com/archives/C09KHA0P1B7/p1762876275492479 &
https://consensyssoftware.atlassian.net/browse/ASSETS-1765

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Ensures Bitcoin redeposit transactions appear in individual asset activity by adjusting non‑EVM token filtering.

  • Non‑EVM activity filtering (ui/components/app/transaction-list/unified-transaction-list.component.js):
    • Update filterNonEvmTxByToken to detect Bitcoin networks (tokenAddress starts with bip122).
    • Include redeposit transactions (empty to array and KeyringTransactionType.Send) when filtering by token, bypassing strict asset match.

Written by Cursor Bugbot for commit c2c7d86. This will update automatically on new commits. Configure here.

da713dc

…in individual asset activity (#37732)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
BTC redeposits not shown in individual asset activity section

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37732?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix BTC redeposits not shown in individual asset
activity

## **Related issues**

Fixes:
https://consensys.slack.com/archives/C09KHA0P1B7/p1762876275492479 &
https://consensyssoftware.atlassian.net/browse/ASSETS-1765

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="796" height="1182" alt="image"
src="https://github.com/user-attachments/assets/30905fe2-fa76-43bd-bcfc-a94ac9b2e6dd"
/>

<!-- [screenshots/recordings] -->

### **After**

<img width="669" height="1042" alt="image"
src="https://github.com/user-attachments/assets/abc0e25b-e285-49aa-aab6-25d6725c1994"
/>

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Ensures Bitcoin redeposit transactions appear in individual asset
activity by updating the non‑EVM token filter.
> 
> - **Non‑EVM activity filtering**:
> - Update `filterNonEvmTxByToken` in
`ui/components/app/transaction-list/unified-transaction-list.component.js`
to treat Bitcoin redeposits as matching when `tokenAddress` starts with
`bip122` and the transaction has no `to` outputs and `type ===
KeyringTransactionType.Send`.
> - Preserve existing filtering that matches transactions by
`asset.type` across `transaction.to` and `transaction.from`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
4da050b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github bot requested a review from a team as a code owner November 13, 2025 09:16
@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 13, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +11 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list/
          • 📄 unified-transaction-list.component.js +11 -0

@metamaskbot
Copy link
Collaborator

Builds ready [c2c7d86]
UI Startup Metrics (1251 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1251108016339413091415
load108294113548111411224
domContentLoaded107593613488111371215
domInteractive221593162067
firstPaint63574135842810661184
backgroundConnect23621930210240252
firstReactRender25174752738
getState22674122646
initialActions004101
loadScripts845712109880911990
setupStore1163041222
numNetworkReqs1367719672
BrowserifyPower User HomeuiStartup19731712302636022673026
load1048891165322212991653
domContentLoaded1040885164422112911644
domInteractive301675205175
firstPaint60114213864199221386
backgroundConnect2322202549236254
firstReactRender27243422834
getState16615022518171225
initialActions001001
loadScripts817662139921610631399
setupStore13102541225
numNetworkReqs1197225372233253
WebpackStandard HomeuiStartup83069812671008311090
load610550103192604836
domContentLoaded603544100688596821
domInteractive161177101441
firstPaint212591009217201813
backgroundConnect251069133154
firstReactRender291781103344
getState1162931215
initialActions001001
loadScripts60054299586594811
setupStore1254051326
numNetworkReqs1367319869
WebpackPower User HomeuiStartup12481123154014614241540
load63256589291678892
domContentLoaded61955487588664875
domInteractive251275204175
firstPaint37061881271576881
backgroundConnect41102175175217
firstReactRender27253012830
getState1409717522151175
initialActions001001
loadScripts61555286585654865
setupStore1162671826
numNetworkReqs1076721154170211
FirefoxBrowserifyStandard HomeuiStartup14891290204714215301821
load1258110915609513311448
domContentLoaded1258110815599513311447
domInteractive1073536152113232
firstPaint------
backgroundConnect48272062750106
firstReactRender26224342633
getState74395714
initialActions001001
loadScripts1230108115389113041415
setupStore167234241336
numNetworkReqs1267516760
BrowserifyPower User HomeuiStartup23912075344837025883448
load13591130187722916081877
domContentLoaded13591130187622916081876
domInteractive19978540167423540
firstPaint------
backgroundConnect992929397226293
firstReactRender432971105071
getState1167318931125189
initialActions002112
loadScripts13321110183522515721835
setupStore2951453928145
numNetworkReqs1376932789234327
WebpackStandard HomeuiStartup15921406213714316251931
load13591185179210514051570
domContentLoaded13591185179210514051569
domInteractive983035851106154
firstPaint------
backgroundConnect4519209245085
firstReactRender302277103046
getState947712743
initialActions002001
loadScripts1330116817129913841536
setupStore176206261358
numNetworkReqs1367217764
WebpackPower User HomeuiStartup24902129313830127223138
load15091212175716016701757
domContentLoaded15091212175716016691757
domInteractive15744432116200432
firstPaint------
backgroundConnect1113233084148330
firstReactRender40315264352
getState1148419432128194
initialActions405012150
loadScripts14751195171915416411719
setupStore4352527036252
numNetworkReqs1325827671168276
📊 Page Load Benchmark Results

Current Commit: c2c7d86 | Date: 11/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 739ms (±96ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±79ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.03s 1.72s 1.08s 1.72s
domContentLoaded 739ms 96ms 713ms 1.66s 765ms 1.66s
firstPaint 86ms 79ms 64ms 872ms 88ms 872ms
firstContentfulPaint 86ms 79ms 64ms 872ms 88ms 872ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit 9ae1878 into release/13.9.0 Nov 13, 2025
172 of 173 checks passed
@gauthierpetetin gauthierpetetin deleted the runway-cherry-pick-13.9.0-1763025411 branch November 13, 2025 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 13, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.9.0 on PR, as PR was cherry-picked in branch 13.9.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.9.0 Issue or pull request that will be included in release 13.9.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants