Skip to content

Conversation

@hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 14, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-11-14.at.15.36.47.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates Shield plan note text and increases displayed savings from 16% to 17% across en and en_GB locales.

  • Localization (i18n):
    • Transaction Shield plan copy:
      • Update shieldPlanCryptoMonthlyNote message to "Total monthly fees pre-approved for a year".
      • Change shieldPlanSave from Save 16% to Save 17%.
    • Affected files: app/_locales/en/messages.json, app/_locales/en_GB/messages.json.

Written by Cursor Bugbot for commit bb797c3. This will update automatically on new commits. Configure here.

@hieu-w hieu-w requested review from a team as code owners November 14, 2025 08:06
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Nov 14, 2025
@hieu-w hieu-w changed the title Fix/hieu/fix release ux fix: Shield Plan Select page text update Nov 14, 2025
@hieu-w hieu-w force-pushed the fix/hieu/fix-release-ux branch from 20c441f to bb797c3 Compare November 14, 2025 08:21
@github-actions github-actions bot added size-XS and removed size-S labels Nov 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [bb797c3]
UI Startup Metrics (1226 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12261073178510812831399
load1061920156610011201227
domContentLoaded105491715619911081209
domInteractive231479152069
firstPaint71790126241510861180
backgroundConnect2332172557238245
firstReactRender27195483046
getState20763102638
initialActions108112
loadScripts827697133598879972
setupStore1152941120
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup21821930315129123173151
load1193997201726714342017
domContentLoaded1167976193025814231930
domInteractive621825469134254
firstPaint773207200450810702004
backgroundConnect26323833023283330
firstReactRender694685148285
getState21916540765245407
initialActions102122
loadScripts935741166825111961668
setupStore26133653036
numNetworkReqs1258919236176192
WebpackStandard HomeuiStartup82070011841008131111
load60855291882605890
domContentLoaded60054689978598860
domInteractive171158111449
firstPaint20161903171202573
backgroundConnect251173142960
firstReactRender3217357343438
getState1162231215
initialActions103111
loadScripts59754488976595849
setupStore1153951317
numNetworkReqs1367519870
WebpackPower User HomeuiStartup1053889149419512491494
load65957010451327071045
domContentLoaded64355810281296901028
domInteractive48132357080235
firstPaint3446910313136931031
backgroundConnect48161674568167
firstReactRender38354734047
getState1409117323151173
initialActions101011
loadScripts63955610181266801018
setupStore13637102437
numNetworkReqs786012521104125
FirefoxBrowserifyStandard HomeuiStartup15261311231214615561798
load1280112215989113171481
domContentLoaded1280112115989113161481
domInteractive1133844670115328
firstPaint------
backgroundConnect4526286284979
firstReactRender27225262747
getState138103111231
initialActions203123
loadScripts1256110315748812851454
setupStore1374571232
numNetworkReqs1267517761
BrowserifyPower User HomeuiStartup33452604475569636804755
load15661321202623918882026
domContentLoaded15661321202623918882026
domInteractive332134816234694816
firstPaint------
backgroundConnect61712916604389531660
firstReactRender82621061192106
getState17411524134206241
initialActions213133
loadScripts15111267200024318602000
setupStore62261162676116
numNetworkReqs1207423556125235
WebpackStandard HomeuiStartup16411426227117516502167
load13901190173110514091654
domContentLoaded13901190173110514091654
domInteractive1003338343110188
firstPaint------
backgroundConnect50252413352114
firstReactRender32258093546
getState157215221349
initialActions103122
loadScripts1362117316749613851592
setupStore177112181353
numNetworkReqs1366918766
WebpackPower User HomeuiStartup33252771427346839174273
load16811471218922619722189
domContentLoaded16801470218922619712189
domInteractive23058606185459606
firstPaint------
backgroundConnect4138010822785901082
firstReactRender927012317105123
getState219118623149197623
initialActions213023
loadScripts16281428215722219122157
setupStore13542533138172533
numNetworkReqs1197624755141247
📊 Page Load Benchmark Results

Current Commit: bb797c3 | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±121ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±119ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±101ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 121ms 1.01s 2.22s 1.07s 2.22s
domContentLoaded 731ms 119ms 697ms 1.89s 747ms 1.89s
firstPaint 86ms 101ms 60ms 1.09s 84ms 1.09s
firstContentfulPaint 86ms 101ms 60ms 1.09s 84ms 1.09s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -206 Bytes (0%)
  • ui: 851 Bytes (0.01%)
  • common: -533 Bytes (-0.01%)

@hieu-w hieu-w added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 14, 2025
@chaitanyapotti chaitanyapotti removed request for a team November 14, 2025 08:56
@chaitanyapotti chaitanyapotti merged commit 5fd017b into fix/confirmation-shield-messages Nov 14, 2025
167 of 172 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/hieu/fix-release-ux branch November 14, 2025 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XS team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants