-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Shield Plan Select page text update #37833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chaitanyapotti
merged 2 commits into
fix/confirmation-shield-messages
from
fix/hieu/fix-release-ux
Nov 14, 2025
Merged
fix: Shield Plan Select page text update #37833
chaitanyapotti
merged 2 commits into
fix/confirmation-shield-messages
from
fix/hieu/fix-release-ux
Nov 14, 2025
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
20c441f to
bb797c3
Compare
Collaborator
Builds ready [bb797c3]
UI Startup Metrics (1226 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
chaitanyapotti
approved these changes
Nov 14, 2025
5fd017b
into
fix/confirmation-shield-messages
167 of 172 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
size-XS
team-onboarding
Onboarding team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-11-14.at.15.36.47.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates Shield plan note text and increases displayed savings from 16% to 17% across en and en_GB locales.
shieldPlanCryptoMonthlyNotemessage to "Total monthly fees pre-approved for a year".shieldPlanSavefromSave 16%toSave 17%.app/_locales/en/messages.json,app/_locales/en_GB/messages.json.Written by Cursor Bugbot for commit bb797c3. This will update automatically on new commits. Configure here.