test: Remove feature flags from onboarding fixture #37857
Merged
+2
−1,321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature flags were accidentally added to the onboarding fixture recently. This wasn't a problem for E2E tests because we refresh feature flags as part of initialization (which itself was a bug), but when we tried to fix this in #37552 it revealed this fixture problem. The onboarding fixture has been updated to not include any feature flags. Individual E2E tests can set the features they need using a manifest override or a feature flag API mock.
Collaborator
Builds ready [f70ce81]
UI Startup Metrics (1258 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
commented
Nov 14, 2025
| "solanaTestnetsEnabled": false, | ||
| "walletFrameworkRpcFailoverEnabled": true | ||
| } | ||
| "cacheTimestamp": 0, |
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
mmm I see 🤔 the resulting onboarding fixture we have is the one exported, once we imported a dist build in the browser, without any modification, after waiting for the wallet to load. If that becomes a problem, then we'll need to add some logic for modifying this and leaving this as an empty object (in the work we are doing for automatically export the fixture)
Member
Author
There was a problem hiding this comment.
The process is correct, in a sense. It would have produced the correct result except for there is a bug during wallet initialization, which caused this state to be updated when it should not have been (feature flags were updated, but it's supposed to delay that until after onboarding)
That bug is fixed in #37552
Member
There was a problem hiding this comment.
oh I get it. Thank you vmuch for further explaining Mark 🙏
david0xd
approved these changes
Nov 14, 2025
seaona
approved these changes
Nov 14, 2025
cryptotavares
approved these changes
Nov 14, 2025
metamaskbot
added
the
release-13.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature flags were accidentally added to the onboarding fixture recently. This wasn't a problem for E2E tests because we refresh feature flags as part of initialization (which itself was a bug), but when we tried to fix this in #37552 it revealed this fixture problem.
The onboarding fixture has been updated to not include any feature flags. Individual E2E tests can set the features they need using a manifest override or a feature flag API mock.
Changelog
CHANGELOG entry: null
Related issues
Unblocks #37552
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Strips
RemoteFeatureFlagControllerdata fromtest/e2e/fixtures/onboarding-fixture.json, settingcacheTimestampto0andremoteFeatureFlagsto{}.test/e2e/fixtures/onboarding-fixture.json):RemoteFeatureFlagController.remoteFeatureFlagscontent.RemoteFeatureFlagController.cacheTimestampto0.Written by Cursor Bugbot for commit f70ce81. This will update automatically on new commits. Configure here.