-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: rewards state and selectors #37875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,476
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔒 @MetaMask/extension-security-team (1 files, +4 -97)
👨🔧 @dbrans (1 files, +4 -97)
👨🔧 @HowardBraham (1 files, +4 -97)
|
132b4e7 to
593f27b
Compare
VGR-GIT
approved these changes
Nov 14, 2025
Collaborator
Builds ready [593f27b]
UI Startup Metrics (1226 ± 84 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Update circular-deps.jsonc Update .madgerc Fix return type Fix bug
593f27b to
bd27c29
Compare
Collaborator
Builds ready [bd27c29]
UI Startup Metrics (1218 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
approved these changes
Nov 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.11.0
Issue or pull request that will be included in release 13.11.0
size-XL
team-rewards
Rewards team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://consensyssoftware.atlassian.net/browse/RWDS-268
Part 3 of #36827 pertaining to ui state and selectors
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a new
rewardsUI state slice with selectors and background-thunk actions, integrates it into the root reducer, and adds comprehensive tests plus minor config updates.ui/ducks/rewards/slice (index.ts) defining onboarding, geo, subscription/season status, feature flag, and error toast state with actions (e.g.,setOnboardingModalOpen,setRewardsGeoMetadata,setSeasonStatus).ui/ducks/index.jsasrewards.ui/ducks/rewards/selectors.ts(e.g.,selectRewardsEnabledwith version-gated flag support, and basic state selectors).ui/store/actions.tswith rewards-related thunks:validateRewardsReferralCode,getRewardsGeoMetadata,rewardsOptIn,rewardsIsOptInSupported,rewardsGetOptInStatus,rewardsLinkAccountsToSubscriptionCandidate,getRewardsSeasonStatus,getRewardsSeasonMetadata,estimateRewardsPoints.updateMetaMetricsTraitshelper.ui/ducks/rewards/index.test.ts), selectors (ui/ducks/rewards/selectors.test.ts), and store actions (ui/store/actions.test.js).rewards..madgercallowed globs.Written by Cursor Bugbot for commit bd27c29. This will update automatically on new commits. Configure here.