Skip to content

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Nov 14, 2025

Description

Fixes these issues when window height is short:

  • Double scrollbar
  • Cut off background

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: ui issues with short window height

Related issues

Fixes:

Manual testing steps

Create a new wallet flow

Screenshots/Recordings

Before

Double Scrollbar Cropped Background
image image
--- ---

After

image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Remove html min-height and .main-container-wrapper min-height to prevent double scrollbars and background cropping on short viewports.

  • CSS/Layout:
    • ui/css/base-styles.scss: Remove html min-height: 500px.
    • ui/css/itcss/components/newui-sections.scss: Remove .main-container-wrapper min-height: 0.
  • Result: Avoids double scrollbars and cropped background on short window heights.

Written by Cursor Bugbot for commit b705258. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Nov 14, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 14, 2025

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +0 -3)
  • 📁 ui/
    • 📁 css/
      • 📁 itcss/
        • 📁 components/
          • 📄 newui-sections.scss +0 -1
        • 📄 base-styles.scss +0 -2

@n3ps n3ps force-pushed the n3ps/fix-body-height branch from 878095a to 409c117 Compare November 14, 2025 20:05
@metamaskbot
Copy link
Collaborator

Builds ready [409c117]
UI Startup Metrics (1232 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12321088164010012881421
load106392514159211281200
domContentLoaded105691014049211231194
domInteractive221478152065
firstPaint68595129041210711161
backgroundConnect23522032812238251
firstReactRender29206083143
getState21760102641
initialActions105112
loadScripts828681117391892964
setupStore1172741117
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup21811809315431722053154
load1146967172621513931726
domContentLoaded1130953171121813861711
domInteractive551716553109165
firstPaint770230171853013881718
backgroundConnect25423030019271300
firstReactRender75511221882122
getState23216935052284350
initialActions103123
loadScripts896735142620211511426
setupStore26857123157
numNetworkReqs1239318633169186
WebpackStandard HomeuiStartup824703115782834989
load60255793871602774
domContentLoaded59555091968597761
domInteractive171180131453
firstPaint18855893172191573
backgroundConnect241267132751
firstReactRender30198193544
getState1162841317
initialActions104111
loadScripts59254890966595751
setupStore1163951319
numNetworkReqs1367419870
WebpackPower User HomeuiStartup1062913154320513371543
load673581970137765970
domContentLoaded653569923124739923
domInteractive36131183986118
firstPaint32163927291577927
backgroundConnect46101994875199
firstReactRender41394624246
getState1399317125151171
initialActions101011
loadScripts649567913121729913
setupStore1162981129
numNetworkReqs80641262299126
FirefoxBrowserifyStandard HomeuiStartup14441301201213514531746
load1211111814708712251424
domContentLoaded1211111814698712251423
domInteractive53333074447159
firstPaint------
backgroundConnect4126121184691
firstReactRender28226072847
getState1166871120
initialActions203122
loadScripts1187110214488212021381
setupStore155226231327
numNetworkReqs1267115756
BrowserifyPower User HomeuiStartup31702487460070234324600
load15201326195820917551958
domContentLoaded15201326195820917541958
domInteractive23768611178407611
firstPaint------
backgroundConnect48815012813638891281
firstReactRender925613322116133
getState17812433349192333
initialActions217137
loadScripts14621265192921116871929
setupStore1123432988140329
numNetworkReqs1207623956121239
WebpackStandard HomeuiStartup17391534244917317432158
load14521298188312214721756
domContentLoaded14511297188212214721756
domInteractive61322563368125
firstPaint------
backgroundConnect59282573665126
firstReactRender372689113755
getState1385871322
initialActions204123
loadScripts14181273179111214371685
setupStore218230311562
numNetworkReqs1366817765
WebpackPower User HomeuiStartup32782533432855638834328
load16721433204822719422048
domContentLoaded16711432204822719412048
domInteractive25087553166436553
firstPaint------
backgroundConnect50117313503568261350
firstReactRender82511342299134
getState20189605129191605
initialActions213133
loadScripts16201366201122819082011
setupStore11722514112110514
numNetworkReqs1307823054198230
📊 Page Load Benchmark Results

Current Commit: 409c117 | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±87ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±113ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±96ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 87ms 1.01s 1.87s 1.06s 1.87s
domContentLoaded 725ms 113ms 699ms 1.82s 735ms 1.82s
firstPaint 84ms 96ms 60ms 1.04s 84ms 1.04s
firstContentfulPaint 84ms 96ms 60ms 1.04s 84ms 1.04s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps force-pushed the n3ps/fix-body-height branch from 409c117 to b705258 Compare November 14, 2025 20:38
@n3ps n3ps marked this pull request as ready for review November 14, 2025 20:51
@n3ps n3ps requested a review from a team as a code owner November 14, 2025 20:51
@n3ps n3ps changed the title fix: body height fix: onboarding layout Nov 14, 2025
@n3ps n3ps enabled auto-merge November 14, 2025 20:51
@metamaskbot
Copy link
Collaborator

Builds ready [b705258]
UI Startup Metrics (1233 ± 91 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1233106314679113031370
load106591512898511351198
domContentLoaded105991012828511291191
domInteractive231499181880
firstPaint62083121841010611165
backgroundConnect23322030710237249
firstReactRender30196083247
getState2295292743
initialActions104113
loadScripts832693104085897968
setupStore1162331119
numNetworkReqs1367519670
BrowserifyPower User HomeuiStartup20821867271823021542718
load1075896172823712941728
domContentLoaded1057883171924212851719
domInteractive621519164156191
firstPaint65019812923439511292
backgroundConnect21219925613217256
firstReactRender74491001688100
getState22516332542255325
initialActions102012
loadScripts863697146722910861467
setupStore21133562635
numNetworkReqs1259818930161189
WebpackStandard HomeuiStartup85372012561118511160
load622563100996613920
domContentLoaded61555999391607894
domInteractive181286131554
firstPaint21759984219196744
backgroundConnect261190162963
firstReactRender321973113756
getState1161931317
initialActions101011
loadScripts61255698289605884
setupStore1162431317
numNetworkReqs1367519872
WebpackPower User HomeuiStartup1072917150122714311501
load69357611311859171131
domContentLoaded66056510001478551000
domInteractive31131093170109
firstPaint44911610033218591003
backgroundConnect581618065161180
firstReactRender40374224142
getState1389415521151155
initialActions101011
loadScripts656563990144845990
setupStore1462682526
numNetworkReqs836513024118130
FirefoxBrowserifyStandard HomeuiStartup14541303200813014631781
load1221111715507712361375
domContentLoaded1221111715507712361375
domInteractive52331673251141
firstPaint------
backgroundConnect4025119174181
firstReactRender28225672846
getState1265581232
initialActions103122
loadScripts1198109814677312171354
setupStore137105121232
numNetworkReqs1267615753
BrowserifyPower User HomeuiStartup33012587510075743545100
load15651283218926818492189
domContentLoaded15651283218926818482189
domInteractive25966673188452673
firstPaint------
backgroundConnect573142148943410681489
firstReactRender946213318108133
getState19487522102257522
initialActions218228
loadScripts15071251214825417482148
setupStore922218149151181
numNetworkReqs1257223060221230
WebpackStandard HomeuiStartup16541474210113517221952
load13971265175310714391630
domContentLoaded13961265175310714391630
domInteractive54301712663118
firstPaint------
backgroundConnect4927121195484
firstReactRender34257273645
getState1285271223
initialActions207123
loadScripts13671243173010114071574
setupStore167102161553
numNetworkReqs1366617863
WebpackPower User HomeuiStartup31022508440659235934406
load16971408251831319912518
domContentLoaded16971407251831319912518
domInteractive26476772234521772
firstPaint------
backgroundConnect36985901279709901
firstReactRender804711724102117
getState16211724537195245
initialActions217137
loadScripts16501378248331019372483
setupStore84242445398244
numNetworkReqs1236923457192234
📊 Page Load Benchmark Results

Current Commit: b705258 | Date: 11/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.33s 1.09s 1.33s
domContentLoaded 723ms 38ms 696ms 999ms 757ms 999ms
firstPaint 76ms 11ms 60ms 160ms 92ms 160ms
firstContentfulPaint 76ms 11ms 60ms 160ms 92ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 11.34 KiB (0.15%)
  • common: 207 Bytes (0%)

@n3ps n3ps added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit b0bce05 Nov 17, 2025
196 checks passed
@n3ps n3ps deleted the n3ps/fix-body-height branch November 17, 2025 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants