Skip to content

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Nov 15, 2025

Description

Fixes the settings title alignment

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: settings title alignment

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-702

Manual testing steps

  1. Open the Settings page
  2. Observe title horizontal alignment

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the 250px max-width from the Settings header title, allowing it to align/flow correctly on small screens.

  • UI/CSS:
    • Remove max-width: 250px from settings-page__header__title-container__title under small-screen layout in ui/pages/settings/index.scss to allow proper title alignment/flow.

Written by Cursor Bugbot for commit 35eeac2. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Nov 15, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [35eeac2]
UI Startup Metrics (1255 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12551088166710113191412
load108393313799311451213
domContentLoaded107692813679211391202
domInteractive231484162169
firstPaint67490127542310871193
backgroundConnect2352192758238251
firstReactRender26195342833
getState2186992537
initialActions104112
loadScripts847701112490910974
setupStore1142841218
numNetworkReqs1367620672
BrowserifyPower User HomeuiStartup20991808266021521922660
load1150988162721013731627
domContentLoaded1125967161921713621619
domInteractive561818257131182
firstPaint707232154339610171543
backgroundConnect25424028611259286
firstReactRender71461121783112
getState21317930036235300
initialActions104114
loadScripts896742137821211271378
setupStore281657113457
numNetworkReqs1219019329149193
WebpackStandard HomeuiStartup84671511661038551134
load62056494087609889
domContentLoaded61355992282604864
domInteractive181264121554
firstPaint20556926208206742
backgroundConnect241182142555
firstReactRender321968103656
getState1161831317
initialActions102111
loadScripts61055791280601854
setupStore1153841316
numNetworkReqs1367620873
WebpackPower User HomeuiStartup1120921189827913901898
load69858510721807731072
domContentLoaded671568986152733986
domInteractive38131654481165
firstPaint40568993352737993
backgroundConnect651423370138233
firstReactRender41394924149
getState1419516923156169
initialActions101011
loadScripts667566975148722975
setupStore96285828
numNetworkReqs836312424122124
FirefoxBrowserifyStandard HomeuiStartup14441300199812314881716
load1214111414838212551395
domContentLoaded1214111314838212541394
domInteractive53321693449164
firstPaint------
backgroundConnect3926146154467
firstReactRender27225162743
getState1175271122
initialActions208123
loadScripts1191108713967812371366
setupStore13653101249
numNetworkReqs1266215857
BrowserifyPower User HomeuiStartup33712588503277538145032
load15791336215026219332150
domContentLoaded15791335215026219332150
domInteractive25685636196498636
firstPaint------
backgroundConnect717157168847910821688
firstReactRender87611161596116
getState17010225649202256
initialActions213023
loadScripts15201303212325817652123
setupStore10633499107132499
numNetworkReqs1187022754140227
WebpackStandard HomeuiStartup16161463201812616511958
load13751193170210614181615
domContentLoaded13751192170210614181614
domInteractive55281932966114
firstPaint------
backgroundConnect48241332452113
firstReactRender332582103344
getState13651101248
initialActions104122
loadScripts1343117416229813881538
setupStore16673151354
numNetworkReqs1366717765
WebpackPower User HomeuiStartup32502661449856734874498
load16381400196318418751963
domContentLoaded16381400196218418741962
domInteractive22168551151429551
firstPaint------
backgroundConnect42615713803286761380
firstReactRender937313620103136
getState190115583108194583
initialActions327137
loadScripts15971371191718618361917
setupStore13042435111152435
numNetworkReqs1258222150174221
📊 Page Load Benchmark Results

Current Commit: 35eeac2 | Date: 11/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±49ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±45ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 49ms 1.02s 1.45s 1.08s 1.45s
domContentLoaded 736ms 45ms 706ms 1.10s 753ms 1.10s
firstPaint 79ms 14ms 60ms 212ms 84ms 212ms
firstContentfulPaint 79ms 14ms 60ms 212ms 84ms 212ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 11.34 KiB (0.15%)
  • common: 207 Bytes (0%)

@n3ps n3ps enabled auto-merge November 15, 2025 02:26
@n3ps n3ps requested a review from a team November 15, 2025 02:28
@n3ps n3ps added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 5317746 Nov 17, 2025
187 of 188 checks passed
@n3ps n3ps deleted the n3ps/fix-settings-title branch November 17, 2025 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants