-
Notifications
You must be signed in to change notification settings - Fork 5.4k
release(runway): cherry-pick fix: cp-13.10.0 bump bitcoin #37911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release(runway): cherry-pick fix: cp-13.10.0 bump bitcoin #37911
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates bitcoin to 1.6.0, which updates from and to fields in the confirmation modal. [](https://codespaces.new/MetaMask/metamask-extension/pull/37906?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Added `from` and `to` to send confirmation view ([#563](MetaMask/snap-bitcoin-wallet#563)) ## **Related issues** Fixes: [Send - Bitcoin - When I perform a Bitcoin Send I can't see the Recipient address in the last confirmation screen, and missleading Account field #37845](#37845) ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps `@metamask/bitcoin-wallet-snap` from ^1.5.0 to ^1.6.0. > > - **Dependencies**: > - Update `@metamask/bitcoin-wallet-snap` to `^1.6.0` in `package.json` and `yarn.lock`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6243b2c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [23c209e]
UI Startup Metrics (1221 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
|
No release label on PR. Adding release label release-13.10.0 on PR, as PR was cherry-picked in branch 13.10.0. |
Description
Updates bitcoin to 1.6.0, which updates from and to fields in the
confirmation modal.
Changelog
CHANGELOG entry: Added
fromandtoto send confirmation view(#563)
Related issues
Fixes: Send - Bitcoin - When I perform a Bitcoin Send I can't see the
Recipient address in the last confirmation screen, and missleading
Account field
#37845
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Bumps
@metamask/bitcoin-wallet-snapdependency to 1.6.0.@metamask/bitcoin-wallet-snapfrom^1.5.0to^1.6.0inpackage.jsonandyarn.lock.1.6.0inattribution.txt.Written by Cursor Bugbot for commit 23c209e. This will update automatically on new commits. Configure here.
eadd65b