Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 17, 2025

Description

Updates bitcoin to 1.6.0, which updates from and to fields in the
confirmation modal.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Added from and to to send confirmation view
(#563)

Related issues

Fixes: Send - Bitcoin - When I perform a Bitcoin Send I can't see the
Recipient address in the last confirmation screen, and missleading
Account field
#37845

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Bumps @metamask/bitcoin-wallet-snap dependency to 1.6.0.

  • Dependencies:
    • Update @metamask/bitcoin-wallet-snap from ^1.5.0 to ^1.6.0 in package.json and yarn.lock.
  • Attributions:
    • Reflect version change to 1.6.0 in attribution.txt.

Written by Cursor Bugbot for commit 23c209e. This will update automatically on new commits. Configure here.

eadd65b

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates bitcoin to 1.6.0, which updates from and to fields in the
confirmation modal.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37906?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added `from` and `to` to send confirmation view
([#563](MetaMask/snap-bitcoin-wallet#563))

## **Related issues**

Fixes: [Send - Bitcoin - When I perform a Bitcoin Send I can't see the
Recipient address in the last confirmation screen, and missleading
Account field
#37845](#37845)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps `@metamask/bitcoin-wallet-snap` from ^1.5.0 to ^1.6.0.
> 
> - **Dependencies**:
> - Update `@metamask/bitcoin-wallet-snap` to `^1.6.0` in `package.json`
and `yarn.lock`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
6243b2c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 17, 2025
@socket-security
Copy link

socket-security bot commented Nov 17, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.5.0 ⏵ 1.6.01001008398 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [23c209e]
UI Startup Metrics (1221 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1221106915769412731381
load106493413028011221204
domContentLoaded105892212958011171197
domInteractive221487161970
firstPaint59980122041210751153
backgroundConnect2332172829236251
firstReactRender27205352936
getState217102112538
initialActions104112
loadScripts831685107679884968
setupStore1062931021
numNetworkReqs1367620674
BrowserifyPower User HomeuiStartup20571755270331523892703
load1141962162724514571627
domContentLoaded1125951158724214381587
domInteractive551816353124163
firstPaint602143161151510441611
backgroundConnect25523428114266281
firstReactRender56486556165
getState22017135454251354
initialActions101011
loadScripts884720134323411861343
setupStore16102031920
numNetworkReqs1027218745176187
WebpackStandard HomeuiStartup8307251213868361073
load60855991473607811
domContentLoaded60154989870602781
domInteractive171269121453
firstPaint18758901180197624
backgroundConnect241185142454
firstReactRender31207693539
getState1052431215
initialActions105111
loadScripts59854788867600770
setupStore1161931318
numNetworkReqs1367419870
WebpackPower User HomeuiStartup1077923156521213321565
load68758611131577601113
domContentLoaded67457610741497451074
domInteractive38141234195123
firstPaint3546410783507521078
backgroundConnect44101744745174
firstReactRender41385444354
getState1366116630153166
initialActions101011
loadScripts66957410631467351063
setupStore116307930
numNetworkReqs836514325107143
FirefoxBrowserifyStandard HomeuiStartup15051311209314715611834
load12671125155810613101521
domContentLoaded12671124155810613101520
domInteractive56332113852154
firstPaint------
backgroundConnect4126108154473
firstReactRender28225662946
getState137214211219
initialActions2013123
loadScripts12421107153110112891489
setupStore14870101330
numNetworkReqs1266615757
BrowserifyPower User HomeuiStartup27962319381550230493815
load14771282199624618171996
domContentLoaded14771281199624618161996
domInteractive19277490128322490
firstPaint------
backgroundConnect29694926288334926
firstReactRender69471021273102
getState1567927249187272
initialActions218238
loadScripts14331243188724017841887
setupStore843816136103161
numNetworkReqs1206725870199258
WebpackStandard HomeuiStartup16031424218613316141934
load1363123716369313921611
domContentLoaded1363123716369313921610
domInteractive58292873664117
firstPaint------
backgroundConnect4720243285084
firstReactRender342384123868
getState126146151117
initialActions103122
loadScripts1334118016178913581548
setupStore15686161253
numNetworkReqs1367017765
WebpackPower User HomeuiStartup31212378426157337204261
load17061445225124419432251
domContentLoaded17061444225124419432251
domInteractive23056654179431654
firstPaint------
backgroundConnect31068862256667862
firstReactRender75501091588109
getState200118678140214678
initialActions213133
loadScripts16491418220324918792203
setupStore13437475134130475
numNetworkReqs1226525367178253
📊 Page Load Benchmark Results

Current Commit: 23c209e | Date: 11/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±61ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±59ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 61ms 1.01s 1.32s 1.26s 1.32s
domContentLoaded 732ms 59ms 702ms 994ms 936ms 994ms
firstPaint 76ms 12ms 56ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 56ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit 9f02238 into release/13.10.0 Nov 17, 2025
168 of 170 checks passed
@gauthierpetetin gauthierpetetin deleted the runway-cherry-pick-13.10.0-1763397149 branch November 17, 2025 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 17, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.10.0 on PR, as PR was cherry-picked in branch 13.10.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.10.0 Issue or pull request that will be included in release 13.10.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants