feat: rewards onboarding components #37919
Merged
+3,089
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| onActionClick, | ||
| }), | ||
| ); | ||
| }, [actionText, description, dispatch, onActionClick, title]); |
There was a problem hiding this comment.
Bug: Functions Break Redux State Principles
The handleClose callback stores a function reference (onActionClick) in Redux state via setErrorToast. Redux state must only contain serializable data, and storing functions violates this principle. This breaks Redux DevTools, time-travel debugging, state persistence, and can cause unexpected behavior when the function reference changes. The function should be stored outside Redux state or referenced by an identifier instead.
sophieqgu
force-pushed
the
rewards-onboarding-components
branch
from
6b69107 to
7536625
Compare
Collaborator
Builds ready [7536625]
UI Startup Metrics (1223 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
jbblanc
previously approved these changes
Nov 18, 2025
VGR-GIT
previously approved these changes
Nov 18, 2025
| borderColor: referralCodeIsError | ||
| ? 'border-error-default' | ||
| : 'border-muted', | ||
| }} |
There was a problem hiding this comment.
Bug: Style Prop Misuse Breaks TextField Appearance
The style prop on the TextField component contains Tailwind CSS class names as values (e.g., 'bg-background-pressed') instead of actual inline CSS values. This will cause the styles to not be applied, as browsers cannot interpret class names as inline style properties. The backgroundColor and borderColor should use actual CSS values or valid CSS custom properties.
Collaborator
Builds ready [cb40b68]
UI Startup Metrics (1252 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
sophieqgu
force-pushed
the
rewards-hooks
branch
from
670a6df to
b8c2ba8
Compare
sophieqgu
dismissed stale reviews from jbblanc and VGR-GIT
The base branch was changed.
Update translation
sophieqgu
force-pushed
the
rewards-onboarding-components
branch
from
cb40b68 to
978bad2
Compare
jonson
approved these changes
Nov 18, 2025
Collaborator
Builds ready [978bad2]
UI Startup Metrics (1229 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jbblanc
approved these changes
Nov 18, 2025
VGR-GIT
approved these changes
Nov 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://consensyssoftware.atlassian.net/browse/RWDS-268
Part 6 of #36827 introduces new rewards onboarding components
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Implements the Rewards onboarding flow (modal with steps, error toast/banner, referral opt‑in) with full tests and new locale strings.
Rewardsonboarding modalui/components/app/rewards/onboarding/OnboardingModal.tsxwith stepsOnboardingIntroStep,OnboardingStep1,OnboardingStep2,OnboardingStep3,OnboardingStep4andProgressIndicator.RewardsErrorBannerandRewardsErrorToast.pending/retry/error) with retry actions; advances through steps; persists modal‑shown flag.onboarding/constants.ts.app/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.Written by Cursor Bugbot for commit 978bad2. This will update automatically on new commits. Configure here.