-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: added support link to unlock page cp-13.10.0 #37967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d21a543]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4479c05]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm QA
| properties: { | ||
| url: SUPPORT_LINK, | ||
| }, | ||
| <Text variant={TextVariant.bodyMd} color={TextColor.textDefault}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to show this always instead of just rehydration flow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this feature existed previously, the UX team requested its removal during the unlock page redesign. Since it's still needed for rehydration, I've implemented a conditional check to maintain this functionality where required.
Builds ready [eb32d48]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [eabbbf4]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [1001a7e]
UI Startup Metrics (1248 ± 77 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
In this PR, we have enabled the MetaMask Support link in unlock page.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-329
Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-Redesign?node-id=18656-27472&m=dev
Changelog
CHANGELOG entry: added the support link back in unlock page.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a support link with tracking to the unlock page, introduces popup-specific logo spacing via a new isPopup prop, and tweaks margins/spacing.
SupportLinkClicked).Forgot password?margin (marginBottom6→4); adjustsunlock-page__mascot-container__horizontal-logodefault margin (60px→24px); adds popup modifier--popupto remove bottom margin.isPopupprop from container (viagetEnvironmentType() === ENVIRONMENT_TYPE_POPUP) to component; applies conditional class toMetaFoxHorizontalLogo.index.scssto add&--popupmodifier and new margins.Written by Cursor Bugbot for commit 1001a7e. This will update automatically on new commits. Configure here.