Skip to content

Conversation

@smgv
Copy link
Contributor

@smgv smgv commented Nov 19, 2025

Description

Open in GitHub Codespaces

In this PR, we have enabled the MetaMask Support link in unlock page.

Jira Link: https://consensyssoftware.atlassian.net/browse/SL-329

Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-Redesign?node-id=18656-27472&m=dev

Changelog

CHANGELOG entry: added the support link back in unlock page.

Related issues

Fixes:

Manual testing steps

  1. Open Extension
  2. Create Wallet
  3. Lock the app
  4. Validate changes in unlock page.

Screenshots/Recordings

Before

Screenshot 2025-11-19 at 1 06 31 PM

After

Screenshot 2025-11-19 at 12 51 52 PM Screenshot 2025-11-19 at 12 52 07 PM Screenshot 2025-11-19 at 12 52 37 PM Screenshot 2025-11-19 at 12 53 04 PM Screenshot 2025-11-19 at 12 53 20 PM Screenshot 2025-11-19 at 12 53 38 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a support link with tracking to the unlock page, introduces popup-specific logo spacing via a new isPopup prop, and tweaks margins/spacing.

  • Unlock Page UI:
    • Support link: Adds “Need help? Contact MetaMask support” with external link and metrics tracking (SupportLinkClicked).
    • Spacing tweaks: Reduces Forgot password? margin (marginBottom 6→4); adjusts unlock-page__mascot-container__horizontal-logo default margin (60px→24px); adds popup modifier --popup to remove bottom margin.
  • Logic/Props:
    • Passes new isPopup prop from container (via getEnvironmentType() === ENVIRONMENT_TYPE_POPUP) to component; applies conditional class to MetaFoxHorizontalLogo.
  • Styles:
    • Updates index.scss to add &--popup modifier and new margins.
  • Tests:
    • Updates snapshot to reflect new support link and spacing changes.

Written by Cursor Bugbot for commit 1001a7e. This will update automatically on new commits. Configure here.

@smgv smgv self-assigned this Nov 19, 2025
@smgv smgv added area-onboarding needs-qa Label will automate into QA workspace team-onboarding Onboarding team labels Nov 19, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d21a543]
📊 Page Load Benchmark Results

Current Commit: d21a543 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±36ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±9ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.02s 1.32s 1.08s 1.32s
domContentLoaded 730ms 36ms 709ms 993ms 756ms 993ms
firstPaint 78ms 9ms 60ms 152ms 84ms 152ms
firstContentfulPaint 78ms 9ms 60ms 152ms 84ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 204 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [4479c05]
📊 Page Load Benchmark Results

Current Commit: 4479c05 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±34ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 37ms 1.01s 1.30s 1.06s 1.30s
domContentLoaded 723ms 34ms 697ms 975ms 739ms 975ms
firstPaint 77ms 12ms 60ms 180ms 88ms 180ms
firstContentfulPaint 77ms 12ms 60ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 204 Bytes (0%)
  • common: 20 Bytes (0%)

@LeVinhGithub LeVinhGithub added QA Passed and removed needs-qa Label will automate into QA workspace labels Nov 19, 2025
Copy link
Contributor

@LeVinhGithub LeVinhGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm QA

properties: {
url: SUPPORT_LINK,
},
<Text variant={TextVariant.bodyMd} color={TextColor.textDefault}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to show this always instead of just rehydration flow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this feature existed previously, the UX team requested its removal during the unlock page redesign. Since it's still needed for rehydration, I've implemented a conditional check to maintain this functionality where required.

cc: @nakulmk @valantia-chang

@metamaskbot
Copy link
Collaborator

Builds ready [eb32d48]
📊 Page Load Benchmark Results

Current Commit: eb32d48 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±37ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.33s 1.06s 1.33s
domContentLoaded 719ms 37ms 697ms 1.01s 735ms 1.01s
firstPaint 77ms 12ms 60ms 184ms 88ms 184ms
firstContentfulPaint 77ms 12ms 60ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 204 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [eabbbf4]
📊 Page Load Benchmark Results

Current Commit: eabbbf4 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±37ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.02s 1.33s 1.08s 1.33s
domContentLoaded 728ms 37ms 709ms 1.00s 759ms 1.00s
firstPaint 76ms 11ms 60ms 168ms 84ms 168ms
firstContentfulPaint 76ms 11ms 60ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 204 Bytes (0%)
  • common: 20 Bytes (0%)

@lwin-kyaw lwin-kyaw enabled auto-merge November 19, 2025 16:06
@metamaskbot
Copy link
Collaborator

Builds ready [1001a7e]
UI Startup Metrics (1248 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1248110414007713151382
load106092312097511221183
domContentLoaded105391411987511191174
domInteractive2514109212185
firstPaint592142119040910521165
backgroundConnect22120025210227241
firstReactRender311969113850
getState351889114057
initialActions103112
loadScripts83969898575906962
setupStore1273341318
numNetworkReqs1367519669
BrowserifyPower User HomeuiStartup18611531249424120302368
load993876160614510011434
domContentLoaded97886815971439741411
domInteractive36151893828151
firstPaint58111314534059351371
backgroundConnect22320228413230247
firstReactRender80451461689100
getState17312533643190277
initialActions102011
loadScripts77267113591427681211
setupStore201071122545
numNetworkReqs966719730107182
WebpackStandard HomeuiStartup8306991161858461008
load59254294373595779
domContentLoaded58553492570589758
domInteractive181277131555
firstPaint19658929205181742
backgroundConnect261186182679
firstReactRender3420249283742
getState18103242225
initialActions102111
loadScripts58253391668587750
setupStore1152131318
numNetworkReqs1467720872
WebpackPower User HomeuiStartup13501155252423014511908
load6435561105123650994
domContentLoaded6215441055110617943
domInteractive31122984221133
firstPaint319591052274576872
backgroundConnect56142765369202
firstReactRender7642107128193
getState16010623220169194
initialActions103012
loadScripts6185421047108615935
setupStore17690172561
numNetworkReqs1306927455196243
FirefoxBrowserifyStandard HomeuiStartup1232104915569812951418
load104790613197811001181
domContentLoaded104690513197911001180
domInteractive64302334583180
firstPaint------
backgroundConnect3820143223991
firstReactRender21175552133
getState105719923
initialActions102012
loadScripts102389212987210721156
setupStore105518928
numNetworkReqs1266516759
BrowserifyPower User HomeuiStartup25711740332733227883193
load1157922162517511811546
domContentLoaded1156922162517511811545
domInteractive13630548123154466
firstPaint------
backgroundConnect189301178223199762
firstReactRender85421812095121
getState24055861254183823
initialActions2025326
loadScripts1118906158416511541476
setupStore95578314096555
numNetworkReqs94572134097201
WebpackStandard HomeuiStartup14751274184012115241755
load1253105615229913121452
domContentLoaded1253105615229913101452
domInteractive71282334584180
firstPaint------
backgroundConnect44211282546110
firstReactRender29218093142
getState146159181250
initialActions1013122
loadScripts1223104014729412861394
setupStore166102191171
numNetworkReqs1367617762
WebpackPower User HomeuiStartup26821991362829128493305
load13371087185415714011698
domContentLoaded13371087185315714011698
domInteractive12628513113147426
firstPaint------
backgroundConnect15728677169191578
firstReactRender87412262697116
getState31170852292763835
initialActions2127327
loadScripts13031071181714913281632
setupStore1088751170101533
numNetworkReqs96602204496212
📊 Page Load Benchmark Results

Current Commit: 1001a7e | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±51ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±49ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 51ms 1.00s 1.31s 1.07s 1.31s
domContentLoaded 721ms 49ms 692ms 994ms 746ms 994ms
firstPaint 77ms 14ms 60ms 200ms 88ms 200ms
firstContentfulPaint 77ms 14ms 60ms 200ms 88ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 204 Bytes (0%)
  • common: 20 Bytes (0%)

@lwin-kyaw lwin-kyaw added this pull request to the merge queue Nov 19, 2025
@smgv smgv changed the title fix: added support link to unlock page fix: added support link to unlock page cp-13.10.0 Nov 19, 2025
Merged via the queue into main with commit 355e33f Nov 19, 2025
176 checks passed
@lwin-kyaw lwin-kyaw deleted the fix/added-support-link-unlock-ui branch November 19, 2025 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 19, 2025
@smgv smgv changed the title fix: added support link to unlock page cp-13.10.0 fix: added support link to unlock page Nov 20, 2025
@smgv smgv changed the title fix: added support link to unlock page fix: added support link to unlock page cp-13.10.0 Nov 20, 2025
@smgv smgv linked an issue Nov 20, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding QA Passed release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-S team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Keep “Contact Support” link on the unlock screen

6 participants