fix: flaky test `Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off` #37983

seaona · 2025-11-19T15:58:58Z

Description

The spec is flaky as sometimes we get a failed request, because we stopped the mock server.

This changes the approach and keeps the mock server open. We only let pass through the ens req
This will avoid errors while other API requests happen on the background, as we keep the rest of the mocks as usual

https://github.com/search?q=org%3AMetaMask+%22failed+to+generate+nonce%22&type=code

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Stabilizes the ENS/IPFS settings e2e test by keeping the mock server running and pass-through ENS requests instead of stopping the server.

E2E Tests (test/e2e/tests/settings/ipfs-ens-resolution.spec.ts):
- Import MockedEndpoint and add ensDomainPassthrough helper to pass through ENS_NAME_URL and ENS_DESTINATION_URL.
- Replace ad-hoc server handling with testSpecificMock: ensDomainPassthrough; remove manual server stop.
- Goal: avoid request failures by keeping mocks active while allowing ENS requests to pass through.

^{Written by Cursor Bugbot for commit 7b076d8. This will update automatically on new commits. Configure here.}

metamaskbot · 2025-11-19T16:29:20Z

Builds ready [892d2f1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1261 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1261	1068	1593	110	1338	1444
			load	1088	903	1392	104	1163	1256
			domContentLoaded	1079	897	1382	102	1155	1247
			domInteractive	25	15	88	17	22	73
			firstPaint	784	168	1434	426	1134	1258
			backgroundConnect	214	187	273	17	220	249
			firstReactRender	28	20	64	9	32	48
			getState	31	16	56	8	35	48
			initialActions	1	0	2	1	1	2
			loadScripts	874	688	1119	97	937	1032
			setupStore	11	7	26	2	12	14
			numNetworkReqs	13	6	76	19	6	72
	Browserify	Power User Home	uiStartup	1898	1577	2714	255	2060	2470
			load	1023	892	1594	150	1025	1432
			domContentLoaded	1009	884	1582	150	1006	1416
			domInteractive	37	15	198	46	28	178
			firstPaint	647	156	1598	399	977	1405
			backgroundConnect	224	208	257	10	231	243
			firstReactRender	77	46	108	13	86	98
			getState	181	131	364	47	197	293
			initialActions	1	0	3	0	1	2
			loadScripts	800	679	1366	149	793	1210
			setupStore	20	10	71	11	26	40
			numNetworkReqs	96	67	199	30	104	172
	Webpack	Standard Home	uiStartup	836	694	1183	86	857	1003
			load	595	543	946	75	602	766
			domContentLoaded	588	538	927	72	598	751
			domInteractive	18	11	104	15	14	55
			firstPaint	197	58	934	203	176	743
			backgroundConnect	25	10	84	15	29	63
			firstReactRender	31	19	88	10	37	46
			getState	19	11	36	5	22	29
			initialActions	1	0	4	1	1	1
			loadScripts	586	536	918	70	595	742
			setupStore	12	6	25	4	14	17
			numNetworkReqs	13	6	76	19	8	70
	Webpack	Power User Home	uiStartup	1330	1167	2011	202	1458	1787
			load	653	566	1092	135	646	1068
			domContentLoaded	633	554	1041	124	623	1022
			domInteractive	31	13	249	42	22	134
			firstPaint	315	62	1046	284	571	1027
			backgroundConnect	46	13	204	35	65	113
			firstReactRender	77	38	109	13	83	95
			getState	150	109	200	18	161	193
			initialActions	1	0	2	0	1	1
			loadScripts	631	552	1032	122	621	1013
			setupStore	20	6	86	16	31	54
			numNetworkReqs	126	66	259	52	167	236
Firefox	Browserify	Standard Home	uiStartup	1231	1078	1739	121	1313	1448
			load	1033	913	1221	80	1100	1184
			domContentLoaded	1032	913	1221	80	1095	1179
			domInteractive	59	30	224	37	82	135
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	20	247	32	40	107
			firstReactRender	22	17	46	6	21	35
			getState	9	5	73	7	9	15
			initialActions	1	0	3	1	1	2
			loadScripts	1008	892	1197	72	1071	1120
			setupStore	13	5	162	18	10	34
			numNetworkReqs	12	6	69	15	7	53
	Browserify	Power User Home	uiStartup	2755	1758	3829	348	2966	3429
			load	1226	1001	1873	202	1272	1679
			domContentLoaded	1226	1000	1873	202	1272	1678
			domInteractive	147	31	607	147	167	547
			firstPaint	-	-	-	-	-	-
			backgroundConnect	215	29	969	235	296	732
			firstReactRender	87	40	206	22	95	126
			getState	239	73	914	248	186	855
			initialActions	3	1	46	7	2	7
			loadScripts	1188	969	1851	200	1223	1657
			setupStore	129	7	826	195	138	735
			numNetworkReqs	96	56	228	43	90	202
	Webpack	Standard Home	uiStartup	1454	1211	1946	137	1505	1758
			load	1240	1040	1546	102	1299	1419
			domContentLoaded	1240	1040	1546	102	1298	1419
			domInteractive	74	24	231	49	86	203
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	19	137	24	43	90
			firstReactRender	28	20	73	9	28	39
			getState	13	6	71	13	10	48
			initialActions	1	0	2	1	2	2
			loadScripts	1213	1025	1530	96	1278	1388
			setupStore	13	5	169	19	10	47
			numNetworkReqs	12	6	68	16	7	63
	Webpack	Power User Home	uiStartup	2779	2124	3691	325	3015	3314
			load	1374	1107	1873	191	1563	1765
			domContentLoaded	1373	1107	1873	191	1562	1765
			domInteractive	135	28	604	122	158	429
			firstPaint	-	-	-	-	-	-
			backgroundConnect	155	23	718	158	193	563
			firstReactRender	85	41	137	18	93	122
			getState	223	76	890	231	176	846
			initialActions	2	1	9	1	2	3
			loadScripts	1342	1076	1853	188	1523	1746
			setupStore	119	5	803	197	101	725
			numNetworkReqs	93	54	222	44	88	201

📊 Page Load Benchmark Results

Current Commit: 892d2f1 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 959ms (±50ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 670ms (±48ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 73ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	959ms	50ms	931ms	1.22s	1.02s	1.22s
domContentLoaded	670ms	48ms	644ms	924ms	698ms	924ms
firstPaint	73ms	12ms	60ms	172ms	88ms	172ms
firstContentfulPaint	73ms	12ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 267 Bytes (0.01%)
ui: -477.75 KiB (-6.4%)
common: 59 Bytes (0%)

metamaskbot · 2025-11-19T17:29:50Z

Builds ready [307d3cb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 99 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1216	1046	1576	99	1288	1393
			load	1040	907	1402	91	1113	1180
			domContentLoaded	1032	904	1393	89	1102	1161
			domInteractive	23	14	96	17	20	75
			firstPaint	616	89	1203	419	1055	1166
			backgroundConnect	213	196	295	12	218	227
			firstReactRender	27	19	68	8	27	46
			getState	31	15	80	10	35	51
			initialActions	1	0	10	1	1	2
			loadScripts	827	696	1189	91	897	956
			setupStore	11	6	31	4	11	17
			numNetworkReqs	13	6	72	19	6	70
	Browserify	Power User Home	uiStartup	1906	1566	2648	243	2079	2331
			load	1021	883	1898	166	1020	1463
			domContentLoaded	1006	875	1879	165	996	1442
			domInteractive	37	17	226	43	28	166
			firstPaint	588	105	1886	402	950	1098
			backgroundConnect	226	207	279	12	232	249
			firstReactRender	83	45	169	19	90	134
			getState	185	143	371	47	197	293
			initialActions	1	0	3	1	1	2
			loadScripts	797	671	1650	162	789	1228
			setupStore	21	11	53	9	27	41
			numNetworkReqs	94	66	196	30	104	175
	Webpack	Standard Home	uiStartup	896	742	1242	86	921	1056
			load	624	573	923	64	631	788
			domContentLoaded	616	567	902	60	624	770
			domInteractive	20	12	79	14	17	57
			firstPaint	207	63	818	202	197	718
			backgroundConnect	29	13	106	18	29	82
			firstReactRender	37	21	290	29	41	56
			getState	21	12	42	6	24	31
			initialActions	1	0	5	1	1	2
			loadScripts	613	564	891	58	621	760
			setupStore	13	7	26	4	16	20
			numNetworkReqs	13	6	75	19	8	70
	Webpack	Power User Home	uiStartup	1312	1151	2348	217	1363	1806
			load	626	550	1148	122	613	963
			domContentLoaded	602	538	1038	105	590	921
			domInteractive	27	13	178	32	19	115
			firstPaint	336	60	1044	271	572	926
			backgroundConnect	56	13	259	53	70	203
			firstReactRender	75	42	98	12	81	91
			getState	156	94	214	18	166	184
			initialActions	1	0	4	0	1	1
			loadScripts	600	536	1030	104	588	913
			setupStore	19	6	93	17	31	52
			numNetworkReqs	125	66	248	50	169	230
Firefox	Browserify	Standard Home	uiStartup	1250	1091	1672	114	1310	1477
			load	1049	932	1347	80	1100	1209
			domContentLoaded	1047	932	1347	80	1097	1209
			domInteractive	58	31	218	35	82	133
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	20	158	21	44	78
			firstReactRender	23	18	46	6	23	38
			getState	10	5	29	4	11	20
			initialActions	1	0	3	0	2	2
			loadScripts	1026	920	1323	74	1078	1165
			setupStore	15	5	189	22	10	67
			numNetworkReqs	12	6	61	15	7	58
	Browserify	Power User Home	uiStartup	2647	1860	3245	280	2859	3160
			load	1178	944	1679	183	1267	1565
			domContentLoaded	1177	938	1679	183	1267	1564
			domInteractive	147	23	619	138	162	478
			firstPaint	-	-	-	-	-	-
			backgroundConnect	188	25	898	208	254	721
			firstReactRender	86	38	168	18	94	111
			getState	237	52	881	245	181	845
			initialActions	2	0	33	3	2	3
			loadScripts	1146	926	1542	174	1234	1528
			setupStore	128	6	795	202	114	750
			numNetworkReqs	92	62	198	35	126	157
	Webpack	Standard Home	uiStartup	1380	1211	1738	115	1427	1638
			load	1174	1032	1447	93	1222	1384
			domContentLoaded	1174	1032	1446	93	1221	1384
			domInteractive	65	28	231	41	87	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	21	86	14	39	70
			firstReactRender	27	19	67	9	28	53
			getState	11	6	108	14	9	41
			initialActions	1	0	3	1	2	2
			loadScripts	1152	1016	1426	89	1201	1339
			setupStore	12	6	44	9	10	34
			numNetworkReqs	13	6	69	17	7	64
	Webpack	Power User Home	uiStartup	2760	2042	3550	326	2937	3480
			load	1366	1114	1992	176	1436	1724
			domContentLoaded	1366	1113	1992	176	1436	1724
			domInteractive	140	30	604	127	161	447
			firstPaint	-	-	-	-	-	-
			backgroundConnect	171	31	853	168	208	543
			firstReactRender	88	42	203	22	98	123
			getState	213	74	865	235	163	811
			initialActions	2	0	30	3	2	7
			loadScripts	1326	1093	1915	167	1363	1695
			setupStore	102	7	775	161	105	705
			numNetworkReqs	95	57	221	44	97	209

📊 Page Load Benchmark Results

Current Commit: 307d3cb | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 725ms (±36ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.00s	1.34s	1.08s	1.34s
domContentLoaded	725ms	36ms	691ms	995ms	745ms	995ms
firstPaint	77ms	11ms	60ms	168ms	84ms	168ms
firstContentfulPaint	77ms	11ms	60ms	168ms	84ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 267 Bytes (0.01%)
ui: -477.75 KiB (-6.4%)
common: 221 Bytes (0%)

test/e2e/tests/settings/ipfs-ens-resolution.spec.ts

metamaskbot · 2025-11-20T08:17:00Z

Builds ready [5ea1f79]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1155 ± 89 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1155	964	1316	89	1228	1297
			load	991	833	1134	81	1061	1102
			domContentLoaded	986	831	1129	80	1054	1092
			domInteractive	22	13	88	16	19	65
			firstPaint	557	138	1124	393	993	1098
			backgroundConnect	199	179	237	10	205	221
			firstReactRender	26	18	53	7	29	40
			getState	30	16	75	10	33	51
			initialActions	1	0	3	1	1	2
			loadScripts	792	644	939	79	862	897
			setupStore	10	5	38	4	11	16
			numNetworkReqs	12	5	78	21	5	73
	Browserify	Power User Home	uiStartup	1879	1536	3015	269	2029	2381
			load	1012	891	1864	171	1010	1482
			domContentLoaded	997	886	1849	170	986	1470
			domInteractive	37	15	228	43	28	162
			firstPaint	561	93	1507	396	944	1437
			backgroundConnect	226	209	262	11	234	252
			firstReactRender	84	45	181	19	90	114
			getState	174	130	329	45	195	285
			initialActions	1	0	5	1	1	2
			loadScripts	789	680	1623	168	783	1253
			setupStore	19	7	80	11	24	35
			numNetworkReqs	97	70	194	31	107	186
	Webpack	Standard Home	uiStartup	800	721	1027	74	821	979
			load	612	554	830	65	621	791
			domContentLoaded	608	551	822	64	616	784
			domInteractive	23	14	81	17	21	77
			firstPaint	216	96	798	156	192	771
			backgroundConnect	10	5	30	6	10	24
			firstReactRender	28	20	41	5	32	38
			getState	29	14	55	10	37	46
			initialActions	1	0	3	1	1	2
			loadScripts	605	549	812	62	614	775
			setupStore	12	7	43	5	13	22
			numNetworkReqs	12	5	78	20	5	76
	Webpack	Power User Home	uiStartup	1431	1131	2312	233	1564	2000
			load	670	581	1078	122	676	1021
			domContentLoaded	660	574	1061	120	659	1008
			domInteractive	35	16	180	36	28	133
			firstPaint	244	87	1068	174	247	619
			backgroundConnect	16	7	54	8	19	31
			firstReactRender	81	42	139	13	88	97
			getState	157	124	263	32	160	237
			initialActions	1	0	3	1	1	2
			loadScripts	657	572	1051	117	657	997
			setupStore	25	7	65	15	35	60
			numNetworkReqs	155	72	507	64	191	280
Firefox	Browserify	Standard Home	uiStartup	1227	1044	1890	134	1272	1509
			load	1031	893	1281	81	1088	1178
			domContentLoaded	1030	893	1281	81	1083	1178
			domInteractive	60	29	217	37	82	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	20	299	37	39	120
			firstReactRender	21	17	49	4	22	30
			getState	10	6	71	10	9	21
			initialActions	1	0	2	0	1	2
			loadScripts	1007	879	1185	72	1054	1144
			setupStore	11	5	173	18	9	30
			numNetworkReqs	12	5	74	17	6	63
	Browserify	Power User Home	uiStartup	2630	1855	3736	345	2808	3397
			load	1145	923	1690	176	1171	1534
			domContentLoaded	1144	923	1690	176	1171	1534
			domInteractive	138	29	592	126	145	496
			firstPaint	-	-	-	-	-	-
			backgroundConnect	208	28	945	238	206	826
			firstReactRender	86	39	131	17	97	114
			getState	241	86	881	243	187	867
			initialActions	2	1	8	1	2	7
			loadScripts	1103	906	1666	160	1118	1511
			setupStore	133	7	848	201	116	736
			numNetworkReqs	96	50	225	42	95	199
	Webpack	Standard Home	uiStartup	1499	1292	1998	145	1511	1852
			load	1268	1113	1597	101	1327	1494
			domContentLoaded	1268	1113	1596	101	1326	1493
			domInteractive	68	30	239	41	96	131
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	22	247	30	44	116
			firstReactRender	28	20	68	7	29	40
			getState	12	6	90	12	11	22
			initialActions	1	0	3	1	2	2
			loadScripts	1243	1098	1572	94	1293	1445
			setupStore	13	6	84	13	11	37
			numNetworkReqs	12	5	70	18	6	66
	Webpack	Power User Home	uiStartup	3565	2618	5358	590	3967	4714
			load	1695	1297	2639	260	1857	2253
			domContentLoaded	1695	1297	2637	260	1857	2252
			domInteractive	172	36	748	167	164	658
			firstPaint	-	-	-	-	-	-
			backgroundConnect	489	36	1635	475	968	1320
			firstReactRender	108	52	277	32	122	158
			getState	299	93	917	261	285	874
			initialActions	5	1	103	12	3	7
			loadScripts	1645	1262	2460	250	1790	2208
			setupStore	93	11	724	126	94	215
			numNetworkReqs	98	64	218	38	101	201

📊 Page Load Benchmark Results

Current Commit: 5ea1f79 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±37ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.02s	1.34s	1.08s	1.34s
domContentLoaded	731ms	37ms	708ms	1.01s	748ms	1.01s
firstPaint	78ms	12ms	64ms	184ms	88ms	184ms
firstContentfulPaint	78ms	12ms	64ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 3.22 KiB (0.07%)
ui: -478.3 KiB (-6.41%)
common: 9.75 KiB (0.11%)

metamaskbot · 2025-11-20T09:12:37Z

Builds ready [488f3c3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1227 ± 94 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1227	1062	1564	94	1296	1371
			load	1053	917	1250	90	1140	1211
			domContentLoaded	1046	912	1243	89	1136	1202
			domInteractive	23	14	96	17	21	72
			firstPaint	575	91	1238	429	1060	1188
			backgroundConnect	211	199	264	9	213	230
			firstReactRender	30	19	151	15	34	47
			getState	32	17	107	12	34	52
			initialActions	1	0	3	1	1	2
			loadScripts	841	702	1020	89	933	992
			setupStore	11	7	29	4	12	22
			numNetworkReqs	12	5	77	21	5	74
	Browserify	Power User Home	uiStartup	1846	1508	2744	267	1971	2508
			load	957	837	1634	164	953	1458
			domContentLoaded	942	828	1620	163	932	1447
			domInteractive	31	15	153	32	26	133
			firstPaint	694	105	1637	365	915	1382
			backgroundConnect	207	187	250	12	212	232
			firstReactRender	78	43	126	15	87	105
			getState	191	136	378	52	208	322
			initialActions	1	0	5	1	1	2
			loadScripts	751	645	1414	160	746	1246
			setupStore	19	8	59	11	26	42
			numNetworkReqs	145	71	304	51	174	249
	Webpack	Standard Home	uiStartup	869	765	1114	85	932	1049
			load	642	581	871	65	647	823
			domContentLoaded	637	578	865	64	643	816
			domInteractive	26	14	104	19	23	79
			firstPaint	220	87	843	141	222	617
			backgroundConnect	13	7	42	8	16	33
			firstReactRender	31	21	116	10	35	39
			getState	33	15	60	10	41	47
			initialActions	1	0	4	1	1	2
			loadScripts	634	576	855	62	640	806
			setupStore	13	7	34	5	15	25
			numNetworkReqs	12	5	78	20	5	72
	Webpack	Power User Home	uiStartup	1489	1245	2313	237	1647	1997
			load	688	589	1226	132	696	1066
			domContentLoaded	678	582	1211	131	676	1057
			domInteractive	40	16	182	42	33	155
			firstPaint	306	110	1220	239	293	991
			backgroundConnect	16	8	45	9	18	41
			firstReactRender	83	54	100	10	90	97
			getState	159	126	258	32	167	228
			initialActions	1	0	5	1	1	2
			loadScripts	675	580	1199	129	674	1046
			setupStore	24	9	68	15	34	52
			numNetworkReqs	147	73	314	55	187	282
Firefox	Browserify	Standard Home	uiStartup	1211	1039	1765	119	1268	1447
			load	1024	894	1475	90	1073	1186
			domContentLoaded	1023	890	1475	91	1073	1181
			domInteractive	60	30	234	42	81	167
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	20	159	19	38	59
			firstReactRender	21	17	39	4	21	32
			getState	9	6	76	7	9	18
			initialActions	1	0	2	0	1	2
			loadScripts	1003	882	1451	85	1045	1166
			setupStore	12	5	98	15	9	42
			numNetworkReqs	11	5	71	16	6	63
	Browserify	Power User Home	uiStartup	2699	1857	3729	351	2854	3541
			load	1149	929	1646	150	1198	1485
			domContentLoaded	1148	924	1645	150	1198	1485
			domInteractive	138	31	562	113	153	423
			firstPaint	-	-	-	-	-	-
			backgroundConnect	264	27	1406	296	362	930
			firstReactRender	88	41	157	21	95	128
			getState	244	88	923	247	180	847
			initialActions	2	1	8	2	3	7
			loadScripts	1094	909	1562	133	1135	1451
			setupStore	111	6	796	175	103	742
			numNetworkReqs	99	64	217	40	101	203
	Webpack	Standard Home	uiStartup	1431	1255	1879	134	1477	1738
			load	1215	1045	1477	103	1271	1435
			domContentLoaded	1214	1045	1477	103	1271	1435
			domInteractive	64	26	194	37	84	130
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	21	146	23	42	103
			firstReactRender	27	20	70	8	30	37
			getState	13	6	143	18	11	29
			initialActions	1	0	3	1	1	2
			loadScripts	1189	1030	1437	95	1249	1388
			setupStore	15	5	166	23	10	72
			numNetworkReqs	12	5	70	17	6	62
	Webpack	Power User Home	uiStartup	2893	2306	3828	317	3093	3518
			load	1421	1171	1889	191	1591	1785
			domContentLoaded	1420	1171	1889	191	1590	1785
			domInteractive	134	30	584	122	141	458
			firstPaint	-	-	-	-	-	-
			backgroundConnect	188	24	1003	204	215	595
			firstReactRender	90	41	202	26	99	131
			getState	265	85	924	274	202	884
			initialActions	4	1	55	9	3	7
			loadScripts	1375	1138	1865	192	1515	1749
			setupStore	145	6	778	215	138	757
			numNetworkReqs	97	58	222	45	95	214

📊 Page Load Benchmark Results

Current Commit: 488f3c3 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±63ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 725ms (±60ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	63ms	1.00s	1.32s	1.25s	1.32s
domContentLoaded	725ms	60ms	692ms	997ms	927ms	997ms
firstPaint	75ms	11ms	56ms	156ms	84ms	156ms
firstContentfulPaint	75ms	11ms	56ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.65 KiB (0.12%)
ui: -478.29 KiB (-6.41%)
common: 10.67 KiB (0.12%)

metamaskbot · 2025-11-20T10:14:07Z

Builds ready [7b076d8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1267 ± 113 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1267	1072	1590	113	1364	1463
			load	1078	924	1336	102	1162	1279
			domContentLoaded	1071	920	1330	102	1156	1273
			domInteractive	24	15	88	17	21	77
			firstPaint	561	104	1358	435	1047	1186
			backgroundConnect	218	199	296	13	222	240
			firstReactRender	27	19	57	8	30	46
			getState	34	18	71	12	42	61
			initialActions	1	0	3	1	1	2
			loadScripts	861	703	1118	101	943	1047
			setupStore	12	5	37	5	12	22
			numNetworkReqs	12	5	74	20	5	72
	Browserify	Power User Home	uiStartup	1888	1544	2876	251	2032	2417
			load	995	870	1818	167	1005	1421
			domContentLoaded	979	860	1797	164	982	1405
			domInteractive	38	14	245	42	31	158
			firstPaint	603	97	1822	421	938	1429
			backgroundConnect	221	199	275	13	230	243
			firstReactRender	81	48	138	15	88	112
			getState	176	128	396	44	189	268
			initialActions	1	0	4	1	1	2
			loadScripts	775	664	1581	162	778	1194
			setupStore	19	10	49	9	26	40
			numNetworkReqs	140	68	390	60	175	258
	Webpack	Standard Home	uiStartup	810	734	1041	70	834	985
			load	614	559	832	60	621	775
			domContentLoaded	609	556	825	60	615	768
			domInteractive	24	14	95	18	22	76
			firstPaint	234	71	791	167	209	633
			backgroundConnect	12	6	32	7	15	28
			firstReactRender	28	19	48	6	32	38
			getState	29	14	51	10	37	45
			initialActions	1	0	3	1	1	2
			loadScripts	606	554	817	58	613	758
			setupStore	12	7	28	4	14	19
			numNetworkReqs	12	5	77	20	5	70
	Webpack	Power User Home	uiStartup	1487	1230	2451	251	1666	2028
			load	694	599	1335	136	690	1051
			domContentLoaded	683	591	1320	134	673	1035
			domInteractive	39	18	191	42	32	167
			firstPaint	317	114	1327	239	396	720
			backgroundConnect	16	8	58	8	21	28
			firstReactRender	85	50	151	13	91	106
			getState	157	127	327	37	172	247
			initialActions	1	0	4	1	1	2
			loadScripts	680	589	1310	132	671	1019
			setupStore	22	10	63	15	29	56
			numNetworkReqs	123	67	263	41	140	242
Firefox	Browserify	Standard Home	uiStartup	1219	1047	1802	123	1285	1444
			load	1024	899	1286	80	1074	1182
			domContentLoaded	1023	894	1286	80	1069	1182
			domInteractive	59	29	235	38	81	142
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	20	159	20	37	76
			firstReactRender	21	17	42	4	22	33
			getState	12	5	132	19	9	52
			initialActions	1	0	3	0	1	2
			loadScripts	1003	883	1260	77	1054	1165
			setupStore	11	6	79	10	9	26
			numNetworkReqs	12	5	66	16	7	61
	Browserify	Power User Home	uiStartup	2640	1992	3522	292	2833	3286
			load	1154	903	1776	178	1244	1493
			domContentLoaded	1153	903	1775	179	1244	1492
			domInteractive	144	30	687	127	160	447
			firstPaint	-	-	-	-	-	-
			backgroundConnect	190	23	934	201	224	713
			firstReactRender	84	42	138	17	93	120
			getState	270	80	869	269	220	857
			initialActions	2	1	13	2	2	7
			loadScripts	1104	884	1646	165	1158	1473
			setupStore	186	6	798	240	194	759
			numNetworkReqs	96	62	198	35	121	174
	Webpack	Standard Home	uiStartup	1419	1251	1991	133	1462	1677
			load	1199	1066	1442	89	1249	1383
			domContentLoaded	1198	1066	1442	89	1249	1383
			domInteractive	60	27	186	37	79	131
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	19	203	28	43	101
			firstReactRender	28	21	74	7	30	38
			getState	18	6	185	26	14	57
			initialActions	1	0	2	1	2	2
			loadScripts	1174	1052	1414	82	1225	1342
			setupStore	13	6	233	24	10	45
			numNetworkReqs	12	5	66	17	6	63
	Webpack	Power User Home	uiStartup	3102	2143	4171	372	3294	3925
			load	1487	1231	2108	213	1655	1928
			domContentLoaded	1487	1230	2108	213	1655	1926
			domInteractive	142	29	614	133	159	491
			firstPaint	-	-	-	-	-	-
			backgroundConnect	272	25	1184	286	477	928
			firstReactRender	92	42	172	20	102	124
			getState	334	89	938	293	561	911
			initialActions	4	1	65	10	3	7
			loadScripts	1434	1183	2035	210	1500	1900
			setupStore	111	7	773	174	89	626
			numNetworkReqs	98	68	227	42	96	207

📊 Page Load Benchmark Results

Current Commit: 7b076d8 | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 987ms (±38ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 685ms (±36ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	987ms	38ms	952ms	1.24s	1.03s	1.24s
domContentLoaded	685ms	36ms	659ms	919ms	721ms	919ms
firstPaint	76ms	14ms	64ms	168ms	88ms	168ms
firstContentfulPaint	76ms	14ms	64ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.65 KiB (0.12%)
ui: -475.73 KiB (-6.38%)
common: 10.67 KiB (0.12%)

fix

892d2f1

metamaskbot added the team-qa QA team label Nov 19, 2025

github-actions bot added the size-XS label Nov 19, 2025

fix

307d3cb

seaona marked this pull request as ready for review November 19, 2025 17:24

seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 19, 2025

seaona self-assigned this Nov 19, 2025

seaona added the flaky tests label Nov 19, 2025

cursor bot reviewed Nov 19, 2025

View reviewed changes

test/e2e/tests/settings/ipfs-ens-resolution.spec.ts Outdated Show resolved Hide resolved

fix bot comment

78aafe4

github-actions bot added size-S and removed size-XS labels Nov 20, 2025

fix

5ea1f79

update

488f3c3

Unik0rnMaggie previously approved these changes Nov 20, 2025

View reviewed changes

seaona added 2 commits November 20, 2025 10:37

upd

843c808

upd

cc3d459

seaona dismissed Unik0rnMaggie’s stale review via cc3d459 November 20, 2025 09:38

seaona added 2 commits November 20, 2025 10:38

rever

619a425

lint

7b076d8

Unik0rnMaggie approved these changes Nov 20, 2025

View reviewed changes

chloeYue approved these changes Nov 20, 2025

View reviewed changes

seaona added this pull request to the merge queue Nov 20, 2025

Merged via the queue into main with commit 5dbfbc2 Nov 20, 2025
176 checks passed

seaona deleted the flaky-ipfs-ens-nonce branch November 20, 2025 10:45

github-actions bot locked and limited conversation to collaborators Nov 20, 2025

metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: flaky test `Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off` #37983

fix: flaky test `Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off` #37983

seaona commented Nov 19, 2025 •

edited by cursor bot

Loading

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: flaky test Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off #37983

fix: flaky test Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off #37983

Conversation

seaona commented Nov 19, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 20, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: flaky test `Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off` #37983

fix: flaky test `Settings Does not fetch ENS data for ENS Domain when ENS and IPFS switched off` #37983

seaona commented Nov 19, 2025 •

edited by cursor bot

Loading