feat: added pna-25 banner #38112
Merged
feat: added pna-25 banner #38112
+361
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [3feccf9]
UI Startup Metrics (1168 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
🧪 @MetaMask/qa (1 files, +1 -0)
🔐 @MetaMask/web3auth (2 files, +23 -2)
|
Collaborator
Builds ready [d270e72]
UI Startup Metrics (1340 ± 126 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
Figma has BodySm text size whereas we're using medium, should we update? 
|
Contributor
|
Should this PR include the metric for toast being displayed or is that a follow-up? From ticket: "Log an event for the notice having been displayed" |
ameliejyc
reviewed
Nov 24, 2025
ameliejyc
reviewed
Nov 24, 2025
Collaborator
Builds ready [3ff5436]
UI Startup Metrics (1233 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [8e6603e]
UI Startup Metrics (1202 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
previously approved these changes
Nov 27, 2025
Collaborator
Builds ready [ca876f7]
UI Startup Metrics (1271 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [7a157ea]
UI Startup Metrics (1231 ± 114 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
previously approved these changes
Nov 28, 2025
OGPoyraz
approved these changes
Nov 28, 2025
AndyMBridges
approved these changes
Nov 28, 2025
Collaborator
Builds ready [bf7d334]
UI Startup Metrics (1231 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chaitanyapotti
approved these changes
Nov 28, 2025
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the updated privacy notice banner on homepage
Feature Flow Diagram
Changelog
CHANGELOG entry: Introduces metametrics banner
Related issues
Fixes: issue
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a feature-flagged MetaMetrics privacy banner (
PNA25) with persistedpna25Acknowledgedstate, onboarding/use-metrics integration, and supporting env/config/i18n updates.Pna25Bannerinui/components/app/toast-master/toast-master.jswith selectorselectShowPna25Bannerand action to acknowledge (setPna25Acknowledged).selectShowPna25Bannerintoast-master/selectors.ts; wiresetPna25Acknowledgedintoast-master/utils.ts.useEnableMetametricsauto-acknowledges whenextensionUxPna25enabled andpna25Acknowledged === false.metametrics.jsandwelcome.jssetpna25Acknowledgedfor new/social users whenEXTENSION_UX_PNA25is enabled; updated checkbox copy toggle.pna25AcknowledgedtoAppStateControllerstate, defaults, metadata, settersetPna25Acknowledged, and background API exposure viametamask-controller.js.app/scripts/constants/sentry-state.ts.shared/types/background.ts; selectorgetPna25Acknowledged.EXTENSION_UX_PNA25: trueacrossbuilds.ymland default envs.pna25BannerTitle,onboardingMetametricCheckboxDescriptionOneUpdatedinapp/_locales/en*/messages.json.METAMETRICS_SETTINGS_LINKinshared/lib/ui-utils.js.pna25Acknowledgedand related ordering tweaks.setPna25Acknowledgedinui/store/actions.tsand background wiring.Written by Cursor Bugbot for commit bf7d334. This will update automatically on new commits. Configure here.